[jira] [Commented] (MNG-6410) When a reactor build fails on an artifactId which is not unique, Maven should provide the groupId when suggesting where build should restart from
[ https://issues.apache.org/jira/browse/MNG-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479954#comment-16479954 ] ASF GitHub Bot commented on MNG-6410: - splatch commented on issue #166: [MNG-6410] Clean suggestion on build resume. URL: https://github.com/apache/maven/pull/166#issuecomment-390057948 Sure, no problem - I will just strip this commit and update PR. The 6028 was open for some time so I decided to work on it while I was around. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > When a reactor build fails on an artifactId which is not unique, Maven should > provide the groupId when suggesting where build should restart from > - > > Key: MNG-6410 > URL: https://issues.apache.org/jira/browse/MNG-6410 > Project: Maven > Issue Type: Bug > Components: Command Line >Affects Versions: 3.5.3 >Reporter: Łukasz Dywicki >Priority: Minor > Fix For: 3.5.4-candidate > > > In multi module builds same artifact id can be repeated with different group > id. For example if project strategy is to use nesting of modules, instead of > using long artifact names, {{ap}} or {{model}} module can occur multiple > times with different group id. > By default maven, upon failed build, prints out only {{-rf :artifactId}}. > When developer will copy given suggestion and run build again then his build > will be started from first module which have given artifact id. > While severity of this bug is quite low, it affects productivity in bigger > projects big time. To improve usability of returned message a Maven should > return {{-rf groupId:artifactId}} once artifact id is not unique. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6410) When a reactor build fails on an artifactId which is not unique, Maven should provide the groupId when suggesting where build should restart from
[ https://issues.apache.org/jira/browse/MNG-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479774#comment-16479774 ] ASF GitHub Bot commented on MNG-6410: - splatch commented on issue #166: [MNG-6410] Clean suggestion on build resume. URL: https://github.com/apache/maven/pull/166#issuecomment-390022505 Sure, no problem - I will just strip this commit and update PR. The 6028 was open for some time so I decided to work on it while I was around. All CLI parameters are available in cliRequest. Whole command may be printed with -rf, if there will be such requirement. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > When a reactor build fails on an artifactId which is not unique, Maven should > provide the groupId when suggesting where build should restart from > - > > Key: MNG-6410 > URL: https://issues.apache.org/jira/browse/MNG-6410 > Project: Maven > Issue Type: Bug > Components: Command Line >Affects Versions: 3.5.3 >Reporter: Łukasz Dywicki >Priority: Minor > Fix For: 3.5.4-candidate > > > In multi module builds same artifact id can be repeated with different group > id. For example if project strategy is to use nesting of modules, instead of > using long artifact names, {{ap}} or {{model}} module can occur multiple > times with different group id. > By default maven, upon failed build, prints out only {{-rf :artifactId}}. > When developer will copy given suggestion and run build again then his build > will be started from first module which have given artifact id. > While severity of this bug is quite low, it affects productivity in bigger > projects big time. To improve usability of returned message a Maven should > return {{-rf groupId:artifactId}} once artifact id is not unique. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6410) When a reactor build fails on an artifactId which is not unique, Maven should provide the groupId when suggesting where build should restart from
[ https://issues.apache.org/jira/browse/MNG-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16479771#comment-16479771 ] ASF GitHub Bot commented on MNG-6410: - hboutemy commented on issue #166: [MNG-6410] Clean suggestion on build resume. URL: https://github.com/apache/maven/pull/166#issuecomment-390020869 I'm not convinced by MNG-6028: can you create the patch for MNG-6410 without MNG-6028, please? This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > When a reactor build fails on an artifactId which is not unique, Maven should > provide the groupId when suggesting where build should restart from > - > > Key: MNG-6410 > URL: https://issues.apache.org/jira/browse/MNG-6410 > Project: Maven > Issue Type: Bug > Components: Command Line >Affects Versions: 3.5.3 >Reporter: Łukasz Dywicki >Priority: Minor > Fix For: 3.5.4-candidate > > > In multi module builds same artifact id can be repeated with different group > id. For example if project strategy is to use nesting of modules, instead of > using long artifact names, {{ap}} or {{model}} module can occur multiple > times with different group id. > By default maven, upon failed build, prints out only {{-rf :artifactId}}. > When developer will copy given suggestion and run build again then his build > will be started from first module which have given artifact id. > While severity of this bug is quite low, it affects productivity in bigger > projects big time. To improve usability of returned message a Maven should > return {{-rf groupId:artifactId}} once artifact id is not unique. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Commented] (MNG-6410) When a reactor build fails on an artifactId which is not unique, Maven should provide the groupId when suggesting where build should restart from
[ https://issues.apache.org/jira/browse/MNG-6410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16472383#comment-16472383 ] ASF GitHub Bot commented on MNG-6410: - splatch opened a new pull request #166: [MNG-6410] Clean suggestion on build resume. URL: https://github.com/apache/maven/pull/166 Make sure that resume suggestion contains a valid value for restarting the build, as same artifact name might occur in different places of multi-module project, it is necessary to check if there is conflict in name. By this way returned suggestion will always be correct and less experienced developers will not get confused with it. JIRA issue: https://issues.apache.org/jira/browse/MNG-6410. A extra note, this pull request depends on another pull #165 - for MNG-6028, which changes the same line, both commits are included in this PR. This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org > When a reactor build fails on an artifactId which is not unique, Maven should > provide the groupId when suggesting where build should restart from > - > > Key: MNG-6410 > URL: https://issues.apache.org/jira/browse/MNG-6410 > Project: Maven > Issue Type: Bug > Components: Command Line >Affects Versions: 3.5.3 >Reporter: Łukasz Dywicki >Priority: Minor > > In multi module builds same artifact id can be repeated with different group > id. For example if project strategy is to use nesting of modules, instead of > using long artifact names, {{ap}} or {{model}} module can occur multiple > times with different group id. > By default maven, upon failed build, prints out only {{-rf :artifactId}}. > When developer will copy given suggestion and run build again then his build > will be started from first module which have given artifact id. > While severity of this bug is quite low, it affects productivity in bigger > projects big time. To improve usability of returned message a Maven should > return {{-rf groupId:artifactId}} once artifact id is not unique. -- This message was sent by Atlassian JIRA (v7.6.3#76005)