[jira] [Commented] (MPOM-134) Add profile to use a different resource bundle for incubator projects
[
https://issues.apache.org/jira/browse/MPOM-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16532968#comment-16532968
]
Hervé Boutemy commented on MPOM-134:
still no solution: postponing to ASF-21
> Add profile to use a different resource bundle for incubator projects
> -
>
> Key: MPOM-134
> URL: https://issues.apache.org/jira/browse/MPOM-134
> Project: Maven POMs
> Issue Type: Improvement
>Affects Versions: ASF-18
>Reporter: Christopher Tubbs
>Priority: Major
> Fix For: ASF-21
>
>
> The {{org.apache:apache-jar-resource-bundle:1.4}} resourceBundle currently
> specified in the parent POM does not handle the DISCLAIMER file for incubator
> projects.
> It would be nice if there were an incubation profile, which could be
> activated for incubating projects, to use an incubating resource bundle which
> did handle this DISCLAIMER file.
> This could be done in several ways:
> # An optional second execution of the {{maven-remote-resources-plugin}} could
> run when the profile is activated, which handles a second resource bundle for
> the DISCLAIMER file.
> # The current resourceBundle could be turned into a property, which is
> overridden when the profile is activated, using a resourceBundle which
> handles everything the current one does, plus the DISCLAIMER file.
> # The current {{maven-remote-resources-plugin}} execution could have the
> {{}} element changed to {{ combine.children="append">}}, and the profile could specify an additional
> {{}} to handle the DISCLAIMER file, for the same execution id
> of {{maven-remote-resources-plugin}}.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MPOM-134) Add profile to use a different resource bundle for incubator projects
[
https://issues.apache.org/jira/browse/MPOM-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16325366#comment-16325366
]
Hervé Boutemy commented on MPOM-134:
we did not find any solution yet to this issue
I'm postponing to ASF-20...
> Add profile to use a different resource bundle for incubator projects
> -
>
> Key: MPOM-134
> URL: https://issues.apache.org/jira/browse/MPOM-134
> Project: Maven POMs
> Issue Type: Improvement
>Affects Versions: ASF-18
>Reporter: Christopher Tubbs
> Fix For: ASF-20
>
>
> The {{org.apache:apache-jar-resource-bundle:1.4}} resourceBundle currently
> specified in the parent POM does not handle the DISCLAIMER file for incubator
> projects.
> It would be nice if there were an incubation profile, which could be
> activated for incubating projects, to use an incubating resource bundle which
> did handle this DISCLAIMER file.
> This could be done in several ways:
> # An optional second execution of the {{maven-remote-resources-plugin}} could
> run when the profile is activated, which handles a second resource bundle for
> the DISCLAIMER file.
> # The current resourceBundle could be turned into a property, which is
> overridden when the profile is activated, using a resourceBundle which
> handles everything the current one does, plus the DISCLAIMER file.
> # The current {{maven-remote-resources-plugin}} execution could have the
> {{}} element changed to {{ combine.children="append">}}, and the profile could specify an additional
> {{}} to handle the DISCLAIMER file, for the same execution id
> of {{maven-remote-resources-plugin}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MPOM-134) Add profile to use a different resource bundle for incubator projects
[
https://issues.apache.org/jira/browse/MPOM-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163590#comment-16163590
]
Christopher Tubbs commented on MPOM-134:
A simple approach would be to make it a variable, and incubator projects would
just override a property like {{asf.resourceBundle}} in their POM.
> Add profile to use a different resource bundle for incubator projects
> -
>
> Key: MPOM-134
> URL: https://issues.apache.org/jira/browse/MPOM-134
> Project: Maven POMs
> Issue Type: Improvement
>Affects Versions: ASF-18
>Reporter: Christopher Tubbs
> Fix For: ASF-19
>
>
> The {{org.apache:apache-jar-resource-bundle:1.4}} resourceBundle currently
> specified in the parent POM does not handle the DISCLAIMER file for incubator
> projects.
> It would be nice if there were an incubation profile, which could be
> activated for incubating projects, to use an incubating resource bundle which
> did handle this DISCLAIMER file.
> This could be done in several ways:
> # An optional second execution of the {{maven-remote-resources-plugin}} could
> run when the profile is activated, which handles a second resource bundle for
> the DISCLAIMER file.
> # The current resourceBundle could be turned into a property, which is
> overridden when the profile is activated, using a resourceBundle which
> handles everything the current one does, plus the DISCLAIMER file.
> # The current {{maven-remote-resources-plugin}} execution could have the
> {{}} element changed to {{ combine.children="append">}}, and the profile could specify an additional
> {{}} to handle the DISCLAIMER file, for the same execution id
> of {{maven-remote-resources-plugin}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MPOM-134) Add profile to use a different resource bundle for incubator projects
[
https://issues.apache.org/jira/browse/MPOM-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16163587#comment-16163587
]
Christopher Tubbs commented on MPOM-134:
Instructions to add {{-Pincubator}} would work. A more complicated, but more
automatic, approach would be to create a small Maven plugin to be included in
the parent POM which adds the resource bundle when it detects a version number
with the {{-incubator}} pattern.
> Add profile to use a different resource bundle for incubator projects
> -
>
> Key: MPOM-134
> URL: https://issues.apache.org/jira/browse/MPOM-134
> Project: Maven POMs
> Issue Type: Improvement
>Affects Versions: ASF-18
>Reporter: Christopher Tubbs
> Fix For: ASF-19
>
>
> The {{org.apache:apache-jar-resource-bundle:1.4}} resourceBundle currently
> specified in the parent POM does not handle the DISCLAIMER file for incubator
> projects.
> It would be nice if there were an incubation profile, which could be
> activated for incubating projects, to use an incubating resource bundle which
> did handle this DISCLAIMER file.
> This could be done in several ways:
> # An optional second execution of the {{maven-remote-resources-plugin}} could
> run when the profile is activated, which handles a second resource bundle for
> the DISCLAIMER file.
> # The current resourceBundle could be turned into a property, which is
> overridden when the profile is activated, using a resourceBundle which
> handles everything the current one does, plus the DISCLAIMER file.
> # The current {{maven-remote-resources-plugin}} execution could have the
> {{}} element changed to {{ combine.children="append">}}, and the profile could specify an additional
> {{}} to handle the DISCLAIMER file, for the same execution id
> of {{maven-remote-resources-plugin}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MPOM-134) Add profile to use a different resource bundle for incubator projects
[
https://issues.apache.org/jira/browse/MPOM-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16106878#comment-16106878
]
Hervé Boutemy commented on MPOM-134:
yes, option 3 is the way to go to add an additional {{resourceBundle}} value
from a profile
the question is: how to activate this profile?
you expect to add instructions to activate the profile manually through {{mvn
-Pincubator}}?
(I'm struggling with an equivalent issue after MPOM-96: writing the profile was
a first step, but now I see that the big issue is to make is automagically
activate (and the pom property I documented just does not work...)
> Add profile to use a different resource bundle for incubator projects
> -
>
> Key: MPOM-134
> URL: https://issues.apache.org/jira/browse/MPOM-134
> Project: Maven POMs
> Issue Type: Improvement
>Affects Versions: ASF-18
>Reporter: Christopher Tubbs
> Fix For: ASF-19
>
>
> The {{org.apache:apache-jar-resource-bundle:1.4}} resourceBundle currently
> specified in the parent POM does not handle the DISCLAIMER file for incubator
> projects.
> It would be nice if there were an incubation profile, which could be
> activated for incubating projects, to use an incubating resource bundle which
> did handle this DISCLAIMER file.
> This could be done in several ways:
> # An optional second execution of the {{maven-remote-resources-plugin}} could
> run when the profile is activated, which handles a second resource bundle for
> the DISCLAIMER file.
> # The current resourceBundle could be turned into a property, which is
> overridden when the profile is activated, using a resourceBundle which
> handles everything the current one does, plus the DISCLAIMER file.
> # The current {{maven-remote-resources-plugin}} execution could have the
> {{}} element changed to {{ combine.children="append">}}, and the profile could specify an additional
> {{}} to handle the DISCLAIMER file, for the same execution id
> of {{maven-remote-resources-plugin}}.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
[jira] [Commented] (MPOM-134) Add profile to use a different resource bundle for incubator projects
[
https://issues.apache.org/jira/browse/MPOM-134?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15406821#comment-15406821
]
Christopher Tubbs commented on MPOM-134:
Option 1 isn't great because a second execution slows down the build slightly,
and changes nearly as much as option 3.
Option 2 is the most minimal change to the parent POM, and would also allow
children to override the property, but it would require a lot of duplication
between the current resourceBundle and the replacement.
Option 3 is probably the best because it adds a second resource bundle without
a second execution.
The actual second resource bundle would have to be created, to handle the
DISCLAIMER file.
> Add profile to use a different resource bundle for incubator projects
> -
>
> Key: MPOM-134
> URL: https://issues.apache.org/jira/browse/MPOM-134
> Project: Maven POMs
> Issue Type: Improvement
>Affects Versions: ASF-18
>Reporter: Christopher Tubbs
> Fix For: ASF-19
>
>
> The {{org.apache:apache-jar-resource-bundle:1.4}} resourceBundle currently
> specified in the parent POM does not handle the DISCLAIMER file for incubator
> projects.
> It would be nice if there were an incubation profile, which could be
> activated for incubating projects, to use an incubating resource bundle which
> did handle this DISCLAIMER file.
> This could be done in several ways:
> # An optional second execution of the {{maven-remote-resources-plugin}} could
> run when the profile is activated, which handles a second resource bundle for
> the DISCLAIMER file.
> # The current resourceBundle could be turned into a property, which is
> overridden when the profile is activated, using a resourceBundle which
> handles everything the current one does, plus the DISCLAIMER file.
> # The current {{maven-remote-resources-plugin}} execution could have the
> {{}} element changed to {{ combine.children="append">}}, and the profile could specify an additional
> {{}} to handle the DISCLAIMER file, for the same execution id
> of {{maven-remote-resources-plugin}}.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
