[ https://issues.apache.org/jira/browse/MESOS-8467?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16813796#comment-16813796 ]
Chun-Hung Hsiao edited comment on MESOS-8467 at 4/10/19 9:06 PM: ----------------------------------------------------------------- Retargeting to 1.8.1. Actually, if we fully resolve MESOS-9667 by publishing the resources upon receiving {{RunTaskMessage}}s this patch won't be needed, so I'm not going to land the patch for now although I already got a ship-it. was (Author: chhsia0): Retargeting to 1.8.0. Actually, if we fully resolve MESOS-9667 by publishing the resources upon receiving {{RunTaskMessage}}s this patch won't be needed, so I'm not going to land the patch for now although I already got a ship-it. > Destroyed executors might be used after `Slave::publishResource()`. > ------------------------------------------------------------------- > > Key: MESOS-8467 > URL: https://issues.apache.org/jira/browse/MESOS-8467 > Project: Mesos > Issue Type: Bug > Affects Versions: 1.5.0 > Reporter: Chun-Hung Hsiao > Assignee: Chun-Hung Hsiao > Priority: Critical > Labels: mesosphere, mesosphere-dss-ga, storage > > In the following code from > [https://github.com/apache/mesos/blob/7b30b9ccd63dbcd3375e012dae6e2ffb9dc6a79f/src/slave/slave.cpp#L2652:] > {code:cpp} > publishResources() > .then(defer(self(), [=] { > return containerizer->update( > executor->containerId, > executor->allocatedResources()); > })) > {code} > A destroyed executor might be dereferenced if it has been move to > {{Framework.completedExecutors}} and kicked out from this circular buffer. We > should refactor {{Slave::publishResources()}} and its uses to make the code > less fragile. -- This message was sent by Atlassian JIRA (v7.6.3#76005)