[jira] [Commented] (MESOS-7935) CMake build should fail immediately for in-source builds

2019-03-08 Thread Alexander Rukletsov (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16787804#comment-16787804 ] Alexander Rukletsov commented on MESOS-7935: [~csnate] — could you please upload the diff? >

[jira] [Commented] (MESOS-7935) CMake build should fail immediately for in-source builds

2018-03-08 Thread Andrew Schwartzmeyer (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16392027#comment-16392027 ] Andrew Schwartzmeyer commented on MESOS-7935: - I don't see a diff in that review. Also

[jira] [Commented] (MESOS-7935) CMake build should fail immediately for in-source builds

2017-10-23 Thread Nathan Jackson (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16215177#comment-16215177 ] Nathan Jackson commented on MESOS-7935: --- [~kaysoky] Have you had a chance to look at my review? >

[jira] [Commented] (MESOS-7935) CMake build should fail immediately for in-source builds

2017-10-13 Thread Nathan Jackson (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16204424#comment-16204424 ] Nathan Jackson commented on MESOS-7935: --- [~kaysoky] I submitted a review. I tried to add [~milipili]

[jira] [Commented] (MESOS-7935) CMake build should fail immediately for in-source builds

2017-10-13 Thread Damien Gerard (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16203458#comment-16203458 ] Damien Gerard commented on MESOS-7935: -- Maybe undocumented by many projects rely on that for years

[jira] [Commented] (MESOS-7935) CMake build should fail immediately for in-source builds

2017-10-11 Thread Joseph Wu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16200575#comment-16200575 ] Joseph Wu commented on MESOS-7935: -- The two options in Damien's suggestion are undocumented (by CMake),

[jira] [Commented] (MESOS-7935) CMake build should fail immediately for in-source builds

2017-10-10 Thread Nathan Jackson (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199807#comment-16199807 ] Nathan Jackson commented on MESOS-7935: --- Alternatively, this provides a better error message.

[jira] [Commented] (MESOS-7935) CMake build should fail immediately for in-source builds

2017-10-10 Thread Nathan Jackson (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16199747#comment-16199747 ] Nathan Jackson commented on MESOS-7935: --- Thanks for assigning this to me! > CMake build should fail

[jira] [Commented] (MESOS-7935) CMake build should fail immediately for in-source builds

2017-10-07 Thread Nathan Jackson (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16195748#comment-16195748 ] Nathan Jackson commented on MESOS-7935: --- I'm interested in taking this on. Seems like this would be

[jira] [Commented] (MESOS-7935) CMake build should fail immediately for in-source builds

2017-09-07 Thread Damien Gerard (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-7935?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16156813#comment-16156813 ] Damien Gerard commented on MESOS-7935: -- Sure. Not recommended and not working are 2 different things.