[jira] [Assigned] (MESOS-9114) cmake build is broken on macos
[
https://issues.apache.org/jira/browse/MESOS-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Mahler reassigned MESOS-9114:
--
Assignee: Chun-Hung Hsiao
> cmake build is broken on macos
> --
>
> Key: MESOS-9114
> URL: https://issues.apache.org/jira/browse/MESOS-9114
> Project: Mesos
> Issue Type: Bug
>Affects Versions: 1.7.0
> Environment: Currently broken e.g., macos-10.13.6, and passes on
> fedora-23.
>Reporter: Benjamin Bannier
>Assignee: Chun-Hung Hsiao
>Priority: Major
>
> Since the changes for MESOS-9092 have landed it seems impossible to perform a
> cmake-based build on macos. This seems independent of the used generator and
> both {{make}} and {{ninja}}-based builds appear broken, e.g.,
> {noformat}
> # cmake ~/src/mesos
> # make stout-tests
> ...
> 87%] Building CXX object
> 3rdparty/stout/tests/CMakeFiles/stout-tests.dir/uuid_tests.cpp.o
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/tests/json_tests.cpp:24:
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/json.hpp:41:
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/jsonify.hpp:36:10:
> fatal error: 'rapidjson/stringbuffer.h' file not found
> #include
> ^~
> ...
> {noformat}
> As a workaround I can apply the following patch,
> {code}
> diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
> index 9b0dfe0ab..b244267e8 100644
> --- a/3rdparty/CMakeLists.txt
> +++ b/3rdparty/CMakeLists.txt
> @@ -440,9 +440,7 @@ EXTERNAL(rapidjson ${RAPIDJSON_VERSION}
> ${CMAKE_CURRENT_BINARY_DIR})
> add_library(rapidjson INTERFACE)
> add_dependencies(rapidjson ${RAPIDJSON_TARGET})
> -target_include_directories(
> -rapidjson INTERFACE
> -${RAPIDJSON_ROOT}/rapidjson-${RAPIDJSON_VERSION}/include)
> +target_include_directories(rapidjson INTERFACE ${RAPIDJSON_ROOT}/include)
> ExternalProject_Add(
>${RAPIDJSON_TARGET}
> {code}
> This however seems to break cmake-based builds on Linux.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-9114) cmake build is broken on macos
[
https://issues.apache.org/jira/browse/MESOS-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559106#comment-16559106
]
Chun-Hung Hsiao commented on MESOS-9114:
Committed the following patch but I haven't found a Fedora 23 image to test
what's failing so I'm leaving this ticket open.
{noformat}
commit e3f9f3ac9eed0cab0b1a27c10e8c60832105874e
Author: Chun-Hung Hsiao
Date: Thu Jul 26 16:31:44 2018 -0700
Fixed rapidjson cmake compilation.
Review: https://reviews.apache.org/r/68073{noformat}
> cmake build is broken on macos
> --
>
> Key: MESOS-9114
> URL: https://issues.apache.org/jira/browse/MESOS-9114
> Project: Mesos
> Issue Type: Bug
>Affects Versions: 1.7.0
> Environment: Currently broken e.g., macos-10.13.6, and passes on
> fedora-23.
>Reporter: Benjamin Bannier
>Priority: Major
>
> Since the changes for MESOS-9092 have landed it seems impossible to perform a
> cmake-based build on macos. This seems independent of the used generator and
> both {{make}} and {{ninja}}-based builds appear broken, e.g.,
> {noformat}
> # cmake ~/src/mesos
> # make stout-tests
> ...
> 87%] Building CXX object
> 3rdparty/stout/tests/CMakeFiles/stout-tests.dir/uuid_tests.cpp.o
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/tests/json_tests.cpp:24:
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/json.hpp:41:
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/jsonify.hpp:36:10:
> fatal error: 'rapidjson/stringbuffer.h' file not found
> #include
> ^~
> ...
> {noformat}
> As a workaround I can apply the following patch,
> {code}
> diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
> index 9b0dfe0ab..b244267e8 100644
> --- a/3rdparty/CMakeLists.txt
> +++ b/3rdparty/CMakeLists.txt
> @@ -440,9 +440,7 @@ EXTERNAL(rapidjson ${RAPIDJSON_VERSION}
> ${CMAKE_CURRENT_BINARY_DIR})
> add_library(rapidjson INTERFACE)
> add_dependencies(rapidjson ${RAPIDJSON_TARGET})
> -target_include_directories(
> -rapidjson INTERFACE
> -${RAPIDJSON_ROOT}/rapidjson-${RAPIDJSON_VERSION}/include)
> +target_include_directories(rapidjson INTERFACE ${RAPIDJSON_ROOT}/include)
> ExternalProject_Add(
>${RAPIDJSON_TARGET}
> {code}
> This however seems to break cmake-based builds on Linux.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (MESOS-8395) Enable GRPC compilation by default.
[ https://issues.apache.org/jira/browse/MESOS-8395?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Chun-Hung Hsiao reassigned MESOS-8395: -- Assignee: Chun-Hung Hsiao Story Points: 1 (was: 2) Target Version/s: 1.7.0 > Enable GRPC compilation by default. > --- > > Key: MESOS-8395 > URL: https://issues.apache.org/jira/browse/MESOS-8395 > Project: Mesos > Issue Type: Task >Reporter: Chun-Hung Hsiao >Assignee: Chun-Hung Hsiao >Priority: Major > -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MESOS-9114) cmake build is broken on macos
[
https://issues.apache.org/jira/browse/MESOS-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559034#comment-16559034
]
Benjamin Bannier edited comment on MESOS-9114 at 7/26/18 11:23 PM:
---
We should probably fix the archive permissions and apply the patch from the
description.
Since this can be reproduced in a bare cmake project with an external project
just extracting our current tarball we probably should also report this to
cmake as incorrect behavior (the failed recursive remove of {{${directory}}}
should not have failed silently).
was (Author: bbannier):
We should probably fix the archive permissions and apply the patch from the
description.
Since this can be reproduced in a bare cmake project with an external project
just extracting our current tarball we probably should also report this to
cmake as incorrect behavior (the recursive remove of {{${directory}}} should
not have failed silently).
> cmake build is broken on macos
> --
>
> Key: MESOS-9114
> URL: https://issues.apache.org/jira/browse/MESOS-9114
> Project: Mesos
> Issue Type: Bug
>Affects Versions: 1.7.0
> Environment: macos-10.13.6
>Reporter: Benjamin Bannier
>Priority: Major
>
> Since the changes for MESOS-9092 have landed it seems impossible to perform a
> cmake-based build on macos. This seems independent of the used generator and
> both {{make}} and {{ninja}}-based builds appear broken, e.g.,
> {noformat}
> # cmake ~/src/mesos
> # make stout-tests
> ...
> 87%] Building CXX object
> 3rdparty/stout/tests/CMakeFiles/stout-tests.dir/uuid_tests.cpp.o
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/tests/json_tests.cpp:24:
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/json.hpp:41:
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/jsonify.hpp:36:10:
> fatal error: 'rapidjson/stringbuffer.h' file not found
> #include
> ^~
> ...
> {noformat}
> As a workaround I can apply the following patch,
> {code}
> diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
> index 9b0dfe0ab..b244267e8 100644
> --- a/3rdparty/CMakeLists.txt
> +++ b/3rdparty/CMakeLists.txt
> @@ -440,9 +440,7 @@ EXTERNAL(rapidjson ${RAPIDJSON_VERSION}
> ${CMAKE_CURRENT_BINARY_DIR})
> add_library(rapidjson INTERFACE)
> add_dependencies(rapidjson ${RAPIDJSON_TARGET})
> -target_include_directories(
> -rapidjson INTERFACE
> -${RAPIDJSON_ROOT}/rapidjson-${RAPIDJSON_VERSION}/include)
> +target_include_directories(rapidjson INTERFACE ${RAPIDJSON_ROOT}/include)
> ExternalProject_Add(
>${RAPIDJSON_TARGET}
> {code}
> This however seems to break cmake-based builds on Linux.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-9114) cmake build is broken on macos
[
https://issues.apache.org/jira/browse/MESOS-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559034#comment-16559034
]
Benjamin Bannier commented on MESOS-9114:
-
We should probably fix the archive permissions and apply the patch from the
description.
Since this can be reproduced in a bare cmake project with an external project
just extracting our current tarball we probably should also report this to
cmake as incorrect behavior (the recursive remove of {{${directory}}} should
not have failed silently).
> cmake build is broken on macos
> --
>
> Key: MESOS-9114
> URL: https://issues.apache.org/jira/browse/MESOS-9114
> Project: Mesos
> Issue Type: Bug
>Affects Versions: 1.7.0
> Environment: macos-10.13.6
>Reporter: Benjamin Bannier
>Priority: Major
>
> Since the changes for MESOS-9092 have landed it seems impossible to perform a
> cmake-based build on macos. This seems independent of the used generator and
> both {{make}} and {{ninja}}-based builds appear broken, e.g.,
> {noformat}
> # cmake ~/src/mesos
> # make stout-tests
> ...
> 87%] Building CXX object
> 3rdparty/stout/tests/CMakeFiles/stout-tests.dir/uuid_tests.cpp.o
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/tests/json_tests.cpp:24:
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/json.hpp:41:
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/jsonify.hpp:36:10:
> fatal error: 'rapidjson/stringbuffer.h' file not found
> #include
> ^~
> ...
> {noformat}
> As a workaround I can apply the following patch,
> {code}
> diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
> index 9b0dfe0ab..b244267e8 100644
> --- a/3rdparty/CMakeLists.txt
> +++ b/3rdparty/CMakeLists.txt
> @@ -440,9 +440,7 @@ EXTERNAL(rapidjson ${RAPIDJSON_VERSION}
> ${CMAKE_CURRENT_BINARY_DIR})
> add_library(rapidjson INTERFACE)
> add_dependencies(rapidjson ${RAPIDJSON_TARGET})
> -target_include_directories(
> -rapidjson INTERFACE
> -${RAPIDJSON_ROOT}/rapidjson-${RAPIDJSON_VERSION}/include)
> +target_include_directories(rapidjson INTERFACE ${RAPIDJSON_ROOT}/include)
> ExternalProject_Add(
>${RAPIDJSON_TARGET}
> {code}
> This however seems to break cmake-based builds on Linux.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Comment Edited] (MESOS-9114) cmake build is broken on macos
[
https://issues.apache.org/jira/browse/MESOS-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559030#comment-16559030
]
Benjamin Bannier edited comment on MESOS-9114 at 7/26/18 11:09 PM:
---
I did some more digging here. The generated files look identical, and so do
manually extracted tarballs. That made we suspect the cmake code doing the
rename of the extracted directory structure,
[https://github.com/Kitware/CMake/blob/e500d6074112c975c96678c0c5f38a2b7e9718b6/Modules/ExternalProject.cmake#L1561-L1566]
{code:java}
message(STATUS \"extracting... [rename]\")
file(REMOVE_RECURSE \${directory})
get_filename_component(contents \${contents} ABSOLUTE)
file(RENAME \${contents} \${directory})
{code}
This extracts the tarball and then moves its content to the final location.
This step seems to fail.
Cmake seems to have an issue with our tarball.
If I extract the tarball, make the top-level directory group-writable, and
repackage, the contents end up in the expected location (no additional
subdirectory under {{src/}}) and the code builds fine with the patch from the
description on both macos and linux.
{code}
$ tar xf /SRC/mesos/3rdparty/rapidjson-1.1.0.tar.gz
$ ls -ld rapidjson-1.1.0
drwxr-xr-x. 3 bbannier bbannier 160 Jul 19 02:15 rapidjson-1.1.0
$ chmod g+w rapidjson-1.1.0
$ tar czf rapidjson-1.1.0.tar.gz rapidjson-1.1.0
$ mv rapidjson-1.1.0.tar.gz /SRC/mesos/3rdparty/rapidjson-1.1.0.tar.gz
{code}
was (Author: bbannier):
I did some more digging here. The generated files look identical, and so do
manually extracted tarballs. That made we suspect the cmake code doing the
rename of the extracted directory structure,
[https://github.com/Kitware/CMake/blob/e500d6074112c975c96678c0c5f38a2b7e9718b6/Modules/ExternalProject.cmake#L1561-L1566]
{code:java}
message(STATUS \"extracting... [rename]\")
file(REMOVE_RECURSE \${directory})
get_filename_component(contents \${contents} ABSOLUTE)
file(RENAME \${contents} \${directory})
{code}
This extracts the tarball and then moves its content to the final contents.
This step fails.
Cmake seems to have an issue with our tarball.
If I extract the tarball, make the top-level directory group-writable, and
repackage, the contents end up in the expected location (no additional
subdirectory under {{src/}}) and the code builds fine with the patch from the
description on both macos and linux.
{code}
$ tar xf /SRC/mesos/3rdparty/rapidjson-1.1.0.tar.gz
$ ls -ld rapidjson-1.1.0
drwxr-xr-x. 3 bbannier bbannier 160 Jul 19 02:15 rapidjson-1.1.0
$ chmod g+w rapidjson-1.1.0
$ tar czf rapidjson-1.1.0.tar.gz rapidjson-1.1.0
$ mv rapidjson-1.1.0.tar.gz /SRC/mesos/3rdparty/rapidjson-1.1.0.tar.gz
{code}
> cmake build is broken on macos
> --
>
> Key: MESOS-9114
> URL: https://issues.apache.org/jira/browse/MESOS-9114
> Project: Mesos
> Issue Type: Bug
>Affects Versions: 1.7.0
> Environment: macos-10.13.6
>Reporter: Benjamin Bannier
>Priority: Major
>
> Since the changes for MESOS-9092 have landed it seems impossible to perform a
> cmake-based build on macos. This seems independent of the used generator and
> both {{make}} and {{ninja}}-based builds appear broken, e.g.,
> {noformat}
> # cmake ~/src/mesos
> # make stout-tests
> ...
> 87%] Building CXX object
> 3rdparty/stout/tests/CMakeFiles/stout-tests.dir/uuid_tests.cpp.o
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/tests/json_tests.cpp:24:
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/json.hpp:41:
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/jsonify.hpp:36:10:
> fatal error: 'rapidjson/stringbuffer.h' file not found
> #include
> ^~
> ...
> {noformat}
> As a workaround I can apply the following patch,
> {code}
> diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
> index 9b0dfe0ab..b244267e8 100644
> --- a/3rdparty/CMakeLists.txt
> +++ b/3rdparty/CMakeLists.txt
> @@ -440,9 +440,7 @@ EXTERNAL(rapidjson ${RAPIDJSON_VERSION}
> ${CMAKE_CURRENT_BINARY_DIR})
> add_library(rapidjson INTERFACE)
> add_dependencies(rapidjson ${RAPIDJSON_TARGET})
> -target_include_directories(
> -rapidjson INTERFACE
> -${RAPIDJSON_ROOT}/rapidjson-${RAPIDJSON_VERSION}/include)
> +target_include_directories(rapidjson INTERFACE ${RAPIDJSON_ROOT}/include)
> ExternalProject_Add(
>${RAPIDJSON_TARGET}
> {code}
> This however seems to break cmake-based builds on Linux.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-9114) cmake build is broken on macos
[
https://issues.apache.org/jira/browse/MESOS-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16559030#comment-16559030
]
Benjamin Bannier commented on MESOS-9114:
-
I did some more digging here. The generated files look identical, and so do
manually extracted tarballs. That made we suspect the cmake code doing the
rename of the extracted directory structure,
[https://github.com/Kitware/CMake/blob/e500d6074112c975c96678c0c5f38a2b7e9718b6/Modules/ExternalProject.cmake#L1561-L1566]
{code:java}
message(STATUS \"extracting... [rename]\")
file(REMOVE_RECURSE \${directory})
get_filename_component(contents \${contents} ABSOLUTE)
file(RENAME \${contents} \${directory})
{code}
This extracts the tarball and then moves its content to the final contents.
This step fails.
Cmake seems to have an issue with our tarball.
If I extract the tarball, make the top-level directory group-writable, and
repackage, the contents end up in the expected location (no additional
subdirectory under {{src/}}) and the code builds fine with the patch from the
description on both macos and linux.
{code}
$ tar xf /SRC/mesos/3rdparty/rapidjson-1.1.0.tar.gz
$ ls -ld rapidjson-1.1.0
drwxr-xr-x. 3 bbannier bbannier 160 Jul 19 02:15 rapidjson-1.1.0
$ chmod g+w rapidjson-1.1.0
$ tar czf rapidjson-1.1.0.tar.gz rapidjson-1.1.0
$ mv rapidjson-1.1.0.tar.gz /SRC/mesos/3rdparty/rapidjson-1.1.0.tar.gz
{code}
> cmake build is broken on macos
> --
>
> Key: MESOS-9114
> URL: https://issues.apache.org/jira/browse/MESOS-9114
> Project: Mesos
> Issue Type: Bug
>Affects Versions: 1.7.0
> Environment: macos-10.13.6
>Reporter: Benjamin Bannier
>Priority: Major
>
> Since the changes for MESOS-9092 have landed it seems impossible to perform a
> cmake-based build on macos. This seems independent of the used generator and
> both {{make}} and {{ninja}}-based builds appear broken, e.g.,
> {noformat}
> # cmake ~/src/mesos
> # make stout-tests
> ...
> 87%] Building CXX object
> 3rdparty/stout/tests/CMakeFiles/stout-tests.dir/uuid_tests.cpp.o
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/tests/json_tests.cpp:24:
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/json.hpp:41:
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/jsonify.hpp:36:10:
> fatal error: 'rapidjson/stringbuffer.h' file not found
> #include
> ^~
> ...
> {noformat}
> As a workaround I can apply the following patch,
> {code}
> diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
> index 9b0dfe0ab..b244267e8 100644
> --- a/3rdparty/CMakeLists.txt
> +++ b/3rdparty/CMakeLists.txt
> @@ -440,9 +440,7 @@ EXTERNAL(rapidjson ${RAPIDJSON_VERSION}
> ${CMAKE_CURRENT_BINARY_DIR})
> add_library(rapidjson INTERFACE)
> add_dependencies(rapidjson ${RAPIDJSON_TARGET})
> -target_include_directories(
> -rapidjson INTERFACE
> -${RAPIDJSON_ROOT}/rapidjson-${RAPIDJSON_VERSION}/include)
> +target_include_directories(rapidjson INTERFACE ${RAPIDJSON_ROOT}/include)
> ExternalProject_Add(
>${RAPIDJSON_TARGET}
> {code}
> This however seems to break cmake-based builds on Linux.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-9114) cmake build is broken on macos
[
https://issues.apache.org/jira/browse/MESOS-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558963#comment-16558963
]
Joseph Wu commented on MESOS-9114:
--
The patch looks correct, as I wouldn't expect the extracted tarball to have an
extra folder (presumably named after the tarball).
The CMake build fails for me on both OSX and Ubuntu 16 (VM) without the patch.
> cmake build is broken on macos
> --
>
> Key: MESOS-9114
> URL: https://issues.apache.org/jira/browse/MESOS-9114
> Project: Mesos
> Issue Type: Bug
>Affects Versions: 1.7.0
> Environment: macos-10.13.6
>Reporter: Benjamin Bannier
>Priority: Major
>
> Since the changes for MESOS-9092 have landed it seems impossible to perform a
> cmake-based build on macos. This seems independent of the used generator and
> both {{make}} and {{ninja}}-based builds appear broken, e.g.,
> {noformat}
> # cmake ~/src/mesos
> # make stout-tests
> ...
> 87%] Building CXX object
> 3rdparty/stout/tests/CMakeFiles/stout-tests.dir/uuid_tests.cpp.o
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/tests/json_tests.cpp:24:
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/json.hpp:41:
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/jsonify.hpp:36:10:
> fatal error: 'rapidjson/stringbuffer.h' file not found
> #include
> ^~
> ...
> {noformat}
> As a workaround I can apply the following patch,
> {code}
> diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
> index 9b0dfe0ab..b244267e8 100644
> --- a/3rdparty/CMakeLists.txt
> +++ b/3rdparty/CMakeLists.txt
> @@ -440,9 +440,7 @@ EXTERNAL(rapidjson ${RAPIDJSON_VERSION}
> ${CMAKE_CURRENT_BINARY_DIR})
> add_library(rapidjson INTERFACE)
> add_dependencies(rapidjson ${RAPIDJSON_TARGET})
> -target_include_directories(
> -rapidjson INTERFACE
> -${RAPIDJSON_ROOT}/rapidjson-${RAPIDJSON_VERSION}/include)
> +target_include_directories(rapidjson INTERFACE ${RAPIDJSON_ROOT}/include)
> ExternalProject_Add(
>${RAPIDJSON_TARGET}
> {code}
> This however seems to break cmake-based builds on Linux.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-8038) Launching GPU task sporadically fails.
[ https://issues.apache.org/jira/browse/MESOS-8038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558938#comment-16558938 ] Zhitao Li commented on MESOS-8038: -- I just attached another full agent log with this issue. > Launching GPU task sporadically fails. > -- > > Key: MESOS-8038 > URL: https://issues.apache.org/jira/browse/MESOS-8038 > Project: Mesos > Issue Type: Bug > Components: allocation, containerization, gpu >Affects Versions: 1.4.0 >Reporter: Sai Teja Ranuva >Assignee: Zhitao Li >Priority: Critical > Attachments: mesos-master.log, mesos-slave-with-issue-uber.txt, > mesos-slave.INFO.log > > > I was running a job which uses GPUs. It runs fine most of the time. > But occasionally I see the following message in the mesos log. > "Collect failed: Requested 1 but only 0 available" > Followed by executor getting killed and the tasks getting lost. This happens > even before the the job starts. A little search in the code base points me to > something related to GPU resource being the probable cause. > There is no deterministic way that this can be reproduced. It happens > occasionally. > I have attached the slave log for the issue. > Using 1.4.0 Mesos Master and 1.4.0 Mesos Slave. -- This message was sent by Atlassian JIRA (v7.6.3#76005)
[jira] [Comment Edited] (MESOS-9114) cmake build is broken on macos
[
https://issues.apache.org/jira/browse/MESOS-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558927#comment-16558927
]
Benjamin Bannier edited comment on MESOS-9114 at 7/26/18 9:42 PM:
--
/cc [~bmahler] [~alexr] [~bennoe]
was (Author: bbannier):
/cc @bmahler @alexr [~bennoe]
> cmake build is broken on macos
> --
>
> Key: MESOS-9114
> URL: https://issues.apache.org/jira/browse/MESOS-9114
> Project: Mesos
> Issue Type: Bug
>Affects Versions: 1.7.0
> Environment: macos-10.13.6
>Reporter: Benjamin Bannier
>Priority: Major
>
> Since the changes for MESOS-9092 have landed it seems impossible to perform a
> cmake-based build on macos. This seems independent of the used generator and
> both {{make}} and {{ninja}}-based builds appear broken, e.g.,
> {noformat}
> # cmake ~/src/mesos
> # make stout-tests
> ...
> 87%] Building CXX object
> 3rdparty/stout/tests/CMakeFiles/stout-tests.dir/uuid_tests.cpp.o
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/tests/json_tests.cpp:24:
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/json.hpp:41:
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/jsonify.hpp:36:10:
> fatal error: 'rapidjson/stringbuffer.h' file not found
> #include
> ^~
> ...
> {noformat}
> As a workaround I can apply the following patch,
> {code}
> diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
> index 9b0dfe0ab..b244267e8 100644
> --- a/3rdparty/CMakeLists.txt
> +++ b/3rdparty/CMakeLists.txt
> @@ -440,9 +440,7 @@ EXTERNAL(rapidjson ${RAPIDJSON_VERSION}
> ${CMAKE_CURRENT_BINARY_DIR})
> add_library(rapidjson INTERFACE)
> add_dependencies(rapidjson ${RAPIDJSON_TARGET})
> -target_include_directories(
> -rapidjson INTERFACE
> -${RAPIDJSON_ROOT}/rapidjson-${RAPIDJSON_VERSION}/include)
> +target_include_directories(rapidjson INTERFACE ${RAPIDJSON_ROOT}/include)
> ExternalProject_Add(
>${RAPIDJSON_TARGET}
> {code}
> This however seems to break cmake-based builds on Linux.
> I suspect this might be related to diverging behavior of {{tar}} on GNU or
> BSD platforms.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-9114) cmake build is broken on macos
[
https://issues.apache.org/jira/browse/MESOS-9114?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16558927#comment-16558927
]
Benjamin Bannier commented on MESOS-9114:
-
/cc @bmahler @alexr [~bennoe]
> cmake build is broken on macos
> --
>
> Key: MESOS-9114
> URL: https://issues.apache.org/jira/browse/MESOS-9114
> Project: Mesos
> Issue Type: Bug
>Affects Versions: 1.7.0
> Environment: macos-10.13.6
>Reporter: Benjamin Bannier
>Priority: Major
>
> Since the changes for MESOS-9092 have landed it seems impossible to perform a
> cmake-based build on macos. This seems independent of the used generator and
> both {{make}} and {{ninja}}-based builds appear broken, e.g.,
> {noformat}
> # cmake ~/src/mesos
> # make stout-tests
> ...
> 87%] Building CXX object
> 3rdparty/stout/tests/CMakeFiles/stout-tests.dir/uuid_tests.cpp.o
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/tests/json_tests.cpp:24:
> In file included from
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/json.hpp:41:
> /Users/bbannier/src/mesos/3rdparty/stout/include/stout/jsonify.hpp:36:10:
> fatal error: 'rapidjson/stringbuffer.h' file not found
> #include
> ^~
> ...
> {noformat}
> As a workaround I can apply the following patch,
> {code}
> diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
> index 9b0dfe0ab..b244267e8 100644
> --- a/3rdparty/CMakeLists.txt
> +++ b/3rdparty/CMakeLists.txt
> @@ -440,9 +440,7 @@ EXTERNAL(rapidjson ${RAPIDJSON_VERSION}
> ${CMAKE_CURRENT_BINARY_DIR})
> add_library(rapidjson INTERFACE)
> add_dependencies(rapidjson ${RAPIDJSON_TARGET})
> -target_include_directories(
> -rapidjson INTERFACE
> -${RAPIDJSON_ROOT}/rapidjson-${RAPIDJSON_VERSION}/include)
> +target_include_directories(rapidjson INTERFACE ${RAPIDJSON_ROOT}/include)
> ExternalProject_Add(
>${RAPIDJSON_TARGET}
> {code}
> This however seems to break cmake-based builds on Linux.
> I suspect this might be related to diverging behavior of {{tar}} on GNU or
> BSD platforms.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Created] (MESOS-9114) cmake build is broken on macos
Benjamin Bannier created MESOS-9114:
---
Summary: cmake build is broken on macos
Key: MESOS-9114
URL: https://issues.apache.org/jira/browse/MESOS-9114
Project: Mesos
Issue Type: Bug
Affects Versions: 1.7.0
Environment: macos-10.13.6
Reporter: Benjamin Bannier
Since the changes for MESOS-9092 have landed it seems impossible to perform a
cmake-based build on macos. This seems independent of the used generator and
both {{make}} and {{ninja}}-based builds appear broken, e.g.,
{noformat}
# cmake ~/src/mesos
# make stout-tests
...
87%] Building CXX object
3rdparty/stout/tests/CMakeFiles/stout-tests.dir/uuid_tests.cpp.o
In file included from
/Users/bbannier/src/mesos/3rdparty/stout/tests/json_tests.cpp:24:
In file included from
/Users/bbannier/src/mesos/3rdparty/stout/include/stout/json.hpp:41:
/Users/bbannier/src/mesos/3rdparty/stout/include/stout/jsonify.hpp:36:10: fatal
error: 'rapidjson/stringbuffer.h' file not found
#include
^~
...
{noformat}
As a workaround I can apply the following patch,
{code}
diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
index 9b0dfe0ab..b244267e8 100644
--- a/3rdparty/CMakeLists.txt
+++ b/3rdparty/CMakeLists.txt
@@ -440,9 +440,7 @@ EXTERNAL(rapidjson ${RAPIDJSON_VERSION}
${CMAKE_CURRENT_BINARY_DIR})
add_library(rapidjson INTERFACE)
add_dependencies(rapidjson ${RAPIDJSON_TARGET})
-target_include_directories(
-rapidjson INTERFACE
-${RAPIDJSON_ROOT}/rapidjson-${RAPIDJSON_VERSION}/include)
+target_include_directories(rapidjson INTERFACE ${RAPIDJSON_ROOT}/include)
ExternalProject_Add(
${RAPIDJSON_TARGET}
{code}
This however seems to break cmake-based builds on Linux.
I suspect this might be related to diverging behavior of {{tar}} on GNU or BSD
platforms.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Assigned] (MESOS-8994) Ensure that the cmake build knows about all source files in the autotools build
[
https://issues.apache.org/jira/browse/MESOS-8994?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Benjamin Bannier reassigned MESOS-8994:
---
Assignee: Andrew Schwartzmeyer (was: Benjamin Bannier)
Assigning to you [~andschwa] as you have https://reviews.apache.org/r/67751/
out ATM. Feel free to assign back to me once that lands and we can hook up
e.g., a post-commit hook.
> Ensure that the cmake build knows about all source files in the autotools
> build
> ---
>
> Key: MESOS-8994
> URL: https://issues.apache.org/jira/browse/MESOS-8994
> Project: Mesos
> Issue Type: Improvement
> Components: build, cmake
>Reporter: Benjamin Bannier
>Assignee: Andrew Schwartzmeyer
>Priority: Critical
>
> We currently maintain two build systems in parallel with autotools still
> being used by the larger part of contributors and cmake catching up in terms
> of coverage and features.
>
> This has lead to situations where certain features were added only to the
> autotools build while updating the cmake build was either implicitly (without
> creating a ticket) deferred or forgotten. Identifying such missing coverage
> makes it harder to gauge where the two build systems stand in terms of
> feature parity and how much work is left before autotools can be retired.
> We should update the cmake build setup to explicitly check whether any
> sources files (headers and sources) unknown to it exist in the tree. Until
> full parity is reached we would likely need to maintain a whitelist of files
> known to be missing in the cmake build (this whitelist would at the same time
> serve as a {{TODO}} list). The LLVM project uses the following function to
> perform closely related work,
> https://github.com/llvm-mirror/llvm/blob/master/cmake/modules/LLVMProcessSources.cmake#L70-L111.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
