[jira] [Commented] (MESOS-5346) Some endpoints do not specify their allowed request methods.
[
https://issues.apache.org/jira/browse/MESOS-5346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15814329#comment-15814329
]
UENISHI Kota commented on MESOS-5346:
-
I'd like to note here that and endpoint {{/files/download}} also has weird
behavior where agents respond full body against any methods like {{POST}}
{{DELETE}} or even {{HEAD}}. Also, under {{GET}} request recognizing {{Range}}
header element to enable smarter download of file contents in a sandbox would
be very nice.
I consider this important because there may be a case where the size of files
ranges like up to ~10GB. Although necessary files or files larger than that
should be saved to more reliable storage like HDFS or S3, depending on result
of a task, files remaining in the sandbox would be sometimes downloaded. Nobody
expects full 10GB body of a file on just HEADing it.
> Some endpoints do not specify their allowed request methods.
>
>
> Key: MESOS-5346
> URL: https://issues.apache.org/jira/browse/MESOS-5346
> Project: Mesos
> Issue Type: Bug
> Components: security, technical debt
>Reporter: Jan Schlicht
> Labels: http, mesosphere, security, tech-debt
>
> Some HTTP endpoints (for example "/flags" or "/state") create a response
> regardless of what the request method is. For example an HTTP POST to the
> "/state" endpoint will create the same response as an HTTP GET.
> While this inconsistency isn't harmful at the moment, it will get problematic
> when authorization is implemented, using separate ACLs for endpoints that can
> be GETed and endpoints that can be POSTed to.
> Validation of the request method should be added to all endpoints, e.g.
> "/state" should return a 405 (Method Not Allowed) when POSTed to.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MESOS-5979) elfio-3.1.patch is actually not applied
[
https://issues.apache.org/jira/browse/MESOS-5979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
UENISHI Kota updated MESOS-5979:
Attachment: (was: apply-elfio-patch.patch)
> elfio-3.1.patch is actually not applied
> ---
>
> Key: MESOS-5979
> URL: https://issues.apache.org/jira/browse/MESOS-5979
> Project: Mesos
> Issue Type: Bug
> Components: build
> Environment: Linux with Nvidia GPU
>Reporter: UENISHI Kota
>
> This does not affect any released version, but affects the HEAD of 1.0.x
> branch and any commit after 89cfa6e. Due to this, mesos-agent will never be
> able start up when it tries to recognize GPU library that has .note.ABI-tag.
> The patch is tiny; I'll follow up with Review Board if needed.
> {code}
> $ cat ../apply-elfio-patch.patch
> diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
> index b966e58..6dac5bd 100755
> --- a/3rdparty/CMakeLists.txt
> +++ b/3rdparty/CMakeLists.txt
> @@ -96,6 +96,8 @@ if (NOT WIN32)
># under the C++11 standard. cf. MESOS-860, MESOS-966.
>PATCH_CMD(${MESOS_3RDPARTY_SRC}/glog-0.3.3.patch GLOG_PATCH_CMD)
>
> + PATCH_CMD(${MESOS_3RDPARTY_SRC}/elfio-3.1.patch ELFIO_PATCH_CMD)
> +
># NOTE: `libev` is "installed" into a lib directory, see "NOTE: (fix for
># MESOS-3250)" comment above for explanation.
>set(LIBEV_CONFIG_CMD ${LIBEV_ROOT}/configure --prefix=${LIBEV_ROOT}-lib)
> @@ -153,6 +155,7 @@ ExternalProject_Add(
> ExternalProject_Add(
>${ELFIO_TARGET}
>PREFIX${ELFIO_CMAKE_ROOT}
> + PATCH_COMMAND ${ELFIO_PATCH_CMD}
>CONFIGURE_COMMAND ${CMAKE_NOOP}
>BUILD_COMMAND ${CMAKE_NOOP}
>INSTALL_COMMAND ${CMAKE_NOOP}
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-5979) elfio-3.1.patch is actually not applied
[
https://issues.apache.org/jira/browse/MESOS-5979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15418292#comment-15418292
]
UENISHI Kota commented on MESOS-5979:
-
Although I posted https://reviews.apache.org/r/51026/ with ELFIO-3.2 which is
downloaded from SourceForge site ( http://elfio.sourceforge.net/ ), it does not
contain Windows .sln files. I wonder how they're built, but unfortunately I
don't have Windows environment so I can't help that. But I think this patch is
necessary for 1.0.1 at least for Linux, as this issue is not solved in
1.0.1-rc1. CC [~klueska] [~hausdorff]
> elfio-3.1.patch is actually not applied
> ---
>
> Key: MESOS-5979
> URL: https://issues.apache.org/jira/browse/MESOS-5979
> Project: Mesos
> Issue Type: Bug
> Components: build
> Environment: Linux with Nvidia GPU
>Reporter: UENISHI Kota
> Attachments: apply-elfio-patch.patch
>
>
> This does not affect any released version, but affects the HEAD of 1.0.x
> branch and any commit after 89cfa6e. Due to this, mesos-agent will never be
> able start up when it tries to recognize GPU library that has .note.ABI-tag.
> The patch is tiny; I'll follow up with Review Board if needed.
> {code}
> $ cat ../apply-elfio-patch.patch
> diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
> index b966e58..6dac5bd 100755
> --- a/3rdparty/CMakeLists.txt
> +++ b/3rdparty/CMakeLists.txt
> @@ -96,6 +96,8 @@ if (NOT WIN32)
># under the C++11 standard. cf. MESOS-860, MESOS-966.
>PATCH_CMD(${MESOS_3RDPARTY_SRC}/glog-0.3.3.patch GLOG_PATCH_CMD)
>
> + PATCH_CMD(${MESOS_3RDPARTY_SRC}/elfio-3.1.patch ELFIO_PATCH_CMD)
> +
># NOTE: `libev` is "installed" into a lib directory, see "NOTE: (fix for
># MESOS-3250)" comment above for explanation.
>set(LIBEV_CONFIG_CMD ${LIBEV_ROOT}/configure --prefix=${LIBEV_ROOT}-lib)
> @@ -153,6 +155,7 @@ ExternalProject_Add(
> ExternalProject_Add(
>${ELFIO_TARGET}
>PREFIX${ELFIO_CMAKE_ROOT}
> + PATCH_COMMAND ${ELFIO_PATCH_CMD}
>CONFIGURE_COMMAND ${CMAKE_NOOP}
>BUILD_COMMAND ${CMAKE_NOOP}
>INSTALL_COMMAND ${CMAKE_NOOP}
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-5979) elfio-3.1.patch is actually not applied
[
https://issues.apache.org/jira/browse/MESOS-5979?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15407063#comment-15407063
]
UENISHI Kota commented on MESOS-5979:
-
As Kevin commented on the review board, upstream ELFIO has our wanted change -
just updating it looks good to me, without adding further tests. I wonder what
kind of tests are suitable for this type of build issue, esp. on Windows.
> elfio-3.1.patch is actually not applied
> ---
>
> Key: MESOS-5979
> URL: https://issues.apache.org/jira/browse/MESOS-5979
> Project: Mesos
> Issue Type: Bug
> Components: build
> Environment: Linux with Nvidia GPU
>Reporter: UENISHI Kota
> Attachments: apply-elfio-patch.patch
>
>
> This does not affect any released version, but affects the HEAD of 1.0.x
> branch and any commit after 89cfa6e. Due to this, mesos-agent will never be
> able start up when it tries to recognize GPU library that has .note.ABI-tag.
> The patch is tiny; I'll follow up with Review Board if needed.
> {code}
> $ cat ../apply-elfio-patch.patch
> diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
> index b966e58..6dac5bd 100755
> --- a/3rdparty/CMakeLists.txt
> +++ b/3rdparty/CMakeLists.txt
> @@ -96,6 +96,8 @@ if (NOT WIN32)
># under the C++11 standard. cf. MESOS-860, MESOS-966.
>PATCH_CMD(${MESOS_3RDPARTY_SRC}/glog-0.3.3.patch GLOG_PATCH_CMD)
>
> + PATCH_CMD(${MESOS_3RDPARTY_SRC}/elfio-3.1.patch ELFIO_PATCH_CMD)
> +
># NOTE: `libev` is "installed" into a lib directory, see "NOTE: (fix for
># MESOS-3250)" comment above for explanation.
>set(LIBEV_CONFIG_CMD ${LIBEV_ROOT}/configure --prefix=${LIBEV_ROOT}-lib)
> @@ -153,6 +155,7 @@ ExternalProject_Add(
> ExternalProject_Add(
>${ELFIO_TARGET}
>PREFIX${ELFIO_CMAKE_ROOT}
> + PATCH_COMMAND ${ELFIO_PATCH_CMD}
>CONFIGURE_COMMAND ${CMAKE_NOOP}
>BUILD_COMMAND ${CMAKE_NOOP}
>INSTALL_COMMAND ${CMAKE_NOOP}
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Updated] (MESOS-5979) elfio-3.1.patch is actually not applied
[
https://issues.apache.org/jira/browse/MESOS-5979?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
UENISHI Kota updated MESOS-5979:
Attachment: apply-elfio-patch.patch
> elfio-3.1.patch is actually not applied
> ---
>
> Key: MESOS-5979
> URL: https://issues.apache.org/jira/browse/MESOS-5979
> Project: Mesos
> Issue Type: Bug
> Components: build
> Environment: Linux with Nvidia GPU
>Reporter: UENISHI Kota
> Attachments: apply-elfio-patch.patch
>
>
> This does not affect any released version, but affects the HEAD of 1.0.x
> branch and any commit after 89cfa6e. Due to this, mesos-agent will never be
> able start up when it tries to recognize GPU library that has .note.ABI-tag.
> The patch is tiny; I'll follow up with Review Board if needed.
> {code}
> $ cat ../apply-elfio-patch.patch
> diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
> index b966e58..6dac5bd 100755
> --- a/3rdparty/CMakeLists.txt
> +++ b/3rdparty/CMakeLists.txt
> @@ -96,6 +96,8 @@ if (NOT WIN32)
># under the C++11 standard. cf. MESOS-860, MESOS-966.
>PATCH_CMD(${MESOS_3RDPARTY_SRC}/glog-0.3.3.patch GLOG_PATCH_CMD)
>
> + PATCH_CMD(${MESOS_3RDPARTY_SRC}/elfio-3.1.patch ELFIO_PATCH_CMD)
> +
># NOTE: `libev` is "installed" into a lib directory, see "NOTE: (fix for
># MESOS-3250)" comment above for explanation.
>set(LIBEV_CONFIG_CMD ${LIBEV_ROOT}/configure --prefix=${LIBEV_ROOT}-lib)
> @@ -153,6 +155,7 @@ ExternalProject_Add(
> ExternalProject_Add(
>${ELFIO_TARGET}
>PREFIX${ELFIO_CMAKE_ROOT}
> + PATCH_COMMAND ${ELFIO_PATCH_CMD}
>CONFIGURE_COMMAND ${CMAKE_NOOP}
>BUILD_COMMAND ${CMAKE_NOOP}
>INSTALL_COMMAND ${CMAKE_NOOP}
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Created] (MESOS-5979) elfio-3.1.patch is actually not applied
UENISHI Kota created MESOS-5979:
---
Summary: elfio-3.1.patch is actually not applied
Key: MESOS-5979
URL: https://issues.apache.org/jira/browse/MESOS-5979
Project: Mesos
Issue Type: Bug
Components: build
Environment: Linux with Nvidia GPU
Reporter: UENISHI Kota
This does not affect any released version, but affects the HEAD of 1.0.x branch
and any commit after 89cfa6e. Due to this, mesos-agent will never be able start
up when it tries to recognize GPU library that has .note.ABI-tag. The patch is
tiny; I'll follow up with Review Board if needed.
{code}
$ cat ../apply-elfio-patch.patch
diff --git a/3rdparty/CMakeLists.txt b/3rdparty/CMakeLists.txt
index b966e58..6dac5bd 100755
--- a/3rdparty/CMakeLists.txt
+++ b/3rdparty/CMakeLists.txt
@@ -96,6 +96,8 @@ if (NOT WIN32)
# under the C++11 standard. cf. MESOS-860, MESOS-966.
PATCH_CMD(${MESOS_3RDPARTY_SRC}/glog-0.3.3.patch GLOG_PATCH_CMD)
+ PATCH_CMD(${MESOS_3RDPARTY_SRC}/elfio-3.1.patch ELFIO_PATCH_CMD)
+
# NOTE: `libev` is "installed" into a lib directory, see "NOTE: (fix for
# MESOS-3250)" comment above for explanation.
set(LIBEV_CONFIG_CMD ${LIBEV_ROOT}/configure --prefix=${LIBEV_ROOT}-lib)
@@ -153,6 +155,7 @@ ExternalProject_Add(
ExternalProject_Add(
${ELFIO_TARGET}
PREFIX${ELFIO_CMAKE_ROOT}
+ PATCH_COMMAND ${ELFIO_PATCH_CMD}
CONFIGURE_COMMAND ${CMAKE_NOOP}
BUILD_COMMAND ${CMAKE_NOOP}
INSTALL_COMMAND ${CMAKE_NOOP}
{code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
