[jira] [Comment Edited] (MESOS-1872) Cleanup right angle bracket in the code base.

2014-10-15 Thread Evelina Dumitrescu (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14168288#comment-14168288
 ] 

Evelina Dumitrescu edited comment on MESOS-1872 at 10/15/14 6:08 PM:
-

Review 
https://reviews.apache.org/r/26605/
https://reviews.apache.org/r/26740/
https://reviews.apache.org/r/26741/
https://reviews.apache.org/r/26739/


was (Author: evelinad):
Review 
https://reviews.apache.org/r/26605/


 Cleanup right angle bracket in the code base.
 -

 Key: MESOS-1872
 URL: https://issues.apache.org/jira/browse/MESOS-1872
 Project: Mesos
  Issue Type: Bug
Reporter: Jie Yu
Assignee: Evelina Dumitrescu
  Labels: c++11, newbie

 As we start to use c++11 style right angle brackets ('' instead of ' '):
 https://reviews.apache.org/r/25861
 We should do a sweep in our code base to make it consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)


[jira] [Comment Edited] (MESOS-1872) Cleanup right angle bracket in the code base.

2014-10-15 Thread Till Toenshoff (JIRA)

[ 
https://issues.apache.org/jira/browse/MESOS-1872?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14172803#comment-14172803
 ] 

Till Toenshoff edited comment on MESOS-1872 at 10/15/14 7:18 PM:
-

Evelina has bravely proposed three review requests (mesos/libprocess/stout) for 
covering the ticket. There is however some greater risk involved and I wanted 
to be sure that we are all aware of the pro’s and con's of such big cleanups.

{{+}} we may need to do cleanups - even major ones at some point, hence I think 
we need a consensus once and for all regarding tickets of the above nature
{{-}} almost all existing RRs will possibly get invalid and everyone with work 
in flight needs to rebase (possibly rather tedious task in particular case).

There may be more.

The only way I can currently see this happening with minimal friction is 
finding a certain date and even time for doing this on a very quick, 
propose/review/commit.

What do you think?


was (Author: tillt):
Evelina has bravely proposed three review requests (mesos/libprocess/stout) for 
covering the ticket. There is however some greater risk involved and I wanted 
to be sure that we are all aware of the pro’s and con's of such big cleanups.

+ we may need to do cleanups - even major ones at some point, hence I think we 
need a consensus once and for all regarding tickets of the above nature
- almost all existing RRs will possibly get invalid and everyone with work in 
flight needs to rebase (possibly rather tedious task in particular case).

There may be more.

The only way I can currently see this happening with minimal friction is 
finding a certain date and even time for doing this on a very quick, 
propose/review/commit.

What do you think?

 Cleanup right angle bracket in the code base.
 -

 Key: MESOS-1872
 URL: https://issues.apache.org/jira/browse/MESOS-1872
 Project: Mesos
  Issue Type: Bug
Reporter: Jie Yu
Assignee: Evelina Dumitrescu
  Labels: c++11, newbie

 As we start to use c++11 style right angle brackets ('' instead of ' '):
 https://reviews.apache.org/r/25861
 We should do a sweep in our code base to make it consistent.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)