[
https://issues.apache.org/jira/browse/MESOS-9185?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16595084#comment-16595084
]
Alexander Rukletsov edited comment on MESOS-9185 at 8/28/18 4:11 PM:
---------------------------------------------------------------------
*1.8.0-dev:*
{noformat}
commit 8496b369d52d27e90da88787242fd6f9d9abb78e
Author: Andrei Budnik <abud...@mesosphere.com>
AuthorDate: Tue Aug 28 16:46:54 2018 +0200
Commit: Alexander Rukletsov <al...@apache.org>
CommitDate: Tue Aug 28 16:46:54 2018 +0200
Added `AgentAPITest.LaunchNestedContainerWithUnknownParent` test.
This test verifies that launch nested container fails when the parent
container is unknown to the containerizer.
Review: https://reviews.apache.org/r/68234/
{noformat}
{noformat}
commit 5fbfb8da5ad62c40752fa7b7e0a0842c892f6857
Author: Andrei Budnik <abud...@mesosphere.com>
AuthorDate: Tue Aug 28 16:47:04 2018 +0200
Commit: Alexander Rukletsov <al...@apache.org>
CommitDate: Tue Aug 28 16:47:04 2018 +0200
Cleaned up container on launch failures in composing containerizer.
Previously, if a parent container was unknown to the composing
containerizer during an attempt to launch a nested container
via `ComposingContainerizerProcess::launch()`, the composing
containerizer returned an error without cleaning up the container.
The `containerizer` field was uninitialized, so a further attempt
to remove or destroy the nested container led to segfault.
This patch removes the container when the parent container is unknown.
Review: https://reviews.apache.org/r/68235/
{noformat}
*backport to 1.7.1:*
{noformat}
commit 1660a0552e58ba4407180508f7e4eeed2050b2a2
Author: Andrei Budnik <abud...@mesosphere.com>
AuthorDate: Tue Aug 28 16:47:04 2018 +0200
Commit: Alexander Rukletsov <al...@apache.org>
CommitDate: Tue Aug 28 18:07:44 2018 +0200
Cleaned up container on launch failures in composing containerizer.
Previously, if a parent container was unknown to the composing
containerizer during an attempt to launch a nested container
via `ComposingContainerizerProcess::launch()`, the composing
containerizer returned an error without cleaning up the container.
The `containerizer` field was uninitialized, so a further attempt
to remove or destroy the nested container led to segfault.
This patch removes the container when the parent container is unknown.
Review: https://reviews.apache.org/r/68235/
(cherry picked from commit 5fbfb8da5ad62c40752fa7b7e0a0842c892f6857)
{noformat}
was (Author: alexr):
{noformat}
commit 8496b369d52d27e90da88787242fd6f9d9abb78e
Author: Andrei Budnik <abud...@mesosphere.com>
AuthorDate: Tue Aug 28 16:46:54 2018 +0200
Commit: Alexander Rukletsov <al...@apache.org>
CommitDate: Tue Aug 28 16:46:54 2018 +0200
Added `AgentAPITest.LaunchNestedContainerWithUnknownParent` test.
This test verifies that launch nested container fails when the parent
container is unknown to the containerizer.
Review: https://reviews.apache.org/r/68234/
{noformat}
{noformat}
commit 5fbfb8da5ad62c40752fa7b7e0a0842c892f6857
Author: Andrei Budnik <abud...@mesosphere.com>
AuthorDate: Tue Aug 28 16:47:04 2018 +0200
Commit: Alexander Rukletsov <al...@apache.org>
CommitDate: Tue Aug 28 16:47:04 2018 +0200
Cleaned up container on launch failures in composing containerizer.
Previously, if a parent container was unknown to the composing
containerizer during an attempt to launch a nested container
via `ComposingContainerizerProcess::launch()`, the composing
containerizer returned an error without cleaning up the container.
The `containerizer` field was uninitialized, so a further attempt
to remove or destroy the nested container led to segfault.
This patch removes the container when the parent container is unknown.
Review: https://reviews.apache.org/r/68235/
{noformat}
> An attempt to remove or destroy container in composing containerizer leads to
> segfault.
> ---------------------------------------------------------------------------------------
>
> Key: MESOS-9185
> URL: https://issues.apache.org/jira/browse/MESOS-9185
> Project: Mesos
> Issue Type: Bug
> Components: agent, containerization
> Affects Versions: 1.7.0
> Reporter: Andrei Budnik
> Assignee: Andrei Budnik
> Priority: Major
> Labels: mesosphere
> Fix For: 1.8.0
>
>
> `LAUNCH_NESTED_CONTAINER` and `LAUNCH_NESTED_CONTAINER_SESSION` leads to
> segfault in the agent when the parent container is unknown to the composing
> containerizer. If the parent container cannot be found during an attempt to
> launch a nested container via `ComposingContainerizerProcess::launch()`, the
> composing container returns an error without cleaning up the container. On
> `launch()` failures, the agent calls `destroy()` which accesses uninitialized
> `containerizer` field.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
