[jira] [Commented] (MESOS-1187) precision errors with allocation calculations

2015-11-09 Thread Jie Yu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14997089#comment-14997089 ] Jie Yu commented on MESOS-1187: --- [~klaus1982], as [~idownes] suggested below, the true fix to this problem

[jira] [Commented] (MESOS-1187) precision errors with allocation calculations

2015-11-07 Thread Klaus Ma (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14995505#comment-14995505 ] Klaus Ma commented on MESOS-1187: - [~jieyu], I'm thinking to find a way for all "double equal checking" as

[jira] [Commented] (MESOS-1187) precision errors with allocation calculations

2015-11-06 Thread Jie Yu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14994149#comment-14994149 ] Jie Yu commented on MESOS-1187: --- To be clear, this is just a short term fix so that we don't end up with

[jira] [Commented] (MESOS-1187) precision errors with allocation calculations

2015-11-02 Thread Ian Downes (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14985702#comment-14985702 ] Ian Downes commented on MESOS-1187: --- I'll ask again: why do we use floats and not fixed point? Many

[jira] [Commented] (MESOS-1187) precision errors with allocation calculations

2015-11-02 Thread Adam B (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14986450#comment-14986450 ] Adam B commented on MESOS-1187: --- +1 to milli-cpus and fixed point. That's what Google uses internally, and

[jira] [Commented] (MESOS-1187) precision errors with allocation calculations

2015-11-01 Thread Klaus Ma (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14984289#comment-14984289 ] Klaus Ma commented on MESOS-1187: - Just go through {{AlmostEqual}} in googletest for double equal check

[jira] [Commented] (MESOS-1187) precision errors with allocation calculations

2015-09-10 Thread Klaus Ma (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738337#comment-14738337 ] Klaus Ma commented on MESOS-1187: - [~jieyu], do you have any comments on that? > precision errors with

[jira] [Commented] (MESOS-1187) precision errors with allocation calculations

2015-09-10 Thread Klaus Ma (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14738336#comment-14738336 ] Klaus Ma commented on MESOS-1187: - Thanks very much for your input :); and you're right about the

[jira] [Commented] (MESOS-1187) precision errors with allocation calculations

2015-09-10 Thread Felix Abecassis (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14739120#comment-14739120 ] Felix Abecassis commented on MESOS-1187: You are right that it can get extremely complex. We are

[jira] [Commented] (MESOS-1187) precision errors with allocation calculations

2015-09-09 Thread Klaus Ma (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14736243#comment-14736243 ] Klaus Ma commented on MESOS-1187: - A patch was uploaded to https://reviews.apache.org/r/38201/ [~jieyu],

[jira] [Commented] (MESOS-1187) precision errors with allocation calculations

2015-09-09 Thread Felix Abecassis (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14737312#comment-14737312 ] Felix Abecassis commented on MESOS-1187: Being new to Mesos, I don't understand all the details of

[jira] [Commented] (MESOS-1187) precision errors with allocation calculations

2015-09-08 Thread Klaus Ma (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14734427#comment-14734427 ] Klaus Ma commented on MESOS-1187: - As [~jieyu] said, we can NOT use == for double; generally, we will

[jira] [Commented] (MESOS-1187) precision errors with allocation calculations

2015-09-08 Thread Klaus Ma (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=14734831#comment-14734831 ] Klaus Ma commented on MESOS-1187: - Have a sample as follow to show how to compare two double, I'm going to

[jira] [Commented] (MESOS-1187) precision errors with allocation calculations

2015-06-24 Thread Jie Yu (JIRA)
[ https://issues.apache.org/jira/browse/MESOS-1187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14600257#comment-14600257 ] Jie Yu commented on MESOS-1187: --- This is a simple test to reproduce: