[ https://issues.apache.org/jira/browse/MESOS-1714?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14120138#comment-14120138 ]
Benjamin Mahler commented on MESOS-1714: ---------------------------------------- For now, this review avoids constructing an unflattened Resources object: https://reviews.apache.org/r/25306/ > The C++ 'Resources' abstraction should keep the underlying resources > flattened. > ------------------------------------------------------------------------------- > > Key: MESOS-1714 > URL: https://issues.apache.org/jira/browse/MESOS-1714 > Project: Mesos > Issue Type: Bug > Components: c++ api > Reporter: Benjamin Mahler > > Currently, the C++ Resources class does not ensure that the underlying > Resources protobufs are kept flat. > This is an issue because some of the methods, e.g. > [Resources::get|https://github.com/apache/mesos/blob/0.19.1/src/common/resources.cpp#L269], > assume the resources are flat. > There is code that constructs unflattened resources, e.g. > [Slave::launchExecutor|https://github.com/apache/mesos/blob/0.19.1/src/slave/slave.cpp#L3353]. > We could prevent this type of construction, however it is perfectly fine if > we ensure the C++ 'Resources' class performs flattening. -- This message was sent by Atlassian JIRA (v6.3.4#6332)