[jira] [Commented] (MESOS-1998) Subversion include path hardcoding
[
https://issues.apache.org/jira/browse/MESOS-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14193265#comment-14193265
]
Till Toenshoff commented on MESOS-1998:
---
Adding results of a compilation attempt to make it easier for users to locate a
solution.
{noformat}
In file included from ../../src/state/log.cpp:25:0:
../../3rdparty/libprocess/3rdparty/stout/include/stout/svn.hpp:21:23: fatal
error: svn_delta.h: No such file or directory
#include svn_delta.h
^
compilation terminated.
make[2]: *** [state/libstate_la-log.lo] Error 1
make[2]: *** Waiting for unfinished jobs
mv -f log/.deps/liblog_la-recover.Tpo log/.deps/liblog_la-recover.Plo
mv -f state/.deps/libstate_la-in_memory.Tpo
state/.deps/libstate_la-in_memory.Plo
libtool: compile: g++-4.9 -DPACKAGE_NAME=\mesos\ -DPACKAGE_TARNAME=\mesos\
-DPACKAGE_VERSION=\0.21.0\ -DPACKAGE_STRING=\mesos 0.21.0\
-DPACKAGE_BUGREPORT=\\ -DPACKAGE_URL=\\ -DPACKAGE=\mesos\
-DVERSION=\0.21.0\ -DSTDC_HEADERS=1 -DHAVE_SYS_TYPES_H=1 -DHAVE_SYS_STAT_H=1
-DHAVE_STDLIB_H=1 -DHAVE_STRING_H=1 -DHAVE_MEMORY_H=1 -DHAVE_STRINGS_H=1
-DHAVE_INTTYPES_H=1 -DHAVE_STDINT_H=1 -DHAVE_UNISTD_H=1 -DHAVE_DLFCN_H=1
-DLT_OBJDIR=\.libs/\ -DHAVE_PTHREAD=1 -DHAVE_LIBZ=1 -DHAVE_LIBCURL=1
-DHAVE_LIBAPR_1=1 -DHAVE_LIBSVN_SUBR_1=1 -DHAVE_LIBSVN_DELTA_1=1
-DHAVE_LIBSASL2=1 -DMESOS_HAS_JAVA=1 -I. -I../../src -Wall -Werror
-DLIBDIR=\/usr/local/lib\ -DPKGLIBEXECDIR=\/usr/local/libexec/mesos\
-DPKGDATADIR=\/usr/local/share/mesos\ -I../../include
-I../../3rdparty/libprocess/include
-I../../3rdparty/libprocess/3rdparty/stout/include -I../include
-I../include/mesos -I../3rdparty/libprocess/3rdparty/boost-1.53.0
-I../3rdparty/libprocess/3rdparty/picojson-4f93734
-I../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src
-I../3rdparty/libprocess/3rdparty/glog-0.3.3/src
-I../3rdparty/libprocess/3rdparty/glog-0.3.3/src -I../3rdparty/leveldb/include
-I../3rdparty/zookeeper-3.4.5/src/c/include
-I../3rdparty/zookeeper-3.4.5/src/c/generated
-I../3rdparty/libprocess/3rdparty/protobuf-2.5.0/src
-I/usr/include/subversion-1 -I/usr/include/apr-1 -I/usr/include/apr-1.0
-D_THREAD_SAFE -g1 -O0 -Wno-unused-local-typedefs -std=c++11
-DGTEST_USE_OWN_TR1_TUPLE=1 -MT state/libstate_la-leveldb.lo -MD -MP -MF
state/.deps/libstate_la-leveldb.Tpo -c ../../src/state/leveldb.cpp -o
state/libstate_la-leveldb.o /dev/null 21
mv -f state/.deps/libstate_la-leveldb.Tpo state/.deps/libstate_la-leveldb.Plo
make[1]: *** [all] Error 2
make: *** [all-recursive] Error 1
{noformat}
Subversion include path hardcoding
--
Key: MESOS-1998
URL: https://issues.apache.org/jira/browse/MESOS-1998
Project: Mesos
Issue Type: Bug
Reporter: Till Toenshoff
Currently, we are using a hardcoded location variant for subversion related
headers. The default path is set to {{/usr/include/subversion-1}}.
This will fail on any OSX homebrew installed version of subversion and may
also fail for other systems.
I would like to suggest changing the current hardcoded path into a basepath
and to reference the actual headers (e.g. svn_delta.h) via
subversion-1/svn_delta.h. This would allow homebrew users (and others) to
build mesos out of the box and without
A. manually supplying the subversion-1 location
B. linking /usr/local/include/subversion-1 towards /usr/include/subversion-1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-1998) Subversion include path hardcoding
[
https://issues.apache.org/jira/browse/MESOS-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185385#comment-14185385
]
Timothy Chen commented on MESOS-1998:
-
One caveat is that some systems name subversion header folder to be
subversion-1.0 via package, so overall not including the path name is more
inclusive unless we somehow do conditionals everywhere.
Subversion include path hardcoding
--
Key: MESOS-1998
URL: https://issues.apache.org/jira/browse/MESOS-1998
Project: Mesos
Issue Type: Bug
Reporter: Till Toenshoff
Currently, we are using a hardcoded location variant for subversion related
headers. The default path is set to {{/usr/include/subversion-1}}.
This will fail on any OSX homebrew installed version of subversion and may
also fail for other systems.
I would like to suggest changing the current hardcoded path into a basepath
and to reference the actual headers (e.g. svn_delta.h) via
subversion-1/svn_delta.h. This would allow homebrew users (and others) to
build mesos out of the box and without
A. manually supplying the subversion-1 location
B. linking /usr/local/include/subversion-1 towards /usr/include/subversion-1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
[jira] [Commented] (MESOS-1998) Subversion include path hardcoding
[
https://issues.apache.org/jira/browse/MESOS-1998?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanelfocusedCommentId=14185692#comment-14185692
]
Till Toenshoff commented on MESOS-1998:
---
That is a good point Timothy, I only checked ubuntu and fedora, both use
subversion-1
Subversion include path hardcoding
--
Key: MESOS-1998
URL: https://issues.apache.org/jira/browse/MESOS-1998
Project: Mesos
Issue Type: Bug
Reporter: Till Toenshoff
Currently, we are using a hardcoded location variant for subversion related
headers. The default path is set to {{/usr/include/subversion-1}}.
This will fail on any OSX homebrew installed version of subversion and may
also fail for other systems.
I would like to suggest changing the current hardcoded path into a basepath
and to reference the actual headers (e.g. svn_delta.h) via
subversion-1/svn_delta.h. This would allow homebrew users (and others) to
build mesos out of the box and without
A. manually supplying the subversion-1 location
B. linking /usr/local/include/subversion-1 towards /usr/include/subversion-1
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
