[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)

2016-04-18 Thread zhou xing (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246883#comment-15246883
 ] 

zhou xing commented on MESOS-3782:
--

[~klueska], Added MESOS-5230 to track this one

> Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create 
> symlinks)
> --
>
> Key: MESOS-3782
> URL: https://issues.apache.org/jira/browse/MESOS-3782
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: zhou xing
> Fix For: 0.29.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)

2016-04-18 Thread Kevin Klues (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15246821#comment-15246821
 ] 

Kevin Klues commented on MESOS-3782:


[~dongdong] Did you ever get  a chance to file a ticket for:

{noformat}
The only odd man out is the `./include/mesos/slave` folder, which we've decided 
to create a new ticket for dealing with (i.e. we should copy this folder to 
`./include/mesos/agent` as part of the install process).
{noformat}

> Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create 
> symlinks)
> --
>
> Key: MESOS-3782
> URL: https://issues.apache.org/jira/browse/MESOS-3782
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: zhou xing
> Fix For: 0.29.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)

2016-04-12 Thread zhou xing (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15238498#comment-15238498
 ] 

zhou xing commented on MESOS-3782:
--

submitted the second patch to make changes in lib process make: 
https://reviews.apache.org/r/46134/

> Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create 
> symlinks)
> --
>
> Key: MESOS-3782
> URL: https://issues.apache.org/jira/browse/MESOS-3782
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: zhou xing
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)

2016-04-06 Thread zhou xing (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15227944#comment-15227944
 ] 

zhou xing commented on MESOS-3782:
--

Submitted review request at: https://reviews.apache.org/r/45806/

> Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create 
> symlinks)
> --
>
> Key: MESOS-3782
> URL: https://issues.apache.org/jira/browse/MESOS-3782
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: zhou xing
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)

2016-03-31 Thread zhou xing (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221173#comment-15221173
 ] 

zhou xing commented on MESOS-3782:
--

yes, will do that

> Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create 
> symlinks)
> --
>
> Key: MESOS-3782
> URL: https://issues.apache.org/jira/browse/MESOS-3782
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: zhou xing
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)

2016-03-31 Thread Kevin Klues (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221168#comment-15221168
 ] 

Kevin Klues commented on MESOS-3782:


I don't think you should copy the {noformat}bin/*slave*.in{noformat} files 
themselves, but rather use AC_CONFIG_FILES in configure.ac to generate them 
from the same input. i.e.,

{noformat}
AC_CONFIG_FILES([bin/mesos-agent.sh:bin/mesos-slave.in.sh], [chmod +x 
bin/mesos-agent.sh])
AC_CONFIG_FILES([bin/mesos-agent-flags.sh:bin/mesos-slave-flags.in.sh])
{noformat}

https://www.gnu.org/savannah-checkouts/gnu/autoconf/manual/autoconf-2.69/html_node/Configuration-Files.html

> Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create 
> symlinks)
> --
>
> Key: MESOS-3782
> URL: https://issues.apache.org/jira/browse/MESOS-3782
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: zhou xing
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)

2016-03-31 Thread Jay Guo (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221165#comment-15221165
 ] 

Jay Guo commented on MESOS-3782:


Or we could copy it twice and change the name in the second copy.

> Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create 
> symlinks)
> --
>
> Key: MESOS-3782
> URL: https://issues.apache.org/jira/browse/MESOS-3782
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: zhou xing
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)

2016-03-31 Thread zhou xing (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221166#comment-15221166
 ] 

zhou xing commented on MESOS-3782:
--

yeap, that could also be a solution

> Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create 
> symlinks)
> --
>
> Key: MESOS-3782
> URL: https://issues.apache.org/jira/browse/MESOS-3782
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: zhou xing
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)

2016-03-31 Thread zhou xing (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15221154#comment-15221154
 ] 

zhou xing commented on MESOS-3782:
--

[~vinodkone], those scripts are not very big, if we just duplicate the shell 
script the only disadvantage here is that if we need to change sth in the shell 
scripts, we need to copy the changes to the mess-agent.sh as well. For now, I 
will just duplicate everything and submit a patch then

> Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create 
> symlinks)
> --
>
> Key: MESOS-3782
> URL: https://issues.apache.org/jira/browse/MESOS-3782
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: zhou xing
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)

2016-03-31 Thread Vinod Kone (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15220626#comment-15220626
 ] 

Vinod Kone commented on MESOS-3782:
---

For step 2) are you suggesting to rename mesos-slave.sh to mesos-agent.sh or to 
make a copy? We can't just rename because operators might be depending on these 
scripts already.

> Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create 
> symlinks)
> --
>
> Key: MESOS-3782
> URL: https://issues.apache.org/jira/browse/MESOS-3782
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: zhou xing
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)

2016-03-29 Thread Kevin Klues (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15217039#comment-15217039
 ] 

Kevin Klues commented on MESOS-3782:


That all seems reasonable to me.  Let me check with Vinod and make sure this 
makes sense to him, and then we can proceed with putting out an RR.

> Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create 
> symlinks)
> --
>
> Key: MESOS-3782
> URL: https://issues.apache.org/jira/browse/MESOS-3782
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: zhou xing
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)

2016-03-27 Thread zhou xing (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15213741#comment-15213741
 ] 

zhou xing commented on MESOS-3782:
--

[~klueska], here is a plan that we want to try:
1. Add a new program named {{mesos-agent}} in {{mesos/src/Makefile.am}} which 
has the similar make rules to {{mess-slave}}. This will generate a duplicate 
executable file named {{mesos-agent}} in {{mesos/build/.libs}} after {{make}} 
(or in {{/usr/local/sbin}} after {{make install}})

2. For the shell scripts in {{mesos/bin}} or {{mesos/src/deploy}}, firstly, we 
can rename them to use the word "agent", e.g. {{mesos-slave.sh}} to 
{{mesos-agent.sh}}; secondly, change the invocation of all the {{mesos-slave}} 
call to {{mesos-agent}} call in the shell scripts content.

3. Change the {{mesos/configure.ac}} and add symlink creation to create link 
files named like **mesos-slave.sh** to link them to the **mesos-agent.sh**. 

After step 3, there will be **mesos-slave.sh** and **mesos-agent.sh** in the 
{{mesos/build/bin}} folder at the same time, so use can both use 
{{mesos-slave.sh}} or {{mesos-agent.sh}} to start the slave node

> Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create 
> symlinks)
> --
>
> Key: MESOS-3782
> URL: https://issues.apache.org/jira/browse/MESOS-3782
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: zhou xing
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)

2016-03-25 Thread Kevin Klues (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212742#comment-15212742
 ] 

Kevin Klues commented on MESOS-3782:


Yes. I was more curious about your actual plans for carrying out this specific 
change.

> Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create 
> symlinks)
> --
>
> Key: MESOS-3782
> URL: https://issues.apache.org/jira/browse/MESOS-3782
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: zhou xing
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)

2016-03-25 Thread Jay Guo (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212734#comment-15212734
 ] 

Jay Guo commented on MESOS-3782:


Long story short, the epic is to replace all keyword `slave` with `agent` in 
the project through several deprecation phase.

This ticket belongs to the epic here: 
https://issues.apache.org/jira/browse/MESOS-1478
And there's a design doc there. Please take a look.

> Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create 
> symlinks)
> --
>
> Key: MESOS-3782
> URL: https://issues.apache.org/jira/browse/MESOS-3782
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: zhou xing
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (MESOS-3782) Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create symlinks)

2016-03-25 Thread Kevin Klues (JIRA) 

[ 
https://issues.apache.org/jira/browse/MESOS-3782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15212714#comment-15212714
 ] 

Kevin Klues commented on MESOS-3782:


I'm curious what the actual plans for this work are. Could you elaborate in the 
description, please?

> Replace Master/Slave Terminology Phase I - Add duplicate binaries (or create 
> symlinks)
> --
>
> Key: MESOS-3782
> URL: https://issues.apache.org/jira/browse/MESOS-3782
> Project: Mesos
>  Issue Type: Task
>Reporter: Diana Arroyo
>Assignee: zhou xing
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)