[
https://issues.apache.org/jira/browse/MESOS-6428?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16162355#comment-16162355
]
Till Toenshoff commented on MESOS-6428:
---
[~jamespeach] we commonly remove the duplication from the RR subject /
description from our commit messages before pushing.
So instead of
```
commit 905c758782f8587276ee207261277517a34482a2
Author: Andrei Budnik
Date: Wed Sep 6 22:02:29 2017 -0700
Used SAFE_EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write`.
Used SAFE_EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write`.
Review: https://reviews.apache.org/r/61801/
```
it would be
```
commit 905c758782f8587276ee207261277517a34482a2
Author: Andrei Budnik
Date: Wed Sep 6 22:02:29 2017 -0700
Used SAFE_EXIT macro in `CgroupsAnyHierarchyTest.ROOT_CGROUPS_Write`.
Review: https://reviews.apache.org/r/61801/
```
> Mesos containerizer helper function signalSafeWriteStatus is not AS-Safe
>
>
> Key: MESOS-6428
> URL: https://issues.apache.org/jira/browse/MESOS-6428
> Project: Mesos
> Issue Type: Bug
> Components: containerization
>Affects Versions: 1.1.0
>Reporter: Benjamin Bannier
>Assignee: Andrei Budnik
> Labels: newbie, tech-debt
> Fix For: 1.5.0
>
>
> In {{src/slave/containerizer/mesos/launch.cpp}} a helper function
> {{signalSafeWriteStatus}} is defined. Its name seems to suggest that this
> function is safe to call in e.g., signal handlers, and it is used in this
> file's {{signalHandler}} for exactly that purpose.
> Currently this function is not AS-Safe since it e.g., allocates memory via
> construction of {{string}} instances, and might destructively modify
> {{errno}}.
> We should clean up this function to be in fact AS-Safe.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
