[ https://issues.apache.org/jira/browse/MESOS-8712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16490094#comment-16490094 ]
Qian Zhang commented on MESOS-8712: ----------------------------------- commit 896c593c7918dd14d44740af22d63f82c0d4813b Author: Andrei Budnik Date: Fri May 25 09:07:36 2018 +0800 Removed `destroyed` from `Container` struct in composing containerizer. Previously, we stored `destroyed` promise for each container and used it to guarantee that `destroy()` returns a non-empty value when the destroy-in-progress stops an launch-in-progress using the next containerizer. Since `wait()` and `destroy()` return the same `ContainerTermination` value when called with the same ContainerID argument, we can remove `destroyed` promise and add callbacks to clean up `containers_` map instead. Moreover, we added a clean up for terminated containers that have been recovered after agent's restart. Review: https://reviews.apache.org/r/66668/ > Remove `destroyed` promise from `Container` struct > -------------------------------------------------- > > Key: MESOS-8712 > URL: https://issues.apache.org/jira/browse/MESOS-8712 > Project: Mesos > Issue Type: Task > Reporter: Andrei Budnik > Assignee: Andrei Budnik > Priority: Major > > [`destroyed` > promise|https://github.com/apache/mesos/blob/5d8a9c1b77f96151da859b4c0c3607d22c36cd18/src/slave/containerizer/composing.cpp#L138] > is not needed anymore, since we can use the property that `wait` and > `destroy` methods depend on the same container termination promise. This > change should affect only composing c'zer. -- This message was sent by Atlassian JIRA (v7.6.3#76005)