[jira] [Commented] (MESOS-9253) Reviewbot is failing when posting a review
[
https://issues.apache.org/jira/browse/MESOS-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16644471#comment-16644471
]
Armand Grillet commented on MESOS-9253:
---
Review request submitted: https://reviews.apache.org/r/68970/
> Reviewbot is failing when posting a review
> --
>
> Key: MESOS-9253
> URL: https://issues.apache.org/jira/browse/MESOS-9253
> Project: Mesos
> Issue Type: Bug
>Reporter: Vinod Kone
>Assignee: Armand Grillet
>Priority: Critical
>
> Observed this in CI.
> [https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Reviewbot/23425/console]
>
> {code}
> 09-23-18_02:12:05 - Running
> /home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py
> Checking if review 68640 needs verification
> Skipping blocking review 68640
> Checking if review 68641 needs verification
> Patch never verified, needs verification
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Verifying review 68641
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Applying review 68640
> python support/apply-reviews.py -n -r 68640
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 156, in verify_review
> apply_reviews(review_request, reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 120, in apply_reviews
> reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 124, in apply_reviews
> apply_review(review_request["id"])
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 97, in apply_review
> shell("python support/apply-reviews.py -n -r %s" % review_id)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 91, in shell
> command, stderr=subprocess.STDOUT, shell=True)
> File "/usr/lib/python3.5/subprocess.py", line 626, in check_output
> **kwargs).stdout
> File "/usr/lib/python3.5/subprocess.py", line 708, in run
> output=stdout, stderr=stderr)
> subprocess.CalledProcessError: Command 'python support/apply-reviews.py -n -r
> 68640' returned non-zero exit status 1
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 292, in
> main()
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 286, in main
> verify_review(review_request, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 217, in verify_review
> output += "\nFull log: "
> TypeError: can't concat bytes to str
> Build step 'Execute shell' marked build as failure
> Sending e-mails to: bui...@mesos.apache.org
> Finished: FAILURE
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-9253) Reviewbot is failing when posting a review
[
https://issues.apache.org/jira/browse/MESOS-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=1665#comment-1665
]
Armand Grillet commented on MESOS-9253:
---
We can see in the last comment of https://reviews.apache.org/r/68965/ that a
Python 3.5 interpreter is now used to run the script and returns a type error.
Working on a fix.
> Reviewbot is failing when posting a review
> --
>
> Key: MESOS-9253
> URL: https://issues.apache.org/jira/browse/MESOS-9253
> Project: Mesos
> Issue Type: Bug
>Reporter: Vinod Kone
>Assignee: Armand Grillet
>Priority: Critical
>
> Observed this in CI.
> [https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Reviewbot/23425/console]
>
> {code}
> 09-23-18_02:12:05 - Running
> /home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py
> Checking if review 68640 needs verification
> Skipping blocking review 68640
> Checking if review 68641 needs verification
> Patch never verified, needs verification
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Verifying review 68641
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Applying review 68640
> python support/apply-reviews.py -n -r 68640
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 156, in verify_review
> apply_reviews(review_request, reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 120, in apply_reviews
> reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 124, in apply_reviews
> apply_review(review_request["id"])
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 97, in apply_review
> shell("python support/apply-reviews.py -n -r %s" % review_id)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 91, in shell
> command, stderr=subprocess.STDOUT, shell=True)
> File "/usr/lib/python3.5/subprocess.py", line 626, in check_output
> **kwargs).stdout
> File "/usr/lib/python3.5/subprocess.py", line 708, in run
> output=stdout, stderr=stderr)
> subprocess.CalledProcessError: Command 'python support/apply-reviews.py -n -r
> 68640' returned non-zero exit status 1
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 292, in
> main()
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 286, in main
> verify_review(review_request, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 217, in verify_review
> output += "\nFull log: "
> TypeError: can't concat bytes to str
> Build step 'Execute shell' marked build as failure
> Sending e-mails to: bui...@mesos.apache.org
> Finished: FAILURE
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-9253) Reviewbot is failing when posting a review
[
https://issues.apache.org/jira/browse/MESOS-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642867#comment-16642867
]
Armand Grillet commented on MESOS-9253:
---
[~vinodkone] The last four runs seem successful, the Jenkins UI is not great
and I am thus unable to check if this is an improvement due to the code that
landed. Can you please check and update this ticket status accordingly?
> Reviewbot is failing when posting a review
> --
>
> Key: MESOS-9253
> URL: https://issues.apache.org/jira/browse/MESOS-9253
> Project: Mesos
> Issue Type: Bug
>Reporter: Vinod Kone
>Assignee: Armand Grillet
>Priority: Critical
>
> Observed this in CI.
> [https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Reviewbot/23425/console]
>
> {code}
> 09-23-18_02:12:05 - Running
> /home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py
> Checking if review 68640 needs verification
> Skipping blocking review 68640
> Checking if review 68641 needs verification
> Patch never verified, needs verification
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Verifying review 68641
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Applying review 68640
> python support/apply-reviews.py -n -r 68640
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 156, in verify_review
> apply_reviews(review_request, reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 120, in apply_reviews
> reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 124, in apply_reviews
> apply_review(review_request["id"])
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 97, in apply_review
> shell("python support/apply-reviews.py -n -r %s" % review_id)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 91, in shell
> command, stderr=subprocess.STDOUT, shell=True)
> File "/usr/lib/python3.5/subprocess.py", line 626, in check_output
> **kwargs).stdout
> File "/usr/lib/python3.5/subprocess.py", line 708, in run
> output=stdout, stderr=stderr)
> subprocess.CalledProcessError: Command 'python support/apply-reviews.py -n -r
> 68640' returned non-zero exit status 1
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 292, in
> main()
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 286, in main
> verify_review(review_request, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 217, in verify_review
> output += "\nFull log: "
> TypeError: can't concat bytes to str
> Build step 'Execute shell' marked build as failure
> Sending e-mails to: bui...@mesos.apache.org
> Finished: FAILURE
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-9253) Reviewbot is failing when posting a review
[
https://issues.apache.org/jira/browse/MESOS-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642248#comment-16642248
]
Armand Grillet commented on MESOS-9253:
---
Review request submitted: https://reviews.apache.org/r/68951/
> Reviewbot is failing when posting a review
> --
>
> Key: MESOS-9253
> URL: https://issues.apache.org/jira/browse/MESOS-9253
> Project: Mesos
> Issue Type: Bug
>Reporter: Vinod Kone
>Assignee: Armand Grillet
>Priority: Critical
>
> Observed this in CI.
> [https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Reviewbot/23425/console]
>
> {code}
> 09-23-18_02:12:05 - Running
> /home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py
> Checking if review 68640 needs verification
> Skipping blocking review 68640
> Checking if review 68641 needs verification
> Patch never verified, needs verification
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Verifying review 68641
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Applying review 68640
> python support/apply-reviews.py -n -r 68640
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 156, in verify_review
> apply_reviews(review_request, reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 120, in apply_reviews
> reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 124, in apply_reviews
> apply_review(review_request["id"])
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 97, in apply_review
> shell("python support/apply-reviews.py -n -r %s" % review_id)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 91, in shell
> command, stderr=subprocess.STDOUT, shell=True)
> File "/usr/lib/python3.5/subprocess.py", line 626, in check_output
> **kwargs).stdout
> File "/usr/lib/python3.5/subprocess.py", line 708, in run
> output=stdout, stderr=stderr)
> subprocess.CalledProcessError: Command 'python support/apply-reviews.py -n -r
> 68640' returned non-zero exit status 1
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 292, in
> main()
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 286, in main
> verify_review(review_request, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 217, in verify_review
> output += "\nFull log: "
> TypeError: can't concat bytes to str
> Build step 'Execute shell' marked build as failure
> Sending e-mails to: bui...@mesos.apache.org
> Finished: FAILURE
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-9253) Reviewbot is failing when posting a review
[
https://issues.apache.org/jira/browse/MESOS-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642225#comment-16642225
]
Armand Grillet commented on MESOS-9253:
---
>From the Jenkins logs, ReviewBot uses Ubuntu 16.04 [which has been updated to
>have Python
>3.6|https://github.com/apache/mesos/commit/cbdb6a5e1c0bb2e61dd0887cfae424ac2422b94d].
>
The issue is here:
https://github.com/apache/mesos/blob/e135b7f2175c01fd67b71b22cdc325ac37853a9d/support/verify-reviews.py#L97
Instead of using the current interpreter (which is Python 3), we specify
{{python}} which is generally still Python 2 following the guidelines given in
https://lists.apache.org/thread.html/c54687ca13873f9b4d06b0e40944c6c8494b8d6a88313336e3a886c6@%3Cdev.mesos.apache.org%3E
I'm going to send a review request changing the line in {{verify-reviews.py}}
to use the current interpreter instead of a hardcoded {{python}}, this should
solve the issue.
> Reviewbot is failing when posting a review
> --
>
> Key: MESOS-9253
> URL: https://issues.apache.org/jira/browse/MESOS-9253
> Project: Mesos
> Issue Type: Bug
>Reporter: Vinod Kone
>Assignee: Armand Grillet
>Priority: Critical
>
> Observed this in CI.
> [https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Reviewbot/23425/console]
>
> {code}
> 09-23-18_02:12:05 - Running
> /home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py
> Checking if review 68640 needs verification
> Skipping blocking review 68640
> Checking if review 68641 needs verification
> Patch never verified, needs verification
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Verifying review 68641
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Applying review 68640
> python support/apply-reviews.py -n -r 68640
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 156, in verify_review
> apply_reviews(review_request, reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 120, in apply_reviews
> reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 124, in apply_reviews
> apply_review(review_request["id"])
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 97, in apply_review
> shell("python support/apply-reviews.py -n -r %s" % review_id)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 91, in shell
> command, stderr=subprocess.STDOUT, shell=True)
> File "/usr/lib/python3.5/subprocess.py", line 626, in check_output
> **kwargs).stdout
> File "/usr/lib/python3.5/subprocess.py", line 708, in run
> output=stdout, stderr=stderr)
> subprocess.CalledProcessError: Command 'python support/apply-reviews.py -n -r
> 68640' returned non-zero exit status 1
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 292, in
> main()
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 286, in main
> verify_review(review_request, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 217, in verify_review
> output += "\nFull log: "
> TypeError: can't concat bytes to str
> Build step 'Execute shell' marked build as failure
> Sending e-mails to: bui...@mesos.apache.org
> Finished: FAILURE
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-9253) Reviewbot is failing when posting a review
[
https://issues.apache.org/jira/browse/MESOS-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16642070#comment-16642070
]
Armand Grillet commented on MESOS-9253:
---
I see the fail in
[https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Reviewbot/23458/console,]
gonna investigate in the coming hours.
> Reviewbot is failing when posting a review
> --
>
> Key: MESOS-9253
> URL: https://issues.apache.org/jira/browse/MESOS-9253
> Project: Mesos
> Issue Type: Bug
>Reporter: Vinod Kone
>Priority: Critical
>
> Observed this in CI.
> [https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Reviewbot/23425/console]
>
> {code}
> 09-23-18_02:12:05 - Running
> /home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py
> Checking if review 68640 needs verification
> Skipping blocking review 68640
> Checking if review 68641 needs verification
> Patch never verified, needs verification
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Verifying review 68641
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Applying review 68640
> python support/apply-reviews.py -n -r 68640
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 156, in verify_review
> apply_reviews(review_request, reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 120, in apply_reviews
> reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 124, in apply_reviews
> apply_review(review_request["id"])
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 97, in apply_review
> shell("python support/apply-reviews.py -n -r %s" % review_id)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 91, in shell
> command, stderr=subprocess.STDOUT, shell=True)
> File "/usr/lib/python3.5/subprocess.py", line 626, in check_output
> **kwargs).stdout
> File "/usr/lib/python3.5/subprocess.py", line 708, in run
> output=stdout, stderr=stderr)
> subprocess.CalledProcessError: Command 'python support/apply-reviews.py -n -r
> 68640' returned non-zero exit status 1
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 292, in
> main()
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 286, in main
> verify_review(review_request, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 217, in verify_review
> output += "\nFull log: "
> TypeError: can't concat bytes to str
> Build step 'Execute shell' marked build as failure
> Sending e-mails to: bui...@mesos.apache.org
> Finished: FAILURE
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-9253) Reviewbot is failing when posting a review
[
https://issues.apache.org/jira/browse/MESOS-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641991#comment-16641991
]
Vinod Kone commented on MESOS-9253:
---
[~ArmandGrillet] Can you please send a review with the above fix?
> Reviewbot is failing when posting a review
> --
>
> Key: MESOS-9253
> URL: https://issues.apache.org/jira/browse/MESOS-9253
> Project: Mesos
> Issue Type: Bug
>Reporter: Vinod Kone
>Priority: Critical
>
> Observed this in CI.
> [https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Reviewbot/23425/console]
>
> {code}
> 09-23-18_02:12:05 - Running
> /home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py
> Checking if review 68640 needs verification
> Skipping blocking review 68640
> Checking if review 68641 needs verification
> Patch never verified, needs verification
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Verifying review 68641
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Applying review 68640
> python support/apply-reviews.py -n -r 68640
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 156, in verify_review
> apply_reviews(review_request, reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 120, in apply_reviews
> reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 124, in apply_reviews
> apply_review(review_request["id"])
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 97, in apply_review
> shell("python support/apply-reviews.py -n -r %s" % review_id)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 91, in shell
> command, stderr=subprocess.STDOUT, shell=True)
> File "/usr/lib/python3.5/subprocess.py", line 626, in check_output
> **kwargs).stdout
> File "/usr/lib/python3.5/subprocess.py", line 708, in run
> output=stdout, stderr=stderr)
> subprocess.CalledProcessError: Command 'python support/apply-reviews.py -n -r
> 68640' returned non-zero exit status 1
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 292, in
> main()
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 286, in main
> verify_review(review_request, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 217, in verify_review
> output += "\nFull log: "
> TypeError: can't concat bytes to str
> Build step 'Execute shell' marked build as failure
> Sending e-mails to: bui...@mesos.apache.org
> Finished: FAILURE
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-9253) Reviewbot is failing when posting a review
[
https://issues.apache.org/jira/browse/MESOS-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641963#comment-16641963
]
Armand Grillet commented on MESOS-9253:
---
[~vinodkone] I've seen this error if {{python}} is Python 2. {{python3
support/apply-reviews.py -n -r 68640}} should work.
> Reviewbot is failing when posting a review
> --
>
> Key: MESOS-9253
> URL: https://issues.apache.org/jira/browse/MESOS-9253
> Project: Mesos
> Issue Type: Bug
>Reporter: Vinod Kone
>Priority: Critical
>
> Observed this in CI.
> [https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Reviewbot/23425/console]
>
> {code}
> 09-23-18_02:12:05 - Running
> /home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py
> Checking if review 68640 needs verification
> Skipping blocking review 68640
> Checking if review 68641 needs verification
> Patch never verified, needs verification
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Verifying review 68641
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Applying review 68640
> python support/apply-reviews.py -n -r 68640
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 156, in verify_review
> apply_reviews(review_request, reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 120, in apply_reviews
> reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 124, in apply_reviews
> apply_review(review_request["id"])
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 97, in apply_review
> shell("python support/apply-reviews.py -n -r %s" % review_id)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 91, in shell
> command, stderr=subprocess.STDOUT, shell=True)
> File "/usr/lib/python3.5/subprocess.py", line 626, in check_output
> **kwargs).stdout
> File "/usr/lib/python3.5/subprocess.py", line 708, in run
> output=stdout, stderr=stderr)
> subprocess.CalledProcessError: Command 'python support/apply-reviews.py -n -r
> 68640' returned non-zero exit status 1
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 292, in
> main()
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 286, in main
> verify_review(review_request, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 217, in verify_review
> output += "\nFull log: "
> TypeError: can't concat bytes to str
> Build step 'Execute shell' marked build as failure
> Sending e-mails to: bui...@mesos.apache.org
> Finished: FAILURE
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-9253) Reviewbot is failing when posting a review
[
https://issues.apache.org/jira/browse/MESOS-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16641939#comment-16641939
]
Vinod Kone commented on MESOS-9253:
---
Reviewbot is still failing
{noformat}
10-08-18_14:40:29 - Running
/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py
Checking if review 68929 needs verification
Skipping blocking review 68929
Checking if review 68941 needs verification
Patch never verified, needs verification
Dependent review:
[https://reviews.apache.org/api/review-requests/68929/]
Verifying review 68941
Dependent review:
[https://reviews.apache.org/api/review-requests/68929/]
Applying review 68929
python support/apply-reviews.py -n -r 68929
Posting review: Bad patch!
Reviews applied: [68941, 68929]
Failed command: python support/apply-reviews.py -n -r 68929
Error:
Traceback (most recent call last):
File "support/apply-reviews.py", line 35, in
import urllib.request
ImportError: No module named request
Full log:
[https://builds.apache.org/job/Mesos-Reviewbot/23458/console]
1 review requests need verification
{noformat}
Maybe it's a python 2 vs 3 issue. [~ArmandGrillet] [~andschwa] Can you take a
look?
> Reviewbot is failing when posting a review
> --
>
> Key: MESOS-9253
> URL: https://issues.apache.org/jira/browse/MESOS-9253
> Project: Mesos
> Issue Type: Bug
>Reporter: Vinod Kone
>Priority: Critical
>
> Observed this in CI.
> [https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Reviewbot/23425/console]
>
> {code}
> 09-23-18_02:12:05 - Running
> /home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py
> Checking if review 68640 needs verification
> Skipping blocking review 68640
> Checking if review 68641 needs verification
> Patch never verified, needs verification
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Verifying review 68641
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Applying review 68640
> python support/apply-reviews.py -n -r 68640
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 156, in verify_review
> apply_reviews(review_request, reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 120, in apply_reviews
> reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 124, in apply_reviews
> apply_review(review_request["id"])
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 97, in apply_review
> shell("python support/apply-reviews.py -n -r %s" % review_id)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 91, in shell
> command, stderr=subprocess.STDOUT, shell=True)
> File "/usr/lib/python3.5/subprocess.py", line 626, in check_output
> **kwargs).stdout
> File "/usr/lib/python3.5/subprocess.py", line 708, in run
> output=stdout, stderr=stderr)
> subprocess.CalledProcessError: Command 'python support/apply-reviews.py -n -r
> 68640' returned non-zero exit status 1
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 292, in
> main()
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 286, in main
> verify_review(review_request, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 217, in verify_review
> output += "\nFull log: "
> TypeError: can't concat bytes to str
> Build step 'Execute shell' marked build as failure
> Sending e-mails to: bui...@mesos.apache.org
> Finished: FAILURE
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
[jira] [Commented] (MESOS-9253) Reviewbot is failing when posting a review
[
https://issues.apache.org/jira/browse/MESOS-9253?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16626200#comment-16626200
]
Vinod Kone commented on MESOS-9253:
---
cc [~andschwa] [~bbannier]
> Reviewbot is failing when posting a review
> --
>
> Key: MESOS-9253
> URL: https://issues.apache.org/jira/browse/MESOS-9253
> Project: Mesos
> Issue Type: Bug
>Reporter: Vinod Kone
>Priority: Critical
>
> Observed this in CI.
> [https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Reviewbot/23425/console]
>
> {code}
> 09-23-18_02:12:05 - Running
> /home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py
> Checking if review 68640 needs verification
> Skipping blocking review 68640
> Checking if review 68641 needs verification
> Patch never verified, needs verification
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Verifying review 68641
> Dependent review: [https://reviews.apache.org/api/review-requests/68640/]
> Applying review 68640
> python support/apply-reviews.py -n -r 68640
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 156, in verify_review
> apply_reviews(review_request, reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 120, in apply_reviews
> reviews, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 124, in apply_reviews
> apply_review(review_request["id"])
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 97, in apply_review
> shell("python support/apply-reviews.py -n -r %s" % review_id)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 91, in shell
> command, stderr=subprocess.STDOUT, shell=True)
> File "/usr/lib/python3.5/subprocess.py", line 626, in check_output
> **kwargs).stdout
> File "/usr/lib/python3.5/subprocess.py", line 708, in run
> output=stdout, stderr=stderr)
> subprocess.CalledProcessError: Command 'python support/apply-reviews.py -n -r
> 68640' returned non-zero exit status 1
> During handling of the above exception, another exception occurred:
> Traceback (most recent call last):
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 292, in
> main()
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 286, in main
> verify_review(review_request, handler)
> File
> "/home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py",
> line 217, in verify_review
> output += "\nFull log: "
> TypeError: can't concat bytes to str
> Build step 'Execute shell' marked build as failure
> Sending e-mails to: bui...@mesos.apache.org
> Finished: FAILURE
> {code}
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
