Vinod Kone created MESOS-9459: --------------------------------- Summary: Reviewbot is not verifying reviews that need verification Key: MESOS-9459 URL: https://issues.apache.org/jira/browse/MESOS-9459 Project: Mesos Issue Type: Bug Reporter: Vinod Kone Assignee: Armand Grillet
For example this run of ReviewBot https://builds.apache.org/view/M-R/view/Mesos/job/Mesos-Reviewbot/23594/console says that there are no reviews to be verified, which is false because if we look at ReviewBoard there are a bunch of reviews that have not been commented on by ReviewBot since a new diff has been posted. {noformat} 12-05-18_23:41:54 - Running /home/jenkins/jenkins-slave/workspace/Mesos-Reviewbot/support/verify-reviews.py 0 review requests need verification {noformat} I see the the logic of the verify-reviews.py script was changed as part of the python3 transition here: https://reviews.apache.org/r/68619/diff/1#27 which likely caused the bug. As an aside, It's unfortunate that python3 update was bundled with logic changes in this review. cc [~andschwa] -- This message was sent by Atlassian JIRA (v7.6.3#76005)