Andrei Budnik created MESOS-9914:
------------------------------------

             Summary: Refactor `MesosTest::StartSlave` in favour of builder 
style interface
                 Key: MESOS-9914
                 URL: https://issues.apache.org/jira/browse/MESOS-9914
             Project: Mesos
          Issue Type: Improvement
          Components: test
            Reporter: Andrei Budnik


Every overload of `MesosTest::StartSlave` method depend on 
`cluster::Slave::create` method, which accepts several arguments. In fact, each 
overload of `MesosTest::StartSlave` accepts a subset of combination of 
arguments that `cluster::Slave::create` accept. Given that the latter accepts 
11 arguments at the moment, and there are already 13 overloads of the 
`MesosTest::StartSlave`, introducing a builder-style interface is very 
desirable. It'd allow adding more arguments to the `cluster::Slave::create` 
without the necessity to update all existing overloads. It would be a local 
change as it won't affect existing tests.

See [this 
comment|https://github.com/apache/mesos/blob/00bb0b6d6abe7700a5adab0bdaf7e91767a2db19/src/tests/mesos.hpp#L160-L177].



--
This message was sent by Atlassian JIRA
(v7.6.14#76016)

Reply via email to