[
https://issues.apache.org/jira/browse/METRON-1801?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636167#comment-16636167
]
ASF GitHub Bot commented on METRON-1801:
GitHub user nickwallen opened a pull request:
GitHub user nickwallen opened a pull request:
https://github.com/apache/metron/pull/1218
METRON-1801 Allow Customization of Elasticsearch Document ID
Currently, the Metron GUID is always used as the Elasticsearch document ID.
As documented in
Nick Allen created METRON-1801:
--
Summary: Allow Customization of Elasticsearch Document ID
Key: METRON-1801
URL: https://issues.apache.org/jira/browse/METRON-1801
Project: Metron
Issue Type:
[
https://issues.apache.org/jira/browse/METRON-1749?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636091#comment-16636091
]
ASF GitHub Bot commented on METRON-1749:
Github user mmiklavc commented on the issue:
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1217
@sardell Thanks for the contribution and write-up! Can you update your
description and reference the discuss thread on this?
First Q looking through the change list in the description -
[
https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16636056#comment-16636056
]
ASF GitHub Bot commented on METRON-1681:
Github user merrimanr commented on the issue:
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1213
The MessageParser.parseOptional call returns a list of JSONObjects which is
then processed (field transformations applied, messages validated, etc). The
difference is WHEN each processed
[
https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635965#comment-16635965
]
ASF GitHub Bot commented on METRON-1681:
Github user nickwallen commented on the issue:
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1213
> Before I go implementing changes we need to decide on callback vs list. I
don't see how we can design an interface that supports both (am I wrong there?)
so we need to choose. Seems to be
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1213
I think the travis failure is unrelated. I have to make changes based on
feedback so I'll keep on eye on it after the next run.
Before I go implementing changes we need to decide on
[
https://issues.apache.org/jira/browse/METRON-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635697#comment-16635697
]
ASF GitHub Bot commented on METRON-1771:
Github user merrimanr commented on a diff in the pull
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/1190#discussion_r222000643
--- Diff:
metron-platform/metron-indexing/src/main/java/org/apache/metron/indexing/dao/MultiIndexDao.java
---
@@ -282,4 +276,27 @@ public Document
Github user simonellistonball commented on the issue:
https://github.com/apache/metron/pull/1060
The fix is not necessary in pure Apache Ambari, and is only required in a
non-Apache toolchain, hence from a pure Apache perspective 'works as designed'
(just not very inclusively
[
https://issues.apache.org/jira/browse/METRON-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635525#comment-16635525
]
ASF GitHub Bot commented on METRON-1615:
Github user simonellistonball commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635523#comment-16635523
]
ASF GitHub Bot commented on METRON-1761:
Github user ottobackwards commented on the issue:
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1184
@mmiklavc Can you take a look at the parser.validate() stuff in the bolt?
Maybe the answer is put a dummy invalid record in there and fail validation for
each parse failure?
---
[
https://issues.apache.org/jira/browse/METRON-1615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635520#comment-16635520
]
ASF GitHub Bot commented on METRON-1615:
Github user mmiklavc commented on the issue:
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1060
> In any case, this is probably not a good Apache fix, since from the
Apache point of view this already 'works as designed'.
Why would a bug fix for incomplete behavior not be a good fix
[
https://issues.apache.org/jira/browse/METRON-1681?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635478#comment-16635478
]
ASF GitHub Bot commented on METRON-1681:
Github user justinleet commented on the issue:
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1213
Re: callback vs list. I'm pretty neutral on which one we do. I probably
have a slight preference towards the callbacks, just because it more closely
matches the original behavior, but I don't
[
https://issues.apache.org/jira/browse/METRON-1771?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635457#comment-16635457
]
ASF GitHub Bot commented on METRON-1771:
Github user merrimanr commented on the issue:
[
https://issues.apache.org/jira/browse/METRON-1761?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16635458#comment-16635458
]
ASF GitHub Bot commented on METRON-1761:
Github user ottobackwards commented on the issue:
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1190
@nickwallen, the latest commit should address your comments. Let me know
what you think.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1184
If you think the "every line fails" == fail, some fails = emit and log
works, we can do that, but I don't know how or if we want to put things in the
error stream. I need to look at it more
24 matches
Mail list logo
