[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-06 Thread GitBox
JonZeolla commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-624657441 That's just a side effect of our merging process, which doesn't use the github built-ins. This was squash merged as 587e9dac9b915f7d0c1116a4432447b5d92e

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-05 Thread GitBox
JonZeolla commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-624043661 @ottobackwards Unit tests and e2e are both passing now. This is an automated message from the

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-04 Thread GitBox
JonZeolla commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-623701958 End to end tests are succeeding, but the unit tests appear to be failing so that needs addressed. Converting this PR to a draft since it's still WIP it seems.

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-04 Thread GitBox
JonZeolla commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-623645487 My concern with writing it in a README is that it would be prone to being incorrect. In `zkg.meta` do we say it requires `zeek >=3.0.0`. I tested against 3.0.5

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on pull request #44: METRON-2270 Update to reflect bro project rename

2020-05-04 Thread GitBox
JonZeolla commented on pull request #44: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/44#issuecomment-623587568 Done This is an automated message from the Apache Git Service. To respond to the message, please