[GitHub] justinleet commented on issue #1325: METRON-1970 Add Metadata to Error Messages Generated During Parsing

2019-02-12 Thread GitBox
justinleet commented on issue #1325: METRON-1970 Add Metadata to Error Messages Generated During Parsing URL: https://github.com/apache/metron/pull/1325#issuecomment-462838439 +1, thanks for the contribution! This is an

[GitHub] justinleet commented on issue #1325: METRON-1970 Add Metadata to Error Messages Generated During Parsing

2019-02-04 Thread GitBox
justinleet commented on issue #1325: METRON-1970 Add Metadata to Error Messages Generated During Parsing URL: https://github.com/apache/metron/pull/1325#issuecomment-460393409 The validation I'd do is to at least test my assumption (dynamic mapping) for ES. And then I'd make sure any

[GitHub] justinleet commented on issue #1325: METRON-1970 Add Metadata to Error Messages Generated During Parsing

2019-01-25 Thread GitBox
justinleet commented on issue #1325: METRON-1970 Add Metadata to Error Messages Generated During Parsing URL: https://github.com/apache/metron/pull/1325#issuecomment-457708817 I believe we index errors into ES and Solr, right? I would expect the metadata fields to not show up in Solr (we