Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1041
@nickwallen Either seems to hit the main issues, I'll close this one out
and we can go with #1013. I'll also close this ticket as a dupe.
---
Github user nickwallen commented on the issue:
https://github.com/apache/metron/pull/1041
Does this also fix the issue from #1013? Or is #1013 also needed? I'm
good either way.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1041
Right, we are on the same page. That is one of the scripts I was
suggesting you ape.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1041
@ottobackwards I think the main thing there would be to do something like
this instead of the rm:
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1041
I would say that the scripts we have wrt PR's and RC's and Commits should
be as common as possible. With the goal that they actually share code down the
line. So I would say that the
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1041
I added the `rm` anyway, since I made another adjustment. Before it was
trying to checkout before cd.
---
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1041
Also, might be worth adding an `rm -rf "$WORKDIR/metron-$VERSION"` to make
sure it's cleared out. If anyone has a preference on that, let me know and I
can add it.
---
