[GitHub] metron issue #1088: Metron 1621: Sorting alerts table by score

2018-06-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1088 And congrats on your first contribution! ---

[GitHub] metron issue #1088: Metron 1621: Sorting alerts table by score

2018-06-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1088 +1 by inspection,thanks for the contribution! ---

[GitHub] metron issue #1088: Metron 1621 - Sorting alerts table by score

2018-06-28 Thread tiborm
Github user tiborm commented on the issue: https://github.com/apache/metron/pull/1088 Thanks @cestella! I asked @sardell to review. ---

[GitHub] metron issue #1088: Metron 1621 - Sorting alerts table by score

2018-06-28 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1088 This looks good to me; investing in the e2e tests seems great to me. One small thing, could you mark the checkboxes in the submission checklist that are completed? I'm not super