[GitHub] metron issue #1111: METRON-1665 Host UIs on Spring Boot and add SSO authenti...

2018-08-28 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/ This has been merged into the feature branch. Can you close @simonellistonball? ---

[GitHub] metron issue #1111: METRON-1665 Host UIs on Spring Boot and add SSO authenti...

2018-08-28 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/ Thanks @simonellistonball. I think this is good enough to start with. +1 ---

[GitHub] metron issue #1111: METRON-1665 Host UIs on Spring Boot and add SSO authenti...

2018-08-27 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/ Here is what I think is pending on this PR: - Address the minor comments I've made inline - Update the metron-rest and/or other relevant READMEs with the new authentication approach -

[GitHub] metron issue #1111: METRON-1665 Host UIs on Spring Boot and add SSO authenti...

2018-08-23 Thread simonellistonball
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/ Thanks for the catches Ryan. My objective around metron-rest was to try and leave it as little changed as possible in this effort, since the ticket is more around the ui hosts,

[GitHub] metron issue #1111: METRON-1665 Host UIs on Spring Boot and add SSO authenti...

2018-08-22 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/ I really like this feature and think it's an important improvement. This PR is a great start and I don't see any major architectural issues. I've added some comments inline for the really minor