[GitHub] metron issue #1119: METRON-1676: Adding date range selector to PCAP filter b...

2018-08-06 Thread tiborm
Github user tiborm commented on the issue: https://github.com/apache/metron/pull/1119 Thanks Ryan! ---

[GitHub] metron issue #1119: METRON-1676: Adding date range selector to PCAP filter b...

2018-08-06 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1119 Can you close this PR? ---

[GitHub] metron issue #1119: METRON-1676: Adding date range selector to PCAP filter b...

2018-08-06 Thread merrimanr
Github user merrimanr commented on the issue: https://github.com/apache/metron/pull/1119 Thanks this looks good to me. +1 ---

[GitHub] metron issue #1119: METRON-1676: Adding date range selector to PCAP filter b...

2018-08-06 Thread tiborm
Github user tiborm commented on the issue: https://github.com/apache/metron/pull/1119 @merrimanr I fixed the license header typo. It's a copy/paste issue so we'll try to find where is it comes from. Thanks! ---

[GitHub] metron issue #1119: METRON-1676: Adding date range selector to PCAP filter b...

2018-07-26 Thread tiborm
Github user tiborm commented on the issue: https://github.com/apache/metron/pull/1119 @justinleet User able to select a year or month by opening the time selector drop-down and clicking on the year of month values on the top. We reused metron's date-picker component. This behavior

[GitHub] metron issue #1119: METRON-1676: Adding date range selector to PCAP filter b...

2018-07-26 Thread tiborm
Github user tiborm commented on the issue: https://github.com/apache/metron/pull/1119 @mmiklavc test instructions added to the PR description and the jira ticket as well ---

[GitHub] metron issue #1119: METRON-1676: Adding date range selector to PCAP filter b...

2018-07-23 Thread justinleet
Github user justinleet commented on the issue: https://github.com/apache/metron/pull/1119 The fields for the date selector are unable to be input manually, which makes doing something simple like changing a year fairly unintuitive. Is there a way to allow the user to be able to make

[GitHub] metron issue #1119: METRON-1676: Adding date range selector to PCAP filter b...

2018-07-23 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1119 > Have you included steps to reproduce the behavior or problem that is being changed or addressed? > > Have you included steps or a guide to how the change may be verified and tested

[GitHub] metron issue #1119: METRON-1676: Adding date range selector to PCAP filter b...

2018-07-20 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1119 Due to a bug in apache rat, our license checking component, it's ignoring all license checks on typescript files. I have submitted a PR to up the rat plugin version and have fixed it in master