Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1140
Merged into feature branch, closing
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1140
@merrimanr - agreed. Pcap hasn't gotten nearly as much attention as the
rest of the core infrastructure for quite some time. I created a Jira to track
this -
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1140
That's fine with me. Just wanted to point out that this test is still
deficient because the pcap topology part really isn't tested that well and the
only coverage we have right now is that it
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1140
> If I introduced a bug to the pcap topology code, which test would fail?
@merrimanr They would all fail because the writing to HDFS sequence files
is incorrect. Prior to this refactoring,
Github user merrimanr commented on the issue:
https://github.com/apache/metron/pull/1140
First off, I think this is definitely an improvement. Putting the
individual pcap queries into separate tests makes it easier to understand when
things go wrong.
Would it make sense to
Github user justinleet commented on the issue:
https://github.com/apache/metron/pull/1140
+1 by inspection. This is great cleanup and makes it a lot easier to
understand.
---
Github user mmiklavc commented on the issue:
https://github.com/apache/metron/pull/1140
I also ran this up in full dev to verify the pcap_query.sh CLI tool still
works as expected.
`$METRON_HOME/bin/pcap_query.sh fixed -bp /apps/metron/pcap/input -df
"-MM-dd-HH-mm" -st
