[GitHub] metron issue #687: METRON-1090 [DISCUSS] Add Assignment to Stellar Language

2018-05-09 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/687 I think I have a minor preference for 2, honestly. I like this work and don't want it to languish or grow too big. Entirely as an aside, we should probably have a set of microbenchmark tests for

[GitHub] metron issue #687: METRON-1090 [DISCUSS] Add Assignment to Stellar Language

2018-05-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/687 Ok, so we are on the same page. I purposely did not put the update in the map resolver because I knew it warranted more discussion etc, and this is it. I just wasn't sure I was understanding

[GitHub] metron issue #687: METRON-1090 [DISCUSS] Add Assignment to Stellar Language

2018-05-09 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/687 So, I guess I'm suggesting that this is like..3/4 of the way to a complete solution, which is for stellar to handle variable assignments completely. Specifically, I'd say that our