GitHub user as22323 opened a pull request:
https://github.com/apache/metron/pull/1046
METRON-1597 EC2 10 Node Deployment - New function to check os and update
*.cfg control_path
## Contributor Comments
This PR updates run.sh to include a function (changeAnsibleControlPath)
that will check for the OS that the run.sh file is run on. It will update the
control_path in ansible.cfg accordingly.
Test1:
Tested the changeAnsibleControlPath function on a sample ansible.cfg across
multiple operating systems. Checked to see if the control_path changed
properly. The attached image shows the results.
Test2:
Testing was done on Mac OS High Sierra using Metron 0.5.0-rc2. The run.sh
file was updated to include changeAnsibleControlPath(). Results below show the
change.
## Pull Request Checklist
Thank you for submitting a contribution to Apache Metron.
Please refer to our [Development
Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235)
for the complete guide to follow for contributions.
Please refer also to our [Build Verification
Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview)
for complete smoke testing guides.
In order to streamline the review of the contribution we ask you follow
these guidelines and ask you to double check the following:
### For all changes:
- [x] Is there a JIRA ticket associated with this PR? If not one needs to
be created at [Metron
Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel).
- [x] Does your PR title start with METRON-XXXX where XXXX is the JIRA
number you are trying to resolve? Pay particular attention to the hyphen "-"
character.
- [x] Has your PR been rebased against the latest commit within the target
branch (typically master)?
### For code changes:
- [x] Have you included steps to reproduce the behavior or problem that is
being changed or addressed?
- [x] Have you included steps or a guide to how the change may be verified
and tested manually?
- [ ] Have you ensured that the full suite of tests and checks have been
executed in the root metron folder via:
```
mvn -q clean integration-test install &&
dev-utilities/build-utils/verify_licenses.sh
```
- [ ] Have you written or updated unit tests and or integration tests to
verify your changes?
- [x] If adding new dependencies to the code, are these dependencies
licensed in a way that is compatible for inclusion under [ASF
2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] Have you verified the basic functionality of the build by building
and running locally with Vagrant full-dev environment or the equivalent?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in
which it is rendered by building and verifying the site-book? If not then run
the following commands and the verify changes via
`site-book/target/site/index.html`:
```
cd site-book
mvn site
```
#### Note:
Please ensure that once the PR is submitted, you check travis-ci for build
issues and submit an update to your PR as soon as possible.
It is also recommended that [travis-ci](https://travis-ci.org) is set up
for your personal repository such that your branches are built there before
submitting a pull request.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/mtemp2/metron master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/metron/pull/1046.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1046
----
commit 74ab7b3f7233c1f13d5794b3fc14684c20bc4551
Author: as22323 <a.k.shah@...>
Date: 2018-06-03T21:49:25Z
New function to check os and update *.cfg control_path accordingly
commit a2a1388e61e21df8b93c1e280bac6ed686940f41
Author: as22323 <a.k.shah@...>
Date: 2018-06-03T23:17:14Z
inc comment on function that overwrites control_path
----
---
