Github user asfgit closed the pull request at:
https://github.com/apache/metron/pull/1172
---
Github user tiborm closed the pull request at:
https://github.com/apache/metron/pull/1172
---
GitHub user tiborm reopened a pull request:
https://github.com/apache/metron/pull/1172
METRON-1724: Date/time validation missing in PCAP query
## Contributor Comments
This PR contains date range validation. We added validation messages with
hints also, to help the user correct
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212383664
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.spec.ts
---
@@ -179,19 +172,6 @@ describe('PcapFiltersComponent',
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212369764
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-packet-line/pcap-packet-line.component.spec.ts
---
@@ -143,38 +132,4 @@
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212342518
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-packet-line/pcap-packet-line.component.spec.ts
---
@@ -143,38 +132,4 @@
Github user merrimanr commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212341861
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.spec.ts
---
@@ -179,19 +172,6 @@
Github user ruffle1986 commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212205588
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License for the
Github user ruffle1986 commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212205052
--- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts
---
@@ -17,13 +17,13 @@
*/
export class PcapRequest {
-
Github user ruffle1986 commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212204263
--- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts
---
@@ -17,13 +17,13 @@
*/
export class PcapRequest {
-
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212196734
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License for the
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r212012726
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License for the
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211990573
--- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts
---
@@ -17,13 +17,13 @@
*/
export class PcapRequest {
-
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211989622
--- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts
---
@@ -17,13 +17,13 @@
*/
export class PcapRequest {
-
Github user tiborm commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211979831
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License for the
Github user ruffle1986 commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211972645
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License for the
Github user ruffle1986 commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211970078
--- Diff: metron-interface/metron-alerts/src/app/pcap/model/pcap.request.ts
---
@@ -17,13 +17,13 @@
*/
export class PcapRequest {
-
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211964997
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License
Github user ruffle1986 commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211960374
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License for the
Github user sardell commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211945169
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License for the
GitHub user tiborm opened a pull request:
https://github.com/apache/metron/pull/1172
METRON-1724: Date/time validation missing in PCAP query
## Contributor Comments
This PR contains date range validation. We added validation messages with
hints also, to help the user correct a
21 matches
Mail list logo
