[GitHub] mmiklavc commented on issue #1338: METRON-2005: Batch Writer writes 0-byte files to HDFS on rotation

2019-02-15 Thread GitBox
mmiklavc commented on issue #1338: METRON-2005: Batch Writer writes 0-byte files to HDFS on rotation URL: https://github.com/apache/metron/pull/1338#issuecomment-464189965 That looks good @justinleet, thanks for the updates. As far as I'm concerned, this looks good. I'm +1 by inspection

[GitHub] mmiklavc commented on issue #1338: METRON-2005: Batch Writer writes 0-byte files to HDFS on rotation

2019-02-15 Thread GitBox
mmiklavc commented on issue #1338: METRON-2005: Batch Writer writes 0-byte files to HDFS on rotation URL: https://github.com/apache/metron/pull/1338#issuecomment-464179018 Can you clarify a but more what file rotation should look like with and without Stellar functions modifying the