[GitHub] ottobackwards commented on issue #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72

2019-02-12 Thread GitBox
ottobackwards commented on issue #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72 URL: https://github.com/apache/metron-bro-plugin-kafka/pull/20#issuecomment-462993968 No I won't, this looks good to me, ran with docker, didn't see the error messages +1

[GitHub] ottobackwards commented on issue #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72

2019-02-12 Thread GitBox
ottobackwards commented on issue #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72 URL: https://github.com/apache/metron-bro-plugin-kafka/pull/20#issuecomment-462974152 So after review: The issue is that bro is calling finish and deleting the objects, and then later the

[GitHub] ottobackwards commented on issue #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72

2019-02-12 Thread GitBox
ottobackwards commented on issue #20: METRON-1910: bro plugin segfaults on src/KafkaWriter.cc:72 URL: https://github.com/apache/metron-bro-plugin-kafka/pull/20#issuecomment-462972595 @nickwallen deleting something twice is an error. ```cpp #include int main() {