[jira] [Updated] (METRON-2347) Move kafka plugin testing to docker compose

2020-04-28 Thread Jon Zeolla (Jira)
[ https://issues.apache.org/jira/browse/METRON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Zeolla updated METRON-2347: --- Description: Currently we use a series of bash scripts to run our tests in docker containers. In

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
JonZeolla commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417038403 ## File path: docker/scripts/docker_run_create_topic_in_kafka.sh ## @@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka with

[jira] [Commented] (METRON-2347) [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread Jon Zeolla (Jira)
[ https://issues.apache.org/jira/browse/METRON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095019#comment-17095019 ] Jon Zeolla commented on METRON-2347: https://github.com/apache/metron-bro-plugin-kafka/pull/42 >

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417041000 ## File path: docker/README.md ## @@ -209,33 +140,21 @@ testing scripts to be added to a pull request, and subsequently to a test

[jira] [Updated] (METRON-2347) [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread Jon Zeolla (Jira)
[ https://issues.apache.org/jira/browse/METRON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Zeolla updated METRON-2347: --- Summary: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests (was: [BRO-PLUGIN-KAFKA]

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417041687 ## File path: docker/containers/zookeeper/Dockerfile ## @@ -16,20 +14,4 @@ # See the License for the specific language governing

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417041583 ## File path: docker/containers/kafka/Dockerfile ## @@ -16,20 +14,4 @@ # See the License for the specific language governing

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417041583 ## File path: docker/containers/kafka/Dockerfile ## @@ -16,20 +14,4 @@ # See the License for the specific language governing

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417041527 ## File path: docker/containers/kafka/Dockerfile ## @@ -16,20 +14,4 @@ # See the License for the specific language governing

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
JonZeolla commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417045900 ## File path: docker/README.md ## @@ -209,33 +140,21 @@ testing scripts to be added to a pull request, and subsequently to a test suite.

[jira] [Updated] (METRON-2347) [BRO-PLUGIN-KAFKA] Replace wait-for-it with docker compose

2020-04-28 Thread Jon Zeolla (Jira)
[ https://issues.apache.org/jira/browse/METRON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Zeolla updated METRON-2347: --- Summary: [BRO-PLUGIN-KAFKA] Replace wait-for-it with docker compose (was: Move kafka plugin

[jira] [Updated] (METRON-2347) [BRO-PLUGIN-KAFKA] Replace wait-for-it with docker compose

2020-04-28 Thread Jon Zeolla (Jira)
[ https://issues.apache.org/jira/browse/METRON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Zeolla updated METRON-2347: --- Description: Currently we use a series of bash scripts to run our tests in docker containers in

[GitHub] [metron-bro-plugin-kafka] JonZeolla opened a new pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
JonZeolla opened a new pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42 ## Contributor Comments This is a first step towards `docker-compose` in our end to end tests. ### Testing Run `./run_end_to_end.sh` and `./finish_end_to_end.sh` ##

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417042597 ## File path: docker/scripts/docker_run_create_topic_in_kafka.sh ## @@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417046810 ## File path: docker/scripts/docker_run_create_topic_in_kafka.sh ## @@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka

[jira] [Updated] (METRON-2347) [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread Jon Zeolla (Jira)
[ https://issues.apache.org/jira/browse/METRON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Zeolla updated METRON-2347: --- Description: Currently we use a series of bash scripts, including a third-party, MIT-licensed

[jira] [Commented] (METRON-2346) Update kafka plugin testing dependencies

2020-04-28 Thread Jon Zeolla (Jira)
[ https://issues.apache.org/jira/browse/METRON-2346?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17095018#comment-17095018 ] Jon Zeolla commented on METRON-2346: https://github.com/apache/metron-bro-plugin-kafka/pull/41 >

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
JonZeolla commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417050279 ## File path: docker/containers/kafka/Dockerfile ## @@ -16,20 +14,4 @@ # See the License for the specific language governing permissions

[jira] [Updated] (METRON-2347) [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread Jon Zeolla (Jira)
[ https://issues.apache.org/jira/browse/METRON-2347?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jon Zeolla updated METRON-2347: --- Description: Currently we use a series of bash scripts to run our tests in docker containers in

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
JonZeolla commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417045301 ## File path: docker/scripts/docker_run_create_topic_in_kafka.sh ## @@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka with

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
JonZeolla commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417045301 ## File path: docker/scripts/docker_run_create_topic_in_kafka.sh ## @@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka with

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
JonZeolla commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417045301 ## File path: docker/scripts/docker_run_create_topic_in_kafka.sh ## @@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka with

[GitHub] [metron-bro-plugin-kafka] JonZeolla commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
JonZeolla commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417050898 ## File path: docker/scripts/docker_run_create_topic_in_kafka.sh ## @@ -80,7 +80,10 @@ echo "Running docker_run_create_topic_in_kafka with

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#issuecomment-620974069 I am +1 on this. Review and run, seems good to me. The wait for it can be a follow on. Please create a jira.

[GitHub] [metron-bro-plugin-kafka] ottobackwards commented on a change in pull request #42: METRON-2347: [BRO-PLUGIN-KAFKA] Use docker compose in end to end tests

2020-04-28 Thread GitBox
ottobackwards commented on a change in pull request #42: URL: https://github.com/apache/metron-bro-plugin-kafka/pull/42#discussion_r417050675 ## File path: docker/containers/kafka/Dockerfile ## @@ -16,20 +14,4 @@ # See the License for the specific language governing