[jira] [Commented] (METRON-1563) Initial Feature Branch Work

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494603#comment-16494603 ] ASF GitHub Bot commented on METRON-1563: Github user ottobackwards commented on the issue:

[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch

2018-05-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1014 Can I ask how we do ++, --, += etc with the := notation? ---

[GitHub] metron issue #1033: METRON-1579: Stellar should return the expression that f...

2018-05-29 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/1033 +1 I will say, that the exception building facilities and builders should be publicly exposed as part of stellar as a follow on. As part of my own antlr work on the syslog stuff, I am

[jira] [Commented] (METRON-1579) Stellar should return the expression that failed in the exception

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494601#comment-16494601 ] ASF GitHub Bot commented on METRON-1579: Github user ottobackwards commented on the issue:

[jira] [Commented] (METRON-1583) issue regarding cisco asa logs

2018-05-29 Thread Simon Elliston Ball (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494581#comment-16494581 ] Simon Elliston Ball commented on METRON-1583: - Would it be possible to share the full log

[jira] [Commented] (METRON-1584) Indexing Topology Crashes with Invalid Message

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494425#comment-16494425 ] ASF GitHub Bot commented on METRON-1584: Github user cestella commented on the issue:

[GitHub] metron issue #1036: METRON-1584 Indexing Topology Crashes with Invalid Messa...

2018-05-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1036 Yeah, I have mixed reactions. I think refactoring opportunistically is damned useful, but if it becomes excessive it can make it hard to review and make it hard for those with open branches in

[jira] [Commented] (METRON-1584) Indexing Topology Crashes with Invalid Message

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494406#comment-16494406 ] ASF GitHub Bot commented on METRON-1584: Github user mmiklavc commented on the issue:

[GitHub] metron issue #1036: METRON-1584 Indexing Topology Crashes with Invalid Messa...

2018-05-29 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1036 I want to take a step back a moment here. I think there are some useful, clarifying refactorings in this PR. I'm generally in favor of refactoring improvements e.g. "handleTick(tuple)" that sum up

[jira] [Commented] (METRON-1584) Indexing Topology Crashes with Invalid Message

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494405#comment-16494405 ] ASF GitHub Bot commented on METRON-1584: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1036: METRON-1584 Indexing Topology Crashes with Invali...

2018-05-29 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1036#discussion_r191596670 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java --- @@ -115,15 +116,37 @@ public void

[jira] [Commented] (METRON-1584) Indexing Topology Crashes with Invalid Message

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494376#comment-16494376 ] ASF GitHub Bot commented on METRON-1584: Github user cestella commented on a diff in the pull

[GitHub] metron pull request #1036: METRON-1584 Indexing Topology Crashes with Invali...

2018-05-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1036#discussion_r191592021 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java --- @@ -115,15 +116,37 @@ public void

[jira] [Commented] (METRON-1584) Indexing Topology Crashes with Invalid Message

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494366#comment-16494366 ] ASF GitHub Bot commented on METRON-1584: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1036: METRON-1584 Indexing Topology Crashes with Invali...

2018-05-29 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1036#discussion_r191590539 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java --- @@ -213,60 +214,144 @@ public void

[jira] [Commented] (METRON-1584) Indexing Topology Crashes with Invalid Message

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494357#comment-16494357 ] ASF GitHub Bot commented on METRON-1584: Github user cestella commented on a diff in the pull

[GitHub] metron pull request #1036: METRON-1584 Indexing Topology Crashes with Invali...

2018-05-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1036#discussion_r191588785 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java --- @@ -115,15 +116,37 @@ public void

[GitHub] metron pull request #1036: METRON-1584 Indexing Topology Crashes with Invali...

2018-05-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1036#discussion_r191588901 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java --- @@ -213,60 +214,144 @@ public void

[jira] [Commented] (METRON-1584) Indexing Topology Crashes with Invalid Message

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494355#comment-16494355 ] ASF GitHub Bot commented on METRON-1584: Github user cestella commented on a diff in the pull

[jira] [Commented] (METRON-1584) Indexing Topology Crashes with Invalid Message

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494352#comment-16494352 ] ASF GitHub Bot commented on METRON-1584: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1036: METRON-1584 Indexing Topology Crashes with Invali...

2018-05-29 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1036#discussion_r191588328 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java --- @@ -115,15 +116,37 @@ public void

[jira] [Commented] (METRON-1584) Indexing Topology Crashes with Invalid Message

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494348#comment-16494348 ] ASF GitHub Bot commented on METRON-1584: Github user nickwallen commented on a diff in the pull

[GitHub] metron pull request #1036: METRON-1584 Indexing Topology Crashes with Invali...

2018-05-29 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1036#discussion_r191587917 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java --- @@ -213,60 +214,144 @@ public void

[jira] [Commented] (METRON-1569) Allow user to change field name conversion when indexing to Elasticsearch

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494330#comment-16494330 ] ASF GitHub Bot commented on METRON-1569: Github user cestella commented on the issue:

[GitHub] metron issue #1022: METRON-1569 Allow user to change field name conversion w...

2018-05-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1022 Ok, I'm comfortable with the change now. +1 by inspection, pending @mmiklavc ---

[jira] [Commented] (METRON-1569) Allow user to change field name conversion when indexing to Elasticsearch

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494329#comment-16494329 ] ASF GitHub Bot commented on METRON-1569: Github user nickwallen commented on a diff in the pull

[jira] [Commented] (METRON-1584) Indexing Topology Crashes with Invalid Message

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494328#comment-16494328 ] ASF GitHub Bot commented on METRON-1584: Github user mmiklavc commented on a diff in the pull

[GitHub] metron pull request #1022: METRON-1569 Allow user to change field name conve...

2018-05-29 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1022#discussion_r191585931 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/field/FieldNameConverters.java --- @@ -0,0 +1,98 @@ +/* + *

[GitHub] metron pull request #1036: METRON-1584 Indexing Topology Crashes with Invali...

2018-05-29 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1036#discussion_r191585908 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java --- @@ -115,15 +116,37 @@ public void

[jira] [Commented] (METRON-1584) Indexing Topology Crashes with Invalid Message

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494322#comment-16494322 ] ASF GitHub Bot commented on METRON-1584: Github user cestella commented on a diff in the pull

[GitHub] metron pull request #1036: METRON-1584 Indexing Topology Crashes with Invali...

2018-05-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1036#discussion_r191585015 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/bolt/BulkMessageWriterBolt.java --- @@ -213,60 +214,144 @@ public void

[jira] [Commented] (METRON-1584) Indexing Topology Crashes with Invalid Message

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494320#comment-16494320 ] ASF GitHub Bot commented on METRON-1584: Github user cestella commented on a diff in the pull

[GitHub] metron pull request #1036: METRON-1584 Indexing Topology Crashes with Invali...

2018-05-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1036#discussion_r191584626 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java --- @@ -115,15 +116,37 @@ public void

[jira] [Commented] (METRON-1584) Indexing Topology Crashes with Invalid Message

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494314#comment-16494314 ] ASF GitHub Bot commented on METRON-1584: Github user cestella commented on a diff in the pull

[GitHub] metron pull request #1036: METRON-1584 Indexing Topology Crashes with Invali...

2018-05-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1036#discussion_r191582496 --- Diff: metron-platform/metron-writer/src/main/java/org/apache/metron/writer/BulkWriterComponent.java --- @@ -115,15 +116,37 @@ public void

[jira] [Commented] (METRON-1569) Allow user to change field name conversion when indexing to Elasticsearch

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494273#comment-16494273 ] ASF GitHub Bot commented on METRON-1569: Github user cestella commented on a diff in the pull

[GitHub] metron pull request #1022: METRON-1569 Allow user to change field name conve...

2018-05-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1022#discussion_r191574312 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/field/FieldNameConverters.java --- @@ -0,0 +1,98 @@ +/* + *

[jira] [Commented] (METRON-1298) TimeRange Picker doesn't work on Safari

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494270#comment-16494270 ] ASF GitHub Bot commented on METRON-1298: Github user nickwallen commented on the issue:

[GitHub] metron issue #830: METRON-1298: TimeRange Picker doesn't work on Safari

2018-05-29 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/830 -1 as this PR has been abandoned. ---

[jira] [Commented] (METRON-1569) Allow user to change field name conversion when indexing to Elasticsearch

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494268#comment-16494268 ] ASF GitHub Bot commented on METRON-1569: Github user nickwallen commented on the issue:

[GitHub] metron issue #1022: METRON-1569 Allow user to change field name conversion w...

2018-05-29 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1022 All review feedback should have been addressed. Let me know if there is anything else @mmiklavc @cestella ---

[jira] [Commented] (METRON-1479) Add editorconfig - create guideline for code formatting in the angular part of the app

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494254#comment-16494254 ] ASF GitHub Bot commented on METRON-1479: Github user nickwallen commented on the issue:

[jira] [Commented] (METRON-1472) Add stylelint support

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1472?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494251#comment-16494251 ] ASF GitHub Bot commented on METRON-1472: Github user nickwallen commented on the issue:

[jira] [Commented] (METRON-1478) Move type definitions to dev-dependencies

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1478?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494256#comment-16494256 ] ASF GitHub Bot commented on METRON-1478: Github user nickwallen commented on the issue:

[jira] [Commented] (METRON-1480) Add yarn as default build tool for the frontend

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494252#comment-16494252 ] ASF GitHub Bot commented on METRON-1480: Github user nickwallen commented on the issue:

[jira] [Commented] (METRON-1474) Add normalizecss

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1474?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494255#comment-16494255 ] ASF GitHub Bot commented on METRON-1474: Github user nickwallen commented on the issue:

[GitHub] metron issue #954: METRON-1478 Move type definitions to dev-dependencies

2018-05-29 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/954 -1 as this has become an abandoned PR. I will open a request to close this. ---

[GitHub] metron issue #956: METRON-1474 Add normalizecss

2018-05-29 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/956 -1 as this has become an abandoned PR. I will open a request to close this PR. ---

[GitHub] metron issue #952: METRON-1480 Add yarn as default build tool for the fronte...

2018-05-29 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/952 -1 as this has become an abandoned PR. I will open a request to close this. ---

[GitHub] metron issue #951: METRON-1479 Add editorconfig - create guideline for code ...

2018-05-29 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/951 -1 as this has become an abandoned PR. I will open a request to close this PR. ---

[GitHub] metron issue #953: METRON-1472 Add stylelint support

2018-05-29 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/953 -1 as this has become an abandoned PR. I will open a request to close this. ---

[jira] [Commented] (METRON-1563) Initial Feature Branch Work

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494207#comment-16494207 ] ASF GitHub Bot commented on METRON-1563: Github user cestella commented on the issue:

[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch

2018-05-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1014 Do we want to expand assignment to `:=` as part of this PR or make it a follow-on in this feature branch? I'm ok with either way. ---

[jira] [Commented] (METRON-1563) Initial Feature Branch Work

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494185#comment-16494185 ] ASF GitHub Bot commented on METRON-1563: Github user cestella commented on the issue:

[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch

2018-05-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1014 >Ultimately, I'd like to see us move to supporting = as that is just way more intuitive for most people. Maybe that means supporting both = and := for some period of time? In my opinion

[jira] [Commented] (METRON-1579) Stellar should return the expression that failed in the exception

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494156#comment-16494156 ] ASF GitHub Bot commented on METRON-1579: GitHub user cestella reopened a pull request:

[jira] [Commented] (METRON-1568) Stellar should have a _ special variable which returns the message in map form

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1568?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494153#comment-16494153 ] ASF GitHub Bot commented on METRON-1568: Github user mmiklavc commented on the issue:

[jira] [Commented] (METRON-1579) Stellar should return the expression that failed in the exception

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494155#comment-16494155 ] ASF GitHub Bot commented on METRON-1579: Github user cestella closed the pull request at:

[GitHub] metron pull request #1033: METRON-1579: Stellar should return the expression...

2018-05-29 Thread cestella
GitHub user cestella reopened a pull request: https://github.com/apache/metron/pull/1033 METRON-1579: Stellar should return the expression that failed in the exception ## Contributor Comments There are situations where we are not including the expression in the exception.

[GitHub] metron issue #1021: METRON-1568: Stellar should have a _ special variable wh...

2018-05-29 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1021 +1 via inspection. ---

[GitHub] metron pull request #1033: METRON-1579: Stellar should return the expression...

2018-05-29 Thread cestella
Github user cestella closed the pull request at: https://github.com/apache/metron/pull/1033 ---

[jira] [Commented] (METRON-1563) Initial Feature Branch Work

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494063#comment-16494063 ] ASF GitHub Bot commented on METRON-1563: Github user nickwallen commented on the issue:

[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch

2018-05-29 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1014 > I am not sure how this PR impacts all the places where Stellar is used and assignment .. Or maybe that is left to a future PR? Sorry, its a little hard to digest that old PR, but I

[jira] [Commented] (METRON-1563) Initial Feature Branch Work

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494059#comment-16494059 ] ASF GitHub Bot commented on METRON-1563: Github user nickwallen commented on the issue:

[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch

2018-05-29 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/1014 > Should assignment be = or :=? Ultimately, I'd like to see us move to supporting `=` as that is just way more intuitive for most people. Maybe that means supporting both `=` and `:=`

[jira] [Commented] (METRON-1544) Flaky test: org.apache.metron.stellar.common.CachingStellarProcessorTest#testCaching

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16494013#comment-16494013 ] ASF GitHub Bot commented on METRON-1544: Github user asfgit closed the pull request at:

[GitHub] metron pull request #1015: METRON-1544 Flaky test: org.apache.metron.stellar...

2018-05-29 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/metron/pull/1015 ---

[jira] [Commented] (METRON-1563) Initial Feature Branch Work

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1563?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493999#comment-16493999 ] ASF GitHub Bot commented on METRON-1563: Github user cestella commented on the issue:

[GitHub] metron issue #1014: METRON-1563 : Base Stellar assign for feature branch

2018-05-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1014 Should assignment be `=` or `:=`? I'm not super opinionated other than we have been using `:=` and we'd break existing installations if we move to `=`, right? ---

[GitHub] metron issue #1015: METRON-1544 Flaky test: org.apache.metron.stellar.common...

2018-05-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1015 +1 for sure ---

[jira] [Commented] (METRON-1544) Flaky test: org.apache.metron.stellar.common.CachingStellarProcessorTest#testCaching

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493982#comment-16493982 ] ASF GitHub Bot commented on METRON-1544: Github user cestella commented on the issue:

[jira] [Commented] (METRON-1584) Indexing Topology Crashes with Invalid Message

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493980#comment-16493980 ] ASF GitHub Bot commented on METRON-1584: GitHub user nickwallen opened a pull request:

[GitHub] metron pull request #1036: METRON-1584 Indexing Topology Crashes with Invali...

2018-05-29 Thread nickwallen
GitHub user nickwallen opened a pull request: https://github.com/apache/metron/pull/1036 METRON-1584 Indexing Topology Crashes with Invalid Message If the indexing topology receives a message containing invalid JSON, the topology will crash. The topology needs to handle these

[jira] [Commented] (METRON-1577) Solr searches don't include the index of the result

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1577?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493968#comment-16493968 ] ASF GitHub Bot commented on METRON-1577: Github user cestella commented on the issue:

[GitHub] metron issue #1031: METRON-1577: Solr searches don't include the index of th...

2018-05-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1031 @merrimanr can you close this PR since it's been committed? ---

[jira] [Assigned] (METRON-1584) Indexing Topology Crashes with Invalid Message

2018-05-29 Thread Nick Allen (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nick Allen reassigned METRON-1584: -- Assignee: Nick Allen > Indexing Topology Crashes with Invalid Message >

[jira] [Commented] (METRON-1579) Stellar should return the expression that failed in the exception

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493939#comment-16493939 ] ASF GitHub Bot commented on METRON-1579: Github user cestella commented on a diff in the pull

[GitHub] metron issue #1033: METRON-1579: Stellar should return the expression that f...

2018-05-29 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/1033 @ottobackwards That makes sense. How do you like it now? ---

[GitHub] metron pull request #1033: METRON-1579: Stellar should return the expression...

2018-05-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1033#discussion_r191513907 --- Diff: metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/common/BaseStellarProcessor.java --- @@ -143,7 +143,11 @@ public T

[jira] [Commented] (METRON-1579) Stellar should return the expression that failed in the exception

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1579?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493935#comment-16493935 ] ASF GitHub Bot commented on METRON-1579: Github user cestella commented on a diff in the pull

[GitHub] metron pull request #1033: METRON-1579: Stellar should return the expression...

2018-05-29 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1033#discussion_r191513381 --- Diff: metron-platform/metron-enrichment/src/main/java/org/apache/metron/enrichment/adapters/stellar/StellarAdapter.java --- @@ -92,6 +96,19 @@ public

[jira] [Commented] (METRON-1544) Flaky test: org.apache.metron.stellar.common.CachingStellarProcessorTest#testCaching

2018-05-29 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1544?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16493834#comment-16493834 ] ASF GitHub Bot commented on METRON-1544: Github user mmiklavc commented on the issue:

[GitHub] metron issue #1015: METRON-1544 Flaky test: org.apache.metron.stellar.common...

2018-05-29 Thread mmiklavc
Github user mmiklavc commented on the issue: https://github.com/apache/metron/pull/1015 lgtm, +1 ---

[jira] [Updated] (METRON-1583) issue regarding cisco asa logs

2018-05-29 Thread manisha tank (JIRA)
[ https://issues.apache.org/jira/browse/METRON-1583?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] manisha tank updated METRON-1583: - Attachment: cisco_asa_logs_error.png > issue regarding cisco asa logs >

[jira] [Created] (METRON-1583) issue regarding cisco asa logs

2018-05-29 Thread manisha tank (JIRA)
manisha tank created METRON-1583: Summary: issue regarding cisco asa logs Key: METRON-1583 URL: https://issues.apache.org/jira/browse/METRON-1583 Project: Metron Issue Type: Bug Affects

[jira] [Created] (METRON-1582) after installation of metron in ubuntu my system is hang

2018-05-29 Thread manisha tank (JIRA)
manisha tank created METRON-1582: Summary: after installation of metron in ubuntu my system is hang Key: METRON-1582 URL: https://issues.apache.org/jira/browse/METRON-1582 Project: Metron