GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
METRON-1911 [WIP] Docker setup for testing bro plugin
Status>
To try:
```
î° ~/src/apache/forks/metron-bro-plugin-kafka î° î docker î° cd docker
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
I had a lot of trouble with compose, so I did it with plain run and a
shared network.
We can look at compose later.
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238431951
--- Diff: docker/containers/bro-localbuild-container/Dockerfile ---
@@ -0,0 +1,49 @@
+#
+# Licensed to the Apache Software
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238431923
--- Diff: docker/in_docker_scripts/build_bro.sh ---
@@ -0,0 +1,31 @@
+#!/usr/bin/env bash
--- End diff --
all set
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
The idea, at least at this point is that when in the container you will
have the 'built in scripts' that we have, and whatever scripts you have mapped
into the con
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
We will also have scripts that do docker exec etc to read from kafka etc.
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238801412
--- Diff: docker/in_docker_scripts/process_data_dir.sh ---
@@ -0,0 +1,32 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238802060
--- Diff: docker/in_docker_scripts/wait-for-it.sh ---
@@ -0,0 +1,161 @@
+#!/usr/bin/env bash
+# Use this script to test if a
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238803083
--- Diff: docker/in_docker_scripts/wait-for-it.sh ---
@@ -0,0 +1,161 @@
+#!/usr/bin/env bash
+# Use this script to test if a
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238803331
--- Diff: docker/run_test.sh.template ---
@@ -0,0 +1,199 @@
+#!/usr/bin/env bash
--- End diff --
so the idea is that
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238804501
--- Diff: docker/in_docker_scripts/build_bro_plugin.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238804842
--- Diff: docker/in_docker_scripts/build_bro_plugin.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238805123
--- Diff: docker/in_docker_scripts/wait-for-it.sh ---
@@ -0,0 +1,161 @@
+#!/usr/bin/env bash
+# Use this script to test if a
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238805529
--- Diff: docker/scripts/create_docker_network.sh ---
@@ -0,0 +1,73 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238805671
--- Diff: docker/scripts/download_sample_pcaps.sh ---
@@ -0,0 +1,101 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238806017
--- Diff: docker/scripts/download_sample_pcaps.sh ---
@@ -0,0 +1,101 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238826943
--- Diff: docker/scripts/process_data_docker.sh ---
@@ -0,0 +1,29 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238827202
--- Diff: docker/run_test.sh.template ---
@@ -0,0 +1,199 @@
+#!/usr/bin/env bash
--- End diff --
i changed it
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
@JonZeolla , I was going to ask you about that, what do you think the best
practice is for these permissions?
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238848200
--- Diff: docker/example_script.sh ---
@@ -0,0 +1,177 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238850232
--- Diff: docker/scripts/cleanup_containers.sh ---
@@ -0,0 +1,30 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238850284
--- Diff: docker/example_script.sh ---
@@ -0,0 +1,177 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238850336
--- Diff: docker/example_script.sh ---
@@ -0,0 +1,177 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r238851540
--- Diff: docker/example_script.sh ---
@@ -0,0 +1,177 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the Apache Software
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r239090484
--- Diff: docker/in_docker_scripts/build_bro_plugin.sh ---
@@ -0,0 +1,39 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
current send to end cmd is:
```bash
./scripts/download_sample_pcaps.sh --data-path=A_FULL_PATH &&
./example_script.sh --skip-docker-build --leave-runnin
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1291
+1 pending updating the dependency csv file
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
@nickwallen @JonZeolla, with the readme done, this is now ready for review
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
@nickwallen @JonZeolla, with the readme done, this is now ready for review
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1292
Could the return be a full json document, that includes the query
parameters? I can see doing these things and writing to file, and wanting more
than just the data, but having the meta data
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1245
Given we have the 5424 parser, and the 3164 parser in PR already, with
chaining, perhaps this parser would be cleaner and easier to configure and
understand if it was re-positioned ( wrt
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1245#discussion_r239847486
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/regex/RegularExpressionsParserTest.java
---
@@ -0,0 +1,152
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1245#discussion_r239859491
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/regex/RegularExpressionsParserTest.java
---
@@ -0,0 +1,152
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/1245#discussion_r239860797
--- Diff:
metron-platform/metron-parsers/src/test/java/org/apache/metron/parsers/regex/RegularExpressionsParserTest.java
---
@@ -0,0 +1,152
Github user ottobackwards commented on the issue:
https://github.com/apache/metron-bro-plugin-kafka/pull/21
ok, this is fixed. The bashSupport formatter in IntelliJ break the array
assignment. Sorry, i didn't redeploy after a format and document run.
Also, I don&#x
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/1292
@nickwallen What I mean is that the returned value has the query parameters
in it, so you have the data and the query you used for it. Please excuse me if
that is already the case
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r240248699
--- Diff: docker/in_docker_scripts/build_bro_plugin.sh ---
@@ -0,0 +1,48 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron-bro-plugin-kafka/pull/21#discussion_r240249191
--- Diff: docker/scripts/download_sample_pcaps.sh ---
@@ -0,0 +1,105 @@
+#!/usr/bin/env bash
+
+#
+# Licensed to the
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/863
The parser topology PRODUCES the original_string. By that very action, and
it's requirement, it can only be used and required by downstream usages either
from rest ( post indexing ) or d
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/863
What I think would be better would be to have a readme about the required
fields and refer to that document from these other documents
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/964
+1 by inspection
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/969
This seems redundant to the metron stellar system. We should have a
discuss thread maybe where Chainlinks are proposed and you can explain why they
may be better.
That aside, you
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/870
I'll test this when it is ready, but if you have other reviews
keeping you from this, i can wait ;)
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
Resolved conflicts, in the event we ever get around to this
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/971
+1 by inspection. much better than my script. Nice!
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/971
@nickwallen , another thing that maintainers of feature branches have to do
is track master.
I have a script ( based off your old old stuff ) for doing this. If I send
it to you would you
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/972
This seems like it should have some documentation to go with it
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/972#discussion_r176855080
--- Diff: metron-platform/metron-parsers/README.md ---
@@ -45,6 +45,33 @@ There are two general types types of parsers:
* `ERROR` : Throw an
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/972#discussion_r176854208
--- Diff: metron-platform/metron-parsers/README.md ---
@@ -45,6 +45,33 @@ There are two general types types of parsers:
* `ERROR` : Throw an
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/972#discussion_r176855220
--- Diff: metron-platform/metron-parsers/README.md ---
@@ -45,6 +45,33 @@ There are two general types types of parsers:
* `ERROR` : Throw an
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/972
+1 by inspection, thanks for the contribution
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/865
I'm going to bump this, because it is on my todo list, but I am not
optimistic
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/687
Bump
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
Should I close this?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/873
I think I'm actually going to get to create a new commons- component to
house this. Will this pr beat that one? Who knows?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/978
Should this work with ubuntu as well? Would it have to be different? Can
you describe how it works?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/978
I didn't think ubuntu had yum repos.d in the image?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/916
Why not add it to /contrib ? Or can we have a way to like to it from docs
or site?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/873
I think if you are writing or testing commands in the repl this would be
useful.
If it were moved from stellar to common it could be integrated with the
topologies.
The reason I
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/687
@nickwallen @cestella @mattf-horton , Sorry, I thought that question was
more to @mattf-horton at the time.
@cestella I'm not sure I understand what you are saying. Are you s
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/873
I wrote this, because I found myself needing to quantify if there was a
problem or bottleneck in a certain complex expression, and we had no way to
find out.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/873
@simonellistonball, i have read and replied to you last about 100 times,
but now I understand. The PR makes it seem like this is a PR for a major
instrumentation/sampling solution, when I
Github user ottobackwards closed the pull request at:
https://github.com/apache/metron/pull/873
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/873
I'm shelving this. Thinks for taking a look.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
This has gone from a small thing to at least 'say' we have a way to check
if we broke all your stellar stuff after upgrade, to stretching it based on
feedback which was a mistake
Github user ottobackwards closed the pull request at:
https://github.com/apache/metron/pull/856
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
The next attempt at this, if there is one, should start off with some sort
of consensus first. And some agreement on initial scope. This PR would have
been smaller and less ambitious, if that
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/856
It has been long enough that **I** don't even like this PR any more.
-1
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/916
@lvets Putting the vagrant file into a /contrib area with a notice that
sets expectation correctly is the way to go then
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/870
as Tribe Called Quest said: "So what's the scenario"?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/931
@nickwallen is this set for review? Or are you working on pulling the
commits out?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/931
Ran the steps with local zeppelin to full_dev node. Works as described. I
have found that I needed to reinstall zeppelin, since I had stellar installed
already, and just removing it from the
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/970
So, @nickwallen , do you propose implementation of Decorator or another
such pattern? Is this problem inherent in the ES part as well? Should the
whole thing be changed? If so in this PR or
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/931
@nickwallen would you like me to commit this? Or would you rather?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/985
Is there a way to test this in the unit tests?
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/984#discussion_r180167513
--- Diff:
metron-deployment/packaging/ambari/metron-mpack/src/main/resources/common-services/METRON/CURRENT/configuration/metron-enrichment-env.xml
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/973
@merrimanr this looks great. A couple of things:
1. Can you give some steps on how to test this? I would like to keep the
FB moving
2. have you ever looked at https
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/526
@iraghumitra What is up with this? Can you close it if you are not going
to de-conflict?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/439
@devopsec : Tyler, can you update this or close it?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/531
So, what is the status of this? Can we at *least* sum up?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/670
What is the status of this?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/684
I will repeat that this should be a feature branch. What are we going to
do here? This is just sitting here getting more and more out of date.
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/687
This is pretty old at this point, and there has been a lot of discussion
all over the place about it. I'm not sure I can sum up where we are.
@cestella can you sum up your current feeli
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/713
what is the status of this PR?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/754
What is the status of this? Can someone who can do EC2 deploys test it out?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/775
@DimDroll any update? Or can you close this?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/789
Still needs conflict resolution, still needs relevancy check
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/830
What is the status of this PR?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/865
@mattf-horton any chance to look at this?
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/979
I think to test we need to try with and without the plugin
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/970
As we are already on a feature branch, can we not iterate and refactor
this? Does it all have to go into *this* pr?
If this is landed, what is keeping @nickwallen from throwing a PR
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/684
I would be happy to help, I think I have a decent handle with the stellar
side, and could get up to speed on the ui stuff with your help.
Think about how we can go about it.
I
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/970
@justinleet @nickwallen , sorry I didn't mean to confuse things. It seems
to me that @nickwallen is willing to do some work on this per his 'vision' and
that might be easier if
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/986
+1 ship it
---
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/985
+1 by inspection. Thanks for the contribution!
---
GitHub user ottobackwards opened a pull request:
https://github.com/apache/metron/pull/989
METRON-1516 Support for Ansible 2.5.0
This PR adds support for Ansible 2.5.0.
No other changes beyond allowing the check to pass where required.
Tested centos and ubuntu, macOS
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/985#discussion_r180753753
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/ClasspathFunctionResolver.java
---
@@ -254,18
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/979
@simonellistonball I'm blocked by https://github.com/apache/metron/pull/989
for this hint hint
---
Github user ottobackwards commented on a diff in the pull request:
https://github.com/apache/metron/pull/985#discussion_r180760561
--- Diff:
metron-stellar/stellar-common/src/main/java/org/apache/metron/stellar/dsl/functions/resolver/ClasspathFunctionResolver.java
---
@@ -254,18
Github user ottobackwards commented on the issue:
https://github.com/apache/metron/pull/989
I'm not sure why the build is failing the zookeeper cache tests...
---
201 - 300 of 385 matches
Mail list logo
