[GitHub] metron issue #1009: 1549: Add empty object test to WriterBoltIntegrationTest...
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1009 Looks like a typo on the title of the PR... "METRON-1549" ---
[GitHub] metron pull request #1001: METRON-1532: Getting started documentation improv...
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/1001#discussion_r187058040 --- Diff: metron-deployment/development/centos6/README.md --- @@ -103,3 +103,8 @@ Tags are listed in the playbooks, some frequently used tags: + `hdp-deploy` - Deploy and Start HDP Services (will start all Hadoop Services) + `sensors` - Deploy and start the sensors. + `sensor-stubs` - Deploy and start the sensor stubs. + + +### Making Metron more stable for developers --- End diff -- I would tend to agree with this and have this advice at the https://github.com/sardell/metron/blob/8034d69e9d3cb7f807881011f6ad50f145f89be8/metron-deployment/development/README.md level since the single node stuff people (probably misguidedly) use for purposes other than dev ---
[GitHub] metron issue #998: METRON-1530: Default proxy config settings in metron-cont...
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/998 LGTM @merrimanr are you +1 on this now? ---
[GitHub] metron pull request #1004: METRON-1489: Retrofit UI tests to run reliably du...
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/metron/pull/1004#discussion_r184743288
--- Diff:
metron-interface/metron-alerts/e2e/alert-details/alert-status/alert-details-status.e2e-spec.ts
---
@@ -23,64 +23,67 @@ import {loadTestData, deleteTestData} from
'../../utils/e2e_util';
import { MetronAlertsPage } from '../../alerts-list/alerts-list.po';
import {TreeViewPage} from '../../alerts-list/tree-view/tree-view.po';
-describe('metron-alerts alert status', function() {
+describe('Test spec for metron details page', function() {
let page: MetronAlertDetailsPage;
let listPage: MetronAlertsPage;
let treePage: TreeViewPage;
let loginPage: LoginPage;
- beforeAll(() => {
-loadTestData();
+ beforeAll(async function() : Promise {
loginPage = new LoginPage();
listPage = new MetronAlertsPage();
treePage = new TreeViewPage();
-loginPage.login();
+
+await loadTestData();
+await loginPage.login();
});
- afterAll(() => {
+ afterAll(async function() : Promise {
new MetronAlertsPage().navigateTo();
-loginPage.logout();
-deleteTestData();
+await loginPage.logout();
+await deleteTestData();
});
beforeEach(() => {
page = new MetronAlertDetailsPage();
jasmine.addMatchers(customMatchers);
});
- it('should change alert statuses', () => {
-let alertId = 'c4c5e418-3938-099e-bb0d-37028a98dca8';
-
-page.navigateTo(alertId);
-page.clickNew();
-expect(page.getAlertStatus('ANY')).toEqual('NEW');
-page.clickOpen();
-expect(page.getAlertStatus('NEW')).toEqual('OPEN');
-expect(listPage.getAlertStatusById(alertId)).toEqual('OPEN');
-page.clickDismiss();
-expect(page.getAlertStatus('OPEN')).toEqual('DISMISS');
-expect(listPage.getAlertStatusById(alertId)).toEqual('DISMISS');
-page.clickEscalate();
-expect(page.getAlertStatus('DISMISS')).toEqual('ESCALATE');
-expect(listPage.getAlertStatusById(alertId)).toEqual('ESCALATE');
-page.clickResolve();
-expect(page.getAlertStatus('ESCALATE')).toEqual('RESOLVE');
-expect(listPage.getAlertStatusById(alertId)).toEqual('RESOLVE');
-page.clickNew();
+ xit('should change alert statuses', async function() : Promise {
--- End diff --
Any particular reason to skip this test?
---
[GitHub] metron pull request #1004: METRON-1489: Retrofit UI tests to run reliably du...
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/metron/pull/1004#discussion_r184743321
--- Diff:
metron-interface/metron-alerts/e2e/alert-details/alert-status/alert-details-status.e2e-spec.ts
---
@@ -101,7 +104,7 @@ describe('metron-alerts alert status', function() {
page.closeDetailPane();
});
- it('should add comments for tree view', () => {
+ xit('should add comments for tree view', () => {
--- End diff --
Any particular reason to skip this test?
---
[GitHub] metron pull request #1020: METRON-1567: Large error message can't be written...
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/1020#discussion_r189398418 --- Diff: metron-platform/metron-solr/src/main/config/schema/error/schema.xml --- @@ -40,6 +39,8 @@ guid + + --- End diff -- Out of curiosity, under which circumstances do we get multiple raw messages? ---
[GitHub] metron pull request #1020: METRON-1567: Large error message can't be written...
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/1020#discussion_r189402062 --- Diff: metron-platform/metron-solr/src/main/config/schema/error/schema.xml --- @@ -40,6 +39,8 @@ guid + + --- End diff -- Makes sense, +1 on this then. ---
[GitHub] metron issue #1021: METRON-1568: Stellar should have a _ special variable wh...
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1021 This is a great feature from my perspective. I've seen a number of people try and build solutions that require access to the whole message for a bunch of custom functions, models, rules engine integrations etc, and as a simple means of doing this, I love the approach. To address some of the points here, I agree, we need to avoid any chance of copying the whole map given the performance risk with some potentially sizable and numerous objects. Assignment... yep, _ should not be allowed on the left hand side, and it's a map, so assignment to an output field shouldn't be a big issue. ---
[GitHub] metron pull request #1060: METRON-1615 Default endpoint locations based on A...
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1060 METRON-1615 Default endpoint locations based on Ambari service locations and config ## Contributor Comments For certain values, the mpacks will now default values for the following settings: - location of storm ui - location of elastic search - location of zeppelin notebook server Testing involves spinning up full dev, and ensuring that while the settings es_url, storm_rest_url and zeppelin_url are set blank, the correct values (node1...) are set in the config files on disk. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/metron METRON-1615 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1060.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1060 commit 162debb2fda9133c3bb2b48d23f928bc73fd Author: Simon Elliston Ball Date: 2018-06-12T14:01:09Z Default endpoint locations based on Ambari service locations and config ---
[GitHub] metron issue #1063: METRON-1618: Stellar boolean expressions should treat mi...
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1063 Should the example target state not be: `is_alert := is_alert || geo_outlier` We should probably have a test for that, but I assume the null is falsey would apply on both sides of the boolean and that things like short cutting `is_thing && FUNC(thing)` would be unaffected (i.e if is_thing is null, FUNC would never run). Should we also include updates to the configs in the use cases folder (since these are kinda documentation) with this PR? ---
[GitHub] metron issue #1132: METRON-1695: Expose pcap properties through Ambari
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1132 +1 to that, PCAP should definitely get its own service, but agreed with @anandsubbu that should probably be a follow on item. ---
[GitHub] metron issue #1150: METRON-1707 Port Profiler to Spark [Feature Branch]
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1150 Do we have to use groupByKey in the spark implementation, is it not possible to use reduceByKey to build the profiles, since profilers are by definition reducible. I've seen groupByKey cause performance problems (see https://databricks.gitbooks.io/databricks-spark-knowledge-base/content/best_practices/prefer_reducebykey_over_groupbykey.html for a good discussion on this). ---
[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/ ---
[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/metron/pull/#discussion_r213124377
--- Diff:
metron-interface/metron-alerts-host/src/main/scripts/metron-alerts.sh ---
@@ -0,0 +1,55 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+if [ -z "${METRON_SSL_PASSWORD}" ]; then
+echo "METRON_SSL_PASSWORD unset."
+fi
+
+METRON_VERSION=${project.version}
+METRON_HOME="${METRON_HOME:-/usr/metron/${METRON_VERSION}}"
+METRON_SYSCONFIG="${METRON_SYSCONFIG:-/etc/default/metron}"
+
+echo "METRON_VERSION=${METRON_VERSION}"
+echo "METRON_HOME=${METRON_HOME}"
+echo "METRON_SYSCONFIG=${METRON_SYSCONFIG}"
+
+if [ -f "$METRON_SYSCONFIG" ]; then
+echo "METRON_SYSCONFIG=${METRON_SYSCONFIG}"
+set -a
+. "$METRON_SYSCONFIG"
+fi
+
+echo "METRON_SPRING_PROFILES_ACTIVE=${METRON_SPRING_PROFILES_ACTIVE}"
+
+METRON_CONFIG_LOCATION="
--spring.config.location=classpath:/application.yml,$METRON_HOME/config/alerts_ui.yml"
+echo "METRON_CONFIG_LOCATION=${METRON_CONFIG_LOCATION}"
+METRON_SPRING_OPTIONS+=${METRON_CONFIG_LOCATION}
--- End diff --
Right, my mistake. We should change it and carry through. Would it make
sense to do that as part of the follow on PR for the mpack work, since that
will be where the bulk of the changes for this would be?
---
[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r213124491 --- Diff: metron-interface/metron-ui-host/pom.xml --- @@ -0,0 +1,142 @@ + + +http://maven.apache.org/POM/4.0.0; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; +xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + +metron-ui-host +jar + +Metron Generic UI Host +Spring Server to host config ui + + +org.apache.metron +metron-interface +0.5.1 + + + --- End diff -- Makes sense. I guess I'm half thinking about the idea of 3rd party extensions, but we can at least be consistent within the official bits and let people override if they absolutely for some strange reason have to definitely use something different. ---
[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r213198753 --- Diff: metron-interface/metron-alerts-host/src/main/java/org/apache/metron/ui/AlertsApplication.java --- @@ -0,0 +1,31 @@ +/** --- End diff -- Done ---
[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r213198883 --- Diff: metron-interface/metron-alerts-host/pom.xml --- @@ -0,0 +1,143 @@ + --- End diff -- Done, and agreed, it should be a formal style guide addition, and part of the formatting configs on the contributor wiki really. ---
[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r213198659 --- Diff: metron-interface/metron-ui-host/pom.xml --- @@ -0,0 +1,142 @@ + + +http://maven.apache.org/POM/4.0.0; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; +xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + +metron-ui-host +jar + +Metron Generic UI Host +Spring Server to host config ui + + +org.apache.metron +metron-interface +0.5.1 + + + --- End diff -- Done, I moved the spring versions up to interface. ---
[GitHub] metron pull request #1172: METRON-1724: Date/time validation missing in PCAP...
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/metron/pull/1172#discussion_r211964997
--- Diff:
metron-interface/metron-alerts/src/app/pcap/pcap-filters/pcap-filters.component.ts
---
@@ -15,63 +15,116 @@
* See the License for the specific language governing permissions and
* limitations under the License.
*/
-import {Component, Input, Output, EventEmitter, OnInit, OnChanges,
SimpleChanges} from '@angular/core';
+import {Component, Input, Output, EventEmitter, OnChanges, SimpleChanges}
from '@angular/core';
+import { FormGroup, FormControl, Validators, ValidationErrors } from
'@angular/forms';
+
import * as moment from 'moment/moment';
import { DEFAULT_TIMESTAMP_FORMAT } from '../../utils/constants';
import { PcapRequest } from '../model/pcap.request';
+const DEFAULT_END_TIME = new Date();
--- End diff --
These names do look like they are likely to collide with other potential
areas of functionality though, so if they are genuinely global concerns, then
fine, otherwise they should probably belong to some form of scope related to
the relevant component.
---
[GitHub] metron issue #1111: METRON-1665 Host UIs on Spring Boot and add SSO authenti...
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/ Thanks for the catches Ryan. My objective around metron-rest was to try and leave it as little changed as possible in this effort, since the ticket is more around the ui hosts, but I would agree that this could be cleaned up as you suggest. On the issue of Roles, I don't think we really make the best use of roles at present, and need a follow on to sort all that out. There is also some debate to be had about how roles should be used. A trivial (and in my view naive) view would be to map roles to LDAP groups. This is quite a common approach, but is also a wrong approach, Roles are logical groups of capability, not groups of user principals. I would like to see a follow on where we actually define and properly apply concepts of roles to access controlled objects in Metron, but in the short term we could definitely use the placeholder TODO here to add a naive mapping. ---
[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r212270804 --- Diff: metron-interface/metron-rest-client/bin/pom.xml --- @@ -0,0 +1,52 @@ + --- End diff -- Yes. Will remove. ---
[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/#discussion_r212225176 --- Diff: metron-interface/metron-ui-host/pom.xml --- @@ -0,0 +1,142 @@ + + +http://maven.apache.org/POM/4.0.0; +xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance; +xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd;> +4.0.0 + +metron-ui-host +jar + +Metron Generic UI Host +Spring Server to host config ui + + +org.apache.metron +metron-interface +0.5.1 + + + --- End diff -- Which properties do you mean? I can see a case for the very general ones for sure, but the spring cloud and jwt versions could very much differ from service to service. Should those live in the metron-ui-host and metron-ui-security project respectively you think? ---
[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/metron/pull/#discussion_r212275406
--- Diff:
metron-interface/metron-alerts-host/src/main/scripts/metron-alerts.sh ---
@@ -0,0 +1,55 @@
+#!/usr/bin/env bash
+#
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor license agreements. See the NOTICE file
+# distributed with this work for additional information
+# regarding copyright ownership. The ASF licenses this file
+# to you under the Apache License, Version 2.0 (the
+# "License"); you may not use this file except in compliance
+# with the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+if [ -z "${METRON_SSL_PASSWORD}" ]; then
+echo "METRON_SSL_PASSWORD unset."
+fi
+
+METRON_VERSION=${project.version}
+METRON_HOME="${METRON_HOME:-/usr/metron/${METRON_VERSION}}"
+METRON_SYSCONFIG="${METRON_SYSCONFIG:-/etc/default/metron}"
+
+echo "METRON_VERSION=${METRON_VERSION}"
+echo "METRON_HOME=${METRON_HOME}"
+echo "METRON_SYSCONFIG=${METRON_SYSCONFIG}"
+
+if [ -f "$METRON_SYSCONFIG" ]; then
+echo "METRON_SYSCONFIG=${METRON_SYSCONFIG}"
+set -a
+. "$METRON_SYSCONFIG"
+fi
+
+echo "METRON_SPRING_PROFILES_ACTIVE=${METRON_SPRING_PROFILES_ACTIVE}"
+
+METRON_CONFIG_LOCATION="
--spring.config.location=classpath:/application.yml,$METRON_HOME/config/alerts_ui.yml"
+echo "METRON_CONFIG_LOCATION=${METRON_CONFIG_LOCATION}"
+METRON_SPRING_OPTIONS+=${METRON_CONFIG_LOCATION}
--- End diff --
They're actually in different environments, so didn't feel the need to
change the convention. These scripts take all their environment from Ambari
launchers in a subsequent PR, rather than the /etc/defaults approach, so there
is no actual collision. I can see an argument for changing them all for
clarity, but could also see the argument for consistency in the context of
potentially growing number of services like this.
---
[GitHub] metron pull request #1127: METRON-1666 Mpack updates for LDAP, SSO config an...
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1127 METRON-1666 Mpack updates for LDAP, SSO config and removal of JPA ## Contributor Comments MPack updates to go with METRON-1665. This adds settings for the SSO, LDAP and SSL options to the mpack, and updates the fulldev blueprint to include Knox and the packaged up METRON-1665 hosts. To test this, apply the other PRs related to METRON-1663, and run up fulldev. Each UI should redirect to KnoxSSO allowing you to authenticate against the knox demo ldap (admin:admin-password is a good sample user). ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/metron METRON-1666 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1127.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1127 commit c4590bb13c9c2113391974624e8a3552b1fd3c8b Author: Simon Elliston Ball Date: 2018-07-19T14:22:50Z Added ansible role to create test CA and required certificates and keystores commit e277ee3d577d47979a664cfb637b706e43ddfc8b Author: Simon Elliston Ball Date: 2018-07-19T14:27:57Z Install Knox, start demo LDAP on full-dev and set gateway.jks after install commit b875d25fb40a9d39b24fd18816a8cafe2f1217a9 Author: Simon Elliston Ball Date: 2018-07-19T14:32:49Z Remove nodejs from full-dev commit bf6100c6d88cf5f737b5abb3bad70f8523d85f38 Author: Simon Elliston Ball Date: 2018-07-19T14:38:29Z Remove nodejs from mpack process commit 6af27e036a026f91169ae24e59be84b8350bf66c Author: Simon Elliston Ball Date: 2018-07-19T14:46:45Z Removed settings for JDBC from REST startup commit fa2642b0b1e449683a57f5d2ff6be9cf5bfe7a77 Author: Simon Elliston Ball Date: 2018-07-19T15:01:26Z Added SSL settings for all UIs and interfaces commit 648aca8f4473a35ef61deda1b9980b1d67ce9c29 Author: Simon Elliston Ball Date: 2018-07-19T15:09:57Z Renamed template file commit 7d898684cc2f17e88b9376f4b8c502e31a14
[GitHub] metron pull request #1104: METRON-1670 Stellar WEEK_OF_YEAR test is locale s...
Github user simonellistonball commented on a diff in the pull request:
https://github.com/apache/metron/pull/1104#discussion_r202600375
--- Diff:
metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/DateFunctionsTest.java
---
@@ -182,7 +182,8 @@ public void testDayOfMonthNull() {
@Test
public void testWeekOfYear() {
Object result = run("WEEK_OF_YEAR(epoch)");
-assertEquals(35, result);
+calendar.setTimeInMillis(AUG2016);
--- End diff --
It is perfectly safe: The instance is create in the @Before annotated
method, so in fact, I am already doing exactly what you suggest. See:
https://github.com/simonellistonball/metron/blob/bafd3827d273c5c33b4293fd338595b8de3a75b2/metron-stellar/stellar-common/src/test/java/org/apache/metron/stellar/dsl/functions/DateFunctionsTest.java#L61
So there is no sharing of this object between tests, since a new instance
is acquired before each test method is run.
The second issue you raise should be handled by a separate unit of change
and a separate ticket if it is really necessary (not sure why it would be, but
perhaps you could raise a JIRA and explain).
---
[GitHub] metron issue #1112: METRON-1668 Remove login services and screens from UIs
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1112 And infact through form based auth if sso is off (see the backend issue METRON-1665). This PR just removes the need to process a spring login form in the Angular app to lighten the load a bit and avoid having multiple front-end login implementations to keep in sync (config and alerts have their own at present). This is more about moving the same functionality out of the angular layer and into a different page. ---
[GitHub] metron pull request #1111: METRON-1665 Host UIs on Spring Boot and add SSO a...
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/ METRON-1665 Host UIs on Spring Boot and add SSO authentication This is part of a move towards using KnoxSSO, and LDAP as an authentication method for Metron UIs. The current UIs are served up by very lightweight nodejs applications, which serve the static bundle files produced by the angular build process, and proxies the rest api. This PR replaces this with Spring Boot applications, using the Spring Security stack. It also provides a shared project used as the base for the UI host application, which ensures consistent security across all UIs (metron-interface/metron-ui-security) an abstract web hosting application with zuul embedded for proxying rest to avoid cors problems (metron-interface/metron-ui-host) and two further concrete applications to do the actual hosting, the angular front-ends have been subtley changed to package themselves in jars which are included in the hosting applications, aiding the ease and integrity of the front end code on deployment. Some tests in the rest api have been changed slightly, and a fix has been applied to AlertsUiController to allow users access to delete their own settings. The metron-rest project has also been adapted to work with metron-ui-security, and so inherits the same authentication benefits. A follow on PR will address changes to the mpack to implement necessary config changes. Nodejs has been removed from the RPMs, and the deployment process, since it is no longer needed beyond the build stage. An additional feature is the filter provided to allow JWT cookies to be passed to a backend through zuul as Authorization Bearer headers, allowing simpler stateless interaction with the rest api for example, which opens the possibility of deploying each layer in a load balanced or HA mode using ribbon config. To test at this stage, you will need to manually configure and launch the metron-alerts and metron-config jars, which behave like init.d scripts. This can be done by launching the jars through the bin/ scripts, but would be a lot easier with the follow on work on mpack elements to configure them. For now, integration tests have been included for key function on the security layer and should be reviewed. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It i
[GitHub] metron issue #1112: METRON-1668 Remove login services and screens from UIs
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1112 Patience, patience :) https://issues.apache.org/jira/browse/METRON-1664 will set all this up in ambari to work on full-dev with an embedded ldap (instead of the current embedded h2) and Knox doing the SSO. ---
[GitHub] metron issue #1112: METRON-1668 Remove login services and screens from UIs
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1112 It would also support ldap authentication, via basic auth. ---
[GitHub] metron pull request #1112: METRON-1668 Remove login services and screens fro...
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1112 METRON-1668 Remove login services and screens from UIs ## Contributor Comments Removing the login screens and modules from the UIs since they are superfluous in the the SSO context, and no-longer have an authentication engine to back them. This can be tested by authentication with basic auth against the new hosts in METRON-1665 and then ensuring the UIs still function, and by ensuring the UIs do not redirect to a login. The authentication will be handled by the hosts that allow loading of the UIs redirecting the browser to a KnoxSSO endpoint, handled in METRON-1665. Note, handling jwt cookie expiry is not included here, but will be left as a follow on task with separate ticketing. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/metron METRON-1668 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1112.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1112 commit 45b8059ae32e8892a281a60ed802f9be973992d6 Author: Simon Elliston Ball Date: 2018-07-19T10:26:57Z Removed login screen from alerts UI commit 2c7909a3dd7a1c0eea588c0b58638f46d41a6f76 Author: Simon Elliston Ball Date: 2018-07-19T10:36:18Z Removed login screen from config UI ---
[GitHub] metron pull request #1113: METRON-1667 Remove the JPA and MySQL elements
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1113 METRON-1667 Remove the JPA and MySQL elements ## Contributor Comments Given that the only use of the JPA elements was for persisting a user database, these dependencies are no longer needed, so will be removed to reduce the vulnerability surface. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/metron METRON-1667 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1113.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1113 commit eeb7d586ae44d6a2768d3972cd3ff367cd065e50 Author: Simon Elliston Ball Date: 2018-07-04T11:22:42Z Removed plugins for eclipselink since jpa is no longer included commit 181d38243bfdc4d75b28891a3b06510391c8d4f2 Author: Simon Elliston Ball Date: 2018-07-12T17:15:16Z Removed configs for JPA commit b3f888e4f95b79e034afd0ff7865f748dcc5b6d3 Author: Simon Elliston Ball Date: 2018-07-12T17:20:50Z Remove JPA elements commit 2a1cc4ea73419cdb96dc6ee7bdc35daa9c2e5804 Author: Simon Elliston Ball Date: 2018-07-19T13:46:52Z updated dependencies list to reflect removal of JPA ---
[GitHub] metron issue #1112: METRON-1668 Remove login services and screens from UIs
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1112 In the case of non-SSO ldap auth, there is a login form, it's just embedded in the spring bits instead of the angular bits. It's not as pretty, but we could add a login.jsp to make it exactly the same experience (but with a lower angular maintenance surface). In the SSO scenario, Knox provides a login form, so we don't need or want one in the angular app. In the direct api access scenario, you could provide a bearer token for SSO with a jwt, or for non-SSO you would just provide basic auth creds and that would auth against LDAP. So, you can still provide creds, through either a token, or a browser based form in all scenarios. ---
[GitHub] metron pull request #1113: METRON-1667 Remove the JPA and MySQL elements
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1113 ---
[GitHub] metron pull request #1114: METRON-1667 Remove the JPA and MySQL elements
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1114 METRON-1667 Remove the JPA and MySQL elements ## Contributor Comments Given that the only use of the JPA elements was for persisting a user database, these dependencies are no longer needed, so will be removed to reduce the vulnerability surface. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/metron METRON-1667 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1114.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1114 commit eeb7d586ae44d6a2768d3972cd3ff367cd065e50 Author: Simon Elliston Ball Date: 2018-07-04T11:22:42Z Removed plugins for eclipselink since jpa is no longer included commit 181d38243bfdc4d75b28891a3b06510391c8d4f2 Author: Simon Elliston Ball Date: 2018-07-12T17:15:16Z Removed configs for JPA commit b3f888e4f95b79e034afd0ff7865f748dcc5b6d3 Author: Simon Elliston Ball Date: 2018-07-12T17:20:50Z Remove JPA elements commit 2a1cc4ea73419cdb96dc6ee7bdc35daa9c2e5804 Author: Simon Elliston Ball Date: 2018-07-19T13:46:52Z updated dependencies list to reflect removal of JPA ---
[GitHub] metron issue #1113: METRON-1667 Remove the JPA and MySQL elements
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1113 Apologies, re-submitting against the feature branch. ---
[GitHub] metron issue #1112: METRON-1668 Remove login services and screens from UIs
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1112 @mmiklavc the knoxsso is enabled with a toggle in the mpack, to follow the pattern for NiFi, Ranger and Atlas etc. There is a kind of failover of auth methods: knoxsso, ldap, nothing in our case. Many of the API calls require auth because they use username to load settings in the rest backend. As such Iâm not sure no-auth makes sense, but maybe a default to anon would allow @rmerrimanâs use case of dev runs, Iâd still say that was a case for a mock backend though, in angular rather than rest. ---
[GitHub] metron pull request #1104: METRON-1670 Stellar WEEK_OF_YEAR test is locale s...
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1104 METRON-1670 Stellar WEEK_OF_YEAR test is locale sensitive ## Contributor Comments Tests were previously not local sensitive. Used a locale sensitive Calendar instance to create ground truth on WeekOfYear test To test, run the tests of a US Locale and a GB Locale. Both should now pass, previously GB locale failed. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [x] Have you written or updated unit tests and or integration tests to verify your changes? - [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [ ] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [ ] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/metron METRON-1670 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1104.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1104 commit bafd3827d273c5c33b4293fd338595b8de3a75b2 Author: Simon Elliston Ball Date: 2018-07-13T22:57:59Z Used a locale sensitive Calendar instance to create ground truth on WeekOfYear test ---
[GitHub] metron issue #978: METRON-1507 Added support for vagrant cachier
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/978 The PR includes ubuntu support, the cachier would just cache debs from apt instead of rpms from yum. TBH I've tested centos more than ubuntu. The use is still the same though, should be transparent to the user. ---
[GitHub] metron pull request #978: METRON-1507 Added support for vagrant cachier
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/978 METRON-1507 Added support for vagrant cachier ## Contributor Comments This is a Vagrant config change to enable the use of vagrant-cachier to reduce build times for the full dev platform. Time saving is heavily network dependent, but anecdotally I've found it saves me around 10 mins per provision of vagrant development environment. YMMV. To test: 1. Install vagrant-cachier, and spin up centos and ubuntu vagrant development platforms. 2. Verify that packages are populated into your local (the client running vagrant) ~/.vagrant/cache directories. 3. vagrant destroy your development environments 4. spin up vagrant environments again, packages should be pulled from the cache instead of the network at this point. Note that the vagrant-cachier plugin is not required, nor shipped, bundled or in any way distributed by this change. It does have a compatible license (MIT) but it is outside of the Metron project scope to install this, so there is no need to update license or dependency documentation. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/metron METRON-1507 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/978.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #978 commit 006bb816622bb5422fb1e8b7d6015e0b9d7c2562 Author: Simon Elliston Ball <simon@...> Date: 2018-04-04T13:10:31Z Added support for vagrant cachier ---
[GitHub] metron issue #978: METRON-1507 Added support for vagrant cachier
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/978 The yum stuff only happens in the centos include in ansible, it's not necessary in the ubuntu version, which uses a different ansible include. An extra test for the record... manual run of the ubuntu14 development environment: building ubuntu14 (measuring start to end of ansible logs) without cache: 45m13 with cache populated: 28m57 so won't change the world, but will hopefully save some coffee during dev-test cycles. ---
[GitHub] metron issue #978: METRON-1507 Added support for vagrant cachier
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/978 Ooops... wrong branch. Let me sort out the PR. ---
[GitHub] metron pull request #978: METRON-1507 Added support for vagrant cachier
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/978 ---
[GitHub] metron pull request #979: METRON-1507 Added support for vagrant cachier
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/979 METRON-1507 Added support for vagrant cachier ## Contributor Comments This is a Vagrant config change to enable the use of vagrant-cachier to reduce build times for the full dev platform. Time saving is heavily network dependent, but anecdotally I've found it saves me around 10 mins per provision of vagrant development environment. YMMV. To test: 1. Install vagrant-cachier, and spin up centos and ubuntu vagrant development platforms. 2. Verify that packages are populated into your local (the client running vagrant) ~/.vagrant/cache directories. 3. vagrant destroy your development environments 4. spin up vagrant environments again, packages should be pulled from the cache instead of the network at this point. Note that the vagrant-cachier plugin is not required, nor shipped, bundled or in any way distributed by this change. It does have a compatible license (MIT) but it is outside of the Metron project scope to install this, so there is no need to update license or dependency documentation. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/metron METRON-1507 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/979.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #979 commit 2b6618d27903a6301834989f0b13f03258e88607 Author: Simon Elliston Ball <simon@...> Date: 2018-04-04T16:38:31Z Added support for vagrant cachier ---
[GitHub] metron pull request #979: METRON-1507 Added support for vagrant cachier
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/979 ---
[GitHub] metron pull request #993: METRON-1507 Add configuration in development vagra...
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/993 METRON-1507 Add configuration in development vagrant files to support vagrant cac⦠## Contributor Comments This is a Vagrant config change to enable the use of vagrant-cachier to reduce build times for the full dev platform. Time saving is heavily network dependent, but anecdotally I've found it saves me around 10 mins per provision of vagrant development environment. YMMV. To test: 1. Install vagrant-cachier, and spin up centos and ubuntu vagrant development platforms. 2. Verify that packages are populated into your local (the client running vagrant) ~/.vagrant/cache directories. 3. vagrant destroy your development environments 4. spin up vagrant environments again, packages should be pulled from the cache instead of the network at this point. 5. spin up a vagrant environment on a machine that does not have cachier installed and ensure that the dev platform still builds Note that the vagrant-cachier plugin is not required, nor shipped, bundled or in any way distributed by this change. It does have a compatible license (MIT) but it is outside of the Metron project scope to install this, so there is no need to update license or dependency documentation. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [x] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [x] Have you included steps or a guide to how the change may be verified and tested manually? - [ ] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/metron METRON-1507 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/993.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #993 commit 2c97d3aad9e5312e010139a403c946cbff9bed6f Author: Simon Elliston Ball <simon@...> Date: 2018-04-12T12:53:04Z Add configuration in development vagrant files to support vagrant cachier ([http://fgrehm.viewdocs.io/vagrant-cachier/)] to reduce development machine install times. ---
[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/873 Did it work out for you to find bottlenecks @ottobackwards ? I would be more inclined to do multi-run micro-benchmarking (I have a bunch of multi-sample perfidix runs on all the parser work I've done for example) rather than a one of timer. Would a more 'proper' run it a thousand times in the proper context of the topology code performance profiler be useful / relevant. Did you get the info you need from this as a quicker (and quite possibly good enough!) approach? ---
[GitHub] metron issue #873: METRON-1367 Stellar should have some instrumentation of f...
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/873 Well, if it helped, cool, letâs keep it... was just curious about your use case and whether we should have a bolder scope or if there is anything like this that would help elsewhere in general performance debugging. Iâm certainly not against this in any way. :) > On 4 Apr 2018, at 22:21, ottobackwards <notificati...@github.com> wrote: > > I'm shelving this. Thinks for taking a look. > > â > You are receiving this because you were mentioned. > Reply to this email directly, view it on GitHub, or mute the thread. > ---
[GitHub] metron issue #942: METRON-1461: Modify the MIN, MAX Stellar methods to take ...
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/942 Do we think we've reached consensus on this? It seems like avoiding the mixed scenarios is a good thing from a performance perspective, which is key to something like this which will be used a lot in baselining use cases. Any one else have any open thoughts on this? ---
[GitHub] metron issue #1001: METRON-1532: Getting started documentation improvements
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1001 +1 thees are useful additions for anyone getting started. ---
[GitHub] metron issue #1233: METRON-1816: Date format Stellar function
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1233 Looks like a very useful gap filler to me. +1 (non-binding) by inspection from me for sure. ---
[GitHub] metron issue #1233: METRON-1816: Date format Stellar function
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1233 I would worry about having to parse the strong argument to determine whether to use a constant or custom formatter, but I guess my concern is limited because weâre caching the formatter anyway so maybe Iâm just over thinking it. Just very conscious we should keep performance at front of mind for this. ---
[GitHub] metron issue #1233: METRON-1816: Date format Stellar function
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1233 @ottobackwards wouldn't ISO constant support require us to do a check on the string before passing to the DateFormat instance, which on something that is likely to be run A LOT (i.e. multiple times for every message) could actually be a significant for performance, which I would say outweighs the convenience of not having to remember what the format looks like. ---
[GitHub] metron issue #1233: METRON-1816: Date format Stellar function
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1233 Right, I hear that! I also really like the idea of a follow on function that returns the default formats as a great solution to this problem. Should we do that? ---
[GitHub] metron issue #1060: METRON-1615 Default endpoint locations based on Ambari s...
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1060 The fix is not necessary in pure Apache Ambari, and is only required in a non-Apache toolchain, hence from a pure Apache perspective 'works as designed' (just not very inclusively designed) ---
[GitHub] metron pull request #1193: METRON-1667 Remove the JPA and MySQL elements
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1193 ---
[GitHub] metron pull request #1203: METRON-1755 Create an architecture document for M...
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1203 ---
[GitHub] metron pull request #1060: METRON-1615 Default endpoint locations based on A...
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1060 ---
[GitHub] metron pull request #1203: METRON-1755 Create an architecture document for M...
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1203 METRON-1755 Create an architecture document for METRON-1663 ## Contributor Comments This adds documentation on the authentication methods used in METRON-1663. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/metron METRON-1755 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1203.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1203 commit ee9e6dfe087a1b68e25e2974f21dab3b5c15029d Author: Simon Elliston Ball Date: 2018-09-18T20:47:29Z Added initial draft on authentication architecture ---
[GitHub] metron issue #1186: METRON-1756: REST tests should use Embedded LDAP in metr...
Github user simonellistonball commented on the issue: https://github.com/apache/metron/pull/1186 +1 by inspection, good call to align it with the other tests instead of leaking the in-memory auth mechanism in. ---
[GitHub] metron pull request #1114: METRON-1667 Remove the JPA and MySQL elements
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1114 ---
[GitHub] metron pull request #1114: METRON-1667 Remove the JPA and MySQL elements
Github user simonellistonball closed the pull request at: https://github.com/apache/metron/pull/1114 ---
[GitHub] metron pull request #1193: METRON-1667 Remove the JPA and MySQL elements
GitHub user simonellistonball opened a pull request: https://github.com/apache/metron/pull/1193 METRON-1667 Remove the JPA and MySQL elements ## Contributor Comments Given that the only use of the JPA elements was for persisting a user database, these dependencies are no longer needed, so will be removed to reduce the vulnerability surface. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/metron METRON-1667 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1193.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1193 commit eeb7d586ae44d6a2768d3972cd3ff367cd065e50 Author: Simon Elliston Ball Date: 2018-07-04T11:22:42Z Removed plugins for eclipselink since jpa is no longer included commit 181d38243bfdc4d75b28891a3b06510391c8d4f2 Author: Simon Elliston Ball Date: 2018-07-12T17:15:16Z Removed configs for JPA commit b3f888e4f95b79e034afd0ff7865f748dcc5b6d3 Author: Simon Elliston Ball Date: 2018-07-12T17:20:50Z Remove JPA elements commit 2a1cc4ea73419cdb96dc6ee7bdc35daa9c2e5804 Author: Simon Elliston Ball Date: 2018-07-19T13:46:52Z updated dependencies list to reflect removal of JPA commit 85f7911c05b463a1399d5145ee6f1e86079c Author: Simon Elliston Ball Date: 2018-07-20T10:07:37Z Removed bean setup for jdbc authentication commit 91b09e4ceea196965191eada696f11e6a9792f76 Author: Simon Elliston Ball Date: 2018-07-20T11:08:58Z Added in-memory auth for tests commit e1e4f4f300160c8cd0e8270c60605cfc528e91c7 Author: Simon Elliston Ball Date: 2018-07-19T10:04:44Z Fixed security test for UI settings commit 88f83f48d28383cb33eca4e47abd1b830b9b6f5a Author: Simon Elliston Ball Date: 2018-07-20T12:59:32Z Property placeholder is only needed for SSO and LDAP branch commit 0fc7b864fe6c03b462c9f13c4a35b45b05a4a551 Author: Simon Elliston Ball Date: 2018-07-20T15:44:06Z Enabled PreAuthorie security for Alerts test fix commit 320de00fac5b9f37590b2962610dd615cba2
[GitHub] metron pull request #1114: METRON-1667 Remove the JPA and MySQL elements
GitHub user simonellistonball reopened a pull request: https://github.com/apache/metron/pull/1114 METRON-1667 Remove the JPA and MySQL elements ## Contributor Comments Given that the only use of the JPA elements was for persisting a user database, these dependencies are no longer needed, so will be removed to reduce the vulnerability surface. ## Pull Request Checklist Thank you for submitting a contribution to Apache Metron. Please refer to our [Development Guidelines](https://cwiki.apache.org/confluence/pages/viewpage.action?pageId=61332235) for the complete guide to follow for contributions. Please refer also to our [Build Verification Guidelines](https://cwiki.apache.org/confluence/display/METRON/Verifying+Builds?show-miniview) for complete smoke testing guides. In order to streamline the review of the contribution we ask you follow these guidelines and ask you to double check the following: ### For all changes: - [x] Is there a JIRA ticket associated with this PR? If not one needs to be created at [Metron Jira](https://issues.apache.org/jira/browse/METRON/?selectedTab=com.atlassian.jira.jira-projects-plugin:summary-panel). - [x] Does your PR title start with METRON- where is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character. - [x] Has your PR been rebased against the latest commit within the target branch (typically master)? ### For code changes: - [ ] Have you included steps to reproduce the behavior or problem that is being changed or addressed? - [ ] Have you included steps or a guide to how the change may be verified and tested manually? - [x] Have you ensured that the full suite of tests and checks have been executed in the root metron folder via: ``` mvn -q clean integration-test install && dev-utilities/build-utils/verify_licenses.sh ``` - [ ] Have you written or updated unit tests and or integration tests to verify your changes? - [x] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)? - [x] Have you verified the basic functionality of the build by building and running locally with Vagrant full-dev environment or the equivalent? ### For documentation related changes: - [x] Have you ensured that format looks appropriate for the output in which it is rendered by building and verifying the site-book? If not then run the following commands and the verify changes via `site-book/target/site/index.html`: ``` cd site-book mvn site ``` Note: Please ensure that once the PR is submitted, you check travis-ci for build issues and submit an update to your PR as soon as possible. It is also recommended that [travis-ci](https://travis-ci.org) is set up for your personal repository such that your branches are built there before submitting a pull request. You can merge this pull request into a Git repository by running: $ git pull https://github.com/simonellistonball/metron METRON-1667 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/metron/pull/1114.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #1114 commit eeb7d586ae44d6a2768d3972cd3ff367cd065e50 Author: Simon Elliston Ball Date: 2018-07-04T11:22:42Z Removed plugins for eclipselink since jpa is no longer included commit 181d38243bfdc4d75b28891a3b06510391c8d4f2 Author: Simon Elliston Ball Date: 2018-07-12T17:15:16Z Removed configs for JPA commit b3f888e4f95b79e034afd0ff7865f748dcc5b6d3 Author: Simon Elliston Ball Date: 2018-07-12T17:20:50Z Remove JPA elements commit 2a1cc4ea73419cdb96dc6ee7bdc35daa9c2e5804 Author: Simon Elliston Ball Date: 2018-07-19T13:46:52Z updated dependencies list to reflect removal of JPA commit 85f7911c05b463a1399d5145ee6f1e86079c Author: Simon Elliston Ball Date: 2018-07-20T10:07:37Z Removed bean setup for jdbc authentication commit 91b09e4ceea196965191eada696f11e6a9792f76 Author: Simon Elliston Ball Date: 2018-07-20T11:08:58Z Added in-memory auth for tests commit e1e4f4f300160c8cd0e8270c60605cfc528e91c7 Author: Simon Elliston Ball Date: 2018-07-19T10:04:44Z Fixed security test for UI settings commit 88f83f48d28383cb33eca4e47abd1b830b9b6f5a Author: Simon Elliston Ball Date: 2018-07-20T12:59:32Z Property placeholder is only needed for SSO and LDAP branch commit 0fc7b864fe6c03b462c9f13c4a35b45b05a4a551 Author: Simon Elliston Ball Date: 2018-07-20T15:44:06Z Enabled PreAuthorie security for Alerts test fix commit 54880ba8f2467fefe56b9c377da00
