[GitHub] metron issue #531: METRON-854 create dhcp dump parser

2018-05-09 Thread basvdl
Github user basvdl commented on the issue: https://github.com/apache/metron/pull/531 Closing PR, since we don't want to change the source code of DHCPdump. Bro should be able to deliver the same functionality. ---

[GitHub] metron issue #531: METRON-854 create dhcp dump parser

2018-05-07 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/531 Just to be clear @basvdl, you are the only one who can close this PR. ---

[GitHub] metron issue #531: METRON-854 create dhcp dump parser

2018-05-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/531 So we are going to close this? ---

[GitHub] metron issue #531: METRON-854 create dhcp dump parser

2018-05-01 Thread basvdl
Github user basvdl commented on the issue: https://github.com/apache/metron/pull/531 @nickwallen agreed! ---

[GitHub] metron issue #531: METRON-854 create dhcp dump parser

2018-05-01 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/531 Agreed @basvdl . I think you are right on with the approach of relying on Bro. Let's close this PR as it definitely is no longer needed then. ---

[GitHub] metron issue #531: METRON-854 create dhcp dump parser

2018-05-01 Thread basvdl
Github user basvdl commented on the issue: https://github.com/apache/metron/pull/531 @nickwallen based on the following pull request (https://github.com/bro/bro/pull/121) Bro has extended their DHCP protocol analyzer. Based on their writing it seems that the same information in

[GitHub] metron issue #531: METRON-854 create dhcp dump parser

2018-04-30 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/531 @basvdl Please close this PR unless you believe it is still needed. This PR will be closed per the [Metron Development

[GitHub] metron issue #531: METRON-854 create dhcp dump parser

2018-04-10 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/531 So, what is the status of this? Can we at *least* sum up? ---