[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language

2018-05-09 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/687 I don't quite get what you are saying. I can't wrap my head around it. If you look at the example from the PR description under concept, that doesn't work without the resolver being updated.

[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language

2018-05-09 Thread cestella
Github user cestella commented on the issue: https://github.com/apache/metron/pull/687 Sorry, @ottobackwards this got lost in the shuffle. What I was saying was that I think we should not adjust the VariableResolver infrastructure to update variables as the result of assignments,

[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language

2018-05-07 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/687 Bump @cestella ---

[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language

2018-04-10 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/687 This is pretty old at this point, and there has been a lot of discussion all over the place about it. I'm not sure I can sum up where we are. @cestella can you sum up your current feeling on

[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language

2018-04-04 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/687 @nickwallen @cestella @mattf-horton , Sorry, I thought that question was more to @mattf-horton at the time. @cestella I'm not sure I understand what you are saying. Are you saying

[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language

2018-04-04 Thread nickwallen
Github user nickwallen commented on the issue: https://github.com/apache/metron/pull/687 > @cestella Should we perhaps separate parsing assignments (e.g. move StellarAssignment.from into the language like you've done here) from actually updating the variables. @ottobackwards

[GitHub] metron issue #687: METRON-1090 Add Assignment to Stellar Language

2018-04-03 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/metron/pull/687 Bump ---