[GitHub] metron pull request #1004: METRON-1489: Retrofit UI tests to run reliably du...

2018-05-02 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1004#discussion_r185477658 --- Diff: metron-interface/metron-alerts/e2e/alerts-list/alerts-list.po.ts --- @@ -272,63 +308,149 @@ export class MetronAlertsPage {

[GitHub] metron pull request #1004: METRON-1489: Retrofit UI tests to run reliably du...

2018-05-02 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1004#discussion_r185477602 --- Diff: metron-interface/metron-alerts/e2e/alert-details/alert-status/alert-details-status.e2e-spec.ts --- @@ -101,7 +104,7 @@ describe('metron-alerts

[GitHub] metron pull request #1004: METRON-1489: Retrofit UI tests to run reliably du...

2018-05-02 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1004#discussion_r185477633 --- Diff: metron-interface/metron-alerts/e2e/alerts-list/alert-status/alerts-list-status.e2e-spec.ts --- @@ -44,84 +45,84 @@ describe('metron-alerts alert

[GitHub] metron pull request #1004: METRON-1489: Retrofit UI tests to run reliably du...

2018-05-02 Thread sardell
Github user sardell commented on a diff in the pull request: https://github.com/apache/metron/pull/1004#discussion_r185477581 --- Diff: metron-interface/metron-alerts/e2e/alert-details/alert-status/alert-details-status.e2e-spec.ts --- @@ -23,64 +23,67 @@ import {loadTestData,

[GitHub] metron pull request #1004: METRON-1489: Retrofit UI tests to run reliably du...

2018-04-29 Thread anandsubbu
Github user anandsubbu commented on a diff in the pull request: https://github.com/apache/metron/pull/1004#discussion_r184889297 --- Diff: metron-interface/metron-alerts/protractor.conf.js --- @@ -32,12 +33,13 @@ exports.config = {

[GitHub] metron pull request #1004: METRON-1489: Retrofit UI tests to run reliably du...

2018-04-29 Thread anandsubbu
Github user anandsubbu commented on a diff in the pull request: https://github.com/apache/metron/pull/1004#discussion_r184888777 --- Diff: metron-interface/metron-alerts/e2e/utils/clean_metron_update_table.ts --- @@ -0,0 +1,52 @@ +declare var Promise: any; +var chalk =

[GitHub] metron pull request #1004: METRON-1489: Retrofit UI tests to run reliably du...

2018-04-27 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1004#discussion_r184750333 --- Diff: metron-interface/metron-alerts/e2e/alerts-list/alerts-list.po.ts --- @@ -272,63 +308,149 @@ export class MetronAlertsPage {

[GitHub] metron pull request #1004: METRON-1489: Retrofit UI tests to run reliably du...

2018-04-27 Thread nickwallen
Github user nickwallen commented on a diff in the pull request: https://github.com/apache/metron/pull/1004#discussion_r184750091 --- Diff: metron-interface/metron-alerts/e2e/alerts-list/alert-status/alerts-list-status.e2e-spec.ts --- @@ -44,84 +45,84 @@ describe('metron-alerts

[GitHub] metron pull request #1004: METRON-1489: Retrofit UI tests to run reliably du...

2018-04-27 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/1004#discussion_r184743321 --- Diff: metron-interface/metron-alerts/e2e/alert-details/alert-status/alert-details-status.e2e-spec.ts --- @@ -101,7 +104,7 @@

[GitHub] metron pull request #1004: METRON-1489: Retrofit UI tests to run reliably du...

2018-04-27 Thread simonellistonball
Github user simonellistonball commented on a diff in the pull request: https://github.com/apache/metron/pull/1004#discussion_r184743288 --- Diff: metron-interface/metron-alerts/e2e/alert-details/alert-status/alert-details-status.e2e-spec.ts --- @@ -23,64 +23,67 @@ import

[GitHub] metron pull request #1004: METRON-1489: Retrofit UI tests to run reliably du...

2018-04-27 Thread sardell
GitHub user sardell opened a pull request: https://github.com/apache/metron/pull/1004 METRON-1489: Retrofit UI tests to run reliably during nightly QE runs ## Contributor Comments This Pull Request includes work started by @iraghumitra on his branch `e2e-using-await-1`. In