[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-18 Thread mmiklavc
Github user mmiklavc closed the pull request at: https://github.com/apache/metron/pull/1108 ---

[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-18 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1108#discussion_r203504416 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/finalizer/PcapFinalizer.java --- @@ -0,0 +1,122 @@ +/** + * Licensed

[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-18 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1108#discussion_r203383057 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/finalizer/PcapCliFinalizer.java --- @@ -0,0 +1,37 @@ +/** + * Licensed

[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-18 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1108#discussion_r203383137 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/finalizer/PcapRestFinalizer.java --- @@ -16,27 +16,21 @@ * limitations

[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-18 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1108#discussion_r203381697 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/finalizer/PcapFinalizerStrategies.java --- @@ -0,0 +1,42 @@ +/** + *

[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-18 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1108#discussion_r203382448 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/finalizer/PcapFinalizer.java --- @@ -0,0 +1,122 @@ +/** + * Licensed

[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-17 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1108#discussion_r203123994 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/mr/PcapJob.java --- @@ -230,69 +274,77 @@ protected void reduce(LongWritable

[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-17 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1108#discussion_r203121809 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/utils/HDFSUtils.java --- @@ -29,6 +29,16 @@ public class

[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-17 Thread merrimanr
Github user merrimanr commented on a diff in the pull request: https://github.com/apache/metron/pull/1108#discussion_r203110747 --- Diff: metron-platform/metron-pcap/src/main/java/org/apache/metron/pcap/mr/PcapJob.java --- @@ -230,69 +274,77 @@ protected void reduce(LongWritable

[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-17 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1108#discussion_r203049283 --- Diff: metron-platform/metron-common/src/main/java/org/apache/metron/common/utils/HDFSUtils.java --- @@ -29,6 +29,16 @@ public class

[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-17 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1108#discussion_r203045282 --- Diff: metron-interface/metron-rest-client/src/main/java/org/apache/metron/rest/model/pcap/PcapRequest.java --- @@ -17,52 +17,57 @@ */

[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-17 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1108#discussion_r203045196 --- Diff: metron-platform/metron-job/src/main/java/org/apache/metron/job/Statusable.java --- @@ -18,20 +18,45 @@ package

[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-17 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1108#discussion_r203044932 --- Diff: metron-platform/metron-job/src/test/java/org/apache/metron/job/manager/InMemoryJobManagerTest.java --- @@ -0,0 +1,192 @@ +package

[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-17 Thread mmiklavc
Github user mmiklavc commented on a diff in the pull request: https://github.com/apache/metron/pull/1108#discussion_r203043785 --- Diff: metron-platform/metron-job/src/main/java/org/apache/metron/job/Statusable.java --- @@ -18,20 +18,45 @@ package

[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-17 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1108#discussion_r203035286 --- Diff: metron-platform/metron-job/src/main/java/org/apache/metron/job/Statusable.java --- @@ -18,20 +18,45 @@ package

[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-17 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1108#discussion_r203035500 --- Diff: metron-platform/metron-job/src/test/java/org/apache/metron/job/manager/InMemoryJobManagerTest.java --- @@ -0,0 +1,192 @@ +package

[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-17 Thread cestella
Github user cestella commented on a diff in the pull request: https://github.com/apache/metron/pull/1108#discussion_r203037439 --- Diff: metron-interface/metron-rest-client/src/main/java/org/apache/metron/rest/model/pcap/PcapRequest.java --- @@ -17,52 +17,57 @@ */

[GitHub] metron pull request #1108: METRON-1614: Create job status abstraction

2018-07-16 Thread mmiklavc
GitHub user mmiklavc opened a pull request: https://github.com/apache/metron/pull/1108 METRON-1614: Create job status abstraction ## Contributor Comments https://issues.apache.org/jira/browse/METRON-1614 ### DO NOT MERGE until follow-on PR created/reviewed/+1'ed