[jira] [Commented] (METRON-618) Eliminate Javac Warnings in metron-analytics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733403#comment-15733403
 ] 

ASF GitHub Bot commented on METRON-618:
---

Github user justinleet commented on the issue:

https://github.com/apache/incubator-metron/pull/391
  
Cleaned up most of the warnings that come from the compiler in 
metron-analytics.  What's left is a couple Error Prone issues (primarily 
related to Charset, which has a separate ticket), and multiline annotations is 
tied to Java 6 (and not something we can much do about, nor am I worried about 
given that it still works).

- For the `toArgs()` methods, swapped out the `Utils` class for 
`Arrays.asList()`.  This itself is `@SafeVarargs`, and since we just iterate 
over it, out methods themselves should be fine as `@SafeVarargs`.
- Said `Utils` class is deleted entirely now.
- Variety of `@SuppressWarnings("unchecked")` added.  These are typically 
things derived from JSONObject or similar, because the JSON library we use only 
has raw types.  I tried to keep these at the minimum scope I could.
- Couple of instances of code get generics applied to them appropriately, 
including one that was previously flagged to suppress raw types (once a couple 
other things that were warnings got fixed with types, that could carry through)

Tested this by spinning up quickdev and running up MaaS and the profiler 
and making sure output came through both of them.


> Eliminate Javac Warnings in metron-analytics
> 
>
> Key: METRON-618
> URL: https://issues.apache.org/jira/browse/METRON-618
> Project: Metron
>  Issue Type: Sub-task
>Affects Versions: 0.3.0
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Minor
>
> Kill off the java compiler warnings in maas project, as much as possible.  
> Most of these are related to missing @SuppressWarnings("unchecked") on code 
> that either should have them, or be refactored so it's not necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (METRON-618) Eliminate Javac Warnings in metron-analytics

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15733373#comment-15733373
 ] 

ASF GitHub Bot commented on METRON-618:
---

GitHub user justinleet opened a pull request:

https://github.com/apache/incubator-metron/pull/391

METRON-618 Eliminate Javac Warnings in metron-analytics



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/justinleet/incubator-metron METRON-618

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/incubator-metron/pull/391.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #391


commit c0f6f71924fb9795ebdeb717d431457e5366e204
Author: justinjleet 
Date:   2016-12-08T19:23:35Z

Eliminating warnings from the analytics package




> Eliminate Javac Warnings in metron-analytics
> 
>
> Key: METRON-618
> URL: https://issues.apache.org/jira/browse/METRON-618
> Project: Metron
>  Issue Type: Sub-task
>Affects Versions: 0.3.0
>Reporter: Justin Leet
>Assignee: Justin Leet
>Priority: Minor
>
> Kill off the java compiler warnings in maas project, as much as possible.  
> Most of these are related to missing @SuppressWarnings("unchecked") on code 
> that either should have them, or be refactored so it's not necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (METRON-585) Pcap Replay Fails to Stop

[Nick Allen (JIRA)]

 [ 
https://issues.apache.org/jira/browse/METRON-585?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Nick Allen updated METRON-585:
--
Affects Version/s: 0.3.0
Fix Version/s: Next + 1

> Pcap Replay Fails to Stop
> -
>
> Key: METRON-585
> URL: https://issues.apache.org/jira/browse/METRON-585
> Project: Metron
>  Issue Type: Bug
>Affects Versions: 0.3.0
>Reporter: Nick Allen
>Assignee: Nick Allen
> Fix For: Next + 1
>
>
> The service script for Pcap Replay often fails to actually stop the tcpreplay 
> process.  
> The `tcpreplay` process is a huge consumer of resources when running on Quick 
> Dev and actually having it stop when asked, would be super nice.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (METRON-587) Integration tests should use common processor implementations where possible

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732472#comment-15732472
 ] 

ASF GitHub Bot commented on METRON-587:
---

Github user ottobackwards commented on the issue:

https://github.com/apache/incubator-metron/pull/374
  
I am going to close this until I figure out what in the latest sync is 
throwing of the timing in the tests


> Integration tests should use common processor implementations where possible
> 
>
> Key: METRON-587
> URL: https://issues.apache.org/jira/browse/METRON-587
> Project: Metron
>  Issue Type: Improvement
>Reporter: Otto Fowler
>Assignee: Otto Fowler
>
> We have 7 or so integration tests that implement the Processor interface.  
> Much of the code in these implementations is the same.  It would be better 
> for the system if we had some common implementations of the Processor 
> interface.
> - This would make it easier to write correct tests
> - This would reduce errors from copy/paste test generation
> - This would clean up the codebase and make it easier to understand



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (METRON-587) Integration tests should use common processor implementations where possible

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-587?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732471#comment-15732471
 ] 

ASF GitHub Bot commented on METRON-587:
---

Github user ottobackwards closed the pull request at:

https://github.com/apache/incubator-metron/pull/374


> Integration tests should use common processor implementations where possible
> 
>
> Key: METRON-587
> URL: https://issues.apache.org/jira/browse/METRON-587
> Project: Metron
>  Issue Type: Improvement
>Reporter: Otto Fowler
>Assignee: Otto Fowler
>
> We have 7 or so integration tests that implement the Processor interface.  
> Much of the code in these implementations is the same.  It would be better 
> for the system if we had some common implementations of the Processor 
> interface.
> - This would make it easier to write correct tests
> - This would reduce errors from copy/paste test generation
> - This would clean up the codebase and make it easier to understand



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Commented] (METRON-364) Stellar - Adding Two Integers Does Not Equal an Integer

[ASF GitHub Bot (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-364?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15732318#comment-15732318
 ] 

ASF GitHub Bot commented on METRON-364:
---

Github user asfgit closed the pull request at:

https://github.com/apache/incubator-metron/pull/390


> Stellar - Adding Two Integers Does Not Equal an Integer
> ---
>
> Key: METRON-364
> URL: https://issues.apache.org/jira/browse/METRON-364
> Project: Metron
>  Issue Type: Bug
>Reporter: Nick Allen
>  Labels: stellar
>
> A test showing the problem which would be part of 
> org.apache.metron.common.stellar.StellarTest  
> ```java
>   @Test
>   public void testAddIntegers()  throws Exception {
> String query = "1 + 1";
> Assert.assertEquals(2, run(query, new HashMap<>()));
> //java.lang.AssertionError:
> //Expected :2
> //Actual   :2.0
>   }
> ```



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (METRON-619) Eliminate Javac warnings in metron-parsers

[Justin Leet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/METRON-619?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Leet updated METRON-619:
---
Assignee: (was: Justin Leet)

> Eliminate Javac warnings in metron-parsers
> --
>
> Key: METRON-619
> URL: https://issues.apache.org/jira/browse/METRON-619
> Project: Metron
>  Issue Type: Sub-task
>Affects Versions: 0.3.0
>Reporter: Justin Leet
>Priority: Minor
>
> Metron-parsers has a lot of Javac warnings.  Clean up the code as necessary 
> to get rid of them.  Probably mostly just missing 
> @SuppressWarnings("unchecked") because things like our JSON library use raw 
> types under the hood.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (METRON-621) Eliminate Javac warnings in metron-platform outside of parsers and enrichment

[Justin Leet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/METRON-621?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Leet updated METRON-621:
---
Assignee: (was: Justin Leet)

> Eliminate Javac warnings in metron-platform outside of parsers and enrichment
> -
>
> Key: METRON-621
> URL: https://issues.apache.org/jira/browse/METRON-621
> Project: Metron
>  Issue Type: Sub-task
>Affects Versions: 0.3.0
>Reporter: Justin Leet
>Priority: Minor
>
> metron-platform has a lot of Javac warnings. Clean up the code as necessary 
> to get rid of them. Probably mostly just missing 
> @SuppressWarnings("unchecked") because things like our JSON library use raw 
> types under the hood.
> metron-parsers and metron-enrichment are covered by other tickets based on 
> how many warnings they have.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Updated] (METRON-620) Eliminate Javac warnings in metron-enrichment

[Justin Leet (JIRA)]

 [ 
https://issues.apache.org/jira/browse/METRON-620?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Justin Leet updated METRON-620:
---
Assignee: (was: Justin Leet)

> Eliminate Javac warnings in metron-enrichment
> -
>
> Key: METRON-620
> URL: https://issues.apache.org/jira/browse/METRON-620
> Project: Metron
>  Issue Type: Sub-task
>Affects Versions: 0.3.0
>Reporter: Justin Leet
>Priority: Minor
>
> metron-enrichment has a lot of Javac warnings.  Clean up the code as 
> necessary to get rid of them.  Probably mostly just missing 
> @SuppressWarnings("unchecked") because things like our JSON library use raw 
> types under the hood.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (METRON-621) Eliminate Javac warnings in metron-platform outside of parsers and enrichment

[Justin Leet (JIRA)]

Justin Leet created METRON-621:
--

 Summary: Eliminate Javac warnings in metron-platform outside of 
parsers and enrichment
 Key: METRON-621
 URL: https://issues.apache.org/jira/browse/METRON-621
 Project: Metron
  Issue Type: Sub-task
Affects Versions: 0.3.0
Reporter: Justin Leet
Assignee: Justin Leet
Priority: Minor


metron-platform has a lot of Javac warnings. Clean up the code as necessary to 
get rid of them. Probably mostly just missing @SuppressWarnings("unchecked") 
because things like our JSON library use raw types under the hood.

metron-parsers and metron-enrichment are covered by other tickets based on how 
many warnings they have.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (METRON-620) Eliminate Javac warnings in metron-enrichment

[Justin Leet (JIRA)]

Justin Leet created METRON-620:
--

 Summary: Eliminate Javac warnings in metron-enrichment
 Key: METRON-620
 URL: https://issues.apache.org/jira/browse/METRON-620
 Project: Metron
  Issue Type: Sub-task
Affects Versions: 0.3.0
Reporter: Justin Leet
Assignee: Justin Leet
Priority: Minor


metron-enrichment has a lot of Javac warnings.  Clean up the code as necessary 
to get rid of them.  Probably mostly just missing 
@SuppressWarnings("unchecked") because things like our JSON library use raw 
types under the hood.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (METRON-618) Eliminate Javac Warnings in metron-analytics

[Justin Leet (JIRA)]

Justin Leet created METRON-618:
--

 Summary: Eliminate Javac Warnings in metron-analytics
 Key: METRON-618
 URL: https://issues.apache.org/jira/browse/METRON-618
 Project: Metron
  Issue Type: Sub-task
Affects Versions: 0.3.0
Reporter: Justin Leet
Assignee: Justin Leet
Priority: Minor


Kill off the java compiler warnings in maas project, as much as possible.  Most 
of these are related to missing @SuppressWarnings("unchecked") on code that 
either should have them, or be refactored so it's not necessary.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Created] (METRON-617) Eliminate Javac warnings in the build

[Justin Leet (JIRA)]

Justin Leet created METRON-617:
--

 Summary: Eliminate Javac warnings in the build
 Key: METRON-617
 URL: https://issues.apache.org/jira/browse/METRON-617
 Project: Metron
  Issue Type: Improvement
Affects Versions: 0.3.0
Reporter: Justin Leet
Assignee: Justin Leet
Priority: Minor


We have a lot of Javac warnings (several hundred) in the build right now. The 
primary cause of these is unchecked types (for reasons including 
org.simple.json uses raw types under the hood).  These should be labelled with 
@SuppressWarnings("unchecked") where appropriate.  In addition, things like 
@SafeVarargs should be added where appropriate, etc.

Given the number of changes in this ticket is significantly larger than even 
the Error Prone warnings (and may require tinkering with generics at 
appropriate points), I'm going to split this up by module (Analytics and 
Platform), and then split platform as necessary (parsers and enrichment in 
particular have a lot).  Otherwise, anything resulting is likely to be too 
large and unmanageable to be properly tested and reviewed.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)