[jira] [Comment Edited] (METRON-263) Configuration push should validate JSON prior to pushing to Zookeeper

[Otto Fowler (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15568946#comment-15568946
 ] 

Otto Fowler edited comment on METRON-263 at 10/12/16 2:53 PM:
--

>From what I can see it just subscribes to changes on the nodes, where is the 
>loading and validation?



was (Author: ottobackwards):
[~nickallen] From what I can see it just subscribes to changes on the nodes, 
where is the loading and validation?


> Configuration push should validate JSON prior to pushing to Zookeeper
> -
>
> Key: METRON-263
> URL: https://issues.apache.org/jira/browse/METRON-263
> Project: Metron
>  Issue Type: Improvement
>Reporter: David M. Lyle
>  Labels: platform
> Fix For: 0.2.1BETA
>
>
> Currently there is no validation that the configuration pushed to zookeeper 
> is valid. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

[jira] [Comment Edited] (METRON-263) Configuration push should validate JSON prior to pushing to Zookeeper

[Nick Allen (JIRA)]

[ 
https://issues.apache.org/jira/browse/METRON-263?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=15566687#comment-15566687
 ] 

Nick Allen edited comment on METRON-263 at 10/11/16 9:38 PM:
-

I would think we would want to mimic what the 
`org.apache.metron.common.bolt.ConfiguredBolt` does in terms of loading the 
configuration in the `prepare` method.  

Beyond just valid JSON, it gets mapped (via Jackson) to a configuration POJO; 
for example 
org.apache.metron.common.configuration.enrichment.SensorEnrichmentConfig.   If 
we can map the JSON to the appropriate configuration POJO, then it seems pretty 
valid.

The parsers, enrichment, indexing, and profiler all have their own 
configuration POJOs that could be used for validation.


was (Author: nickwallen):
I would think we would want to mimic what the 
org.apache.metron.common.bolt.ConfiguredBolt does in terms of loading the 
configuration.  Beyond just valid JSON, it gets mapped (via Jackson) to a 
configuration type; example 
org.apache.metron.common.configuration.enrichment.SensorEnrichmentConfig. 

> Configuration push should validate JSON prior to pushing to Zookeeper
> -
>
> Key: METRON-263
> URL: https://issues.apache.org/jira/browse/METRON-263
> Project: Metron
>  Issue Type: Improvement
>Reporter: David M. Lyle
>  Labels: platform
> Fix For: 0.2.1BETA
>
>
> Currently there is no validation that the configuration pushed to zookeeper 
> is valid. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)