samuele-andreoli closed issue #25: Test and fix using DEBUG_NORM in amcl
URL: https://github.com/apache/incubator-milagro-MPC/issues/25
This is an automated message from the Apache Git Service.
To respond to the message,
samuele-andreoli merged pull request #27: Fix bug when using amcl compiled with
DEBUG_NORM
URL: https://github.com/apache/incubator-milagro-MPC/pull/27
This is an automated message from the Apache Git Service.
To respond to
samuele-andreoli opened a new pull request #30: Add amcl wrappers
URL: https://github.com/apache/incubator-milagro-MPC/pull/30
This is an automated message from the Apache Git Service.
To respond to the message, please log
sonarcloud[bot] commented on issue #30: Add amcl wrappers
URL:
https://github.com/apache/incubator-milagro-MPC/pull/30#issuecomment-596475192
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-milagro-MPC=30=false=BUG)
sonarcloud[bot] commented on issue #27: Fix bug when using amcl compiled with
DEBUG_NORM
URL:
https://github.com/apache/incubator-milagro-MPC/pull/27#issuecomment-596472467
Kudos, SonarCloud Quality Gate passed!
samuele-andreoli opened a new pull request #31: Update AMCL and apply trick to
MTA ZKP
URL: https://github.com/apache/incubator-milagro-MPC/pull/31
This is an automated message from the Apache Git Service.
To respond to the
sonarcloud[bot] commented on issue #31: Update AMCL and apply trick to MTA ZKP
URL:
https://github.com/apache/incubator-milagro-MPC/pull/31#issuecomment-597169982
Kudos, SonarCloud Quality Gate passed!
samuele-andreoli closed pull request #30: Add amcl wrappers
URL: https://github.com/apache/incubator-milagro-MPC/pull/30
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
samuele-andreoli opened a new pull request #30: Add amcl wrappers
URL: https://github.com/apache/incubator-milagro-MPC/pull/30
This is an automated message from the Apache Git Service.
To respond to the message, please log
samuele-andreoli opened a new pull request #80: Review suggestions from Mike
URL: https://github.com/apache/incubator-milagro-crypto-c/pull/80
This is an automated message from the Apache Git Service.
To respond to the
samuele-andreoli opened a new pull request #37: Review suggestions from Mike
URL: https://github.com/apache/incubator-milagro-MPC/pull/37
This is an automated message from the Apache Git Service.
To respond to the message,
sonarcloud[bot] commented on issue #37: Review suggestions from Mike
URL:
https://github.com/apache/incubator-milagro-MPC/pull/37#issuecomment-613918020
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-milagro-MPC=37=false=BUG)
giorgiozoppi opened a new issue #81: Support of BGV scheme inside milagro
URL: https://github.com/apache/incubator-milagro-crypto-c/issues/81
Due to the advanced in cloud computing and storage data, a full homomorphic
encryption is desired
In a nutshell, a fully homomorphic encryption
giorgiozoppi commented on issue #21: SHA hash might be not initialized correctly
URL:
https://github.com/apache/incubator-milagro-crypto-c/issues/21#issuecomment-615490813
The security-checks PR closes this.
This is an
giorgiozoppi closed issue #21: SHA hash might be not initialized correctly
URL: https://github.com/apache/incubator-milagro-crypto-c/issues/21
This is an automated message from the Apache Git Service.
To respond to the
giorgiozoppi opened a new pull request #82: Added security checks:
URL: https://github.com/apache/incubator-milagro-crypto-c/pull/82
- Removed sprintf for octect/utils conversion
- Closed file descriptor for tests (first part)
kirk-baird commented on issue #14:
URL:
https://github.com/apache/incubator-milagro-crypto-rust/issues/14#issuecomment-616892254
Note `cargo fmt` will work if we call it from `src/`
This is an automated message from the
kirk-baird opened a new pull request #18:
URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/18
# What has been changed
- Copying has been replaced with the compiler optimised `Clone` trait.
- Unnecessary variables have been removed where possible.
- Constructors
kirk-baird opened a new issue #19:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/19
# What is the issue
Benchmarking currently consists of one file `BenchtestALL.rs`. Thus should
be updated to the `cargo bench` format.
# Steps to resolve
- Move
kealan commented on issue #18:
URL:
https://github.com/apache/incubator-milagro-crypto-rust/pull/18#issuecomment-617045455
Hi Kirk There are some conflicts that need resolving for this PR
This is an automated message from
blenessy opened a new issue #83:
URL: https://github.com/apache/incubator-milagro-crypto-c/issues/83
Hi guys!
Thanks a lot for this wonderful lib!
I managed to generate the necessary
[bindings](https://github.com/blenessy/AMCL.jl) and expose the complete API of
this lib in
sonarcloud[bot] removed a comment on issue #37: Review suggestions from Mike
URL:
https://github.com/apache/incubator-milagro-MPC/pull/37#issuecomment-613918020
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] commented on issue #37: Review suggestions from Mike
URL:
https://github.com/apache/incubator-milagro-MPC/pull/37#issuecomment-614041731
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-milagro-MPC=37=false=BUG)
sonarcloud[bot] removed a comment on issue #37: Review suggestions from Mike
URL:
https://github.com/apache/incubator-milagro-MPC/pull/37#issuecomment-614041731
Kudos, SonarCloud Quality Gate passed!
sonarcloud[bot] commented on issue #37: Review suggestions from Mike
URL:
https://github.com/apache/incubator-milagro-MPC/pull/37#issuecomment-614573113
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-milagro-MPC=37=false=BUG)
samuele-andreoli merged pull request #80: Review suggestions from Mike
URL: https://github.com/apache/incubator-milagro-crypto-c/pull/80
This is an automated message from the Apache Git Service.
To respond to the message,
samuele-andreoli merged pull request #37: Review suggestions from Mike
URL: https://github.com/apache/incubator-milagro-MPC/pull/37
This is an automated message from the Apache Git Service.
To respond to the message, please
samuele-andreoli closed issue #24: Add wrappers for AES and RSA
URL: https://github.com/apache/incubator-milagro-MPC/issues/24
This is an automated message from the Apache Git Service.
To respond to the message, please log
samuele-andreoli merged pull request #30: Add amcl wrappers
URL: https://github.com/apache/incubator-milagro-MPC/pull/30
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
samuele-andreoli closed issue #29: Update AMCL and use new trick
URL: https://github.com/apache/incubator-milagro-MPC/issues/29
This is an automated message from the Apache Git Service.
To respond to the message, please log
samuele-andreoli merged pull request #31: Update AMCL and apply trick to MTA ZKP
URL: https://github.com/apache/incubator-milagro-MPC/pull/31
This is an automated message from the Apache Git Service.
To respond to the
sonarcloud[bot] commented on issue #32: Fix paillier sk dump and build warnings
URL:
https://github.com/apache/incubator-milagro-MPC/pull/32#issuecomment-599575989
Kudos, SonarCloud Quality Gate passed!
samuele-andreoli opened a new pull request #32: Fix paillier sk dump and build
warnings
URL: https://github.com/apache/incubator-milagro-MPC/pull/32
This is an automated message from the Apache Git Service.
To respond to
kirk-baird opened a new issue #14: Cargo fmt and doc tests fail
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/14
# Issues
`cargo fmt` fails due to being unable to find the module `big` in `./`
`rustfmt` will run indefinitely
`cargo test --doc` will
samuele-andreoli merged pull request #79: Issue74 review ct
URL: https://github.com/apache/incubator-milagro-crypto-c/pull/79
This is an automated message from the Apache Git Service.
To respond to the message, please log on
samuele-andreoli closed issue #74: BIG comp (and potentially others) not
constant time
URL: https://github.com/apache/incubator-milagro-crypto-c/issues/74
This is an automated message from the Apache Git Service.
To respond
kirk-baird closed pull request #16: Fix tests
URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/16
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kirk-baird opened a new pull request #16: Fix tests
URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/16
# Issue Resolved
Fixes #15
# Additional Comments
- This PR also improves rust styling by changing comments to `//` as opposed
to `/* ... */`
-
kirk-baird commented on issue #16: Fix tests
URL:
https://github.com/apache/incubator-milagro-crypto-rust/pull/16#issuecomment-606331121
I close this as I thought tests were still fail but realised it was just the
`doc-tests` and there is already an issue, so I'm re-opening it.
kirk-baird opened a new pull request #16: Fix tests
URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/16
# Issue Resolved
Fixes #15
# Additional Comments
- This PR also improves rust styling by changing comments to `//` as opposed
to `/* ... */`
-
kealan closed issue #15: Failing Tests
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/15
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kealan merged pull request #16: Fix tests
URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/16
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kealan opened a new issue #35: update python AES code
URL: https://github.com/apache/incubator-milagro-MPC/issues/35
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kealan opened a new pull request #36: update python code for aes and core utils
URL: https://github.com/apache/incubator-milagro-MPC/pull/36
# Update Python code
1. Add function to generate random string
2. Refactor example_aes
closes #35
sonarcloud[bot] commented on issue #36: update python code for aes and core
utils
URL:
https://github.com/apache/incubator-milagro-MPC/pull/36#issuecomment-606749108
Kudos, SonarCloud Quality Gate passed!
kirk-baird commented on issue #7: HKDF
URL:
https://github.com/apache/incubator-milagro-crypto-rust/issues/7#issuecomment-606923397
HKDF has been implemented
[here](https://github.com/sigp/incubator-milagro-crypto-rust/tree/bls-standard)
and tested here however is no longer required by
kirk-baird closed issue #7: HKDF
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/7
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kealan closed issue #35: update python AES code
URL: https://github.com/apache/incubator-milagro-MPC/issues/35
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
kealan merged pull request #36: update python code for aes and core utils
URL: https://github.com/apache/incubator-milagro-MPC/pull/36
This is an automated message from the Apache Git Service.
To respond to the message,
kirk-baird opened a new issue #15: Failing Tests
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/15
# What is the issue?
Currently the following tests are failing:
```
test bls24::bls192::tests::test_bls ... FAILED
test bls48::bls256::tests::test_bls
kealan opened a new pull request #34: fix typos in include files
URL: https://github.com/apache/incubator-milagro-MPC/pull/34
This is an automated message from the Apache Git Service.
To respond to the message, please log on
kealan merged pull request #34: fix typos in include files
URL: https://github.com/apache/incubator-milagro-MPC/pull/34
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
samuele-andreoli commented on a change in pull request #34: fix typos in
include files
URL:
https://github.com/apache/incubator-milagro-MPC/pull/34#discussion_r398448631
##
File path: scripts/buildAMCL.sh
##
@@ -15,7 +15,7 @@ git clone
kealan commented on a change in pull request #34: fix typos in include files
URL:
https://github.com/apache/incubator-milagro-MPC/pull/34#discussion_r398466937
##
File path: scripts/buildAMCL.sh
##
@@ -15,7 +15,7 @@ git clone
kirk-baird opened a new pull request #13: [WIP] Cleanup tests
URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/13
# What has been Changed
The tests have been converted into rust unit test cases.
The tests can now be run generally for each of the different
kealan merged pull request #13: [WIP] Cleanup tests
URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/13
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
samuele-andreoli opened a new pull request #79: Issue74 review ct
URL: https://github.com/apache/incubator-milagro-crypto-c/pull/79
close #74
This is an automated message from the Apache Git Service.
To respond to the
giorgiozoppi edited a comment on pull request #82:
URL:
https://github.com/apache/incubator-milagro-crypto-c/pull/82#issuecomment-620777821
Looks like we have cover all stop. It is perfectly fine to have a %80 of
coverage for a complex project like this. Could you relax a bit?
giorgiozoppi commented on pull request #82:
URL:
https://github.com/apache/incubator-milagro-crypto-c/pull/82#issuecomment-620777821
Looks like we have cover all stop. It is perfectly fine to have a %80 of
coverage for a complex project like this. Could you relax a bit!
blenessy commented on issue #83:
URL:
https://github.com/apache/incubator-milagro-crypto-c/issues/83#issuecomment-619500510
Going with `MilagroCrypto` then.
This is an automated message from the Apache Git Service.
To
kirk-baird commented on issue #18:
URL:
https://github.com/apache/incubator-milagro-crypto-rust/pull/18#issuecomment-617477819
I've merged `develop` and resolved all of the conflicts so it is ready for
merging.
This is an
kirk-baird opened a new issue #20:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/20
# What is the issue
The BLS standard has updated to
[hash-to-curve-07](https://tools.ietf.org/html/draft-irtf-cfrg-hash-to-curve-07).
These are breaking changes and need
kirk-baird opened a new issue #22:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/22
# Issue
Hash-to-curve functionality has been implemented for BLS381 however it has
not been implemented for any other curves.
# ToDo
Implement `hash-to-curve` for
kirk-baird opened a new pull request #23:
URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/23
# Issue
`ECP::tostring()` was not calling affine before printing the (x, y)
coordinates and so they were out by the `Z` factor.
# Fix
Call `affine()` before
kirk-baird opened a new pull request #21:
URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/21
# Issue Addressed
#20
# What has been changed
`sgn0` is to be used as parity for field elements.
Slight change and DST length to prevent potential length
kirk-baird opened a new issue #24:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/24
# What is the Issue
Many results are converted from raw data (i.e. ints / bytes) many times.
These results could be cached to reduce rework.
These results can be cached
kirk-baird opened a new issue #25:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/25
# What is the issue
The standard states the BLS381 should use `points_to_octets` (i.e. ECPx from
bytes) in accordance with the ZCash
kirk-baird commented on issue #3:
URL:
https://github.com/apache/incubator-milagro-crypto-rust/issues/3#issuecomment-623765043
I've split this into multiple parts and thus closing this in favour of:
#22
#25
#26
#27
kirk-baird opened a new issue #26:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/26
# What is the issue
The
[BLS-Signature-Standard-v02](https://tools.ietf.org/html/draft-irtf-cfrg-bls-signature-02#section-2)
states a range of core operations that need to be
kirk-baird opened a new issue #27:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/27
# What is the issue
There are 3 BLS Schemes in the
[BLS-Signature-Standard-v02](https://tools.ietf.org/html/draft-irtf-cfrg-bls-signature-02#section-3).
* Basic
* Message
kirk-baird opened a new pull request #28:
URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/28
# What has been changed
Clean up some of the mod files that are initialising empty arrays.
Fix mutability from #23
kirk-baird commented on pull request #28:
URL:
https://github.com/apache/incubator-milagro-crypto-rust/pull/28#issuecomment-624514858
@kealan do you think we would be able to merge this one?
This is an automated message
kirk-baird opened a new issue #33:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/33
# What is the issue
Items such as secret keys should be zeroed before the memory is freed.
This can be acomplished through the crate
kirk-baird opened a new issue #34:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/34
# What is the issue
`hash_to_curve()` uses an inefficient cofactor clearing method on G1.
# ToDo
Consider using `pair::g1mul()` for this.
sonarcloud[bot] removed a comment on pull request #38:
URL:
https://github.com/apache/incubator-milagro-MPC/pull/38#issuecomment-629102717
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-milagro-MPC=38=false=BUG)
sonarcloud[bot] commented on pull request #38:
URL:
https://github.com/apache/incubator-milagro-MPC/pull/38#issuecomment-629192629
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-milagro-MPC=38=false=BUG)
kirk-baird opened a new pull request #36:
URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/36
# What has been done
Fuzz targets for BLS12-381 serialisation have been added to ensure there are
no panics in the serialization functions.
Fuzzers can be run as
sonarcloud[bot] commented on pull request #38:
URL:
https://github.com/apache/incubator-milagro-MPC/pull/38#issuecomment-629102717
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-milagro-MPC=38=false=BUG)
samuele-andreoli opened a new pull request #38:
URL: https://github.com/apache/incubator-milagro-MPC/pull/38
Address the findings in the NCC review.
* Add UserID and AdditionalData to Schnorr Proofs, double Schnorr Proofs,
and the NIZKP of factoring to make them non-replayable.
*
kealan closed pull request #33: fix python bug
URL: https://github.com/apache/incubator-milagro-MPC/pull/33
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kealan opened a new pull request #78: fix cmake warning
URL: https://github.com/apache/incubator-milagro-crypto-c/pull/78
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
kealan opened a new pull request #33: fix python bug
URL: https://github.com/apache/incubator-milagro-MPC/pull/33
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kealan merged pull request #78: fix cmake warning
URL: https://github.com/apache/incubator-milagro-crypto-c/pull/78
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
samuele-andreoli merged pull request #32: Fix paillier sk dump and build
warnings
URL: https://github.com/apache/incubator-milagro-MPC/pull/32
This is an automated message from the Apache Git Service.
To respond to the
sonarcloud[bot] commented on issue #33: fix python bug
URL:
https://github.com/apache/incubator-milagro-MPC/pull/33#issuecomment-601821077
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-milagro-MPC=33=false=BUG)
sonarcloud[bot] removed a comment on issue #30: Add amcl wrappers
URL:
https://github.com/apache/incubator-milagro-MPC/pull/30#issuecomment-596475192
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-milagro-MPC=30=false=BUG)
sonarcloud[bot] commented on issue #30: Add amcl wrappers
URL:
https://github.com/apache/incubator-milagro-MPC/pull/30#issuecomment-596717030
Kudos, SonarCloud Quality Gate passed!
[](https://sonarcloud.io/project/issues?id=apache_incubator-milagro-MPC=30=false=BUG)
kirk-baird edited a comment on pull request #28:
URL:
https://github.com/apache/incubator-milagro-crypto-rust/pull/28#issuecomment-624514858
@kealan do you think we would be able to merge this one?
#Edit:
On second thought never mind I'll close in favour of #29
kirk-baird opened a new pull request #29:
URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/29
# Issues Addressed
#26 (For BLS381 only)
#27 (For BLS381 only)
# Additional Comments
Replaces #28
This standard will first be implemented for
kirk-baird opened a new pull request #31:
URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/31
# Issue Addressed
#25
# What has been changes
Implementation of the
kirk-baird opened a new issue #32:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/32
# What is the issue
Currently `ECP::tobytes()` is the only one with point compression
It should be added for `ECP2`, `ECP4`, `ECP8` to half the size of the bytes
kirk-baird opened a new issue #30:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/30
# What is the issue
There are currently no tests for SHA2-384 (`HASH384`).
# What needs to be done
Tests need to be written, unfortunately SHA2-384 does not have
samuele-andreoli merged pull request #38:
URL: https://github.com/apache/incubator-milagro-MPC/pull/38
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kirk-baird opened a new issue #37:
URL: https://github.com/apache/incubator-milagro-crypto-rust/issues/37
# What is the issue
Subgroup checks are currently being performed using GLV method for G1 and GS
method for G2.
This may perform incorrect scalar multiplications for
kirk-baird opened a new pull request #38:
URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/38
# What has been done
* There was a bug in the curve `fp512bn` on 32 bit OS which would stop it
from compiling.
* Update rust edition to 2018
* Clean up module
kealan merged pull request #38:
URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/38
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
kealan merged pull request #36:
URL: https://github.com/apache/incubator-milagro-crypto-rust/pull/36
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
gimer edited a comment on issue #85:
URL:
https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-688924815
a) correct me if I'm wrong, but there are no building instructions for ms vs
b) answering @giorgiozoppi
> VS2019 supports C99 and i suppose C11
gimer opened a new issue #85:
URL: https://github.com/apache/incubator-milagro-crypto-c/issues/85
Hello,
We've prepared bunch of changes that enable milagro compilation in MS Visual
Studio.
The changes can be divided into 3 groups:
1. trivial name<->type clash
2.
giorgiozoppi removed a comment on issue #85:
URL:
https://github.com/apache/incubator-milagro-crypto-c/issues/85#issuecomment-688913239
VS2019 supports C99 and i suppose C11
This is an automated message from the Apache Git
401 - 500 of 647 matches
Mail list logo
