[
https://issues.apache.org/jira/browse/MINIFICPP-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404278#comment-16404278
]
ASF GitHub Bot commented on MINIFICPP-430:
--
Github user asfgit closed the pull
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/282
---
Github user asfgit closed the pull request at:
https://github.com/apache/nifi-minifi-cpp/pull/275
---
[
https://issues.apache.org/jira/browse/MINIFICPP-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404275#comment-16404275
]
ASF GitHub Bot commented on MINIFICPP-414:
--
Github user asfgit closed the pull
[
https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404273#comment-16404273
]
ASF GitHub Bot commented on NIFI-4325:
--
Github user MikeThomsen commented on the issue
Github user MikeThomsen commented on the issue:
https://github.com/apache/nifi/pull/2113
> I hope my review doesn't come off in the wrong way, there is a lot of
great work here and I just want to make sure the usability is top notch.
Not at all. It's all fair and good feedback
[
https://issues.apache.org/jira/browse/MINIFICPP-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404269#comment-16404269
]
ASF GitHub Bot commented on MINIFICPP-434:
--
Github user phrocker commented on
Github user phrocker commented on a diff in the pull request:
https://github.com/apache/nifi-minifi-cpp/pull/284#discussion_r175313368
--- Diff: CMakeLists.txt ---
@@ -186,6 +186,11 @@ if (NOT DISABLE_SCRIPTING)
createExtension(SCRIPTING-EXTENSIONS "SCRIPTING EXTENSIONS" "T
[
https://issues.apache.org/jira/browse/NIFIREG-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404255#comment-16404255
]
ASF GitHub Bot commented on NIFIREG-120:
Github user kevdoran commented on the is
Github user kevdoran commented on the issue:
https://github.com/apache/nifi-registry/pull/89
The branch is working if you donât need to run it securely. I have some
fixes that enable an LDAP secured instance to work. Iâll work with
@Chaffelson to get this PR merged in the next wee
[
https://issues.apache.org/jira/browse/NIFI-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404230#comment-16404230
]
ASF GitHub Bot commented on NIFI-4246:
--
Github user jdye64 commented on a diff in the
Github user jdye64 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2085#discussion_r175308013
--- Diff:
nifi-nar-bundles/nifi-oauth-bundle/nifi-oauth/src/main/java/org/apache/nifi/oauth/AbstractOAuthControllerService.java
---
@@ -0,0 +1,172 @@
+/*
[
https://issues.apache.org/jira/browse/NIFI-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404229#comment-16404229
]
ASF GitHub Bot commented on NIFI-4246:
--
Github user jdye64 commented on a diff in the
Github user jdye64 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2085#discussion_r175308002
--- Diff:
nifi-nar-bundles/nifi-oauth-bundle/nifi-oauth/src/main/java/org/apache/nifi/oauth/AbstractOAuthControllerService.java
---
@@ -0,0 +1,172 @@
+/*
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/2113
Hey @MikeThomsen, just finished up another round of reviewing. Again,
mostly focused on the error handling portion.
I hope my review doesn't come off in the wrong way, there is a lot of gr
[
https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404219#comment-16404219
]
ASF GitHub Bot commented on NIFI-4325:
--
Github user JPercivall commented on the issue:
[
https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404218#comment-16404218
]
ASF GitHub Bot commented on NIFI-4325:
--
Github user JPercivall commented on a diff in
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175306495
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/JsonQueryElas
[
https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404214#comment-16404214
]
ASF GitHub Bot commented on NIFI-4325:
--
Github user JPercivall commented on a diff in
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175306340
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceIm
[
https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404210#comment-16404210
]
ASF GitHub Bot commented on NIFI-4325:
--
Github user JPercivall commented on a diff in
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175306133
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceIm
[
https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404200#comment-16404200
]
ASF GitHub Bot commented on NIFI-4325:
--
Github user JPercivall commented on a diff in
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175305604
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceIm
[
https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404199#comment-16404199
]
ASF GitHub Bot commented on NIFI-4325:
--
Github user JPercivall commented on a diff in
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175305459
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/JsonQueryElas
[
https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404197#comment-16404197
]
ASF GitHub Bot commented on NIFI-4325:
--
Github user JPercivall commented on a diff in
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175305389
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/JsonQueryElas
[
https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404194#comment-16404194
]
ASF GitHub Bot commented on NIFI-4325:
--
Github user JPercivall commented on a diff in
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175304957
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceIm
[
https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404191#comment-16404191
]
ASF GitHub Bot commented on NIFI-4325:
--
Github user JPercivall commented on a diff in
Github user JPercivall commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2113#discussion_r175304809
--- Diff:
nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceIm
[
https://issues.apache.org/jira/browse/MINIFICPP-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404131#comment-16404131
]
ASF GitHub Bot commented on MINIFICPP-434:
--
Github user achristianson commente
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/284
Fixed the Macintosh issue.
---
[
https://issues.apache.org/jira/browse/NIFI-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
James Wing updated NIFI-4981:
-
Resolution: Fixed
Fix Version/s: 1.6.0
Status: Resolved (was: Patch Available)
> Allow t
[
https://issues.apache.org/jira/browse/NIFI-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404117#comment-16404117
]
ASF GitHub Bot commented on NIFI-4981:
--
Github user jvwing commented on the issue:
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2556
LGTM:
* Full build passes
* Good use of SystemResourceConsideration for memory consideration
* Good test coverage
* PutEmail worked correctly in my testing with various content option
co
[
https://issues.apache.org/jira/browse/NIFI-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404107#comment-16404107
]
ASF subversion and git services commented on NIFI-4981:
---
Commit 4687e
Github user asfgit closed the pull request at:
https://github.com/apache/nifi/pull/2556
---
[
https://issues.apache.org/jira/browse/NIFI-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404108#comment-16404108
]
ASF GitHub Bot commented on NIFI-4981:
--
Github user asfgit closed the pull request at:
[
https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404102#comment-16404102
]
ASF GitHub Bot commented on NIFI-4325:
--
Github user JPercivall commented on the issue:
Github user JPercivall commented on the issue:
https://github.com/apache/nifi/pull/2113
Taking a look now. WRT:
> Ok, I can do that from now on. Shouldn't they be squashed before a merge
into master?
Yup, they will be squashed prior to merge to master but the reviewer
[
https://issues.apache.org/jira/browse/MINIFICPP-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404076#comment-16404076
]
ASF GitHub Bot commented on MINIFICPP-434:
--
Github user achristianson commente
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/284
@phrocker No technical need, just following the process (one commit per
pr). It's not really two commits for this one PR, it's just based on that git
history.
Looking into mac
Github user phrocker commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/284
Seems like there is no need for #283. If these both contain 433.
---
[
https://issues.apache.org/jira/browse/MINIFICPP-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404074#comment-16404074
]
ASF GitHub Bot commented on MINIFICPP-434:
--
Github user phrocker commented on
[
https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404069#comment-16404069
]
ASF GitHub Bot commented on NIFI-4989:
--
Github user MikeThomsen commented on a diff in
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2560#discussion_r175296639
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java
---
@@ -196,6 +237,
Github user jvwing commented on the issue:
https://github.com/apache/nifi/pull/2556
Reviewing
---
[
https://issues.apache.org/jira/browse/NIFI-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404057#comment-16404057
]
ASF GitHub Bot commented on NIFI-4981:
--
Github user jvwing commented on the issue:
[
https://issues.apache.org/jira/browse/MINIFICPP-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404056#comment-16404056
]
ASF GitHub Bot commented on MINIFICPP-434:
--
Github user achristianson commente
[
https://issues.apache.org/jira/browse/MINIFICPP-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404055#comment-16404055
]
ASF GitHub Bot commented on MINIFICPP-434:
--
GitHub user achristianson opened a
Github user achristianson commented on the issue:
https://github.com/apache/nifi-minifi-cpp/pull/284
Depends on merge of MINIFICPP-433
---
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/284
MINIFICPP-434 Added ExecuteSQL(ite) implementation, tests, and docs
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of t
Andrew Christianson created MINIFICPP-434:
-
Summary: Create ExecuteSQL (lite) implementation
Key: MINIFICPP-434
URL: https://issues.apache.org/jira/browse/MINIFICPP-434
Project: NiFi MiNiFi C++
[
https://issues.apache.org/jira/browse/NIFIREG-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404050#comment-16404050
]
ASF GitHub Bot commented on NIFIREG-120:
Github user qcho commented on the issue:
Github user qcho commented on the issue:
https://github.com/apache/nifi-registry/pull/89
Love to see this PR. I was about to start a similar project myself!
How is it going? Can I help in anything?
---
[
https://issues.apache.org/jira/browse/MINIFICPP-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404013#comment-16404013
]
ASF GitHub Bot commented on MINIFICPP-433:
--
GitHub user achristianson opened a
GitHub user achristianson opened a pull request:
https://github.com/apache/nifi-minifi-cpp/pull/283
MINIFICPP-433 Added PutSQL(ite) implementation, tests, docs, and license
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review
Andrew Christianson created MINIFICPP-433:
-
Summary: Create PutSQL (lite) implementation
Key: MINIFICPP-433
URL: https://issues.apache.org/jira/browse/MINIFICPP-433
Project: NiFi MiNiFi C++
Github user zenfenan commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2560#discussion_r175289508
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java
---
@@ -196,6 +237,33
[
https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404011#comment-16404011
]
ASF GitHub Bot commented on NIFI-4989:
--
Github user zenfenan commented on a diff in th
[
https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403992#comment-16403992
]
ASF GitHub Bot commented on NIFI-4989:
--
Github user MikeThomsen commented on a diff in
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2560#discussion_r175286408
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java
---
@@ -137,6 +151,
[
https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403989#comment-16403989
]
ASF GitHub Bot commented on NIFI-4989:
--
Github user MikeThomsen commented on a diff in
[
https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403990#comment-16403990
]
ASF GitHub Bot commented on NIFI-4989:
--
Github user MikeThomsen commented on a diff in
[
https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403988#comment-16403988
]
ASF GitHub Bot commented on NIFI-4989:
--
Github user MikeThomsen commented on a diff in
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2560#discussion_r175286257
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/PutMongoIT.java
---
@@ -96,6 +99,
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2560#discussion_r175286235
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java
---
@@ -86,19 +91,2
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2560#discussion_r175286234
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java
---
@@ -169,14 +208
Github user MikeThomsen commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2560#discussion_r175285785
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java
---
@@ -86,19 +91,2
[
https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403977#comment-16403977
]
ASF GitHub Bot commented on NIFI-4989:
--
Github user MikeThomsen commented on a diff in
[
https://issues.apache.org/jira/browse/NIFI-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403967#comment-16403967
]
ASF GitHub Bot commented on NIFI-4981:
--
Github user zenfenan commented on the issue:
Github user zenfenan commented on the issue:
https://github.com/apache/nifi/pull/2556
+1 Looks good to me. Thank you @pvillard31 :)
---
[
https://issues.apache.org/jira/browse/NIFI-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403964#comment-16403964
]
ASF GitHub Bot commented on NIFI-4981:
--
Github user pvillard31 commented on a diff in
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2556#discussion_r175285317
--- Diff:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java
---
@@ -194,6 +20
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2560#discussion_r175284988
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java
---
@@ -86,19 +91,27
[
https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403963#comment-16403963
]
ASF GitHub Bot commented on NIFI-4989:
--
Github user pvillard31 commented on a diff in
Github user pvillard31 commented on a diff in the pull request:
https://github.com/apache/nifi/pull/2560#discussion_r175285159
--- Diff:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java
---
@@ -137,6 +151,3
[
https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403962#comment-16403962
]
ASF GitHub Bot commented on NIFI-4989:
--
Github user pvillard31 commented on a diff in
80 matches
Mail list logo