[jira] [Commented] (MINIFICPP-430) GetFile incorrectly reports 0 file size for non-regular files

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-430?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404278#comment-16404278 ] ASF GitHub Bot commented on MINIFICPP-430: -- Github user asfgit closed the pull

[GitHub] nifi-minifi-cpp pull request #282: MINIFICPP-430 Fixed improper size reporti...

2018-03-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/282 ---

[GitHub] nifi-minifi-cpp pull request #275: MINIFICPP-414 Added boolean Expression La...

2018-03-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi-minifi-cpp/pull/275 ---

[jira] [Commented] (MINIFICPP-414) Implement Expression Language boolean logic operations

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-414?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404275#comment-16404275 ] ASF GitHub Bot commented on MINIFICPP-414: -- Github user asfgit closed the pull

[jira] [Commented] (NIFI-4325) Create a new ElasticSearch processor that supports the JSON DSL

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404273#comment-16404273 ] ASF GitHub Bot commented on NIFI-4325: -- Github user MikeThomsen commented on the issue

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-18 Thread MikeThomsen
Github user MikeThomsen commented on the issue: https://github.com/apache/nifi/pull/2113 > I hope my review doesn't come off in the wrong way, there is a lot of great work here and I just want to make sure the usability is top notch. Not at all. It's all fair and good feedback

[jira] [Commented] (MINIFICPP-434) Create ExecuteSQL (lite) implementation

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404269#comment-16404269 ] ASF GitHub Bot commented on MINIFICPP-434: -- Github user phrocker commented on

[GitHub] nifi-minifi-cpp pull request #284: MINIFICPP-434 Added ExecuteSQL(ite) imple...

2018-03-18 Thread phrocker
Github user phrocker commented on a diff in the pull request: https://github.com/apache/nifi-minifi-cpp/pull/284#discussion_r175313368 --- Diff: CMakeLists.txt --- @@ -186,6 +186,11 @@ if (NOT DISABLE_SCRIPTING) createExtension(SCRIPTING-EXTENSIONS "SCRIPTING EXTENSIONS" "T

[jira] [Commented] (NIFIREG-120) Basic Docker Image

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFIREG-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404255#comment-16404255 ] ASF GitHub Bot commented on NIFIREG-120: Github user kevdoran commented on the is

[GitHub] nifi-registry issue #89: NIFIREG-120 Basic Docker Image Support

2018-03-18 Thread kevdoran
Github user kevdoran commented on the issue: https://github.com/apache/nifi-registry/pull/89 The branch is working if you don’t need to run it securely. I have some fixes that enable an LDAP secured instance to work. I’ll work with @Chaffelson to get this PR merged in the next wee

[jira] [Commented] (NIFI-4246) OAuth 2 Authorization support - Client Credentials Grant

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404230#comment-16404230 ] ASF GitHub Bot commented on NIFI-4246: -- Github user jdye64 commented on a diff in the

[GitHub] nifi pull request #2085: NIFI-4246 - Client Credentials Grant based OAuth2 C...

2018-03-18 Thread jdye64
Github user jdye64 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2085#discussion_r175308013 --- Diff: nifi-nar-bundles/nifi-oauth-bundle/nifi-oauth/src/main/java/org/apache/nifi/oauth/AbstractOAuthControllerService.java --- @@ -0,0 +1,172 @@ +/*

[jira] [Commented] (NIFI-4246) OAuth 2 Authorization support - Client Credentials Grant

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404229#comment-16404229 ] ASF GitHub Bot commented on NIFI-4246: -- Github user jdye64 commented on a diff in the

[GitHub] nifi pull request #2085: NIFI-4246 - Client Credentials Grant based OAuth2 C...

2018-03-18 Thread jdye64
Github user jdye64 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2085#discussion_r175308002 --- Diff: nifi-nar-bundles/nifi-oauth-bundle/nifi-oauth/src/main/java/org/apache/nifi/oauth/AbstractOAuthControllerService.java --- @@ -0,0 +1,172 @@ +/*

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-18 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 Hey @MikeThomsen, just finished up another round of reviewing. Again, mostly focused on the error handling portion. I hope my review doesn't come off in the wrong way, there is a lot of gr

[jira] [Commented] (NIFI-4325) Create a new ElasticSearch processor that supports the JSON DSL

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404219#comment-16404219 ] ASF GitHub Bot commented on NIFI-4325: -- Github user JPercivall commented on the issue:

[jira] [Commented] (NIFI-4325) Create a new ElasticSearch processor that supports the JSON DSL

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404218#comment-16404218 ] ASF GitHub Bot commented on NIFI-4325: -- Github user JPercivall commented on a diff in

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-18 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175306495 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/JsonQueryElas

[jira] [Commented] (NIFI-4325) Create a new ElasticSearch processor that supports the JSON DSL

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404214#comment-16404214 ] ASF GitHub Bot commented on NIFI-4325: -- Github user JPercivall commented on a diff in

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-18 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175306340 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceIm

[jira] [Commented] (NIFI-4325) Create a new ElasticSearch processor that supports the JSON DSL

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404210#comment-16404210 ] ASF GitHub Bot commented on NIFI-4325: -- Github user JPercivall commented on a diff in

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-18 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175306133 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceIm

[jira] [Commented] (NIFI-4325) Create a new ElasticSearch processor that supports the JSON DSL

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404200#comment-16404200 ] ASF GitHub Bot commented on NIFI-4325: -- Github user JPercivall commented on a diff in

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-18 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175305604 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceIm

[jira] [Commented] (NIFI-4325) Create a new ElasticSearch processor that supports the JSON DSL

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404199#comment-16404199 ] ASF GitHub Bot commented on NIFI-4325: -- Github user JPercivall commented on a diff in

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-18 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175305459 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/JsonQueryElas

[jira] [Commented] (NIFI-4325) Create a new ElasticSearch processor that supports the JSON DSL

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404197#comment-16404197 ] ASF GitHub Bot commented on NIFI-4325: -- Github user JPercivall commented on a diff in

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-18 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175305389 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-restapi-processors/src/main/java/org/apache/nifi/processors/elasticsearch/JsonQueryElas

[jira] [Commented] (NIFI-4325) Create a new ElasticSearch processor that supports the JSON DSL

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404194#comment-16404194 ] ASF GitHub Bot commented on NIFI-4325: -- Github user JPercivall commented on a diff in

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-18 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175304957 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceIm

[jira] [Commented] (NIFI-4325) Create a new ElasticSearch processor that supports the JSON DSL

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404191#comment-16404191 ] ASF GitHub Bot commented on NIFI-4325: -- Github user JPercivall commented on a diff in

[GitHub] nifi pull request #2113: NIFI-4325 Added new processor that uses the JSON DS...

2018-03-18 Thread JPercivall
Github user JPercivall commented on a diff in the pull request: https://github.com/apache/nifi/pull/2113#discussion_r175304809 --- Diff: nifi-nar-bundles/nifi-elasticsearch-bundle/nifi-elasticsearch-client-service/src/main/java/org/apache/nifi/elasticsearch/ElasticSearchClientServiceIm

[jira] [Commented] (MINIFICPP-434) Create ExecuteSQL (lite) implementation

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404131#comment-16404131 ] ASF GitHub Bot commented on MINIFICPP-434: -- Github user achristianson commente

[GitHub] nifi-minifi-cpp issue #284: MINIFICPP-434 Added ExecuteSQL(ite) implementati...

2018-03-18 Thread achristianson
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/284 Fixed the Macintosh issue. ---

[jira] [Updated] (NIFI-4981) Allow to use the flowfile content as body in PutEmail

2018-03-18 Thread James Wing (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] James Wing updated NIFI-4981: - Resolution: Fixed Fix Version/s: 1.6.0 Status: Resolved (was: Patch Available) > Allow t

[jira] [Commented] (NIFI-4981) Allow to use the flowfile content as body in PutEmail

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404117#comment-16404117 ] ASF GitHub Bot commented on NIFI-4981: -- Github user jvwing commented on the issue:

[GitHub] nifi issue #2556: NIFI-4981 - Allow using FF's content as message in PutEmai...

2018-03-18 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/2556 LGTM: * Full build passes * Good use of SystemResourceConsideration for memory consideration * Good test coverage * PutEmail worked correctly in my testing with various content option co

[jira] [Commented] (NIFI-4981) Allow to use the flowfile content as body in PutEmail

2018-03-18 Thread ASF subversion and git services (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404107#comment-16404107 ] ASF subversion and git services commented on NIFI-4981: --- Commit 4687e

[GitHub] nifi pull request #2556: NIFI-4981 - Allow using FF's content as message in ...

2018-03-18 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/nifi/pull/2556 ---

[jira] [Commented] (NIFI-4981) Allow to use the flowfile content as body in PutEmail

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404108#comment-16404108 ] ASF GitHub Bot commented on NIFI-4981: -- Github user asfgit closed the pull request at:

[jira] [Commented] (NIFI-4325) Create a new ElasticSearch processor that supports the JSON DSL

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404102#comment-16404102 ] ASF GitHub Bot commented on NIFI-4325: -- Github user JPercivall commented on the issue:

[GitHub] nifi issue #2113: NIFI-4325 Added new processor that uses the JSON DSL.

2018-03-18 Thread JPercivall
Github user JPercivall commented on the issue: https://github.com/apache/nifi/pull/2113 Taking a look now. WRT: > Ok, I can do that from now on. Shouldn't they be squashed before a merge into master? Yup, they will be squashed prior to merge to master but the reviewer

[jira] [Commented] (MINIFICPP-434) Create ExecuteSQL (lite) implementation

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404076#comment-16404076 ] ASF GitHub Bot commented on MINIFICPP-434: -- Github user achristianson commente

[GitHub] nifi-minifi-cpp issue #284: MINIFICPP-434 Added ExecuteSQL(ite) implementati...

2018-03-18 Thread achristianson
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/284 @phrocker No technical need, just following the process (one commit per pr). It's not really two commits for this one PR, it's just based on that git history. Looking into mac

[GitHub] nifi-minifi-cpp issue #284: MINIFICPP-434 Added ExecuteSQL(ite) implementati...

2018-03-18 Thread phrocker
Github user phrocker commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/284 Seems like there is no need for #283. If these both contain 433. ---

[jira] [Commented] (MINIFICPP-434) Create ExecuteSQL (lite) implementation

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404074#comment-16404074 ] ASF GitHub Bot commented on MINIFICPP-434: -- Github user phrocker commented on

[jira] [Commented] (NIFI-4989) PutMongo cannot specify nested fields or multiple lookup keys

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404069#comment-16404069 ] ASF GitHub Bot commented on NIFI-4989: -- Github user MikeThomsen commented on a diff in

[GitHub] nifi pull request #2560: NIFI-4989 Made PutMongo able to use nested lookup k...

2018-03-18 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2560#discussion_r175296639 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java --- @@ -196,6 +237,

[GitHub] nifi issue #2556: NIFI-4981 - Allow using FF's content as message in PutEmai...

2018-03-18 Thread jvwing
Github user jvwing commented on the issue: https://github.com/apache/nifi/pull/2556 Reviewing ---

[jira] [Commented] (NIFI-4981) Allow to use the flowfile content as body in PutEmail

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404057#comment-16404057 ] ASF GitHub Bot commented on NIFI-4981: -- Github user jvwing commented on the issue:

[jira] [Commented] (MINIFICPP-434) Create ExecuteSQL (lite) implementation

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404056#comment-16404056 ] ASF GitHub Bot commented on MINIFICPP-434: -- Github user achristianson commente

[jira] [Commented] (MINIFICPP-434) Create ExecuteSQL (lite) implementation

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-434?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404055#comment-16404055 ] ASF GitHub Bot commented on MINIFICPP-434: -- GitHub user achristianson opened a

[GitHub] nifi-minifi-cpp issue #284: MINIFICPP-434 Added ExecuteSQL(ite) implementati...

2018-03-18 Thread achristianson
Github user achristianson commented on the issue: https://github.com/apache/nifi-minifi-cpp/pull/284 Depends on merge of MINIFICPP-433 ---

[GitHub] nifi-minifi-cpp pull request #284: MINIFICPP-434 Added ExecuteSQL(ite) imple...

2018-03-18 Thread achristianson
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/284 MINIFICPP-434 Added ExecuteSQL(ite) implementation, tests, and docs Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review of t

[jira] [Created] (MINIFICPP-434) Create ExecuteSQL (lite) implementation

2018-03-18 Thread Andrew Christianson (JIRA)
Andrew Christianson created MINIFICPP-434: - Summary: Create ExecuteSQL (lite) implementation Key: MINIFICPP-434 URL: https://issues.apache.org/jira/browse/MINIFICPP-434 Project: NiFi MiNiFi C++

[jira] [Commented] (NIFIREG-120) Basic Docker Image

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFIREG-120?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404050#comment-16404050 ] ASF GitHub Bot commented on NIFIREG-120: Github user qcho commented on the issue:

[GitHub] nifi-registry issue #89: NIFIREG-120 Basic Docker Image Support

2018-03-18 Thread qcho
Github user qcho commented on the issue: https://github.com/apache/nifi-registry/pull/89 Love to see this PR. I was about to start a similar project myself! How is it going? Can I help in anything? ---

[jira] [Commented] (MINIFICPP-433) Create PutSQL (lite) implementation

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/MINIFICPP-433?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404013#comment-16404013 ] ASF GitHub Bot commented on MINIFICPP-433: -- GitHub user achristianson opened a

[GitHub] nifi-minifi-cpp pull request #283: MINIFICPP-433 Added PutSQL(ite) implement...

2018-03-18 Thread achristianson
GitHub user achristianson opened a pull request: https://github.com/apache/nifi-minifi-cpp/pull/283 MINIFICPP-433 Added PutSQL(ite) implementation, tests, docs, and license Thank you for submitting a contribution to Apache NiFi - MiNiFi C++. In order to streamline the review

[jira] [Created] (MINIFICPP-433) Create PutSQL (lite) implementation

2018-03-18 Thread Andrew Christianson (JIRA)
Andrew Christianson created MINIFICPP-433: - Summary: Create PutSQL (lite) implementation Key: MINIFICPP-433 URL: https://issues.apache.org/jira/browse/MINIFICPP-433 Project: NiFi MiNiFi C++

[GitHub] nifi pull request #2560: NIFI-4989 Made PutMongo able to use nested lookup k...

2018-03-18 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2560#discussion_r175289508 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java --- @@ -196,6 +237,33

[jira] [Commented] (NIFI-4989) PutMongo cannot specify nested fields or multiple lookup keys

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16404011#comment-16404011 ] ASF GitHub Bot commented on NIFI-4989: -- Github user zenfenan commented on a diff in th

[jira] [Commented] (NIFI-4989) PutMongo cannot specify nested fields or multiple lookup keys

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403992#comment-16403992 ] ASF GitHub Bot commented on NIFI-4989: -- Github user MikeThomsen commented on a diff in

[GitHub] nifi pull request #2560: NIFI-4989 Made PutMongo able to use nested lookup k...

2018-03-18 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2560#discussion_r175286408 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java --- @@ -137,6 +151,

[jira] [Commented] (NIFI-4989) PutMongo cannot specify nested fields or multiple lookup keys

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403989#comment-16403989 ] ASF GitHub Bot commented on NIFI-4989: -- Github user MikeThomsen commented on a diff in

[jira] [Commented] (NIFI-4989) PutMongo cannot specify nested fields or multiple lookup keys

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403990#comment-16403990 ] ASF GitHub Bot commented on NIFI-4989: -- Github user MikeThomsen commented on a diff in

[jira] [Commented] (NIFI-4989) PutMongo cannot specify nested fields or multiple lookup keys

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403988#comment-16403988 ] ASF GitHub Bot commented on NIFI-4989: -- Github user MikeThomsen commented on a diff in

[GitHub] nifi pull request #2560: NIFI-4989 Made PutMongo able to use nested lookup k...

2018-03-18 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2560#discussion_r175286257 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/PutMongoIT.java --- @@ -96,6 +99,

[GitHub] nifi pull request #2560: NIFI-4989 Made PutMongo able to use nested lookup k...

2018-03-18 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2560#discussion_r175286235 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java --- @@ -86,19 +91,2

[GitHub] nifi pull request #2560: NIFI-4989 Made PutMongo able to use nested lookup k...

2018-03-18 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2560#discussion_r175286234 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java --- @@ -169,14 +208

[GitHub] nifi pull request #2560: NIFI-4989 Made PutMongo able to use nested lookup k...

2018-03-18 Thread MikeThomsen
Github user MikeThomsen commented on a diff in the pull request: https://github.com/apache/nifi/pull/2560#discussion_r175285785 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java --- @@ -86,19 +91,2

[jira] [Commented] (NIFI-4989) PutMongo cannot specify nested fields or multiple lookup keys

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403977#comment-16403977 ] ASF GitHub Bot commented on NIFI-4989: -- Github user MikeThomsen commented on a diff in

[jira] [Commented] (NIFI-4981) Allow to use the flowfile content as body in PutEmail

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403967#comment-16403967 ] ASF GitHub Bot commented on NIFI-4981: -- Github user zenfenan commented on the issue:

[GitHub] nifi issue #2556: NIFI-4981 - Allow using FF's content as message in PutEmai...

2018-03-18 Thread zenfenan
Github user zenfenan commented on the issue: https://github.com/apache/nifi/pull/2556 +1 Looks good to me. Thank you @pvillard31 :) ---

[jira] [Commented] (NIFI-4981) Allow to use the flowfile content as body in PutEmail

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4981?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403964#comment-16403964 ] ASF GitHub Bot commented on NIFI-4981: -- Github user pvillard31 commented on a diff in

[GitHub] nifi pull request #2556: NIFI-4981 - Allow using FF's content as message in ...

2018-03-18 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2556#discussion_r175285317 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java --- @@ -194,6 +20

[GitHub] nifi pull request #2560: NIFI-4989 Made PutMongo able to use nested lookup k...

2018-03-18 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2560#discussion_r175284988 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java --- @@ -86,19 +91,27

[jira] [Commented] (NIFI-4989) PutMongo cannot specify nested fields or multiple lookup keys

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403963#comment-16403963 ] ASF GitHub Bot commented on NIFI-4989: -- Github user pvillard31 commented on a diff in

[GitHub] nifi pull request #2560: NIFI-4989 Made PutMongo able to use nested lookup k...

2018-03-18 Thread pvillard31
Github user pvillard31 commented on a diff in the pull request: https://github.com/apache/nifi/pull/2560#discussion_r175285159 --- Diff: nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/PutMongo.java --- @@ -137,6 +151,3

[jira] [Commented] (NIFI-4989) PutMongo cannot specify nested fields or multiple lookup keys

2018-03-18 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4989?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16403962#comment-16403962 ] ASF GitHub Bot commented on NIFI-4989: -- Github user pvillard31 commented on a diff in