[jira] [Commented] (NIFI-5166) Create deep learning classification and regression processor

2018-06-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5166?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515330#comment-16515330 ] ASF GitHub Bot commented on NIFI-5166: -- Github user mans2singh commented on the issue:

[GitHub] nifi issue #2686: NIFI-5166 - Deep learning classification and regression pr...

2018-06-17 Thread mans2singh
Github user mans2singh commented on the issue: https://github.com/apache/nifi/pull/2686 @ijokarumawak - I've created two flow templates for testing the DL4J processor. The first with a file input and file output. The second flow reads a row from rdbms based on id

[jira] [Commented] (NIFI-4982) Add a DistributedMapCacheLookupService

2018-06-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515291#comment-16515291 ] ASF GitHub Bot commented on NIFI-4982: -- Github user ijokarumawak commented on the issue:

[GitHub] nifi issue #2558: NIFI-4982 - Add a DistributedMapCacheLookupService

2018-06-17 Thread ijokarumawak
Github user ijokarumawak commented on the issue: https://github.com/apache/nifi/pull/2558 No further comments from me, I'm +1. @zenfenan please merge. Thanks! ---

[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header

2018-06-17 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2800 +1 LGTM, mvn install and contrib-check pass, use of MineType utility per best practices. ---

[jira] [Commented] (NIFI-5317) Support non-ASCII X-Mailer header

2018-06-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515215#comment-16515215 ] ASF GitHub Bot commented on NIFI-5317: -- Github user ottobackwards commented on the issue:

[jira] [Commented] (NIFI-5317) Support non-ASCII X-Mailer header

2018-06-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515165#comment-16515165 ] ASF GitHub Bot commented on NIFI-5317: -- Github user ottobackwards commented on the issue:

[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header

2018-06-17 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2800 Yikes, sorry. ---

[jira] [Commented] (NIFI-5317) Support non-ASCII X-Mailer header

2018-06-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515154#comment-16515154 ] ASF GitHub Bot commented on NIFI-5317: -- Github user dtrodrigues commented on the issue:

[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header

2018-06-17 Thread dtrodrigues
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi/pull/2800 I updated the test X-Mailer header to be more explicit that it's non-ASCII ---

[jira] [Commented] (NIFI-5317) Support non-ASCII X-Mailer header

2018-06-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515139#comment-16515139 ] ASF GitHub Bot commented on NIFI-5317: -- Github user dtrodrigues commented on a diff in the pull

[GitHub] nifi pull request #2800: NIFI-5317 - support non-ASCII X-Mailer header

2018-06-17 Thread dtrodrigues
Github user dtrodrigues commented on a diff in the pull request: https://github.com/apache/nifi/pull/2800#discussion_r195935356 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java --- @@

[jira] [Commented] (NIFI-5317) Support non-ASCII X-Mailer header

2018-06-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515129#comment-16515129 ] ASF GitHub Bot commented on NIFI-5317: -- Github user ottobackwards commented on a diff in the pull

[GitHub] nifi pull request #2800: NIFI-5317 - support non-ASCII X-Mailer header

2018-06-17 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2800#discussion_r195934550 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/test/java/org/apache/nifi/processors/standard/TestPutEmail.java --- @@

[jira] [Commented] (NIFI-5317) Support non-ASCII X-Mailer header

2018-06-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515128#comment-16515128 ] ASF GitHub Bot commented on NIFI-5317: -- Github user ottobackwards commented on a diff in the pull

[GitHub] nifi pull request #2800: NIFI-5317 - support non-ASCII X-Mailer header

2018-06-17 Thread ottobackwards
Github user ottobackwards commented on a diff in the pull request: https://github.com/apache/nifi/pull/2800#discussion_r195934504 --- Diff: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/PutEmail.java --- @@ -320,6

[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header

2018-06-17 Thread dtrodrigues
Github user dtrodrigues commented on the issue: https://github.com/apache/nifi/pull/2800 Header setting is now refactored into a function and there are tests for non-ascii headers ---

[jira] [Commented] (NIFI-5317) Support non-ASCII X-Mailer header

2018-06-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515118#comment-16515118 ] ASF GitHub Bot commented on NIFI-5317: -- Github user dtrodrigues commented on the issue:

[jira] [Commented] (NIFI-4982) Add a DistributedMapCacheLookupService

2018-06-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-4982?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515114#comment-16515114 ] ASF GitHub Bot commented on NIFI-4982: -- Github user zenfenan commented on a diff in the pull request:

[GitHub] nifi pull request #2558: NIFI-4982 - Add a DistributedMapCacheLookupService

2018-06-17 Thread zenfenan
Github user zenfenan commented on a diff in the pull request: https://github.com/apache/nifi/pull/2558#discussion_r195933469 --- Diff:

[jira] [Commented] (NIFI-5317) Support non-ASCII X-Mailer header

2018-06-17 Thread ASF GitHub Bot (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5317?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16515097#comment-16515097 ] ASF GitHub Bot commented on NIFI-5317: -- Github user ottobackwards commented on the issue:

[GitHub] nifi issue #2800: NIFI-5317 - support non-ASCII X-Mailer header

2018-06-17 Thread ottobackwards
Github user ottobackwards commented on the issue: https://github.com/apache/nifi/pull/2800 This looks good, just two comments. 1. If we are going to add support for non-ascii, the test should test non-ascii, can we add that? 2. We now have a pattern of use in two places

[jira] [Assigned] (NIFI-5282) GCPProcessor with HTTP Proxy with Authentication

2018-06-17 Thread Sivaprasanna Sethuraman (JIRA)
[ https://issues.apache.org/jira/browse/NIFI-5282?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Sivaprasanna Sethuraman reassigned NIFI-5282: - Assignee: Sivaprasanna Sethuraman > GCPProcessor with HTTP Proxy with