[
https://issues.apache.org/jira/browse/NIFI-6385?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Koji Kawamura reassigned NIFI-6385:
---
Assignee: Koji Kawamura
> Wait processor ignores all FlowFiles except for the first one in
alopresto commented on issue #3537: NIFI-5973 Adds ShellUserGroupProvider.
URL: https://github.com/apache/nifi/pull/3537#issuecomment-503393281
Generic comment before I forget, I think there are more locations in the
code when the shell runner runs a command without a description of what's
alopresto edited a comment on issue #3537: NIFI-5973 Adds
ShellUserGroupProvider.
URL: https://github.com/apache/nifi/pull/3537#issuecomment-503392271
I'm hoping I just missed a configuration value (either failed to populate or
copied a stale value from an old config).
*
alopresto commented on issue #3537: NIFI-5973 Adds ShellUserGroupProvider.
URL: https://github.com/apache/nifi/pull/3537#issuecomment-503392271
I'm hoping I just missed a configuration value (either failed to populate or
copied a stale value from an old config).
*
natural commented on issue #3537: NIFI-5973 Adds ShellUserGroupProvider.
URL: https://github.com/apache/nifi/pull/3537#issuecomment-503390545
@alopresto
Thanks again for testing again.
Can you review/post you ldap mapping, e.g.,
`nifi.security.identity.mapping.` and friends?
natural commented on a change in pull request #3537: NIFI-5973 Adds
ShellUserGroupProvider.
URL: https://github.com/apache/nifi/pull/3537#discussion_r295106474
##
File path:
natural commented on a change in pull request #3537: NIFI-5973 Adds
ShellUserGroupProvider.
URL: https://github.com/apache/nifi/pull/3537#discussion_r295106443
##
File path:
natural commented on a change in pull request #3537: NIFI-5973 Adds
ShellUserGroupProvider.
URL: https://github.com/apache/nifi/pull/3537#discussion_r295106325
##
File path:
natural commented on a change in pull request #3537: NIFI-5973 Adds
ShellUserGroupProvider.
URL: https://github.com/apache/nifi/pull/3537#discussion_r295106308
##
File path:
alopresto commented on a change in pull request #3537: NIFI-5973 Adds
ShellUserGroupProvider.
URL: https://github.com/apache/nifi/pull/3537#discussion_r295096657
##
File path:
alopresto commented on a change in pull request #3537: NIFI-5973 Adds
ShellUserGroupProvider.
URL: https://github.com/apache/nifi/pull/3537#discussion_r295096481
##
File path:
alopresto commented on a change in pull request #3537: NIFI-5973 Adds
ShellUserGroupProvider.
URL: https://github.com/apache/nifi/pull/3537#discussion_r295096259
##
File path:
alopresto commented on issue #3537: NIFI-5973 Adds ShellUserGroupProvider.
URL: https://github.com/apache/nifi/pull/3537#issuecomment-503377730
Hi Troy. Reviewing this leads me to the same scenario I encountered on PR
#3495 -- the authentication with LDAP works successfully, but the user
alopresto commented on issue #3537: NIFI-5973 Adds ShellUserGroupProvider.
URL: https://github.com/apache/nifi/pull/3537#issuecomment-503365789
Reviewing...
This is an automated message from the Apache Git Service.
To respond
natural closed pull request #3495: NIFI-5973 Adds ShellUserGroupProvider
URL: https://github.com/apache/nifi/pull/3495
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
natural opened a new pull request #3537: NIFI-5973 Adds ShellUserGroupProvider.
URL: https://github.com/apache/nifi/pull/3537
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
Supersedes
natural commented on issue #3495: NIFI-5973 Adds ShellUserGroupProvider
URL: https://github.com/apache/nifi/pull/3495#issuecomment-503362766
Closing in favor of #3537.
This is an automated message from the Apache Git Service.
arpadboda commented on a change in pull request #585: MINIFICPP-910 - Extend
StringUtils with string join capability
URL: https://github.com/apache/nifi-minifi-cpp/pull/585#discussion_r295064908
##
File path: libminifi/include/utils/StringUtils.h
##
@@ -92,172 +103,104 @@
Mark Payne created NIFI-6385:
Summary: Wait processor ignores all FlowFiles except for the first
one in the queue.
Key: NIFI-6385
URL: https://issues.apache.org/jira/browse/NIFI-6385
Project: Apache NiFi
jtstorck edited a comment on issue #3520: NIFI-5373 Created new module
nifi-metrics
URL: https://github.com/apache/nifi/pull/3520#issuecomment-503299922
As I understand it, all binary artifacts (NARs) from the NiFi build that
include `Dropwizard Metrics` need to include `Dropwizard
jtstorck commented on issue #3520: NIFI-5373 Created new module nifi-metrics
URL: https://github.com/apache/nifi/pull/3520#issuecomment-503299922
As I understand it, all binary artifacts from the NiFi build that include
`Dropwizard Metrics` need to include `Dropwizard Metrics`' NOTICE in
markap14 commented on issue #3536: NIFI-6380: Introduced the notion of
Parameters and Parameter Contexts…
URL: https://github.com/apache/nifi/pull/3536#issuecomment-503287246
OK I rebased against master and pushed 2 new commits. The first addresses
all of your feedback thus far, I
[
https://issues.apache.org/jira/browse/NIFI-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mark Payne updated NIFI-6382:
-
Description: Need to ensure that flows saved to the Flow Registry have all
Parameters also passed in,
[
https://issues.apache.org/jira/browse/NIFI-6382?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866863#comment-16866863
]
Mark Payne commented on NIFI-6382:
--
One thing of note that is important to check is the Parameter Context
gideonkorir commented on a change in pull request #3343: Nifi 5572
URL: https://github.com/apache/nifi/pull/3343#discussion_r294937124
##
File path:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/util/DataTypeUtils.java
##
@@ -1378,6 +1393,61
gideonkorir commented on a change in pull request #3343: Nifi 5572
URL: https://github.com/apache/nifi/pull/3343#discussion_r294935890
##
File path:
nifi-commons/nifi-record/src/main/java/org/apache/nifi/serialization/record/RecordFieldType.java
##
@@ -265,6 +270,19 @@
Mark Payne created NIFI-6384:
Summary: Provide auditing of changes to Parameters
Key: NIFI-6384
URL: https://issues.apache.org/jira/browse/NIFI-6384
Project: Apache NiFi
Issue Type: Sub-task
phrocker commented on a change in pull request #595: Add windows tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/595#discussion_r294933253
##
File path: appveyor.yml
##
@@ -1,11 +1,9 @@
-image: Visual Studio 2015
+image: Visual Studio 2017
environment:
phrocker commented on a change in pull request #595: Add windows tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/595#discussion_r294932845
##
File path: cmake/LibreSSL.cmake
##
@@ -29,7 +29,9 @@ function(use_libre_ssl SOURCE_DIR BINARY_DIR)
endif(WIN32)
phrocker commented on a change in pull request #595: Add windows tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/595#discussion_r294932845
##
File path: cmake/LibreSSL.cmake
##
@@ -29,7 +29,9 @@ function(use_libre_ssl SOURCE_DIR BINARY_DIR)
endif(WIN32)
phrocker commented on a change in pull request #595: Add windows tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/595#discussion_r294932484
##
File path: CMakeLists.txt
##
@@ -414,21 +398,6 @@
include_directories(thirdparty/yaml-cpp-yaml-cpp-20171024/include)
phrocker commented on a change in pull request #595: Add windows tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/595#discussion_r294932303
##
File path: CMakeLists.txt
##
@@ -437,21 +406,16 @@ if(BOOTSTRAP)
return()
endif()
-message(" BOOTSTRAP
phrocker closed pull request #571: MINIFICPP-883: Add windows build script
URL: https://github.com/apache/nifi-minifi-cpp/pull/571
This is an automated message from the Apache Git Service.
To respond to the message, please
phrocker commented on issue #571: MINIFICPP-883: Add windows build script
URL: https://github.com/apache/nifi-minifi-cpp/pull/571#issuecomment-503226367
Closing and combining this with #595
This is an automated message from
phrocker commented on a change in pull request #595: Add windows tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/595#discussion_r294931777
##
File path: CMakeLists.txt
##
@@ -337,10 +321,11 @@ endif()
-DBUILD_TESTING=OFF
bakaid commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294919196
##
File path: nanofi/ecu/tail_file.c
##
@@ -0,0 +1,206 @@
+/*
+ * Licensed to the Apache Software
phrocker commented on a change in pull request #595: Add windows tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/595#discussion_r294911689
##
File path: CMakeLists.txt
##
@@ -299,8 +287,8 @@ endif(DISABLE_CURL)
if(NOT DISABLE_CURL AND (NOT USE_SYSTEM_CURL))
phrocker commented on a change in pull request #595: Add windows tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/595#discussion_r294911416
##
File path: CMakeLists.txt
##
@@ -188,12 +204,12 @@ if (NOT OPENSSL_OFF)
else()
phrocker commented on a change in pull request #595: Add windows tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/595#discussion_r294911265
##
File path: CMakeLists.txt
##
@@ -130,6 +143,8 @@ endif()
include(CheckCXXCompilerFlag)
if (WIN32)
phrocker commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294907911
##
File path: nanofi/tests/CTailFileTests.cpp
##
@@ -0,0 +1,365 @@
+/**
+ *
+ * Licensed to the Apache
phrocker commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294905956
##
File path: nanofi/CMakeLists.txt
##
@@ -103,4 +105,5 @@ endif(ENABLE_PYTHON AND NOT STATIC_BUILD)
bakaid commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294902901
##
File path: nanofi/src/core/string_utils.c
##
@@ -0,0 +1,165 @@
+/**
+ *
+ * Licensed to the Apache
bakaid commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294902901
##
File path: nanofi/src/core/string_utils.c
##
@@ -0,0 +1,165 @@
+/**
+ *
+ * Licensed to the Apache
phrocker commented on issue #590: MINIFICPP-621 Nanofi Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#issuecomment-503200542
@msharee9 per @bakaid there are some use after frees that probably should be
addressed. Thanks!
[
https://issues.apache.org/jira/browse/MINIFICPP-919?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Mr TheSegfault resolved MINIFICPP-919.
--
Resolution: Fixed
> Site2Site transaction CRC checksum randomly fails to match on
bakaid commented on issue #590: MINIFICPP-621 Nanofi Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#issuecomment-503196323
@phrocker please see my last review. There are - among other things -
multiple use-after-free issues in the code. It should not be merged
bakaid commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294889785
##
File path: nanofi/src/core/string_utils.c
##
@@ -0,0 +1,165 @@
+/**
+ *
+ * Licensed to the Apache
bakaid commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294886759
##
File path: nanofi/src/core/string_utils.c
##
@@ -0,0 +1,165 @@
+/**
+ *
+ * Licensed to the Apache
bakaid commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294882647
##
File path: nanofi/src/core/flowfiles.c
##
@@ -0,0 +1,52 @@
+/**
+ *
+ * Licensed to the Apache
bakaid commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294880584
##
File path: nanofi/ecu/tail_file.c
##
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software
bakaid commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294874054
##
File path: nanofi/ecu/tail_file.c
##
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software
bakaid commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294879206
##
File path: nanofi/ecu/tail_file.c
##
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software
bakaid commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294878612
##
File path: nanofi/ecu/tail_file.c
##
@@ -0,0 +1,214 @@
+/*
+ * Licensed to the Apache Software
bakaid commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294885906
##
File path: nanofi/src/core/string_utils.c
##
@@ -0,0 +1,165 @@
+/**
+ *
+ * Licensed to the Apache
scottyaslan commented on issue #3536: NIFI-6380: Introduced the notion of
Parameters and Parameter Contexts…
URL: https://github.com/apache/nifi/pull/3536#issuecomment-503190858
Does it make sense to add auditing history to parameter contexts?
scottyaslan commented on issue #3536: NIFI-6380: Introduced the notion of
Parameters and Parameter Contexts…
URL: https://github.com/apache/nifi/pull/3536#issuecomment-503187775
Can we add a description field to the parameter context?
[
https://issues.apache.org/jira/browse/MINIFICPP-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Bakai updated MINIFICPP-926:
---
Fix Version/s: 0.7.0
> Nanofi tailfile should have a configurable chunk size
>
[
https://issues.apache.org/jira/browse/MINIFICPP-927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Daniel Bakai updated MINIFICPP-927:
---
Fix Version/s: 0.7.0
> Nanofi tailfile should have a configurable delimiter
>
Murtuza Shareef created MINIFICPP-927:
-
Summary: Nanofi tailfile should have a configurable delimiter
Key: MINIFICPP-927
URL: https://issues.apache.org/jira/browse/MINIFICPP-927
Project: Apache
[
https://issues.apache.org/jira/browse/MINIFICPP-927?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Murtuza Shareef updated MINIFICPP-927:
--
Labels: CAPI ECU nanofi (was: )
> Nanofi tailfile should have a configurable
[
https://issues.apache.org/jira/browse/MINIFICPP-926?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Murtuza Shareef updated MINIFICPP-926:
--
Labels: CAPI ECU nanofi (was: )
> Nanofi tailfile should have a configurable chunk
Murtuza Shareef created MINIFICPP-926:
-
Summary: Nanofi tailfile should have a configurable chunk size
Key: MINIFICPP-926
URL: https://issues.apache.org/jira/browse/MINIFICPP-926
Project: Apache
phrocker commented on a change in pull request #585: MINIFICPP-910 - Extend
StringUtils with string join capability
URL: https://github.com/apache/nifi-minifi-cpp/pull/585#discussion_r294863650
##
File path: libminifi/include/utils/StringUtils.h
##
@@ -92,172 +103,104 @@
phrocker commented on a change in pull request #585: MINIFICPP-910 - Extend
StringUtils with string join capability
URL: https://github.com/apache/nifi-minifi-cpp/pull/585#discussion_r294863650
##
File path: libminifi/include/utils/StringUtils.h
##
@@ -92,172 +103,104 @@
phrocker commented on a change in pull request #585: MINIFICPP-910 - Extend
StringUtils with string join capability
URL: https://github.com/apache/nifi-minifi-cpp/pull/585#discussion_r294863650
##
File path: libminifi/include/utils/StringUtils.h
##
@@ -92,172 +103,104 @@
Daniel Bakai created MINIFICPP-925:
--
Summary: TailFile in delimiter mode stops working if it encounters
a line longer than 4095 bytes
Key: MINIFICPP-925
URL: https://issues.apache.org/jira/browse/MINIFICPP-925
arpadboda commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294850071
##
File path: nanofi/tests/CTailFileTests.cpp
##
@@ -0,0 +1,365 @@
+/**
+ *
+ * Licensed to the Apache
arpadboda commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294848846
##
File path: nanofi/src/core/string_utils.c
##
@@ -0,0 +1,165 @@
+/**
+ *
+ * Licensed to the Apache
bakaid commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294829533
##
File path: nanofi/tests/CTailFileTests.cpp
##
@@ -0,0 +1,365 @@
+/**
+ *
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/MINIFICPP-896?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=16866568#comment-16866568
]
Otto Fowler commented on MINIFICPP-896:
---
I don't believe that description is correct, every
phrocker opened a new pull request #595: Add windows tests
URL: https://github.com/apache/nifi-minifi-cpp/pull/595
Still a WIP..
To enable tests on windows I needed to either resolve many dependency issues
with linkages or take a more appropriate step, which was make EL a true
bakaid commented on a change in pull request #590: MINIFICPP-621 Nanofi
Tailfile example
URL: https://github.com/apache/nifi-minifi-cpp/pull/590#discussion_r294664224
##
File path: nanofi/tests/CTailFileTests.cpp
##
@@ -0,0 +1,365 @@
+/**
+ *
+ * Licensed to the Apache
[
https://issues.apache.org/jira/browse/NIFI-5098?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Satwik Bhandiwad reassigned NIFI-5098:
--
Assignee: Satwik Bhandiwad
> NiFi fails to start if invalid NiFi Registry URI is
73 matches
Mail list logo