[GitHub] [nifi] natural commented on a change in pull request #4207: NIFI-7203 Add ZooKeeper client and server TLS

2020-04-13 Thread GitBox
natural commented on a change in pull request #4207: NIFI-7203 Add ZooKeeper client and server TLS URL: https://github.com/apache/nifi/pull/4207#discussion_r407780342 ## File path:

[GitHub] [nifi] natural commented on issue #4202: NIFI-7203 Support for TLS in Zookeeper Server

2020-04-13 Thread GitBox
natural commented on issue #4202: NIFI-7203 Support for TLS in Zookeeper Server URL: https://github.com/apache/nifi/pull/4202#issuecomment-613139346 > @natural Would you be able to snag the tests from #4207 and make the change to the logic and zookeeper.properties and then we'll just turn

[GitHub] [nifi] natural commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server

2020-04-13 Thread GitBox
natural commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server URL: https://github.com/apache/nifi/pull/4202#discussion_r407768819 ## File path:

[GitHub] [nifi] natural commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server

2020-04-13 Thread GitBox
natural commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server URL: https://github.com/apache/nifi/pull/4202#discussion_r407768501 ## File path:

[GitHub] [nifi] natural commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server

2020-04-13 Thread GitBox
natural commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server URL: https://github.com/apache/nifi/pull/4202#discussion_r407768245 ## File path:

[GitHub] [nifi] natural commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server

2020-04-13 Thread GitBox
natural commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server URL: https://github.com/apache/nifi/pull/4202#discussion_r407768353 ## File path:

[GitHub] [nifi] rfellows opened a new pull request #4208: [NIFI-7358] - Fix: Sorting on 'Estimated Time to Back Pressure' in th…

2020-04-13 Thread GitBox
rfellows opened a new pull request #4208: [NIFI-7358] - Fix: Sorting on 'Estimated Time to Back Pressure' in th… URL: https://github.com/apache/nifi/pull/4208 …e Connection summary table does not work properly Thank you for submitting a contribution to Apache NiFi. Please

[jira] [Created] (NIFI-7358) Sorting on "Estimated Time to Back Pressure" in the Connection summary table does not work properly

2020-04-13 Thread Rob Fellows (Jira)
Rob Fellows created NIFI-7358: - Summary: Sorting on "Estimated Time to Back Pressure" in the Connection summary table does not work properly Key: NIFI-7358 URL: https://issues.apache.org/jira/browse/NIFI-7358

[GitHub] [nifi] jfrazee commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server

2020-04-13 Thread GitBox
jfrazee commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server URL: https://github.com/apache/nifi/pull/4202#discussion_r407726084 ## File path:

[GitHub] [nifi] jfrazee commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server

2020-04-13 Thread GitBox
jfrazee commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server URL: https://github.com/apache/nifi/pull/4202#discussion_r407726084 ## File path:

[GitHub] [nifi] jfrazee commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server

2020-04-13 Thread GitBox
jfrazee commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server URL: https://github.com/apache/nifi/pull/4202#discussion_r407696242 ## File path:

[GitHub] [nifi] jfrazee commented on issue #4202: NIFI-7203 Support for TLS in Zookeeper Server

2020-04-13 Thread GitBox
jfrazee commented on issue #4202: NIFI-7203 Support for TLS in Zookeeper Server URL: https://github.com/apache/nifi/pull/4202#issuecomment-613075157 @natural Would you be able to snag the tests from #4207 and make the change to the logic and zookeeper.properties and then we'll just turn

[GitHub] [nifi] jfrazee commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server

2020-04-13 Thread GitBox
jfrazee commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server URL: https://github.com/apache/nifi/pull/4202#discussion_r407690070 ## File path:

[GitHub] [nifi] jfrazee commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server

2020-04-13 Thread GitBox
jfrazee commented on a change in pull request #4202: NIFI-7203 Support for TLS in Zookeeper Server URL: https://github.com/apache/nifi/pull/4202#discussion_r407690275 ## File path:

[GitHub] [nifi] jfrazee commented on issue #4202: NIFI-7203 Support for TLS in Zookeeper Server

2020-04-13 Thread GitBox
jfrazee commented on issue #4202: NIFI-7203 Support for TLS in Zookeeper Server URL: https://github.com/apache/nifi/pull/4202#issuecomment-613039039 @natural Otherwise the implementation appears to be correct. This is an

[GitHub] [nifi] jfrazee commented on issue #4207: NIFI-7203 Add ZooKeeper client and server TLS

2020-04-13 Thread GitBox
jfrazee commented on issue #4207: NIFI-7203 Add ZooKeeper client and server TLS URL: https://github.com/apache/nifi/pull/4207#issuecomment-613031456 @joewitt Both? I had just finished up the work but with the addition of the client implementation and server tests which hadn't existed

[GitHub] [nifi] jfrazee commented on issue #4202: NIFI-7203 Support for TLS in Zookeeper Server

2020-04-13 Thread GitBox
jfrazee commented on issue #4202: NIFI-7203 Support for TLS in Zookeeper Server URL: https://github.com/apache/nifi/pull/4202#issuecomment-613029136 @natural Having also recently implemented this (#4207) I have a couple of comments: - Secure and insecure aren't mutually exclusive so if

[GitHub] [nifi] joewitt commented on issue #4207: NIFI-7203 Add ZooKeeper client and server TLS

2020-04-13 Thread GitBox
joewitt commented on issue #4207: NIFI-7203 Add ZooKeeper client and server TLS URL: https://github.com/apache/nifi/pull/4207#issuecomment-613028522 @jfrazee Is this PR related to/duplicative/complimentary to https://github.com/apache/nifi/pull/4202?

[GitHub] [nifi] jfrazee opened a new pull request #4207: NIFI-7203 Add ZooKeeper client and server TLS

2020-04-13 Thread GitBox
jfrazee opened a new pull request #4207: NIFI-7203 Add ZooKeeper client and server TLS URL: https://github.com/apache/nifi/pull/4207 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR

[GitHub] [nifi] ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration

2020-04-13 Thread GitBox
ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration URL: https://github.com/apache/nifi/pull/4201#issuecomment-613001810 Actually, having run check style with that enabled... it seems that it is more normal than I thought lol: ```bash

[GitHub] [nifi] ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration

2020-04-13 Thread GitBox
ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration URL: https://github.com/apache/nifi/pull/4201#issuecomment-612992109 Review and tests make sense, built with contrib-check all good. Personally, I don't think end of line comments are

[jira] [Updated] (NIFI-7304) Default value for content length filter blocks Site to Site communication

2020-04-13 Thread Andy LoPresto (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy LoPresto updated NIFI-7304: Status: Patch Available (was: In Progress) > Default value for content length filter blocks Site

[GitHub] [nifi] ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration

2020-04-13 Thread GitBox
ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration URL: https://github.com/apache/nifi/pull/4201#issuecomment-612984602 @ijokarumawak can you take a look, you have reviewed the wait processor stuff before

[GitHub] [nifi] ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration

2020-04-13 Thread GitBox
ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration URL: https://github.com/apache/nifi/pull/4201#issuecomment-612984447 Reviewing This is an automated message from the

[jira] [Created] (NIFI-7356) Enable TLS for embedded Zookeeper when NiFi has TLS enabled

2020-04-13 Thread Troy Melhase (Jira)
Troy Melhase created NIFI-7356: -- Summary: Enable TLS for embedded Zookeeper when NiFi has TLS enabled Key: NIFI-7356 URL: https://issues.apache.org/jira/browse/NIFI-7356 Project: Apache NiFi

[jira] [Created] (NIFI-7357) Make Zookeeper TLS Properties Available via nifi.properties

2020-04-13 Thread Troy Melhase (Jira)
Troy Melhase created NIFI-7357: -- Summary: Make Zookeeper TLS Properties Available via nifi.properties Key: NIFI-7357 URL: https://issues.apache.org/jira/browse/NIFI-7357 Project: Apache NiFi

[jira] [Updated] (MINIFICPP-1191) minor bootstrap typo

2020-04-13 Thread Dustin Rodrigues (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1191?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Dustin Rodrigues updated MINIFICPP-1191: Resolution: Not A Bug Status: Resolved (was: Patch Available) > minor

[GitHub] [nifi-minifi-cpp] dtrodrigues commented on issue #753: MINIFICPP-1191 - fix bootstrap typo

2020-04-13 Thread GitBox
dtrodrigues commented on issue #753: MINIFICPP-1191 - fix bootstrap typo URL: https://github.com/apache/nifi-minifi-cpp/pull/753#issuecomment-612981718 Whoops, yeah you're right. I mis-read. This is an automated message from

[GitHub] [nifi-minifi-cpp] dtrodrigues closed pull request #753: MINIFICPP-1191 - fix bootstrap typo

2020-04-13 Thread GitBox
dtrodrigues closed pull request #753: MINIFICPP-1191 - fix bootstrap typo URL: https://github.com/apache/nifi-minifi-cpp/pull/753 This is an automated message from the Apache Git Service. To respond to the message, please

[GitHub] [nifi] alopresto opened a new pull request #4206: NIFI-7304 Disabled CLF by default and allow S2S & cluster comms to bypass length check

2020-04-13 Thread GitBox
alopresto opened a new pull request #4206: NIFI-7304 Disabled CLF by default and allow S2S & cluster comms to bypass length check URL: https://github.com/apache/nifi/pull/4206 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here:

[GitHub] [nifi-minifi-cpp] apiri commented on issue #753: MINIFICPP-1191 - fix bootstrap typo

2020-04-13 Thread GitBox
apiri commented on issue #753: MINIFICPP-1191 - fix bootstrap typo URL: https://github.com/apache/nifi-minifi-cpp/pull/753#issuecomment-612969099 Hey @dtrodrigues. I believe this to be correct given that we are inspecting if cmake should be skipped. If not, the command is actually being

[GitHub] [nifi] alopresto commented on issue #4099: NIFI-7170: Add option to disable anonymous authentication

2020-04-13 Thread GitBox
alopresto commented on issue #4099: NIFI-7170: Add option to disable anonymous authentication URL: https://github.com/apache/nifi/pull/4099#issuecomment-612962685 Matt, can you explain in what scenario(s) a user would be able to authenticate as `anonymous`? My understanding is there is

[GitHub] [nifi-registry] bbende opened a new pull request #276: NIFIREG-385 Make revision feature configurable

2020-04-13 Thread GitBox
bbende opened a new pull request #276: NIFIREG-385 Make revision feature configurable URL: https://github.com/apache/nifi-registry/pull/276 This is an automated message from the Apache Git Service. To respond to the

[GitHub] [nifi] EndzeitBegins edited a comment on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration

2020-04-13 Thread GitBox
EndzeitBegins edited a comment on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration URL: https://github.com/apache/nifi/pull/4201#issuecomment-612940158 @ottobackwards Thanks for the reply. I've updated the fork accordingly. The changes should be easier to see

[GitHub] [nifi] EndzeitBegins commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration

2020-04-13 Thread GitBox
EndzeitBegins commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration URL: https://github.com/apache/nifi/pull/4201#issuecomment-612940158 @ottobackwards Thanks for the reply. I've updated the fork accordingly. The changes should be easiert to see now.

[jira] [Created] (NIFIREG-385) Make revision feature configurable

2020-04-13 Thread Bryan Bende (Jira)
Bryan Bende created NIFIREG-385: --- Summary: Make revision feature configurable Key: NIFIREG-385 URL: https://issues.apache.org/jira/browse/NIFIREG-385 Project: NiFi Registry Issue Type:

[jira] [Updated] (NIFI-7354) Allow dynamic configuration of analytics properties in Docker

2020-04-13 Thread Aldrin Piri (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Aldrin Piri updated NIFI-7354: -- Fix Version/s: 1.12.0 Resolution: Fixed Status: Resolved (was: Patch Available) >

[jira] [Commented] (NIFI-7354) Allow dynamic configuration of analytics properties in Docker

2020-04-13 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7354?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082303#comment-17082303 ] ASF subversion and git services commented on NIFI-7354: --- Commit

[GitHub] [nifi] asfgit closed pull request #4203: NIFI-7354: Allow analytics properties to be set via environment variables in dockermaven

2020-04-13 Thread GitBox
asfgit closed pull request #4203: NIFI-7354: Allow analytics properties to be set via environment variables in dockermaven URL: https://github.com/apache/nifi/pull/4203 This is an automated message from the Apache Git

[GitHub] [nifi] mcgilman commented on issue #4099: NIFI-7170: Add option to disable anonymous authentication

2020-04-13 Thread GitBox
mcgilman commented on issue #4099: NIFI-7170: Add option to disable anonymous authentication URL: https://github.com/apache/nifi/pull/4099#issuecomment-612885579 @alopresto I think I agree with you and I'm happy to update this PR to reflect that. However, I just want to reiterate so there

[GitHub] [nifi] ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration

2020-04-13 Thread GitBox
ottobackwards commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration URL: https://github.com/apache/nifi/pull/4201#issuecomment-612880334 Thanks for improving this. Your diff's are the complete files. Please re-submit without formatting changes etc.

[jira] [Commented] (NIFI-7348) FlowFiles re-entering a Wait-processor after they've expired expire immediatelly

2020-04-13 Thread Otto Fowler (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17082268#comment-17082268 ] Otto Fowler commented on NIFI-7348: --- I don't think this is intentional. > FlowFiles re-entering a

[GitHub] [nifi] EndzeitBegins commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration

2020-04-13 Thread GitBox
EndzeitBegins commented on issue #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration URL: https://github.com/apache/nifi/pull/4201#issuecomment-612867048 Re-run CI build because of flaky tests. This is an

[GitHub] [nifi] EndzeitBegins opened a new pull request #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration

2020-04-13 Thread GitBox
EndzeitBegins opened a new pull request #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration URL: https://github.com/apache/nifi/pull/4201 Description of PR The WAIT processor removes attribute WAIT_START_TIMESTAMP after transferring FlowFiles to the

[GitHub] [nifi] EndzeitBegins closed pull request #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration

2020-04-13 Thread GitBox
EndzeitBegins closed pull request #4201: NIFI-7348 Wait - Removes WAIT_START_TIMESTAMP after expiration URL: https://github.com/apache/nifi/pull/4201 This is an automated message from the Apache Git Service. To respond to

[jira] [Updated] (NIFI-7348) FlowFiles re-entering a Wait-processor after they've expired expire immediatelly

2020-04-13 Thread Lucas Ottersbach (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7348?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Lucas Ottersbach updated NIFI-7348: --- Description: We recently noticed a behaviour of the Wait processor that we thought of to be