hunyadi-dev commented on a change in pull request #773:
URL: https://github.com/apache/nifi-minifi-cpp/pull/773#discussion_r416332021
##
File path: libminifi/test/unit/MinifiConcurrentQueueTests.cpp
##
@@ -123,37 +234,79 @@ TEST_CASE("TestConqurrentQueue::testQueueWithReAdd",
hunyadi-dev commented on a change in pull request #773:
URL: https://github.com/apache/nifi-minifi-cpp/pull/773#discussion_r416330228
##
File path: libminifi/include/utils/MinifiConcurrentQueue.h
##
@@ -127,33 +147,58 @@ class ConditionConcurrentQueue : private
Sandhiya created NIFI-7402:
--
Summary: PutCassandraRecord Processor doesn't allow to dump case
sensitive columns data to dump into Cassandra DB
Key: NIFI-7402
URL: https://issues.apache.org/jira/browse/NIFI-7402
alopresto commented on a change in pull request #4224:
URL: https://github.com/apache/nifi/pull/4224#discussion_r416274639
##
File path:
alopresto commented on a change in pull request #4224:
URL: https://github.com/apache/nifi/pull/4224#discussion_r416273764
##
File path:
alopresto commented on a change in pull request #4224:
URL: https://github.com/apache/nifi/pull/4224#discussion_r416272053
##
File path:
alopresto commented on a change in pull request #4224:
URL: https://github.com/apache/nifi/pull/4224#discussion_r416264801
##
File path:
alopresto commented on pull request #4231:
URL: https://github.com/apache/nifi/pull/4231#issuecomment-620314181
It looks like the `PutMongo` and `DeleteMongo` processors (as well as
`GetMongoRecord`, `PutMongoRecord`, and `DeleteMongoRecord`) could also take
advantage of these new
alopresto commented on a change in pull request #4231:
URL: https://github.com/apache/nifi/pull/4231#discussion_r416249400
##
File path:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java
##
@@ -271,4
alopresto commented on a change in pull request #4231:
URL: https://github.com/apache/nifi/pull/4231#discussion_r416248876
##
File path:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java
##
@@ -253,7
alopresto commented on a change in pull request #4231:
URL: https://github.com/apache/nifi/pull/4231#discussion_r416248237
##
File path:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java
##
@@ -253,7
alopresto commented on a change in pull request #4231:
URL: https://github.com/apache/nifi/pull/4231#discussion_r416245301
##
File path:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java
##
@@ -85,6
alopresto commented on a change in pull request #4231:
URL: https://github.com/apache/nifi/pull/4231#discussion_r416245565
##
File path:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/main/java/org/apache/nifi/processors/mongodb/GetMongo.java
##
@@ -85,6
MuazmaZ commented on pull request #4237:
URL: https://github.com/apache/nifi/pull/4237#issuecomment-620307700
@sushilkm this works as expected and creates the container if it doesn't
exist already, also tested if an invalid name was given, it throws the right
exception. Thanks for adding
[
https://issues.apache.org/jira/browse/NIFI-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-7377:
Fix Version/s: 1.12.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
[
https://issues.apache.org/jira/browse/NIFI-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-7377:
Status: Patch Available (was: In Progress)
> Improve logs in NiFi stateless
>
[
https://issues.apache.org/jira/browse/NIFI-7377?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17094040#comment-17094040
]
ASF subversion and git services commented on NIFI-7377:
---
Commit
bakaid commented on pull request #629:
URL: https://github.com/apache/nifi-minifi-cpp/pull/629#issuecomment-620304506
@arpadboda @szaszm
Rebased to latest master and rewrote state storage to the new centralized
one.
Also found an error in ListSFTP's and TailFile's state parsing
bakaid commented on a change in pull request #629:
URL: https://github.com/apache/nifi-minifi-cpp/pull/629#discussion_r416237833
##
File path: CMakeLists.txt
##
@@ -480,6 +480,18 @@ if ((ENABLE_ALL OR ENABLE_SFTP) AND NOT DISABLE_CURL)
createExtension(SFTP "SFTP
[
https://issues.apache.org/jira/browse/NIFI-6913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sushil Kumar reassigned NIFI-6913:
--
Assignee: Sushil Kumar
> PutAzureBlobStorage processor Container Name to allow to create a
sushilkm opened a new pull request #4237:
URL: https://github.com/apache/nifi/pull/4237
Description of PR
PutAzureBlobStorage processor will create container if not exists; fixes bug
NIFI-6913
In order to streamline the review of the contribution we ask you
to ensure
YolandaMDavis commented on a change in pull request #4229:
URL: https://github.com/apache/nifi/pull/4229#discussion_r416220568
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-prometheus-utils/src/main/java/org/apache/nifi/prometheus/util/BulletinMetricsHolder.java
##
YolandaMDavis commented on a change in pull request #4229:
URL: https://github.com/apache/nifi/pull/4229#discussion_r416218450
##
File path:
nifi-nar-bundles/nifi-extension-utils/nifi-prometheus-utils/src/main/java/org/apache/nifi/prometheus/util/BulletinMetricsHolder.java
##
MuazmaZ commented on pull request #3906:
URL: https://github.com/apache/nifi/pull/3906#issuecomment-620283421
@sushilkm it looks good to me. Tested the functionality and it changes the
default so the user can enter the blob name.
sjyang18 commented on a change in pull request #4227:
URL: https://github.com/apache/nifi/pull/4227#discussion_r416201601
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/test/java/org/apache/nifi/processors/azure/storage/ITPutAzureDataLakeStorage.java
sushilkm commented on a change in pull request #3906:
URL: https://github.com/apache/nifi/pull/3906#discussion_r416186168
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage.java
##
sushilkm commented on a change in pull request #3906:
URL: https://github.com/apache/nifi/pull/3906#discussion_r416186168
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage.java
##
[
https://issues.apache.org/jira/browse/NIFI-7003?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sushil Kumar reassigned NIFI-7003:
--
Assignee: Sushil Kumar
> Issuing "nifi.sh stop" on deleted node makes it to join the cluster
[
https://issues.apache.org/jira/browse/NIFI-6911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sushil Kumar reassigned NIFI-6911:
--
Assignee: Sushil Kumar
> PutAzureBlobStorage processor uses an undefined default value for
[
https://issues.apache.org/jira/browse/NIFI-4913?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sushil Kumar reassigned NIFI-4913:
--
Assignee: Sushil Kumar
> Specifying "run.as" in bootstrap.properties causes environment
sushilkm commented on a change in pull request #3906:
URL: https://github.com/apache/nifi/pull/3906#discussion_r416186168
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage.java
##
jfrazee commented on a change in pull request #3906:
URL: https://github.com/apache/nifi/pull/3906#discussion_r416179992
##
File path:
nifi-nar-bundles/nifi-azure-bundle/nifi-azure-processors/src/main/java/org/apache/nifi/processors/azure/storage/PutAzureBlobStorage.java
##
sushilkm commented on pull request #3906:
URL: https://github.com/apache/nifi/pull/3906#issuecomment-620256927
@pvillard31 @turcsanyip as suggested I have updated the PR to only update
PutAzureBlobStorage processor, please check this one.
[
https://issues.apache.org/jira/browse/NIFI-6911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sushil Kumar updated NIFI-6911:
---
Summary: PutAzureBlobStorage processor uses an undefined default value for
'Blob' property (was:
[
https://issues.apache.org/jira/browse/NIFI-6911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Sushil Kumar updated NIFI-6911:
---
Description:
PutAzureBlobStorage uses an undefined default value ${azure.blobname} for Blob
[
https://issues.apache.org/jira/browse/NIFI-6860?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093939#comment-17093939
]
Josef Zahner commented on NIFI-6860:
[~tmelhase] in my case the issue was fully reproducible. I'm off
[
https://issues.apache.org/jira/browse/NIFI-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-7389:
Fix Version/s: 1.12.0
Resolution: Fixed
Status: Resolved (was: Patch Available)
[
https://issues.apache.org/jira/browse/NIFI-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto reassigned NIFI-7389:
---
Assignee: Sushil Kumar
> Missing heartbeat counts to disconnect a node in cluster should be
[
https://issues.apache.org/jira/browse/NIFI-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-7389:
Labels: cluster heartbeat (was: )
> Missing heartbeat counts to disconnect a node in cluster
[
https://issues.apache.org/jira/browse/NIFI-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Andy LoPresto updated NIFI-7389:
Status: Patch Available (was: Open)
> Missing heartbeat counts to disconnect a node in cluster
[
https://issues.apache.org/jira/browse/NIFI-7389?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093906#comment-17093906
]
ASF subversion and git services commented on NIFI-7389:
---
Commit
[
https://issues.apache.org/jira/browse/MINIFICPP-839?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Arpad Boda reassigned MINIFICPP-839:
Assignee: Arpad Boda
> Multiple memory leaks because of shared_ptr cycles
>
[
https://issues.apache.org/jira/browse/MINIFICPP-1175?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dániel Bakai resolved MINIFICPP-1175.
-
Resolution: Fixed
Done in the scope of MINIFICPP-550
> ControllerService neither
[
https://issues.apache.org/jira/browse/MINIFICPP-550?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Dániel Bakai updated MINIFICPP-550:
---
Resolution: Fixed
Status: Resolved (was: Patch Available)
> Create RocksDB
arpadboda commented on pull request #605:
URL: https://github.com/apache/nifi-minifi-cpp/pull/605#issuecomment-620196128
Built and tested, seems to work based on my tests as well, so LGTM, merging
this.
Follow-ups may naturally pop up.
[
https://issues.apache.org/jira/browse/NIFI-7401?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Joey Frazee updated NIFI-7401:
--
Description: In order to fully support ZooKeeper TLS, NiFi must be able to
connect to a client-TLS
Joey Frazee created NIFI-7401:
-
Summary: Add ZooKeeper client TLS to CuratorLeaderElectionManager
Key: NIFI-7401
URL: https://issues.apache.org/jira/browse/NIFI-7401
Project: Apache NiFi
Issue
alopresto commented on pull request #4236:
URL: https://github.com/apache/nifi/pull/4236#issuecomment-620183696
Made a recommendation for changing the property name. Once that's done, I'll
run the full build with tests and merge. Thanks for the contribution.
alopresto commented on a change in pull request #4236:
URL: https://github.com/apache/nifi/pull/4236#discussion_r416085004
##
File path:
nifi-commons/nifi-properties/src/main/java/org/apache/nifi/util/NiFiProperties.java
##
@@ -203,6 +203,7 @@
// cluster common
MuazmaZ commented on pull request #4227:
URL: https://github.com/apache/nifi/pull/4227#issuecomment-620174551
@turcsanyip Looks good to me. I was able to run the tests and verify the
functionality.
This is an automated
ottobackwards commented on a change in pull request #4234:
URL: https://github.com/apache/nifi/pull/4234#discussion_r416066144
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##
@@
ottobackwards commented on a change in pull request #4234:
URL: https://github.com/apache/nifi/pull/4234#discussion_r416061201
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##
@@
ottobackwards commented on a change in pull request #4234:
URL: https://github.com/apache/nifi/pull/4234#discussion_r416054817
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##
@@
ottobackwards commented on a change in pull request #4234:
URL: https://github.com/apache/nifi/pull/4234#discussion_r416054076
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##
@@
ottobackwards commented on a change in pull request #4234:
URL: https://github.com/apache/nifi/pull/4234#discussion_r416052749
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##
@@
arpadboda commented on a change in pull request #773:
URL: https://github.com/apache/nifi-minifi-cpp/pull/773#discussion_r416046058
##
File path: libminifi/include/utils/MinifiConcurrentQueue.h
##
@@ -127,33 +147,58 @@ class ConditionConcurrentQueue : private
ConcurrentQueue
ottobackwards commented on a change in pull request #4234:
URL: https://github.com/apache/nifi/pull/4234#discussion_r416051173
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##
@@
ottobackwards commented on a change in pull request #4234:
URL: https://github.com/apache/nifi/pull/4234#discussion_r416051173
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##
@@
arpadboda commented on a change in pull request #773:
URL: https://github.com/apache/nifi-minifi-cpp/pull/773#discussion_r416040742
##
File path: libminifi/include/utils/MinifiConcurrentQueue.h
##
@@ -99,6 +106,19 @@ class ConcurrentQueue {
return true;
}
+ template
markap14 commented on a change in pull request #4234:
URL: https://github.com/apache/nifi/pull/4234#discussion_r416038768
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##
@@
sushilkm opened a new pull request #4236:
URL: https://github.com/apache/nifi/pull/4236
Description of PR
Makes Missable heartbeat counts configurable; fixes NIFI-7389
Earlier the number was hardcoded as 8, this PR targets to make the count
configurable via usage of
ottobackwards commented on pull request #4234:
URL: https://github.com/apache/nifi/pull/4234#issuecomment-620144998
@markap14, it is an artifact. My first implementation did do that, but I
knew it was wrong. I refactored to the current way after looking through the
Multipart api a bit.
ottobackwards edited a comment on pull request #4234:
URL: https://github.com/apache/nifi/pull/4234#issuecomment-620144998
@markap14, it is an artifact. My first implementation did do that, but I
knew it was wrong. I refactored to the current way after looking through the
Multipart api
ottobackwards commented on a change in pull request #4234:
URL: https://github.com/apache/nifi/pull/4234#discussion_r416033229
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##
@@
ottobackwards commented on a change in pull request #4234:
URL: https://github.com/apache/nifi/pull/4234#discussion_r416030191
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##
@@
markap14 commented on a change in pull request #4234:
URL: https://github.com/apache/nifi/pull/4234#discussion_r416029131
##
File path:
nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/InvokeHTTP.java
##
@@
szaszm commented on a change in pull request #773:
URL: https://github.com/apache/nifi-minifi-cpp/pull/773#discussion_r415924891
##
File path: libminifi/include/utils/MinifiConcurrentQueue.h
##
@@ -32,7 +33,7 @@ namespace utils {
// Provides a queue API and guarantees no
[
https://issues.apache.org/jira/browse/NIFI-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093759#comment-17093759
]
Joe Witt commented on NIFI-7400:
WOW! Brandon even uses the same name. I must have read that 4 years ago
[
https://issues.apache.org/jira/browse/NIFI-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093755#comment-17093755
]
Johan Cronsioe edited comment on NIFI-7400 at 4/27/20, 5:21 PM:
[~joewitt]
[
https://issues.apache.org/jira/browse/NIFI-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093755#comment-17093755
]
Johan Cronsioe commented on NIFI-7400:
--
[~joewitt] Yes i agree with your suggestion. I was a bit fast
joewitt commented on pull request #4235:
URL: https://github.com/apache/nifi/pull/4235#issuecomment-620112213
I replied as soon as I saw the JIRA. I recommend this not be a new
processor but rather a new strategy on DistributeLoad. See comments on the
JIRA. In either case thanks for
johancr opened a new pull request #4235:
URL: https://github.com/apache/nifi/pull/4235
…hen primary relationship is unavailable."
Thank you for submitting a contribution to Apache NiFi.
Please provide a short description of the PR here:
Description of PR
[
https://issues.apache.org/jira/browse/NIFI-7400?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093743#comment-17093743
]
Joe Witt commented on NIFI-7400:
[~johancr] If I understand your ask correctly you would like a processor
Johan Cronsioe created NIFI-7400:
Summary: Processor to route Flowfile when relationship is
unavailable
Key: NIFI-7400
URL: https://issues.apache.org/jira/browse/NIFI-7400
Project: Apache NiFi
bakaid edited a comment on pull request #605:
URL: https://github.com/apache/nifi-minifi-cpp/pull/605#issuecomment-620087034
I am done with my final verification, the following has been tested
successfully:
- Using the new state storage for:
- TailFile
- ListSFTP
-
bakaid commented on pull request #605:
URL: https://github.com/apache/nifi-minifi-cpp/pull/605#issuecomment-620087034
I am done with my final verification, the following has been tested
successfully:
- Using the new state storage for:
- TailFile
- ListSFTP
- CWEL
-
hunyadi-dev opened a new pull request #773:
URL: https://github.com/apache/nifi-minifi-cpp/pull/773
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
szaszm commented on a change in pull request #629:
URL: https://github.com/apache/nifi-minifi-cpp/pull/629#discussion_r415842470
##
File path: CMakeLists.txt
##
@@ -480,6 +480,18 @@ if ((ENABLE_ALL OR ENABLE_SFTP) AND NOT DISABLE_CURL)
createExtension(SFTP "SFTP
HorizonNet commented on a change in pull request #4231:
URL: https://github.com/apache/nifi/pull/4231#discussion_r415698289
##
File path:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/GetMongoIT.java
##
@@ -668,4
[
https://issues.apache.org/jira/browse/NIFI-7399?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17093305#comment-17093305
]
Pierre Villard commented on NIFI-7399:
--
Hi [~DamD] - is it similar to NIFI-3785 ?
> Change
karthik-kadajji commented on a change in pull request #4231:
URL: https://github.com/apache/nifi/pull/4231#discussion_r415621438
##
File path:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/GetMongoIT.java
##
@@
karthik-kadajji commented on a change in pull request #4231:
URL: https://github.com/apache/nifi/pull/4231#discussion_r415619429
##
File path:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/GetMongoIT.java
##
@@
karthik-kadajji commented on a change in pull request #4231:
URL: https://github.com/apache/nifi/pull/4231#discussion_r415618114
##
File path:
nifi-nar-bundles/nifi-mongodb-bundle/nifi-mongodb-processors/src/test/java/org/apache/nifi/processors/mongodb/GetMongoIT.java
##
@@
msharee9 opened a new pull request #772:
URL: https://github.com/apache/nifi-minifi-cpp/pull/772
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
84 matches
Mail list logo