[
https://issues.apache.org/jira/browse/NIFI-7802?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17194909#comment-17194909
]
ASF subversion and git services commented on NIFI-7802:
---
Commit
thenatog closed pull request #4525:
URL: https://github.com/apache/nifi/pull/4525
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
wangwentao commented on pull request #2997:
URL: https://github.com/apache/nifi/pull/2997#issuecomment-690988265
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mattyb149 commented on pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#issuecomment-691211449
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pvillard31 commented on pull request #296:
URL: https://github.com/apache/nifi-registry/pull/296#issuecomment-691457645
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
patricker commented on pull request #2231:
URL: https://github.com/apache/nifi/pull/2231#issuecomment-691267480
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mattyb149 commented on pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#issuecomment-69142
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mattyb149 closed pull request #4520:
URL: https://github.com/apache/nifi/pull/4520
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
naddym commented on a change in pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#discussion_r487080018
##
File path:
pvillard31 closed pull request #295:
URL: https://github.com/apache/nifi-registry/pull/295
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
szaszm commented on a change in pull request #837:
URL: https://github.com/apache/nifi-minifi-cpp/pull/837#discussion_r487110101
##
File path: cmake/BundledSpdlog.cmake
##
@@ -0,0 +1,70 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
pvillard31 commented on pull request #298:
URL: https://github.com/apache/nifi-registry/pull/298#issuecomment-691148453
Code change LGTM, merged to main, thanks @bbende
This is an automated message from the Apache Git
mattyb149 commented on a change in pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#discussion_r487072327
##
File path:
naddym commented on pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#issuecomment-691219583
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kevdoran closed pull request #301:
URL: https://github.com/apache/nifi-registry/pull/301
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
thenatog commented on pull request #4525:
URL: https://github.com/apache/nifi/pull/4525#issuecomment-691315601
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pvillard31 commented on pull request #2997:
URL: https://github.com/apache/nifi/pull/2997#issuecomment-690998588
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
asfgit closed pull request #4521:
URL: https://github.com/apache/nifi/pull/4521
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #4518:
URL: https://github.com/apache/nifi/pull/4518
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
kevdoran commented on pull request #4510:
URL: https://github.com/apache/nifi/pull/4510#issuecomment-691138605
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bbende commented on pull request #296:
URL: https://github.com/apache/nifi-registry/pull/296#issuecomment-691097051
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
pvillard31 commented on pull request #4518:
URL: https://github.com/apache/nifi/pull/4518#issuecomment-691142574
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
lordgamez commented on pull request #900:
URL: https://github.com/apache/nifi-minifi-cpp/pull/900#issuecomment-690927794
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
szaszm commented on a change in pull request #900:
URL: https://github.com/apache/nifi-minifi-cpp/pull/900#discussion_r486988154
##
File path: extensions/bustache/ApplyTemplate.h
##
@@ -61,7 +61,7 @@ class ApplyTemplate : public core::Processor {
class WriteCallback :
turcsanyip commented on pull request #4464:
URL: https://github.com/apache/nifi/pull/4464#issuecomment-691150833
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mattyb149 commented on a change in pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#discussion_r487099612
##
File path: nifi-mock/pom.xml
##
@@ -58,6 +58,11 @@
nifi-data-provenance-utils
1.13.0-SNAPSHOT
+
+
arpadboda closed pull request #904:
URL: https://github.com/apache/nifi-minifi-cpp/pull/904
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gadLinux commented on pull request #4300:
URL: https://github.com/apache/nifi/pull/4300#issuecomment-691492193
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
thenatog commented on pull request #296:
URL: https://github.com/apache/nifi-registry/pull/296#issuecomment-691313090
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
scottyaslan commented on pull request #4524:
URL: https://github.com/apache/nifi/pull/4524#issuecomment-691286522
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
pvillard31 commented on pull request #4521:
URL: https://github.com/apache/nifi/pull/4521#issuecomment-691136251
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bbende commented on a change in pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#discussion_r487063820
##
File path: nifi-mock/pom.xml
##
@@ -58,6 +58,11 @@
nifi-data-provenance-utils
1.13.0-SNAPSHOT
+
+
patricker edited a comment on pull request #2231:
URL: https://github.com/apache/nifi/pull/2231#issuecomment-691303281
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
lordgamez commented on a change in pull request #900:
URL: https://github.com/apache/nifi-minifi-cpp/pull/900#discussion_r486989122
##
File path: extensions/bustache/ApplyTemplate.h
##
@@ -61,7 +61,7 @@ class ApplyTemplate : public core::Processor {
class WriteCallback :
pvillard31 commented on pull request #300:
URL: https://github.com/apache/nifi-registry/pull/300#issuecomment-691144411
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pvillard31 closed pull request #298:
URL: https://github.com/apache/nifi-registry/pull/298
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
adamdebreceni commented on a change in pull request #900:
URL: https://github.com/apache/nifi-minifi-cpp/pull/900#discussion_r486855212
##
File path: extensions/bustache/ApplyTemplate.h
##
@@ -61,7 +61,7 @@ class ApplyTemplate : public core::Processor {
class WriteCallback
pvillard31 commented on pull request #147:
URL: https://github.com/apache/nifi-registry/pull/147#issuecomment-691204060
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pvillard31 commented on pull request #295:
URL: https://github.com/apache/nifi-registry/pull/295#issuecomment-691201938
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pvillard31 closed pull request #300:
URL: https://github.com/apache/nifi-registry/pull/300
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
naddym commented on a change in pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#discussion_r487080018
##
File path:
pvillard31 closed pull request #295:
URL: https://github.com/apache/nifi-registry/pull/295
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
szaszm commented on a change in pull request #837:
URL: https://github.com/apache/nifi-minifi-cpp/pull/837#discussion_r487110101
##
File path: cmake/BundledSpdlog.cmake
##
@@ -0,0 +1,70 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
pvillard31 commented on pull request #298:
URL: https://github.com/apache/nifi-registry/pull/298#issuecomment-691148453
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
mattyb149 closed pull request #4520:
URL: https://github.com/apache/nifi/pull/4520
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
mattyb149 commented on a change in pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#discussion_r487072327
##
File path:
naddym commented on pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#issuecomment-691219583
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use
kevdoran closed pull request #301:
URL: https://github.com/apache/nifi-registry/pull/301
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go
pvillard31 commented on pull request #2997:
URL: https://github.com/apache/nifi/pull/2997#issuecomment-690998588
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
asfgit closed pull request #4521:
URL: https://github.com/apache/nifi/pull/4521
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #4518:
URL: https://github.com/apache/nifi/pull/4518
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
thenatog commented on pull request #4525:
URL: https://github.com/apache/nifi/pull/4525#issuecomment-691315601
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bbende commented on pull request #296:
URL: https://github.com/apache/nifi-registry/pull/296#issuecomment-691097051
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
kevdoran commented on pull request #4510:
URL: https://github.com/apache/nifi/pull/4510#issuecomment-691138605
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mattyb149 commented on pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#issuecomment-691211449
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
wangwentao commented on pull request #2997:
URL: https://github.com/apache/nifi/pull/2997#issuecomment-690988265
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
pvillard31 commented on pull request #296:
URL: https://github.com/apache/nifi-registry/pull/296#issuecomment-691457645
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
patricker commented on pull request #2231:
URL: https://github.com/apache/nifi/pull/2231#issuecomment-691267480
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mattyb149 commented on pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#issuecomment-69142
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
szaszm commented on a change in pull request #900:
URL: https://github.com/apache/nifi-minifi-cpp/pull/900#discussion_r486988154
##
File path: extensions/bustache/ApplyTemplate.h
##
@@ -61,7 +61,7 @@ class ApplyTemplate : public core::Processor {
class WriteCallback :
pvillard31 commented on pull request #4521:
URL: https://github.com/apache/nifi/pull/4521#issuecomment-691136251
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
turcsanyip commented on pull request #4464:
URL: https://github.com/apache/nifi/pull/4464#issuecomment-691150833
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
mattyb149 commented on a change in pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#discussion_r487099612
##
File path: nifi-mock/pom.xml
##
@@ -58,6 +58,11 @@
nifi-data-provenance-utils
1.13.0-SNAPSHOT
+
+
arpadboda closed pull request #904:
URL: https://github.com/apache/nifi-minifi-cpp/pull/904
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
gadLinux commented on pull request #4300:
URL: https://github.com/apache/nifi/pull/4300#issuecomment-691492193
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
thenatog commented on pull request #296:
URL: https://github.com/apache/nifi-registry/pull/296#issuecomment-691313090
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pvillard31 commented on pull request #4518:
URL: https://github.com/apache/nifi/pull/4518#issuecomment-691142574
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
scottyaslan commented on pull request #4524:
URL: https://github.com/apache/nifi/pull/4524#issuecomment-691286522
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub
bbende commented on a change in pull request #4519:
URL: https://github.com/apache/nifi/pull/4519#discussion_r487063820
##
File path: nifi-mock/pom.xml
##
@@ -58,6 +58,11 @@
nifi-data-provenance-utils
1.13.0-SNAPSHOT
+
+
lordgamez commented on a change in pull request #900:
URL: https://github.com/apache/nifi-minifi-cpp/pull/900#discussion_r486989122
##
File path: extensions/bustache/ApplyTemplate.h
##
@@ -61,7 +61,7 @@ class ApplyTemplate : public core::Processor {
class WriteCallback :
patricker edited a comment on pull request #2231:
URL: https://github.com/apache/nifi/pull/2231#issuecomment-691303281
This is an automated message from the Apache Git Service.
To respond to the message, please log on to
pvillard31 commented on pull request #300:
URL: https://github.com/apache/nifi-registry/pull/300#issuecomment-691144411
LGTM, merged to main, thanks @bbende
This is an automated message from the Apache Git Service.
To
mattyb149 commented on a change in pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#discussion_r487072327
##
File path:
pvillard31 closed pull request #298:
URL: https://github.com/apache/nifi-registry/pull/298
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
adamdebreceni commented on a change in pull request #900:
URL: https://github.com/apache/nifi-minifi-cpp/pull/900#discussion_r486855212
##
File path: extensions/bustache/ApplyTemplate.h
##
@@ -61,7 +61,7 @@ class ApplyTemplate : public core::Processor {
class WriteCallback
pvillard31 commented on pull request #147:
URL: https://github.com/apache/nifi-registry/pull/147#issuecomment-691204060
Hey @kotarot - I know this is an old one but do you mind rebasing it? happy
to review and merge it.
pvillard31 commented on pull request #295:
URL: https://github.com/apache/nifi-registry/pull/295#issuecomment-691201938
Tested against a Github repository, LGTM, thanks @bbende, this is merged to
main
This is an automated
mattyb149 closed pull request #4520:
URL: https://github.com/apache/nifi/pull/4520
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to
pvillard31 closed pull request #300:
URL: https://github.com/apache/nifi-registry/pull/300
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
naddym commented on a change in pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#discussion_r487080018
##
File path:
pvillard31 closed pull request #295:
URL: https://github.com/apache/nifi-registry/pull/295
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above
szaszm commented on a change in pull request #837:
URL: https://github.com/apache/nifi-minifi-cpp/pull/837#discussion_r487110101
##
File path: cmake/BundledSpdlog.cmake
##
@@ -0,0 +1,70 @@
+# Licensed to the Apache Software Foundation (ASF) under one
+# or more contributor
pvillard31 commented on pull request #298:
URL: https://github.com/apache/nifi-registry/pull/298#issuecomment-691148453
Code change LGTM, merged to main, thanks @bbende
This is an automated message from the Apache Git
naddym commented on pull request #4520:
URL: https://github.com/apache/nifi/pull/4520#issuecomment-691219583
Thanks @mattyb149 for the review and the merge.
This is an automated message from the Apache Git Service.
To
kevdoran closed pull request #301:
URL: https://github.com/apache/nifi-registry/pull/301
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to
pvillard31 commented on pull request #2997:
URL: https://github.com/apache/nifi/pull/2997#issuecomment-690998588
Is it possible to rebase against the main branch (note that we don't use the
master branch anymore) and squash all of your commits into a single one?
asfgit closed pull request #4521:
URL: https://github.com/apache/nifi/pull/4521
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
asfgit closed pull request #4518:
URL: https://github.com/apache/nifi/pull/4518
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the
thenatog commented on pull request #4525:
URL: https://github.com/apache/nifi/pull/4525#issuecomment-691315601
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and
bbende commented on pull request #296:
URL: https://github.com/apache/nifi-registry/pull/296#issuecomment-691097051
Updates look good, still two remaining comments...
1) The default nifi-registry.properties should be updated to include the
OIDC properties
kevdoran commented on pull request #4510:
URL: https://github.com/apache/nifi/pull/4510#issuecomment-691138605
Thanks @simonbence! At a glance, looks very well thought out and designed.
Will review...
This is an automated
thenatog commented on pull request #4525:
URL: https://github.com/apache/nifi/pull/4525#issuecomment-691516380
Tested with a PropertiesFileLookupService and an XMLFileLookupService, looks
good. Contrib check + tests all passed.
+1
gadLinux commented on pull request #4300:
URL: https://github.com/apache/nifi/pull/4300#issuecomment-691492193
I rebased this branch, maybe we should decide what to do...
This is an automated message from the Apache Git
pvillard31 commented on pull request #296:
URL: https://github.com/apache/nifi-registry/pull/296#issuecomment-691457645
Fixing the build issue in #303.
This is an automated message from the Apache Git Service.
To respond to
pvillard31 opened a new pull request #303:
URL: https://github.com/apache/nifi-registry/pull/303
Thank you for submitting a contribution to Apache NiFi Registry.
Please provide a short description of the PR here:
Description of PR
Fixing the build issue after I
[
https://issues.apache.org/jira/browse/NIFIREG-346?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Pierre Villard reopened NIFIREG-346:
Assignee: Pierre Villard (was: Bryan Bende)
Reopening to fix the build issue following
96 matches
Mail list logo
