[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #839: MINIFICPP-1279 - Optimize for size + refactor

2020-09-21 Thread GitBox
arpadboda commented on a change in pull request #839: URL: https://github.com/apache/nifi-minifi-cpp/pull/839#discussion_r492043884 ## File path: libminifi/include/utils/FlatMap.h ## @@ -0,0 +1,211 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi] alopresto merged pull request #4536: NIFI-7816: Correct documentation example for urlEncode function in Ex…

2020-09-21 Thread GitBox
alopresto merged pull request #4536: URL: https://github.com/apache/nifi/pull/4536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] jfrazee closed pull request #4535: NIFI-7794 Adding a property to PutAzureStorageBlob to determine whether to check the existence of a container and create it if necessary

2020-09-21 Thread GitBox
jfrazee closed pull request #4535: URL: https://github.com/apache/nifi/pull/4535 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] asfgit closed pull request #4530: NIFI-5061-NiFi documentation incomplete/wrong for EL hierarchy.

2020-09-21 Thread GitBox
asfgit closed pull request #4530: URL: https://github.com/apache/nifi/pull/4530 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [nifi] mattyb149 closed pull request #3188: NIFI-5829 Create Lookup Controller Services for RecordSetWriter and R…

2020-09-21 Thread GitBox
mattyb149 closed pull request #3188: URL: https://github.com/apache/nifi/pull/3188 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] frankgh commented on a change in pull request #4538: NIFI-7817 - Fix ParquetReader instantiation error

2020-09-21 Thread GitBox
frankgh commented on a change in pull request #4538: URL: https://github.com/apache/nifi/pull/4538#discussion_r492320381 ## File path: nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/parquet/utils/ParquetUtils.java ## @@ -168,9

[GitHub] [nifi] bbende commented on a change in pull request #4538: NIFI-7817 - Fix ParquetReader instantiation error

2020-09-21 Thread GitBox
bbende commented on a change in pull request #4538: URL: https://github.com/apache/nifi/pull/4538#discussion_r492285575 ## File path: nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/parquet/utils/ParquetUtils.java ## @@ -168,9

[GitHub] [nifi] alopresto commented on a change in pull request #4536: NIFI-7816: Correct documentation example for urlEncode function in Ex…

2020-09-21 Thread GitBox
alopresto commented on a change in pull request #4536: URL: https://github.com/apache/nifi/pull/4536#discussion_r492205670 ## File path: nifi-docs/src/main/asciidoc/expression-language-guide.adoc ## @@ -1385,7 +1385,7 @@ Each of the following functions will encode a string

[GitHub] [nifi] mattyb149 commented on pull request #3188: NIFI-5829 Create Lookup Controller Services for RecordSetWriter and R…

2020-09-21 Thread GitBox
mattyb149 commented on pull request #3188: URL: https://github.com/apache/nifi/pull/3188#issuecomment-696306763 +1 LGTM, ran contrib-check and tried various lookups for readers and writers. Thanks for this new feature! Merging to main

[GitHub] [nifi] naddym commented on a change in pull request #4536: NIFI-7816: Correct documentation example for urlEncode function in Ex…

2020-09-21 Thread GitBox
naddym commented on a change in pull request #4536: URL: https://github.com/apache/nifi/pull/4536#discussion_r492214906 ## File path: nifi-docs/src/main/asciidoc/expression-language-guide.adoc ## @@ -1385,7 +1385,7 @@ Each of the following functions will encode a string

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #839: MINIFICPP-1279 - Optimize for size + refactor

2020-09-21 Thread GitBox
adamdebreceni commented on a change in pull request #839: URL: https://github.com/apache/nifi-minifi-cpp/pull/839#discussion_r492072291 ## File path: libminifi/include/utils/Id.h ## @@ -43,107 +44,41 @@ class uuid; #define UUID_TIME_STR "time" #define UUID_WINDOWS_STR

[GitHub] [nifi] pvillard31 commented on a change in pull request #4538: NIFI-7817 - Fix ParquetReader instantiation error

2020-09-21 Thread GitBox
pvillard31 commented on a change in pull request #4538: URL: https://github.com/apache/nifi/pull/4538#discussion_r492291850 ## File path: nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/parquet/utils/ParquetUtils.java ## @@ -168,9

[GitHub] [nifi] alopresto commented on pull request #4476: NIFI-7673 Standalone diagnosis mode verifies independent node

2020-09-21 Thread GitBox
alopresto commented on pull request #4476: URL: https://github.com/apache/nifi/pull/4476#issuecomment-696463326 I returned to this today; I am not done reviewing the code itself, but I rebased it against `main` and resolved the merge conflicts. The current branch is at

[GitHub] [nifi] mattyb149 commented on a change in pull request #4539: NIFI-7824:GenerateTableFetch Improvement

2020-09-21 Thread GitBox
mattyb149 commented on a change in pull request #4539: URL: https://github.com/apache/nifi/pull/4539#discussion_r492194436 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java ##

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #839: MINIFICPP-1279 - Optimize for size + refactor

2020-09-21 Thread GitBox
szaszm commented on a change in pull request #839: URL: https://github.com/apache/nifi-minifi-cpp/pull/839#discussion_r491104495 ## File path: libminifi/include/utils/Id.h ## @@ -43,107 +44,41 @@ class uuid; #define UUID_TIME_STR "time" #define UUID_WINDOWS_STR "windows" -

[GitHub] [nifi] alopresto commented on pull request #4476: NIFI-7673 Standalone diagnosis mode verifies independent node

2020-09-21 Thread GitBox
alopresto commented on pull request #4476: URL: https://github.com/apache/nifi/pull/4476#issuecomment-696463326 I returned to this today; I am not done reviewing the code itself, but I rebased it against `main` and resolved the merge conflicts. The current branch is at

[jira] [Updated] (NIFI-7794) PutAzureBlobStorage doesn't work without permission to list containers

2020-09-21 Thread Joey Frazee (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joey Frazee updated NIFI-7794: -- Resolution: Fixed Status: Resolved (was: Patch Available) > PutAzureBlobStorage doesn't work

[jira] [Updated] (NIFI-7794) PutAzureBlobStorage doesn't work without permission to list containers

2020-09-21 Thread Joey Frazee (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7794?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joey Frazee updated NIFI-7794: -- Fix Version/s: 1.13.0 > PutAzureBlobStorage doesn't work without permission to list containers >

[jira] [Commented] (NIFI-7794) PutAzureBlobStorage doesn't work without permission to list containers

2020-09-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199692#comment-17199692 ] ASF subversion and git services commented on NIFI-7794: --- Commit

[GitHub] [nifi] jfrazee closed pull request #4535: NIFI-7794 Adding a property to PutAzureStorageBlob to determine whether to check the existence of a container and create it if necessary

2020-09-21 Thread GitBox
jfrazee closed pull request #4535: URL: https://github.com/apache/nifi/pull/4535 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] frankgh commented on a change in pull request #4538: NIFI-7817 - Fix ParquetReader instantiation error

2020-09-21 Thread GitBox
frankgh commented on a change in pull request #4538: URL: https://github.com/apache/nifi/pull/4538#discussion_r492320381 ## File path: nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/parquet/utils/ParquetUtils.java ## @@ -168,9

[GitHub] [nifi] pvillard31 commented on a change in pull request #4538: NIFI-7817 - Fix ParquetReader instantiation error

2020-09-21 Thread GitBox
pvillard31 commented on a change in pull request #4538: URL: https://github.com/apache/nifi/pull/4538#discussion_r492299109 ## File path: nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/parquet/utils/ParquetUtils.java ## @@ -168,9

[GitHub] [nifi] bbende commented on a change in pull request #4538: NIFI-7817 - Fix ParquetReader instantiation error

2020-09-21 Thread GitBox
bbende commented on a change in pull request #4538: URL: https://github.com/apache/nifi/pull/4538#discussion_r492295053 ## File path: nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/parquet/utils/ParquetUtils.java ## @@ -168,9

[GitHub] [nifi] sardell opened a new pull request #4542: NIFI-7650: Add basic focus management to UI

2020-09-21 Thread GitBox
sardell opened a new pull request #4542: URL: https://github.com/apache/nifi/pull/4542 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR This PR adds some basic focus management to the NiFi

[GitHub] [nifi] pvillard31 commented on a change in pull request #4538: NIFI-7817 - Fix ParquetReader instantiation error

2020-09-21 Thread GitBox
pvillard31 commented on a change in pull request #4538: URL: https://github.com/apache/nifi/pull/4538#discussion_r492291850 ## File path: nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/parquet/utils/ParquetUtils.java ## @@ -168,9

[jira] [Updated] (NIFI-7816) Correct documentation example for urlEncode function in Expression Language Guide

2020-09-21 Thread Andy LoPresto (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy LoPresto updated NIFI-7816: Resolution: Fixed Status: Resolved (was: Patch Available) > Correct documentation example

[jira] [Updated] (NIFI-7816) Correct documentation example for urlEncode function in Expression Language Guide

2020-09-21 Thread Andy LoPresto (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7816?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Andy LoPresto updated NIFI-7816: Fix Version/s: 1.13.0 > Correct documentation example for urlEncode function in Expression Language

[jira] [Commented] (NIFI-7816) Correct documentation example for urlEncode function in Expression Language Guide

2020-09-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7816?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199611#comment-17199611 ] ASF subversion and git services commented on NIFI-7816: --- Commit

[GitHub] [nifi] alopresto merged pull request #4536: NIFI-7816: Correct documentation example for urlEncode function in Ex…

2020-09-21 Thread GitBox
alopresto merged pull request #4536: URL: https://github.com/apache/nifi/pull/4536 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[jira] [Created] (NIFI-7829) Filter type dropdown in UI is not accessible by keyboard

2020-09-21 Thread Shane Ardell (Jira)
Shane Ardell created NIFI-7829: -- Summary: Filter type dropdown in UI is not accessible by keyboard Key: NIFI-7829 URL: https://issues.apache.org/jira/browse/NIFI-7829 Project: Apache NiFi Issue

[jira] [Created] (NIFI-7828) SlickGrid has visually hidden focusable elements

2020-09-21 Thread Shane Ardell (Jira)
Shane Ardell created NIFI-7828: -- Summary: SlickGrid has visually hidden focusable elements Key: NIFI-7828 URL: https://issues.apache.org/jira/browse/NIFI-7828 Project: Apache NiFi Issue Type:

[GitHub] [nifi] bbende commented on a change in pull request #4538: NIFI-7817 - Fix ParquetReader instantiation error

2020-09-21 Thread GitBox
bbende commented on a change in pull request #4538: URL: https://github.com/apache/nifi/pull/4538#discussion_r492285575 ## File path: nifi-nar-bundles/nifi-parquet-bundle/nifi-parquet-processors/src/main/java/org/apache/nifi/parquet/utils/ParquetUtils.java ## @@ -168,9

[jira] [Updated] (NIFI-5829) Create Lookup Controller Services for RecordSetWriter and RecordReader

2020-09-21 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-5829: --- Fix Version/s: 1.13.0 Resolution: Fixed Status: Resolved (was: Patch Available) >

[jira] [Commented] (NIFI-5829) Create Lookup Controller Services for RecordSetWriter and RecordReader

2020-09-21 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-5829?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17199598#comment-17199598 ] ASF subversion and git services commented on NIFI-5829: --- Commit

[GitHub] [nifi] mattyb149 commented on pull request #3188: NIFI-5829 Create Lookup Controller Services for RecordSetWriter and R…

2020-09-21 Thread GitBox
mattyb149 commented on pull request #3188: URL: https://github.com/apache/nifi/pull/3188#issuecomment-696306763 +1 LGTM, ran contrib-check and tried various lookups for readers and writers. Thanks for this new feature! Merging to main

[GitHub] [nifi] mattyb149 closed pull request #3188: NIFI-5829 Create Lookup Controller Services for RecordSetWriter and R…

2020-09-21 Thread GitBox
mattyb149 closed pull request #3188: URL: https://github.com/apache/nifi/pull/3188 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to

[GitHub] [nifi] naddym commented on a change in pull request #4536: NIFI-7816: Correct documentation example for urlEncode function in Ex…

2020-09-21 Thread GitBox
naddym commented on a change in pull request #4536: URL: https://github.com/apache/nifi/pull/4536#discussion_r492214906 ## File path: nifi-docs/src/main/asciidoc/expression-language-guide.adoc ## @@ -1385,7 +1385,7 @@ Each of the following functions will encode a string

[jira] [Updated] (NIFI-7827) PutS3Object multipart state directory should be configurable

2020-09-21 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7827?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard updated NIFI-7827: - Status: Patch Available (was: Open) > PutS3Object multipart state directory should be

[GitHub] [nifi] pvillard31 opened a new pull request #4541: NIFI-7827 - PutS3Object - configuration of the multipart temp dir

2020-09-21 Thread GitBox
pvillard31 opened a new pull request #4541: URL: https://github.com/apache/nifi/pull/4541 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR _Enables X functionality; fixes bug NIFI-._

[jira] [Updated] (NIFI-7825) Support native library loading via absolute path

2020-09-21 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7825?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi updated NIFI-7825: -- Status: Patch Available (was: Open) > Support native library loading via absolute path >

[GitHub] [nifi] turcsanyip opened a new pull request #4540: NIFI-7825: Support native library loading via absolute path

2020-09-21 Thread GitBox
turcsanyip opened a new pull request #4540: URL: https://github.com/apache/nifi/pull/4540 Use an AspectJ aspect and agent to intercept the load native library calls at runtime, copy the native library file to temp folder and proceed with the newly created file in order to provide

[GitHub] [nifi] alopresto commented on a change in pull request #4536: NIFI-7816: Correct documentation example for urlEncode function in Ex…

2020-09-21 Thread GitBox
alopresto commented on a change in pull request #4536: URL: https://github.com/apache/nifi/pull/4536#discussion_r492205670 ## File path: nifi-docs/src/main/asciidoc/expression-language-guide.adoc ## @@ -1385,7 +1385,7 @@ Each of the following functions will encode a string

[GitHub] [nifi] mattyb149 commented on a change in pull request #4539: NIFI-7824:GenerateTableFetch Improvement

2020-09-21 Thread GitBox
mattyb149 commented on a change in pull request #4539: URL: https://github.com/apache/nifi/pull/4539#discussion_r492195079 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java ##

[GitHub] [nifi] mattyb149 commented on a change in pull request #4539: NIFI-7824:GenerateTableFetch Improvement

2020-09-21 Thread GitBox
mattyb149 commented on a change in pull request #4539: URL: https://github.com/apache/nifi/pull/4539#discussion_r492194436 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/GenerateTableFetch.java ##

[jira] [Assigned] (NIFI-7584) LOG OUT button does not work when OpenID Connect is used for authentication

2020-09-21 Thread M Tien (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7584?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] M Tien reassigned NIFI-7584: Assignee: M Tien (was: Nathan Gough) > LOG OUT button does not work when OpenID Connect is used for

[jira] [Created] (NIFI-7827) PutS3Object multipart state directory should be configurable

2020-09-21 Thread Pierre Villard (Jira)
Pierre Villard created NIFI-7827: Summary: PutS3Object multipart state directory should be configurable Key: NIFI-7827 URL: https://issues.apache.org/jira/browse/NIFI-7827 Project: Apache NiFi

[jira] [Created] (NIFI-7826) Embedded NiFi documentation import external resources

2020-09-21 Thread Pierre Villard (Jira)
Pierre Villard created NIFI-7826: Summary: Embedded NiFi documentation import external resources Key: NIFI-7826 URL: https://issues.apache.org/jira/browse/NIFI-7826 Project: Apache NiFi

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #839: MINIFICPP-1279 - Optimize for size + refactor

2020-09-21 Thread GitBox
adamdebreceni commented on a change in pull request #839: URL: https://github.com/apache/nifi-minifi-cpp/pull/839#discussion_r492161123 ## File path: libminifi/include/utils/FlatMap.h ## @@ -0,0 +1,211 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[jira] [Updated] (NIFI-7824) GenerateTableFetch Improvement

2020-09-21 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-7824?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess updated NIFI-7824: --- Status: Patch Available (was: Open) > GenerateTableFetch Improvement >

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #839: MINIFICPP-1279 - Optimize for size + refactor

2020-09-21 Thread GitBox
adamdebreceni commented on a change in pull request #839: URL: https://github.com/apache/nifi-minifi-cpp/pull/839#discussion_r492161123 ## File path: libminifi/include/utils/FlatMap.h ## @@ -0,0 +1,211 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #839: MINIFICPP-1279 - Optimize for size + refactor

2020-09-21 Thread GitBox
adamdebreceni commented on a change in pull request #839: URL: https://github.com/apache/nifi-minifi-cpp/pull/839#discussion_r492158478 ## File path: libminifi/include/utils/FlatMap.h ## @@ -0,0 +1,211 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #839: MINIFICPP-1279 - Optimize for size + refactor

2020-09-21 Thread GitBox
szaszm commented on a change in pull request #839: URL: https://github.com/apache/nifi-minifi-cpp/pull/839#discussion_r492154686 ## File path: libminifi/include/utils/FlatMap.h ## @@ -0,0 +1,211 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #839: MINIFICPP-1279 - Optimize for size + refactor

2020-09-21 Thread GitBox
szaszm commented on a change in pull request #839: URL: https://github.com/apache/nifi-minifi-cpp/pull/839#discussion_r492150716 ## File path: libminifi/include/utils/FlatMap.h ## @@ -0,0 +1,211 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or more

[jira] [Created] (NIFI-7825) Support native library loading via absolute path

2020-09-21 Thread Peter Turcsanyi (Jira)
Peter Turcsanyi created NIFI-7825: - Summary: Support native library loading via absolute path Key: NIFI-7825 URL: https://issues.apache.org/jira/browse/NIFI-7825 Project: Apache NiFi Issue

[jira] [Created] (MINIFICPP-1377) Add build number parameter for linux distribution builds

2020-09-21 Thread Gabor Gyimesi (Jira)
Gabor Gyimesi created MINIFICPP-1377: Summary: Add build number parameter for linux distribution builds Key: MINIFICPP-1377 URL: https://issues.apache.org/jira/browse/MINIFICPP-1377 Project:

[jira] [Created] (MINIFICPP-1376) Create PutS3Object processor

2020-09-21 Thread Gabor Gyimesi (Jira)
Gabor Gyimesi created MINIFICPP-1376: Summary: Create PutS3Object processor Key: MINIFICPP-1376 URL: https://issues.apache.org/jira/browse/MINIFICPP-1376 Project: Apache NiFi MiNiFi C++

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #839: MINIFICPP-1279 - Optimize for size + refactor

2020-09-21 Thread GitBox
adamdebreceni commented on a change in pull request #839: URL: https://github.com/apache/nifi-minifi-cpp/pull/839#discussion_r492112318 ## File path: libminifi/include/utils/FlatMap.h ## @@ -0,0 +1,211 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #839: MINIFICPP-1279 - Optimize for size + refactor

2020-09-21 Thread GitBox
adamdebreceni commented on a change in pull request #839: URL: https://github.com/apache/nifi-minifi-cpp/pull/839#discussion_r492072291 ## File path: libminifi/include/utils/Id.h ## @@ -43,107 +44,41 @@ class uuid; #define UUID_TIME_STR "time" #define UUID_WINDOWS_STR

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #839: MINIFICPP-1279 - Optimize for size + refactor

2020-09-21 Thread GitBox
adamdebreceni commented on a change in pull request #839: URL: https://github.com/apache/nifi-minifi-cpp/pull/839#discussion_r492072291 ## File path: libminifi/include/utils/Id.h ## @@ -43,107 +44,41 @@ class uuid; #define UUID_TIME_STR "time" #define UUID_WINDOWS_STR

[GitHub] [nifi-minifi-cpp] arpadboda commented on a change in pull request #839: MINIFICPP-1279 - Optimize for size + refactor

2020-09-21 Thread GitBox
arpadboda commented on a change in pull request #839: URL: https://github.com/apache/nifi-minifi-cpp/pull/839#discussion_r492043884 ## File path: libminifi/include/utils/FlatMap.h ## @@ -0,0 +1,211 @@ +/** + * + * Licensed to the Apache Software Foundation (ASF) under one or

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #839: MINIFICPP-1279 - Optimize for size + refactor

2020-09-21 Thread GitBox
szaszm commented on a change in pull request #839: URL: https://github.com/apache/nifi-minifi-cpp/pull/839#discussion_r491104495 ## File path: libminifi/include/utils/Id.h ## @@ -43,107 +44,41 @@ class uuid; #define UUID_TIME_STR "time" #define UUID_WINDOWS_STR "windows" -