[jira] [Commented] (NIFI-8435) PutKudu 1.13.2 Memory Leak

2021-05-19 Thread Josef Zahner (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17348073#comment-17348073 ] Josef Zahner commented on NIFI-8435: Thanks [~pvillard], did you do some tests to verify your change?

[jira] [Created] (NIFI-8619) Allow direct access to individual cluster nodes' UI behind proxy and ensure writing & loading of valid flow.xml.gz

2021-05-19 Thread Phu-Thien Tran (Jira)
Phu-Thien Tran created NIFI-8619: Summary: Allow direct access to individual cluster nodes' UI behind proxy and ensure writing & loading of valid flow.xml.gz Key: NIFI-8619 URL:

[GitHub] [nifi] github-actions[bot] closed pull request #4554: NIFI-7842 Return Lists when multiple records are returned to the restlookupservice

2021-05-19 Thread GitBox
github-actions[bot] closed pull request #4554: URL: https://github.com/apache/nifi/pull/4554 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [nifi] github-actions[bot] closed pull request #4723: NIFI-8084: add keyboard functionality and aria labels to checkboxes

2021-05-19 Thread GitBox
github-actions[bot] closed pull request #4723: URL: https://github.com/apache/nifi/pull/4723 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Resolved] (NIFI-8325) Rework SNMP processors

2021-05-19 Thread Peter Turcsanyi (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Peter Turcsanyi resolved NIFI-8325. --- Fix Version/s: 1.14.0 Resolution: Fixed > Rework SNMP processors >

[jira] [Commented] (NIFI-8325) Rework SNMP processors

2021-05-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8325?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347875#comment-17347875 ] ASF subversion and git services commented on NIFI-8325: --- Commit

[GitHub] [nifi] asfgit closed pull request #5028: NIFI-8325: Complete SNMP refactor: SNMP GET and SET processors rework, unit tests added

2021-05-19 Thread GitBox
asfgit closed pull request #5028: URL: https://github.com/apache/nifi/pull/5028 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[jira] [Resolved] (NIFI-8435) PutKudu 1.13.2 Memory Leak

2021-05-19 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8435?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-8435. -- Fix Version/s: 1.14.0 Resolution: Fixed We believe there is no memory leak however there

[jira] [Commented] (NIFI-8435) PutKudu 1.13.2 Memory Leak

2021-05-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8435?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347839#comment-17347839 ] ASF subversion and git services commented on NIFI-8435: --- Commit

[GitHub] [nifi] asfgit closed pull request #5020: NIFI-8435 Added Kudu Client Worker Count property

2021-05-19 Thread GitBox
asfgit closed pull request #5020: URL: https://github.com/apache/nifi/pull/5020 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] markap14 commented on pull request #5080: NIFI-8609: Added unit test that is ignored so that it can be manually…

2021-05-19 Thread GitBox
markap14 commented on pull request #5080: URL: https://github.com/apache/nifi/pull/5080#issuecomment-844405144 Thanks for the review @gresockj . Not sure that we really need to encourage developers to use it, to be honest. I created the unit test to verify that the changes that I was

[jira] [Updated] (NIFI-8618) Allow stateless NiFi to reference environment variables as parameters

2021-05-19 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8618?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-8618: - Assignee: Mark Payne Status: Patch Available (was: Open) > Allow stateless NiFi to reference

[jira] [Updated] (NIFI-8617) Move nifi-stateless to top-level and create assembly

2021-05-19 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8617?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-8617: - Status: Patch Available (was: Open) > Move nifi-stateless to top-level and create assembly >

[GitHub] [nifi] markap14 opened a new pull request #5087: NIFI-8617, NIFI-8618: Refactored stateless nifi to be a top-level component, created stateless assembly

2021-05-19 Thread GitBox
markap14 opened a new pull request #5087: URL: https://github.com/apache/nifi/pull/5087 Also updated to make use of environment variables. Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of

[jira] [Created] (NIFI-8618) Allow stateless NiFi to reference environment variables as parameters

2021-05-19 Thread Mark Payne (Jira)
Mark Payne created NIFI-8618: Summary: Allow stateless NiFi to reference environment variables as parameters Key: NIFI-8618 URL: https://issues.apache.org/jira/browse/NIFI-8618 Project: Apache NiFi

[jira] [Updated] (NIFI-8466) Offloading the Single Node load balancing target causes ignored backpressure

2021-05-19 Thread Nathan Gough (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Nathan Gough updated NIFI-8466: --- Fix Version/s: 1.14.0 Resolution: Fixed Status: Resolved (was: Patch Available) >

[jira] [Commented] (NIFI-8466) Offloading the Single Node load balancing target causes ignored backpressure

2021-05-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8466?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347821#comment-17347821 ] ASF subversion and git services commented on NIFI-8466: --- Commit

[GitHub] [nifi] thenatog closed pull request #5025: NIFI-8466: Resolving offload bug with Single Node load balanced queues

2021-05-19 Thread GitBox
thenatog closed pull request #5025: URL: https://github.com/apache/nifi/pull/5025 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] thenatog commented on pull request #5025: NIFI-8466: Resolving offload bug with Single Node load balanced queues

2021-05-19 Thread GitBox
thenatog commented on pull request #5025: URL: https://github.com/apache/nifi/pull/5025#issuecomment-844342861 +1 will merge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific

[GitHub] [nifi] thenatog edited a comment on pull request #5025: NIFI-8466: Resolving offload bug with Single Node load balanced queues

2021-05-19 Thread GitBox
thenatog edited a comment on pull request #5025: URL: https://github.com/apache/nifi/pull/5025#issuecomment-844332373 Tested this out on a 3 node cluster without the fix, identified the issue as stated. Attached is a screenshot of what it looked like for me - files stuck in the queue, and

[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1074: MINIFICPP-1560 - Change some c2 log levels

2021-05-19 Thread GitBox
fgerlits closed pull request #1074: URL: https://github.com/apache/nifi-minifi-cpp/pull/1074 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [nifi] thenatog commented on pull request #5025: NIFI-8466: Resolving offload bug with Single Node load balanced queues

2021-05-19 Thread GitBox
thenatog commented on pull request #5025: URL: https://github.com/apache/nifi/pull/5025#issuecomment-844332373 Tested this out on a 3 node cluster without the fix, identified the issue as stated. Attached is a screenshot of what it looked like for me - files stuck in the queue, and the

[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1072: MINIFICPP-1482 - Fix C2RequestClassTest transient failure

2021-05-19 Thread GitBox
fgerlits closed pull request #1072: URL: https://github.com/apache/nifi-minifi-cpp/pull/1072 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1063: MINIFICPP-1203 - Linter reported redundand blank lines

2021-05-19 Thread GitBox
fgerlits closed pull request #1063: URL: https://github.com/apache/nifi-minifi-cpp/pull/1063 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #1055: MINIFICPP-1454 Reduce duplication of CMake parameters in docker build

2021-05-19 Thread GitBox
fgerlits closed pull request #1055: URL: https://github.com/apache/nifi-minifi-cpp/pull/1055 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[jira] [Created] (NIFI-8617) Move nifi-stateless to top-level and create assembly

2021-05-19 Thread Mark Payne (Jira)
Mark Payne created NIFI-8617: Summary: Move nifi-stateless to top-level and create assembly Key: NIFI-8617 URL: https://issues.apache.org/jira/browse/NIFI-8617 Project: Apache NiFi Issue Type:

[GitHub] [nifi] naddym commented on a change in pull request #5083: NIFI-8613: Improve FlattenJson Processor

2021-05-19 Thread GitBox
naddym commented on a change in pull request #5083: URL: https://github.com/apache/nifi/pull/5083#discussion_r635419567 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FlattenJson.java ## @@

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5083: NIFI-8613: Improve FlattenJson Processor

2021-05-19 Thread GitBox
exceptionfactory commented on a change in pull request #5083: URL: https://github.com/apache/nifi/pull/5083#discussion_r635391629 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FlattenJson.java ##

[jira] [Assigned] (MINIFICPP-1518) Migrate integration tests (without secutity protocol settings) for ConsumeKafka to behave

2021-05-19 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1518?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi reassigned MINIFICPP-1518: Assignee: Gabor Gyimesi (was: Adam Hunyadi) > Migrate integration tests

[jira] [Updated] (MINIFICPP-1369) Implement ConsumeKafka processor

2021-05-19 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi updated MINIFICPP-1369: - Description: Implement ConsumeKafka processor to support consuming Kafka topic(s).

[jira] [Assigned] (MINIFICPP-1369) Implement ConsumeKafka processor

2021-05-19 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1369?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi reassigned MINIFICPP-1369: Assignee: Gabor Gyimesi (was: Adam Hunyadi) > Implement ConsumeKafka

[jira] [Assigned] (MINIFICPP-1373) Implement and test a simplified ConsumeKafka processor without security protocols

2021-05-19 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi reassigned MINIFICPP-1373: Assignee: Gabor Gyimesi (was: Adam Hunyadi) > Implement and test a

[jira] [Reopened] (MINIFICPP-1373) Implement and test a simplified ConsumeKafka processor without security protocols

2021-05-19 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi reopened MINIFICPP-1373: -- > Implement and test a simplified ConsumeKafka processor without security > protocols

[jira] [Assigned] (MINIFICPP-1374) Implement security protocol support for ConsumeKafka

2021-05-19 Thread Gabor Gyimesi (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1374?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Gabor Gyimesi reassigned MINIFICPP-1374: Assignee: Gabor Gyimesi (was: Adam Hunyadi) > Implement security protocol

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

2021-05-19 Thread GitBox
szaszm commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635316167 ## File path: libminifi/src/Configure.cpp ## @@ -37,6 +37,10 @@ bool Configure::get(const std::string& key, std::string& value) const { bool

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

2021-05-19 Thread GitBox
adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635310034 ## File path: libminifi/include/core/logging/Logger.h ## @@ -68,13 +69,32 @@ inline T conditional_conversion(T t) { } template -inline

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

2021-05-19 Thread GitBox
adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635306229 ## File path: libminifi/src/Configure.cpp ## @@ -37,6 +37,10 @@ bool Configure::get(const std::string& key, std::string& value) const {

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

2021-05-19 Thread GitBox
szaszm commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635299532 ## File path: libminifi/include/core/logging/Logger.h ## @@ -68,13 +69,32 @@ inline T conditional_conversion(T t) { } template -inline

[jira] [Updated] (MINIFICPP-304) Release MiNiFI C++ Version 0.3.0

2021-05-19 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-304?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda updated MINIFICPP-304: - Labels: release (was: ) > Release MiNiFI C++ Version 0.3.0 >

[jira] [Updated] (MINIFICPP-379) Release 0.4.0

2021-05-19 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-379?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda updated MINIFICPP-379: - Labels: release (was: ) > Release 0.4.0 > - > > Key:

[jira] [Updated] (MINIFICPP-172) Release MiNiFi C++ 0.2.0

2021-05-19 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-172?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda updated MINIFICPP-172: - Labels: release (was: ) > Release MiNiFi C++ 0.2.0 > > >

[jira] [Updated] (MINIFICPP-230) Perform MiNiFi C++ 0.1.0 release

2021-05-19 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-230?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda updated MINIFICPP-230: - Labels: release (was: ) > Perform MiNiFi C++ 0.1.0 release >

[jira] [Updated] (MINIFICPP-519) Release MiNiFi CPP 0.5.0

2021-05-19 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-519?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda updated MINIFICPP-519: - Labels: release (was: ) > Release MiNiFi CPP 0.5.0 > > >

[jira] [Updated] (MINIFICPP-770) Release 0.6.0

2021-05-19 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-770?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda updated MINIFICPP-770: - Labels: release (was: ) > Release 0.6.0 > - > > Key:

[jira] [Updated] (MINIFICPP-1463) Release 0.9.0

2021-05-19 Thread Arpad Boda (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1463?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Arpad Boda updated MINIFICPP-1463: -- Labels: release (was: ) > Release 0.9.0 > - > > Key:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

2021-05-19 Thread GitBox
szaszm commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635293708 ## File path: libminifi/src/Configure.cpp ## @@ -37,6 +37,10 @@ bool Configure::get(const std::string& key, std::string& value) const { bool

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on pull request #1072: MINIFICPP-1482 - Fix C2RequestClassTest transient failure

2021-05-19 Thread GitBox
adamdebreceni commented on pull request #1072: URL: https://github.com/apache/nifi-minifi-cpp/pull/1072#issuecomment-844137446 > What was the root cause here? Is the test still valid when the json parsing has failed, or is it an indication of another issue? the civet handler

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

2021-05-19 Thread GitBox
adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635265649 ## File path: libminifi/include/utils/Enum.h ## @@ -60,6 +63,22 @@ namespace utils { #define FOR_EACH_8(fn, delim, _1, _2, _3, _4, _5, _6,

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

2021-05-19 Thread GitBox
adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635264523 ## File path: libminifi/src/c2/HeartbeatJsonSerializer.cpp ## @@ -0,0 +1,333 @@ +/** + * Licensed to the Apache Software Foundation (ASF)

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

2021-05-19 Thread GitBox
adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635264297 ## File path: libminifi/src/Configure.cpp ## @@ -37,6 +37,10 @@ bool Configure::get(const std::string& key, std::string& value) const {

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1072: MINIFICPP-1482 - Fix C2RequestClassTest transient failure

2021-05-19 Thread GitBox
szaszm commented on pull request #1072: URL: https://github.com/apache/nifi-minifi-cpp/pull/1072#issuecomment-844129936 What was the root cause here? Is the test still valid when the json parsing has failed, or is it an indication of another issue? -- This is an automated message from

[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

2021-05-19 Thread GitBox
adamdebreceni commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r635261808 ## File path: libminifi/include/core/logging/Logger.h ## @@ -68,13 +69,32 @@ inline T conditional_conversion(T t) { } template -inline

[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1040: MINIFICPP-1329- Fix implementation and usages of string to bool

2021-05-19 Thread GitBox
szaszm closed pull request #1040: URL: https://github.com/apache/nifi-minifi-cpp/pull/1040 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [nifi] naddym commented on a change in pull request #5083: NIFI-8613: Improve FlattenJson Processor

2021-05-19 Thread GitBox
naddym commented on a change in pull request #5083: URL: https://github.com/apache/nifi/pull/5083#discussion_r635235984 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FlattenJson.java ## @@

[GitHub] [nifi] naddym commented on a change in pull request #5083: NIFI-8613: Improve FlattenJson Processor

2021-05-19 Thread GitBox
naddym commented on a change in pull request #5083: URL: https://github.com/apache/nifi/pull/5083#discussion_r635235720 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FlattenJson.java ## @@

[GitHub] [nifi] naddym commented on pull request #5083: NIFI-8613: Improve FlattenJson Processor

2021-05-19 Thread GitBox
naddym commented on pull request #5083: URL: https://github.com/apache/nifi/pull/5083#issuecomment-844102150 Thank you @exceptionfactory for the detailed review. All suggestions pointed out looks good, will work on changing them.. -- This is an automated message from the Apache Git

[GitHub] [nifi-minifi-cpp] fgerlits commented on pull request #851: MINIFICPP-1203 - Remove obsolate distinction between headers and sources when running linter checks

2021-05-19 Thread GitBox
fgerlits commented on pull request #851: URL: https://github.com/apache/nifi-minifi-cpp/pull/851#issuecomment-844099438 Closing this as https://github.com/apache/nifi-minifi-cpp/pull/1069 will be merged instead. -- This is an automated message from the Apache Git Service. To respond to

[GitHub] [nifi-minifi-cpp] fgerlits closed pull request #851: MINIFICPP-1203 - Remove obsolate distinction between headers and sources when running linter checks

2021-05-19 Thread GitBox
fgerlits closed pull request #851: URL: https://github.com/apache/nifi-minifi-cpp/pull/851 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

2021-05-19 Thread GitBox
szaszm commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r633704910 ## File path: libminifi/include/core/logging/Logger.h ## @@ -68,13 +69,32 @@ inline T conditional_conversion(T t) { } template -inline

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

2021-05-19 Thread GitBox
szaszm commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r633702768 ## File path: libminifi/include/core/logging/Logger.h ## @@ -68,13 +69,32 @@ inline T conditional_conversion(T t) { } template -inline

[GitHub] [nifi] JonathanKessler commented on pull request #4780: NIFI-8126 Include Total Queued Duration in ConnectionStatus metrics

2021-05-19 Thread GitBox
JonathanKessler commented on pull request #4780: URL: https://github.com/apache/nifi/pull/4780#issuecomment-844082215 Happy to contribute, thank you for the guidance! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use

[GitHub] [nifi] timeabarna opened a new pull request #5086: NIFI-8522 NiFi can duplicate controller services when generating temp…

2021-05-19 Thread GitBox
timeabarna opened a new pull request #5086: URL: https://github.com/apache/nifi/pull/5086 Fix controller service duplication when generating templates https://issues.apache.org/jira/browse/NIFI-8522 Description of PR Fixing controller service duplication In

[GitHub] [nifi] exceptionfactory commented on pull request #5085: Nifi 1.13.x fix corrupt flow.xml.gz and add web context root

2021-05-19 Thread GitBox
exceptionfactory commented on pull request #5085: URL: https://github.com/apache/nifi/pull/5085#issuecomment-844076932 Thanks for your contribution @phuthientran. As noted in the checklist, all pull requests must meet several minimum criteria for consideration. In particular, a [Jira

[jira] [Commented] (NIFI-8469) Change ProcessSession so that commits are asynchronous

2021-05-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347648#comment-17347648 ] ASF subversion and git services commented on NIFI-8469: --- Commit

[jira] [Updated] (NIFI-8469) Change ProcessSession so that commits are asynchronous

2021-05-19 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-8469: - Fix Version/s: 1.14.0 Resolution: Fixed Status: Resolved (was: Patch Available) >

[jira] [Commented] (NIFI-8469) Change ProcessSession so that commits are asynchronous

2021-05-19 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8469?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17347647#comment-17347647 ] ASF subversion and git services commented on NIFI-8469: --- Commit

[GitHub] [nifi] markap14 closed pull request #5042: NIFI-8469: Updated ProcessSession to have commitAsync methods and deprecated commit; updated stateless to make use of this improvement

2021-05-19 Thread GitBox
markap14 closed pull request #5042: URL: https://github.com/apache/nifi/pull/5042 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] markap14 commented on pull request #5042: NIFI-8469: Updated ProcessSession to have commitAsync methods and deprecated commit; updated stateless to make use of this improvement

2021-05-19 Thread GitBox
markap14 commented on pull request #5042: URL: https://github.com/apache/nifi/pull/5042#issuecomment-844071657 Thanks @gresockj. I've seen no other reviews and no objections anywhere. After putting it away for a few weeks I came back and did a thorough code review myself as well. And the

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5083: NIFI-8613: Improve FlattenJson Processor

2021-05-19 Thread GitBox
exceptionfactory commented on a change in pull request #5083: URL: https://github.com/apache/nifi/pull/5083#discussion_r635195935 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/FlattenJson.java ##

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1044: MINIFICPP-1526 Add ConsumeJournald to consume systemd journal messages

2021-05-19 Thread GitBox
szaszm commented on a change in pull request #1044: URL: https://github.com/apache/nifi-minifi-cpp/pull/1044#discussion_r635062484 ## File path: CMakeLists.txt ## @@ -564,6 +560,14 @@ if (ENABLE_ALL OR ENABLE_AZURE) createExtension(AZURE-EXTENSIONS "AZURE EXTENSIONS"

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1044: MINIFICPP-1526 Add ConsumeJournald to consume systemd journal messages

2021-05-19 Thread GitBox
szaszm commented on a change in pull request #1044: URL: https://github.com/apache/nifi-minifi-cpp/pull/1044#discussion_r635058808 ## File path: CMakeLists.txt ## @@ -564,6 +560,14 @@ if (ENABLE_ALL OR ENABLE_AZURE) createExtension(AZURE-EXTENSIONS "AZURE EXTENSIONS"

[jira] [Resolved] (MINIFICPP-1562) Failing CI due to corrupted cache on Windows-2019

2021-05-19 Thread Martin Zink (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1562?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Martin Zink resolved MINIFICPP-1562. Resolution: Fixed > Failing CI due to corrupted cache on Windows-2019 >

[GitHub] [nifi-minifi-cpp] martinzink closed pull request #1075: MINIFICPP-1562: Failing CI due to corrupted cache on Windows-2019

2021-05-19 Thread GitBox
martinzink closed pull request #1075: URL: https://github.com/apache/nifi-minifi-cpp/pull/1075 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1075: MINIFICPP-1562: Failing CI due to corrupted cache on Windows-2019

2021-05-19 Thread GitBox
lordgamez commented on pull request #1075: URL: https://github.com/apache/nifi-minifi-cpp/pull/1075#issuecomment-843832937 I'm not sure it is needed to clear the cache anymore. After merging a new commit to the `main` branch the cache was updated and after rebasing my change #1073 the

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1057: MINIFICPP-1537 - Log heartbeats on demand

2021-05-19 Thread GitBox
fgerlits commented on a change in pull request #1057: URL: https://github.com/apache/nifi-minifi-cpp/pull/1057#discussion_r634979684 ## File path: libminifi/src/c2/protocols/RESTProtocol.cpp ## @@ -318,133 +178,7 @@ bool RESTProtocol::containsPayload(const C2Payload ) {