[GitHub] [nifi] timeabarna commented on a change in pull request #5115: NIFI-8642 Select the default Old Gen Memory Pool for Memory Reporting…

2021-06-02 Thread GitBox
timeabarna commented on a change in pull request #5115: URL: https://github.com/apache/nifi/pull/5115#discussion_r644503629 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java ## @@

[GitHub] [nifi] timeabarna commented on a change in pull request #5115: NIFI-8642 Select the default Old Gen Memory Pool for Memory Reporting…

2021-06-02 Thread GitBox
timeabarna commented on a change in pull request #5115: URL: https://github.com/apache/nifi/pull/5115#discussion_r644502868 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java ## @@

[GitHub] [nifi] timeabarna commented on a change in pull request #5115: NIFI-8642 Select the default Old Gen Memory Pool for Memory Reporting…

2021-06-02 Thread GitBox
timeabarna commented on a change in pull request #5115: URL: https://github.com/apache/nifi/pull/5115#discussion_r644503629 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java ## @@

[GitHub] [nifi] timeabarna commented on a change in pull request #5115: NIFI-8642 Select the default Old Gen Memory Pool for Memory Reporting…

2021-06-02 Thread GitBox
timeabarna commented on a change in pull request #5115: URL: https://github.com/apache/nifi/pull/5115#discussion_r644502868 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java ## @@

[GitHub] [nifi] timeabarna commented on a change in pull request #5115: NIFI-8642 Select the default Old Gen Memory Pool for Memory Reporting…

2021-06-02 Thread GitBox
timeabarna commented on a change in pull request #5115: URL: https://github.com/apache/nifi/pull/5115#discussion_r644502293 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java ## @@

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
exceptionfactory commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r65054 ## File path: nifi-commons/nifi-security-kms/src/main/java/org/apache/nifi/security/kms/KeyProviderFactory.java ## @@ -0,0 +1,85 @@ +/* + *

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
exceptionfactory commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r62480 ## File path: nifi-commons/nifi-security-kms/src/main/java/org/apache/nifi/security/kms/reader/StandardFileBasedKeyReader.java ## @@ -0,0 +1,115

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
exceptionfactory commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r61479 ## File path: nifi-commons/nifi-security-kms/src/main/java/org/apache/nifi/security/kms/KeyProviderFactory.java ## @@ -0,0 +1,85 @@ +/* + *

[GitHub] [nifi] exceptionfactory commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
exceptionfactory commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r60450 ## File path: nifi-docs/src/main/asciidoc/user-guide.adoc ## @@ -2922,6 +2922,34 @@

[GitHub] [nifi] andrewmlim commented on pull request #5107: NIFIREG-395 - Implemented the ability to import and export versioned …

2021-06-02 Thread GitBox
andrewmlim commented on pull request #5107: URL: https://github.com/apache/nifi/pull/5107#issuecomment-853498233 +1 LGTM Ran through same test cases I did for https://github.com/apache/nifi-registry/pull/319 including some basic authorization testing. -- This is an automated message

[jira] [Updated] (NIFI-8652) PutAzureCosmosDBRecord generates Long running task detected on processor warning and does not update 'In' process rate.

2021-06-02 Thread Seokwon Yang (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seokwon Yang updated NIFI-8652: --- Description: When we generate and insert bulk records into Azure Cosmos DB with

[jira] [Updated] (NIFI-8652) PutAzureCosmosDBRecord generates Long running task detected on processor warning and does not update 'In' process rate.

2021-06-02 Thread Seokwon Yang (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8652?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Seokwon Yang updated NIFI-8652: --- Description: When we generate and insert bulk records into Azure Cosmos DB with

[jira] [Created] (NIFI-8652) PutAzureCosmosDBRecord generates Long running task detected on processor warning and does not update 'In' process rate.

2021-06-02 Thread Seokwon Yang (Jira)
Seokwon Yang created NIFI-8652: -- Summary: PutAzureCosmosDBRecord generates Long running task detected on processor warning and does not update 'In' process rate. Key: NIFI-8652 URL:

[jira] [Updated] (NIFI-8433) Add decommission command to nifi.sh

2021-06-02 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8433?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-8433: - Issue Type: New Feature (was: Improvement) > Add decommission command to nifi.sh >

[jira] [Updated] (NIFI-8260) Process Group Import JSON file

2021-06-02 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8260?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-8260: - Issue Type: New Feature (was: Improvement) > Process Group Import JSON file >

[jira] [Updated] (NIFI-8126) Include Total Queued Duration in metrics reported via ConnectionStatus

2021-06-02 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8126?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-8126: - Issue Type: New Feature (was: Improvement) > Include Total Queued Duration in metrics reported via

[jira] [Updated] (NIFI-8188) Processors: right click / run once

2021-06-02 Thread Mark Payne (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8188?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Mark Payne updated NIFI-8188: - Issue Type: New Feature (was: Improvement) > Processors: right click / run once >

[GitHub] [nifi] Lehel44 commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r644355018 ## File path:

[GitHub] [nifi] Lehel44 commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r644353844 ## File path: nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/util/KeyStoreUtils.java ## @@ -27,23 +27,24 @@ import

[GitHub] [nifi] Lehel44 commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r644349920 ## File path: nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/kms/CryptoUtils.java ## @@ -133,43 +124,28 @@ public static boolean

[GitHub] [nifi] Lehel44 commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r644349920 ## File path: nifi-commons/nifi-security-utils/src/main/java/org/apache/nifi/security/kms/CryptoUtils.java ## @@ -133,43 +124,28 @@ public static boolean

[GitHub] [nifi] Lehel44 commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r644337507 ## File path: nifi-commons/nifi-security-kms/src/main/java/org/apache/nifi/security/kms/KeyProviderFactory.java ## @@ -0,0 +1,85 @@ +/* + * Licensed to the

[GitHub] [nifi] Lehel44 commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r644337507 ## File path: nifi-commons/nifi-security-kms/src/main/java/org/apache/nifi/security/kms/KeyProviderFactory.java ## @@ -0,0 +1,85 @@ +/* + * Licensed to the

[GitHub] [nifi] Lehel44 commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r644337507 ## File path: nifi-commons/nifi-security-kms/src/main/java/org/apache/nifi/security/kms/KeyProviderFactory.java ## @@ -0,0 +1,85 @@ +/* + * Licensed to the

[GitHub] [nifi] Lehel44 commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r644337507 ## File path: nifi-commons/nifi-security-kms/src/main/java/org/apache/nifi/security/kms/KeyProviderFactory.java ## @@ -0,0 +1,85 @@ +/* + * Licensed to the

[GitHub] [nifi] Lehel44 commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r644337507 ## File path: nifi-commons/nifi-security-kms/src/main/java/org/apache/nifi/security/kms/KeyProviderFactory.java ## @@ -0,0 +1,85 @@ +/* + * Licensed to the

[GitHub] [nifi] Lehel44 commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r644337507 ## File path: nifi-commons/nifi-security-kms/src/main/java/org/apache/nifi/security/kms/KeyProviderFactory.java ## @@ -0,0 +1,85 @@ +/* + * Licensed to the

[GitHub] [nifi] Lehel44 commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r644337507 ## File path: nifi-commons/nifi-security-kms/src/main/java/org/apache/nifi/security/kms/KeyProviderFactory.java ## @@ -0,0 +1,85 @@ +/* + * Licensed to the

[GitHub] [nifi] Lehel44 commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r644337507 ## File path: nifi-commons/nifi-security-kms/src/main/java/org/apache/nifi/security/kms/KeyProviderFactory.java ## @@ -0,0 +1,85 @@ +/* + * Licensed to the

[GitHub] [nifi] Lehel44 commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r644337507 ## File path: nifi-commons/nifi-security-kms/src/main/java/org/apache/nifi/security/kms/KeyProviderFactory.java ## @@ -0,0 +1,85 @@ +/* + * Licensed to the

[GitHub] [nifi] Lehel44 commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r644337507 ## File path: nifi-commons/nifi-security-kms/src/main/java/org/apache/nifi/security/kms/KeyProviderFactory.java ## @@ -0,0 +1,85 @@ +/* + * Licensed to the

[GitHub] [nifi] greyp9 commented on a change in pull request #5110: NIFI-8511 Added KeyStore implementation of KeyProvider

2021-06-02 Thread GitBox
greyp9 commented on a change in pull request #5110: URL: https://github.com/apache/nifi/pull/5110#discussion_r644226669 ## File path: nifi-commons/nifi-security-kms/src/main/java/org/apache/nifi/security/kms/reader/StandardFileBasedKeyReader.java ## @@ -0,0 +1,115 @@ +/* + *

[GitHub] [nifi] Lehel44 edited a comment on pull request #5038: NIFI-8498: Optional removal of fields with UpdateRecord

2021-06-02 Thread GitBox
Lehel44 edited a comment on pull request #5038: URL: https://github.com/apache/nifi/pull/5038#issuecomment-853366893 I'd like to recommend a little refactor about optionals. I think there's a lot of branching among the private methods based on optional values. My idea is to let the

[GitHub] [nifi] Lehel44 edited a comment on pull request #5038: NIFI-8498: Optional removal of fields with UpdateRecord

2021-06-02 Thread GitBox
Lehel44 edited a comment on pull request #5038: URL: https://github.com/apache/nifi/pull/5038#issuecomment-853366893 I'd like to recommend a little refactor about optionals. I think there's a lot of branching among the private methods based on optional values. My idea is to let the

[GitHub] [nifi] Lehel44 edited a comment on pull request #5038: NIFI-8498: Optional removal of fields with UpdateRecord

2021-06-02 Thread GitBox
Lehel44 edited a comment on pull request #5038: URL: https://github.com/apache/nifi/pull/5038#issuecomment-853366893 I'd like to recommend a little refactor about optionals. I think there's a lot of branching among the private methods based on optional values. My idea is to let the

[GitHub] [nifi] Lehel44 edited a comment on pull request #5038: NIFI-8498: Optional removal of fields with UpdateRecord

2021-06-02 Thread GitBox
Lehel44 edited a comment on pull request #5038: URL: https://github.com/apache/nifi/pull/5038#issuecomment-853366893 I'd like to recommend a little refactor about optionals. I think there's a lot of branching among the private methods based on optional values. My idea is to let the

[GitHub] [nifi] Lehel44 edited a comment on pull request #5038: NIFI-8498: Optional removal of fields with UpdateRecord

2021-06-02 Thread GitBox
Lehel44 edited a comment on pull request #5038: URL: https://github.com/apache/nifi/pull/5038#issuecomment-853366893 I'd like to recommend a little refactor about optionals. I think there's a lot of branching among the private methods based on optional values. My idea is to let the

[GitHub] [nifi] Lehel44 edited a comment on pull request #5038: NIFI-8498: Optional removal of fields with UpdateRecord

2021-06-02 Thread GitBox
Lehel44 edited a comment on pull request #5038: URL: https://github.com/apache/nifi/pull/5038#issuecomment-853366893 I'd like to recommend a little refactor about optionals. I think there's a lot of branching among the private methods based on optional values. My idea is to let the

[GitHub] [nifi] Lehel44 commented on pull request #5038: NIFI-8498: Optional removal of fields with UpdateRecord

2021-06-02 Thread GitBox
Lehel44 commented on pull request #5038: URL: https://github.com/apache/nifi/pull/5038#issuecomment-853366893 I'd like to recommend a little refactor about optionals. I think there's a lot of branching among the private methods based on optional values. My idea is to let the methods

[GitHub] [nifi] Lehel44 commented on a change in pull request #5038: NIFI-8498: Optional removal of fields with UpdateRecord

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5038: URL: https://github.com/apache/nifi/pull/5038#discussion_r644276237 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateRecord.java ## @@

[GitHub] [nifi] Lehel44 commented on a change in pull request #5038: NIFI-8498: Optional removal of fields with UpdateRecord

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5038: URL: https://github.com/apache/nifi/pull/5038#discussion_r644268396 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateRecord.java ## @@

[GitHub] [nifi] mtien-apache commented on pull request #5107: NIFIREG-395 - Implemented the ability to import and export versioned …

2021-06-02 Thread GitBox
mtien-apache commented on pull request #5107: URL: https://github.com/apache/nifi/pull/5107#issuecomment-853307246 @exceptionfactory @bbende @sardell @andrewmlim Would you review one more time? Opened a new PR after NiFi Registry was migrated into NiFi. There are no code changes on my end

[jira] [Updated] (NIFI-8651) Refactor SensitivePropertiesProviderFactory

2021-06-02 Thread Joseph Gresock (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8651?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Joseph Gresock updated NIFI-8651: - Description: In order to facilitate extensibility with SensitivePropertiesProviders (as in

[jira] [Created] (NIFI-8651) Refactor SensitivePropertiesProviderFactory

2021-06-02 Thread Joseph Gresock (Jira)
Joseph Gresock created NIFI-8651: Summary: Refactor SensitivePropertiesProviderFactory Key: NIFI-8651 URL: https://issues.apache.org/jira/browse/NIFI-8651 Project: Apache NiFi Issue Type:

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1089: MINIFICPP-1567 enable linter checks in extensions (part 1)

2021-06-02 Thread GitBox
martinzink commented on a change in pull request #1089: URL: https://github.com/apache/nifi-minifi-cpp/pull/1089#discussion_r644128074 ## File path: extensions/windows-event-log/wel/JSONUtils.h ## @@ -20,9 +20,10 @@ #undef RAPIDJSON_ASSERT #define RAPIDJSON_ASSERT(x) if

[jira] [Resolved] (NIFI-8471) Parameter Contexts - show referencing process groups

2021-06-02 Thread Pierre Villard (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8471?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Pierre Villard resolved NIFI-8471. -- Fix Version/s: 1.14.0 Resolution: Fixed > Parameter Contexts - show referencing process

[jira] [Commented] (NIFI-8471) Parameter Contexts - show referencing process groups

2021-06-02 Thread ASF subversion and git services (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8471?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355846#comment-17355846 ] ASF subversion and git services commented on NIFI-8471: --- Commit

[GitHub] [nifi] asfgit closed pull request #5048: NIFI-8471 Parameter Contexts - show referencing process groups

2021-06-02 Thread GitBox
asfgit closed pull request #5048: URL: https://github.com/apache/nifi/pull/5048 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please

[GitHub] [nifi] Lehel44 commented on a change in pull request #5038: NIFI-8498: Optional removal of fields with UpdateRecord

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5038: URL: https://github.com/apache/nifi/pull/5038#discussion_r644112482 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateRecord.java ## @@

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1082: MINIFICPP-1494 Allow InvokeHTTP GET requests without incoming flowfile

2021-06-02 Thread GitBox
lordgamez commented on a change in pull request #1082: URL: https://github.com/apache/nifi-minifi-cpp/pull/1082#discussion_r644112320 ## File path: extensions/http-curl/tests/HttpGetIntegrationTest.cpp ## @@ -63,78 +62,134 @@ class HttpResponder : public CivetHandler { }

[GitHub] [nifi] Lehel44 commented on a change in pull request #5038: NIFI-8498: Optional removal of fields with UpdateRecord

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5038: URL: https://github.com/apache/nifi/pull/5038#discussion_r644111513 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-processors/src/main/java/org/apache/nifi/processors/standard/UpdateRecord.java ## @@

[jira] [Updated] (NIFI-8650) Flow Analysis

2021-06-02 Thread Tamas Palfy (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Palfy updated NIFI-8650: -- Description: Add new concept: Flow analysis based on user-defined rules UNDER CONSTRUCTION Flow

[jira] [Updated] (NIFI-8650) Flow Analysis

2021-06-02 Thread Tamas Palfy (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Palfy updated NIFI-8650: -- Description: Add new concept: Flow analysis based on user-defined rules UNDER CONSTRUCTION Flow

[jira] [Assigned] (NIFI-8650) Flow Analysis

2021-06-02 Thread Tamas Palfy (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8650?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Tamas Palfy reassigned NIFI-8650: - Assignee: Tamas Palfy > Flow Analysis > - > > Key: NIFI-8650 >

[jira] [Created] (NIFI-8650) Flow Analysis

2021-06-02 Thread Tamas Palfy (Jira)
Tamas Palfy created NIFI-8650: - Summary: Flow Analysis Key: NIFI-8650 URL: https://issues.apache.org/jira/browse/NIFI-8650 Project: Apache NiFi Issue Type: New Feature Components: Core

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1089: MINIFICPP-1567 enable linter checks in extensions (part 1)

2021-06-02 Thread GitBox
martinzink commented on a change in pull request #1089: URL: https://github.com/apache/nifi-minifi-cpp/pull/1089#discussion_r644107147 ## File path: extensions/windows-event-log/TailEventLog.cpp ## @@ -19,14 +19,16 @@ */ #include "TailEventLog.h" +#include Review

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1089: MINIFICPP-1567 enable linter checks in extensions (part 1)

2021-06-02 Thread GitBox
martinzink commented on a change in pull request #1089: URL: https://github.com/apache/nifi-minifi-cpp/pull/1089#discussion_r644107147 ## File path: extensions/windows-event-log/TailEventLog.cpp ## @@ -19,14 +19,16 @@ */ #include "TailEventLog.h" +#include Review

[GitHub] [nifi-minifi-cpp] fgerlits commented on a change in pull request #1093: MINIFICPP-1578 Upgrade OS versions in docker builds

2021-06-02 Thread GitBox
fgerlits commented on a change in pull request #1093: URL: https://github.com/apache/nifi-minifi-cpp/pull/1093#discussion_r644102891 ## File path: docker/DockerBuild.sh ## @@ -113,20 +113,19 @@ else DOCKERFILE="Dockerfile" fi -TAG="" +TAG="${MINIFI_VERSION}" + if [

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1089: MINIFICPP-1567 enable linter checks in extensions (part 1)

2021-06-02 Thread GitBox
szaszm commented on a change in pull request #1089: URL: https://github.com/apache/nifi-minifi-cpp/pull/1089#discussion_r644092746 ## File path: extensions/windows-event-log/TailEventLog.cpp ## @@ -19,14 +19,16 @@ */ #include "TailEventLog.h" +#include Review comment:

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1089: MINIFICPP-1567 enable linter checks in extensions (part 1)

2021-06-02 Thread GitBox
szaszm commented on a change in pull request #1089: URL: https://github.com/apache/nifi-minifi-cpp/pull/1089#discussion_r644092746 ## File path: extensions/windows-event-log/TailEventLog.cpp ## @@ -19,14 +19,16 @@ */ #include "TailEventLog.h" +#include Review comment:

[GitHub] [nifi] Lehel44 commented on a change in pull request #5111: NIFI-8645: Disable LongRunningTaskMonitor by default

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5111: URL: https://github.com/apache/nifi/pull/5111#discussion_r644082430 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java ## @@

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1089: MINIFICPP-1567 enable linter checks in extensions (part 1)

2021-06-02 Thread GitBox
martinzink commented on a change in pull request #1089: URL: https://github.com/apache/nifi-minifi-cpp/pull/1089#discussion_r644078368 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -127,8 +129,8 @@ core::Property

[GitHub] [nifi] Lehel44 commented on a change in pull request #5111: NIFI-8645: Disable LongRunningTaskMonitor by default

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5111: URL: https://github.com/apache/nifi/pull/5111#discussion_r644074264 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-framework-core/src/main/java/org/apache/nifi/controller/FlowController.java ## @@

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1089: MINIFICPP-1567 enable linter checks in extensions (part 1)

2021-06-02 Thread GitBox
martinzink commented on a change in pull request #1089: URL: https://github.com/apache/nifi-minifi-cpp/pull/1089#discussion_r644072659 ## File path: extensions/windows-event-log/ConsumeWindowsEventLog.cpp ## @@ -127,8 +129,8 @@ core::Property

[GitHub] [nifi] Lehel44 commented on a change in pull request #5111: NIFI-8645: Disable LongRunningTaskMonitor by default

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5111: URL: https://github.com/apache/nifi/pull/5111#discussion_r644068907 ## File path: nifi-nar-bundles/nifi-framework-bundle/nifi-framework/nifi-resources/src/main/resources/conf/nifi.properties ## @@ -321,5 +321,5 @@

[GitHub] [nifi-minifi-cpp] martinzink commented on a change in pull request #1089: MINIFICPP-1567 enable linter checks in extensions (part 1)

2021-06-02 Thread GitBox
martinzink commented on a change in pull request #1089: URL: https://github.com/apache/nifi-minifi-cpp/pull/1089#discussion_r644067626 ## File path: extensions/coap/controllerservice/CoapConnector.h ## @@ -15,8 +15,12 @@ * See the License for the specific language governing

[jira] [Updated] (NIFI-8638) passwords - sensiteve context properties - not working

2021-06-02 Thread Jul Tomten (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8638?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Jul Tomten updated NIFI-8638: - Description: An issue with passowords for the  getJMS and InvokeHTTP processors - I want to store the

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1085: MINIFICPP-1568 Retry PDH processor run to fix test flakiness

2021-06-02 Thread GitBox
szaszm commented on pull request #1085: URL: https://github.com/apache/nifi-minifi-cpp/pull/1085#issuecomment-853071094 Ok, I see. It sounds like it would be complicated to ensure that onTrigger results in actual data. -- This is an automated message from the Apache Git Service. To

[GitHub] [nifi] Lehel44 commented on a change in pull request #5115: NIFI-8642 Select the default Old Gen Memory Pool for Memory Reporting…

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5115: URL: https://github.com/apache/nifi/pull/5115#discussion_r643998697 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java ## @@ -90,14

[GitHub] [nifi] Lehel44 commented on a change in pull request #5115: NIFI-8642 Select the default Old Gen Memory Pool for Memory Reporting…

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5115: URL: https://github.com/apache/nifi/pull/5115#discussion_r643997332 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java ## @@ -90,14

[GitHub] [nifi] Lehel44 commented on a change in pull request #5115: NIFI-8642 Select the default Old Gen Memory Pool for Memory Reporting…

2021-06-02 Thread GitBox
Lehel44 commented on a change in pull request #5115: URL: https://github.com/apache/nifi/pull/5115#discussion_r643995331 ## File path: nifi-nar-bundles/nifi-standard-bundle/nifi-standard-reporting-tasks/src/main/java/org/apache/nifi/controller/MonitorMemory.java ## @@ -90,14

[GitHub] [nifi-minifi-cpp] martinzink edited a comment on pull request #1085: MINIFICPP-1568 Retry PDH processor run to fix test flakiness

2021-06-02 Thread GitBox
martinzink edited a comment on pull request #1085: URL: https://github.com/apache/nifi-minifi-cpp/pull/1085#issuecomment-853051992 > What is the timing issue? Is it unfeasible to eliminate it instead of a workaround in the test? The problem is that the processor opens the windows

[GitHub] [nifi-minifi-cpp] martinzink commented on pull request #1085: MINIFICPP-1568 Retry PDH processor run to fix test flakiness

2021-06-02 Thread GitBox
martinzink commented on pull request #1085: URL: https://github.com/apache/nifi-minifi-cpp/pull/1085#issuecomment-853051992 > What is the timing issue? Is it unfeasible to eliminate it instead of a workaround in the test? The problem is that the processor opens the windows pdh query

[jira] [Updated] (MINIFICPP-1085) CWEL checkpointing

2021-06-02 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1085?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits updated MINIFICPP-1085: -- Fix Version/s: (was: 0.10.0) 0.7.0 > CWEL checkpointing >

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1083: MINIFICPP-1507 convert OutputStream::write to size_t

2021-06-02 Thread GitBox
szaszm commented on a change in pull request #1083: URL: https://github.com/apache/nifi-minifi-cpp/pull/1083#discussion_r643987776 ## File path: extensions/libarchive/CompressContent.h ## @@ -180,11 +180,11 @@ class CompressContent : public core::Processor { int status_;

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1083: MINIFICPP-1507 convert OutputStream::write to size_t

2021-06-02 Thread GitBox
szaszm commented on a change in pull request #1083: URL: https://github.com/apache/nifi-minifi-cpp/pull/1083#discussion_r643987418 ## File path: extensions/standard-processors/processors/GenerateFlowFile.h ## @@ -67,16 +67,14 @@ class GenerateFlowFile : public core::Processor

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1083: MINIFICPP-1507 convert OutputStream::write to size_t

2021-06-02 Thread GitBox
szaszm commented on a change in pull request #1083: URL: https://github.com/apache/nifi-minifi-cpp/pull/1083#discussion_r643987530 ## File path: extensions/libarchive/MergeContent.h ## @@ -80,18 +80,18 @@ class BinaryConcatenationMerge : public MergeBin { int64_t

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1083: MINIFICPP-1507 convert OutputStream::write to size_t

2021-06-02 Thread GitBox
szaszm commented on a change in pull request #1083: URL: https://github.com/apache/nifi-minifi-cpp/pull/1083#discussion_r643987158 ## File path: libminifi/test/rocksdb-tests/RocksDBStreamTests.cpp ## @@ -45,7 +45,9 @@ TEST_CASE_METHOD(RocksDBStreamTest, "Verify simple

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1083: MINIFICPP-1507 convert OutputStream::write to size_t

2021-06-02 Thread GitBox
szaszm commented on a change in pull request #1083: URL: https://github.com/apache/nifi-minifi-cpp/pull/1083#discussion_r643986978 ## File path: controller/Controller.h ## @@ -36,7 +36,7 @@ bool sendSingleCommand(std::unique_ptr socket, uint8_t op, c

[GitHub] [nifi-minifi-cpp] szaszm commented on a change in pull request #1083: MINIFICPP-1507 convert OutputStream::write to size_t

2021-06-02 Thread GitBox
szaszm commented on a change in pull request #1083: URL: https://github.com/apache/nifi-minifi-cpp/pull/1083#discussion_r643986747 ## File path: libminifi/src/io/FileStream.cpp ## @@ -113,34 +113,33 @@ void FileStream::seek(size_t offset) { logging::LOG_ERROR(logger_) <<

[jira] [Updated] (MINIFICPP-1373) Implement and test a simplified ConsumeKafka processor without security protocols

2021-06-02 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1373?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits updated MINIFICPP-1373: -- Fix Version/s: (was: 0.10.0) 0.11.0 > Implement and test a

[GitHub] [nifi] mattyb149 opened a new pull request #5116: NIFI-8625: Refactor scripted components to use ScriptRunner to fix concurrency issues

2021-06-02 Thread GitBox
mattyb149 opened a new pull request #5116: URL: https://github.com/apache/nifi/pull/5116 Thank you for submitting a contribution to Apache NiFi. Please provide a short description of the PR here: Description of PR Replaces ScriptEngineConfigurator with

[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1085: MINIFICPP-1568 Retry PDH processor run to fix test flakiness

2021-06-02 Thread GitBox
lordgamez commented on pull request #1085: URL: https://github.com/apache/nifi-minifi-cpp/pull/1085#issuecomment-853043871 > What is the timing issue? Is it unfeasible to eliminate it instead of a workaround in the test? The timing issue is not in our code, but comes from the

[jira] [Commented] (NIFI-8625) ExecuteScript processor always stuck after restart or multi thread

2021-06-02 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8625?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355739#comment-17355739 ] Matt Burgess commented on NIFI-8625: The script configurators have become cumbersome, they were

[jira] [Resolved] (MINIFICPP-1560) Reclassify some c2 logs

2021-06-02 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1560?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits resolved MINIFICPP-1560. --- Resolution: Fixed Fixed by https://github.com/apache/nifi-minifi-cpp/pull/1074

[jira] [Assigned] (NIFI-8625) ExecuteScript processor always stuck after restart or multi thread

2021-06-02 Thread Matt Burgess (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8625?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Matt Burgess reassigned NIFI-8625: -- Assignee: Matt Burgess > ExecuteScript processor always stuck after restart or multi thread >

[jira] [Resolved] (MINIFICPP-1546) CMake OPC Flags missing from README.md

2021-06-02 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1546?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits resolved MINIFICPP-1546. --- Resolution: Fixed Fixed by https://github.com/apache/nifi-minifi-cpp/pull/1056

[jira] [Resolved] (MINIFICPP-1564) Remove unused c2 update functionality

2021-06-02 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1564?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits resolved MINIFICPP-1564. --- Resolution: Fixed Fixed by https://github.com/apache/nifi-minifi-cpp/pull/1079

[jira] [Resolved] (MINIFICPP-1547) Change default c2 protocol to RESTSender

2021-06-02 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1547?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits resolved MINIFICPP-1547. --- Resolution: Fixed Fixed by https://github.com/apache/nifi-minifi-cpp/pull/1058

[jira] [Resolved] (MINIFICPP-1554) Log unexpected status codes in RESTSender

2021-06-02 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1554?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits resolved MINIFICPP-1554. --- Resolution: Fixed Fixed by https://github.com/apache/nifi-minifi-cpp/pull/1068

[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1085: MINIFICPP-1568 Retry PDH processor run to fix test flakiness

2021-06-02 Thread GitBox
szaszm commented on pull request #1085: URL: https://github.com/apache/nifi-minifi-cpp/pull/1085#issuecomment-853037420 What is the timing issue? Is it unfeasible to eliminate it instead of a workaround in the test? -- This is an automated message from the Apache Git Service. To respond

[jira] [Resolved] (MINIFICPP-1450) Revive SQL processor

2021-06-02 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1450?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits resolved MINIFICPP-1450. --- Resolution: Fixed Fixed by https://github.com/apache/nifi-minifi-cpp/pull/1004

[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1093: MINIFICPP-1578 Upgrade OS versions in docker builds

2021-06-02 Thread GitBox
lordgamez commented on a change in pull request #1093: URL: https://github.com/apache/nifi-minifi-cpp/pull/1093#discussion_r643800567 ## File path: docker/DockerBuild.sh ## @@ -113,20 +113,19 @@ else DOCKERFILE="Dockerfile" fi -TAG="" +TAG="${MINIFI_VERSION}" + if [

[jira] [Commented] (NIFI-8610) Invalid bigdecimal values in ORC when multiple avro records provided

2021-06-02 Thread Peter Gyori (Jira)
[ https://issues.apache.org/jira/browse/NIFI-8610?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel=17355725#comment-17355725 ] Peter Gyori commented on NIFI-8610: --- Hi [~alien11689] , May I ask you to send an e-mail to

[jira] [Updated] (MINIFICPP-1278) Add Python processor tests to CI

2021-06-02 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1278?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits updated MINIFICPP-1278: -- Fix Version/s: (was: 0.10.0) 0.11.0 > Add Python processor

[jira] [Updated] (MINIFICPP-1215) Document and test SQL extension

2021-06-02 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1215?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits updated MINIFICPP-1215: -- Fix Version/s: (was: 0.10.0) 0.11.0 > Document and test SQL

[jira] [Resolved] (MINIFICPP-987) Error handling in GetFile has multiple issues

2021-06-02 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits resolved MINIFICPP-987. -- Resolution: Fixed > Error handling in GetFile has multiple issues >

[jira] [Updated] (MINIFICPP-987) Error handling in GetFile has multiple issues

2021-06-02 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-987?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits updated MINIFICPP-987: - Fix Version/s: 0.11.0 > Error handling in GetFile has multiple issues >

[jira] [Updated] (MINIFICPP-1572) Fix -Wmaybe-uninitialized warnings

2021-06-02 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1572?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits updated MINIFICPP-1572: -- Fix Version/s: 0.11.0 > Fix -Wmaybe-uninitialized warnings >

[jira] [Updated] (MINIFICPP-1569) Windows jobs do not run tests in CI

2021-06-02 Thread Ferenc Gerlits (Jira)
[ https://issues.apache.org/jira/browse/MINIFICPP-1569?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Ferenc Gerlits updated MINIFICPP-1569: -- Fix Version/s: 0.11.0 > Windows jobs do not run tests in CI >

  1   2   >